From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.3923.1642042055113158013 for ; Wed, 12 Jan 2022 18:47:35 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=k+eIp/tE; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042055; x=1673578055; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=l0grSjb5/jsXN8BC0mOLGI9dVTyH4Vp3AtSDqhNhDzk=; b=k+eIp/tET9kMgxRs452ihcz6azM4bOHF58hz1GueUwoF1IlivoYShpAp st2VNiFwFVzVWR24P+FFvgbv/mz5TPJA7zR+bIjXbBZCTwiPt/DR51pSL 4yvAxn1yA3wmSkfODaik30S0qJzv/HzaEmr0DueniuUFBzC2TrZdOS9BU MtcH/cMh3xXyqtutxg8RkBmXzNVTHHls4zi+LRk0M8BboifWHrsboWMCF jlW5YZXgcBJ2Jvxkup6beAjyBwbwqYg5f1gaBkxEy6xciR5Fpu6I7NFhT oxdUK4306ayEtfAuJrni4FFeDRabyMIjggfJWWhzWOBugfTguW5e+oYTD Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="330261312" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="330261312" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:47:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="613802763" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2022 18:47:34 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:47:33 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:47:33 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:47:33 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:47:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BU3nO0raUkOMYL9DMCUm0enyxbuwO/EK3pKbPdI+Rit6zhQxcL8U5CyNuxVfX7oBZQmFc40Y9UM7ZHwbfD/l1lMAz9B267VxLu9JMn34WHa4nib04GIf7B5NphHIN0l+sus0ZJ5XbOI/MuBiTqdGJIuhUGfLkxYEjzHs+lTp4Qok9QP1clbW6jXEkXsW2cAN3pgY/b4IBGPwjkX3wxu3NWgNc1KYQb3wkgT8f31uLGZv5zpMBGtlwS9SCUbnICnamShZ/v9jc5hPoTYkwmnOdMju3pSEBoYcXdiSlFw//zeoVGNC2h430lzMPqTqjy/BAJ2XanepIgip0uhc6xGLgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hZXWAS0oGtSqmmP9LmnArFry1eKCbSpizdTOmWIz6Vg=; b=N78MWnoh54wFwfrCHuZ/hpbvbczgIzEBQss65Ea3ehuUtdPUFWzTUFeh/gdxDoWLoGWbMKwc2E/gvBIVDH9XSPMwlfQaLbOnV1aiBgsKnOQv5owsbqFPGjIeLCDngmPWDKVqmvnMGxFD+fM62DEJW0uASBtztPXQt/gYSaZ7flBnVMOebYpcqMgH4av6PCoX09n8jjhupAfZM+IZR0/xYW1EYUBH+Y/cQiRfZy6JnzzA8KvC/DqAGsY1wwyOCgOTLPOnwL6h+uVmexME6F7n7TLanHBMSiO1/+3e/v2DjMOiQpqpysL1DmBDjhPJHLVIS4SpaKudO00BuqeyFmpRkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR1101MB2285.namprd11.prod.outlook.com (2603:10b6:301:57::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 02:47:27 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:47:27 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Oram, Isaac W" CC: "Dong, Eric" , "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 19/27] Usb3DebugFeaturePkg: Align with feature design guidelines Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 19/27] Usb3DebugFeaturePkg: Align with feature design guidelines Thread-Index: AQHYB1swNSYRfdz+80Ocqsl47ZRzSKxgJgDQ Date: Thu, 13 Jan 2022 02:47:27 +0000 Message-ID: References: <73c2a258db12f55a69b20e4580b3e78768a72ad0.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: <73c2a258db12f55a69b20e4580b3e78768a72ad0.1641953242.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95a27c38-8fc0-498b-be99-08d9d63f0934 x-ms-traffictypediagnostic: MWHPR1101MB2285:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l6LgxzKLWGiBJyLHUZOXZIUo1EOxFME9PhKYPb4ZQD3/MloPn6UP8ZuLf5q17bV0PE38Pd2GhFfaTzyblt+RldH9sgBPfrniFonc0Agi3vlaQX4jaVTf1g/qsL8RODBBZlnev1B8jdw5crCqPkJYkPHxNzxTxbFBja8BhtgZfWfx40M1SdwPKuHE268QoHFFqFH7y1rzi2utAwNbfRnOeGyiJ0DfXVaVzecdOwLZdHU0eUisNcm9I4TpQxRVksj337815tCiAoCCEtB6WbzqyFTsGzX8lpaUi/eQYoVcRDk8Yt0CoEYoGY+f/iBlC2PjpPZV7j93BX8Is5McbIncCdfhwUY/262sR/zhDuZN+JmtFDYqda0B/GDZKiDTUxKnPAtgua3qif7paNNMgtk2YmZb+MO+SOKuaYbXHumfJ0hkpo6tN6YizMUkApz7vQTw2xOXYcFR/aE25kao5rPmg17UzT/LTRsoftcOMcBF94PzMql1ltdptjRQ7ud8vzOh1qpeaZo8h+8Isxaw+A7qQStuptYCBSJtdKpjfMBDfvYWoJm1F0E/UyzhcmSCeHNpSTLZvGqTCITM7da3D4/pTuP19MB7oR91sVOdfmrQaUsht40NM9SeUsM1BGqS8PMH6s2B2X6GkgFW/K2pwv9RUtglvXFGdZUO0UiSuQp9YSXERzegTiYelUIrMJF69Td3DC7eR8Bs55TZ++LfAL1egEBt7sAKpmFWEQWfAgDi5vjfa13+w+ICUbjBqdueauisYqrte2jrMooRzguu7j0aBXvEg0knCuIurxrZfTKpvo72UIZzuh+W9m9wqK+rofZuot4f8qzebDwAP81iQ2rdBg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(110136005)(55016003)(7696005)(66946007)(66476007)(54906003)(64756008)(76116006)(66446008)(6506007)(316002)(71200400001)(8676002)(83380400001)(38070700005)(2906002)(966005)(5660300002)(38100700002)(33656002)(53546011)(6636002)(82960400001)(19627235002)(86362001)(52536014)(9686003)(26005)(30864003)(186003)(508600001)(122000001)(4326008)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?msFWmP3rvQYMV7/O8Vl4wxNpWpj7UXQKPCGhuXb38SFjxwwE12bpCgo3YyZH?= =?us-ascii?Q?1F+xuGWvCI3puwEHbU8NkIyVHvlC7+zRo+kwPwHvhzyHrqfVaQ8Qvp3+73Wf?= =?us-ascii?Q?DlMoXiALtxZYG5ndRW69IO+6AlLJYV8osHrH9KCA2+2+ANnqCWKZdT37ha6P?= =?us-ascii?Q?82DeQZkROGBdIYBDQnIVXk008INJ3aIDLS7SKA8BqcXjqiCFfJP+e7k3+TtT?= =?us-ascii?Q?Nb3/tbdevmrLfU1gVLs5Bhz5RZ5JQxXOPp0Ounu0uuNpNeKhxVaoFCfPvNhx?= =?us-ascii?Q?c+aFusvF2ctgWu+DkWqideP4mCny4T0t38Liot0Z6IdUzpysDJy4rIZQEpTy?= =?us-ascii?Q?wx5EN/1gpHQWW9p5RyOwMb58OdByyc8obnjpNg27AdaoPhS8MU1TOHoB0KO4?= =?us-ascii?Q?Hne9oTCxQQXZudT+wVABp3JTItmpZMIQdGXhqrCprc4t6SPwjkjJcMlFbmUN?= =?us-ascii?Q?y5AYrtrBNuWFN6Hr26uqpx9R95m3bDMsANj9hFPYBG/3ZGB90yG5+TwnGzpM?= =?us-ascii?Q?3VwRkIXrQRCubyfd9PaVR3b0Mg6IbpcEoAy4GcW1giN0hjtQv52AvMuhUj76?= =?us-ascii?Q?WHiKWut4fy6niVnZyRaE8UKSQSjeOjuCeNi99QPCmI+O9MHFXhF/L40MPiXp?= =?us-ascii?Q?cWbYtY6U3MI3HdVU8QJRVky0ka+Z8LL+HizaREMUAkv1UqHOcTWDNWc7KmRF?= =?us-ascii?Q?pt0lturDyB/NxBWUMZ7noPCezxB04YY/w3zP8Oj+GgBjdfS1UR5/sQZUS1If?= =?us-ascii?Q?5UA3raaH4kyqiecM32eHMdqaMHayy8R2QFirspqBTqpMUzRUGFUy0eBERjJd?= =?us-ascii?Q?nr7gVKWAvnZ7cRUQ9Xp8/8NwTA8MS9Y3QfY5Nv6+zUpDsAT0J5uRb2WcJVRY?= =?us-ascii?Q?PCiSx3KYi/YMUv/+KUJJPlGrU7aVTNhMC/Vi4IgNaCBA/PmqhCc4PhHSoNqh?= =?us-ascii?Q?9OWAadlEakE/s6XCGHNLlmyjh1lf21xlnoOHNKEBCElEIFVzeIeXzzIBXS/z?= =?us-ascii?Q?bMpj6s/oQth3hFb6+bnO9R9G9TPkPu71RpjjqycVs6XttRf0eeAFxrETx3jQ?= =?us-ascii?Q?tjxQrvf3clgzZ7q7iFVOajXDCjHfAIHml2OJxA2/yhfxQwV7iTAIFWP56z7e?= =?us-ascii?Q?e0PBq4PfJa+JIpiygTdUbxwA0XEk3dAVK2A5Orrvc5MF4l8y68f5Y+ONwKIC?= =?us-ascii?Q?Cnlqobbk11YwAs5qeF1M5k18vIDQiNoPxl2RJDsWxEPn+MLvmoLCtRhdgJ9T?= =?us-ascii?Q?n+EYTZQJW8qPplmBuGdqdNQNrZjzlH2loW3CyjZWyj6UacjivigESDgHhqaI?= =?us-ascii?Q?4RvFqOB1YEMShDYeHNWajxGTeorNOFGMgnfw1CsdSIvlplre9+cD5T3tyRaN?= =?us-ascii?Q?ey53hzDAMOHR4uJLZXBAI6rZnV7gsgSFf5ymn/MOLnxbFJmcuYPojlwDKL6Q?= =?us-ascii?Q?7zIMTaRR7Ly7JckYhujBgOdLeJAPDO3CV0Cuxs/g3bxqEL1sEYJRFpuK6RPc?= =?us-ascii?Q?1EBaI6R46hPmXfr3ifL7hzD3huLIR4Q5QiQ+riGZ1fpSPrxLtIdXhPDvZxBk?= =?us-ascii?Q?stsphHfp2OKM+BPslmg8UGlfefnkYVp7L2TfxRbKl0s/LC83Y6jKU0JIRSp0?= =?us-ascii?Q?sXVfNAJkYKOUASJVEFe//5ectjKEbBy63wfrvbK/bapOtXwDySeoDmC27YN6?= =?us-ascii?Q?y6iRBA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95a27c38-8fc0-498b-be99-08d9d63f0934 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:47:27.4590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zvZREWjd2kNkBW+OWl1DPrhLvTpDVSs+FUn+X2rIDHiIJIfYHroMenRsI80ao7O9zlmI5mY7VL97yHA2WC5i7kOKftv+5eUmt7Sam0Gkkq4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2285 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Isaac, Comments inline. Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oram, > Isaac W > Sent: Tuesday, January 11, 2022 6:20 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Dong, Eric > ; Gao, Liming > Subject: [edk2-devel][edk2-platforms][PATCH V1 19/27] > Usb3DebugFeaturePkg: Align with feature design guidelines >=20 > Remove build of common libraries. Boards will already have those. >=20 > Modified Usb3DebugFeature.dsc to treat libraries like libraries. > Usb3DebugFeaturePkg.dsc uses the component trick for standalone build > testing of the libraries. >=20 > Added a PCD to allow board to select between NULL, regular, and IO MMU > library instances. Prior implementation of Usb3DebugFeature.dsc was not > useful as an includable file because it didn't specify LibaryClass instan= ce to > use. >=20 > Removed unused CMOS PCD. >=20 > Updated some of the readme sections. >=20 > Cc: Eric Dong > Cc: Liming Gao >=20 > Signed-off-by: Isaac Oram > --- >=20 > Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeatu > re.dsc | 131 ++++---------------- > Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md = | > 50 +++++--- >=20 > Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.d > ec | 14 +-- >=20 > Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.d > sc | 18 +++ > 4 files changed, 81 insertions(+), 132 deletions(-) >=20 > diff --git > a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFea > ture.dsc > b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFea > ture.dsc > index 1e3aaecd5d..a87a5b428b 100644 > --- > a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFea > ture.dsc > +++ > b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFea > t > +++ ure.dsc > @@ -31,122 +31,35 @@ > # >=20 > ########################################################## > ###################### >=20 > -!include MdePkg/MdeLibs.dsc.inc > +[LibraryClasses.Common] > + > +Usb3DebugPortParamLibo|Usb3DebugFeaturePkg/Library/Usb3DebugPort > ParamLi Typo here. Usb3DebugPortParamLibo should be Usb3DebugPortParamLib. > +bPcd/Usb3DebugPortParamLibPcd.inf >=20 > -[LibraryClasses] > - ####################################### > - # Edk2 Packages > - ####################################### > - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > - BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > - DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > - PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > - > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem > plate.inf > - > UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo > otServicesTableLib.inf > - > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry > Point.inf > - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > - > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf > - > -[LibraryClasses.common.PEIM] > - ####################################### > - # Edk2 Packages > - ####################################### > - HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > - > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemory > AllocationLib.inf > - > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/P > eiServicesTablePointerLibIdt.inf > - > -[LibraryClasses.common.DXE_DRIVER] > - ####################################### > - # Edk2 Packages > - ####################################### > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo > ryAllocationLib.inf > - > -[LibraryClasses.common.DXE_RUNTIME_DRIVER] > - ####################################### > - # Edk2 Packages > - ####################################### > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo > ryAllocationLib.inf > - UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > - > -[LibraryClasses.common.UEFI_DRIVER] > - ####################################### > - # Edk2 Packages > - ####################################### > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo > ryAllocationLib.inf > - > - > ########################################################## > ###################### > -# > -# Component section - list of all components that need built for this fe= ature. > -# > -# Note: The EDK II DSC file is not used to specify how compiled binary > images get placed > -# into firmware volume images. This section is just a list of modu= les to > compile from > -# source into UEFI-compliant binaries. > -# It is the FDF file that contains information on combining binary= files into > firmware > -# volume images, whose concept is beyond UEFI and is described in = PI > specification. > -# There may also be modules listed in this section that are not re= quired in > the FDF file, > -# When a module listed here is excluded from FDF file, then UEFI- > compliant binary will be > -# generated for it, but the binary will not be put into any firmwa= re > volume. > -# > - > ########################################################## > ###################### > # > -# Feature PEI Components > +# If NULL Usb3DebugPortLib library instance desired > # > - > -# @todo: Change below line to [Components.$(PEI_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 > -# is completed. > -[Components.IA32] > - ##################################### > - # USB3 Debug Feature Package > - ##################################### > - > - # Add library instances here that are not included in package componen= ts > and should be tested > - # in the package build. > - > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.in > f > - > Usb3DebugFeaturePkg/Library/Usb3DebugPortParamLibPcd/Usb3DebugPor > tParamLibPcd.inf > - > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibPei.inf > - > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibPeiIo > Mmu.inf > - > - # Add components here that should be included in the package build. > +!if gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance > =3D=3D 0 > + [LibraryClasses.Common] > + > +Usb3DebugPortLib|Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb > 3Debug > +PortLibNull.inf > +!endif >=20 > # > -# Feature DXE Components > +# If regular Usb3DebugPortLib library instance desired > # > +!if gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance > =3D=3D 1 > + [LibraryClasses.PEI_CORE, LibraryClasses.PEIM] > + > +Usb3DebugPortLib|Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb > 3Debug > +PortLibPei.inf >=20 > -# @todo: Change below line to [Components.$(DXE_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 > -# is completed. > -[Components.X64] > - ##################################### > - # USB3 Debug Feature Package > - ##################################### > - > - # Add library instances here that are not included in package componen= ts > and should be tested > - # in the package build. > - > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.in > f > - > Usb3DebugFeaturePkg/Library/Usb3DebugPortParamLibPcd/Usb3DebugPor > tParamLibPcd.inf > - > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibDxe.in > f > - > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibDxeIo > Mmu.inf > + [LibraryClasses.DXE_CORE, LibraryClasses.DXE_DRIVER, > LibraryClasses.DXE_RUNTIME_DRIVER, LibraryClasses.SMM_CORE, > LibraryClasses.DXE_SMM_DRIVER, LibraryClasses.UEFI_DRIVER] > + > +Usb3DebugPortLib|Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb > 3Debug > +PortLibDxe.inf > +!endif >=20 > - # Add components here that should be included in the package build. > - > - > ########################################################## > ######################################### > -# > -# BuildOptions Section - Define the module specific tool chain flags tha= t > should be used as > -# the default flags for a module. These flags are= appended to any > -# standard flags that are defined by the build pr= ocess. They can > be > -# applied for any modules or only those modules w= ith the > specific > -# module style (EDK or EDKII) specified in [Compo= nents] section. > # > -# For advanced features, it is recommended to ena= ble > [BuildOptions] in > -# the applicable INF file so it does not affect t= he whole board > package > -# build when this DSC file is active. > +# If regular Usb3DebugPortLib library instance desired > # > - > ########################################################## > ######################################### > -[BuildOptions] > +!if gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance > =3D=3D 2 > + [LibraryClasses.PEI_CORE, LibraryClasses.PEIM] > + > +Usb3DebugPortLib|Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb > 3Debug > +PortLibPeiIoMmu.inf > + > + [LibraryClasses.DXE_CORE, LibraryClasses.DXE_DRIVER, > LibraryClasses.DXE_RUNTIME_DRIVER, LibraryClasses.SMM_CORE, > LibraryClasses.DXE_SMM_DRIVER, LibraryClasses.UEFI_DRIVER] > + > +Usb3DebugPortLib|Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb > 3Debug > +PortLibDxeIoMmu.inf > +!endif > diff --git a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md > b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md > index dc92f108ff..c8afcf9fd2 100644 > --- a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md > +++ b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md > @@ -29,12 +29,15 @@ The description should not be constrained to > implementation details but provide feature is supposed to work. >=20 > ## Firmware Volumes > -*_TODO_* > -A bulleted list of the firmware volumes that feature module(s) are place= d in. > +Not applicable, the feature only produces libraries. >=20 > ## Modules > -*_TODO_* > -A bulleted list of the modules that make up the feature. > +* Usb3DebugPortLibDxe > +* Usb3DebugPortLibDxeIoMmu > +* Usb3DebugPortLibNull > +* Usb3DebugPortLibPei > +* Usb3DebugPortLibPeiIoMmu > +* Usb3DebugPortParamLibPcd >=20 > ## > *_TODO_* > @@ -76,11 +79,7 @@ This is particularly useful for features that use cust= om > build tools or require standard flow in the feature package template is = used, > this section may be empty. >=20 > ## Test Point Results > -*_TODO_* > -The test(s) that can verify porting is complete for the feature. > - > -Each feature must describe at least one test point to verify the feature= is > successful. If the test point is not -implemented, this should be stated. > +No test points implemented >=20 > ## Functional Exit Criteria > *_TODO_* > @@ -90,8 +89,28 @@ This section should provide an ordered list of criteri= a > that a board integrator functional on their board. >=20 > ## Feature Enabling Checklist > -*_TODO_* > -An ordered list of required activities to achieve desired functionality = for the > feature. > +* In the board DSC file, enable the feature ``` [PcdsFeatureFlag] > + > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable|TRU > E > +``` > +* In the board DSC file, select the implementation desired ``` > +[PcdsFixedAtBuild] > + # 0 =3D Non-functional instance > + # 1 =3D Regular instance > + # 2 =3D IO MMU instance > + > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|1 > +``` > +* In the board DSC file, configure the PCI device information ``` > +[PcdsFixedAtBuild] > + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsbSerialXhciBus|0x00 > + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsbSerialXhciDev|0x14 > + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsbSerialXhciFunc|0x00 > + > +gUsb3DebugFeaturePkgTokenSpaceGuid.PcdXhciDefaultBaseAddress|0xFE > A10000 > +``` > + >=20 > ## Performance Impact > A general expectation for the impact on overall boot performance due to > using this feature. > @@ -102,7 +121,8 @@ This section is expected to provide guidance on: > * How to manage performance impact of the feature >=20 > ## Common Optimizations > -*_TODO_* > -Common size or performance tuning options for this feature. > - > -This section is recommended but not required. If not used, the contents > should be left empty. > +* In the board DSC file, tune the timeout value ``` [PcdsFixedAtBuild] > + > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdXhciHostWaitTimeout|2000000 > +``` > diff --git > a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg. > dec > b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg > .dec > index 2b19e48491..353001b0f8 100644 > --- > a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg. > dec > +++ > b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg > .d > +++ ec > @@ -36,6 +36,12 @@ >=20 > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable|FAL > SE|BOOLEAN|0xA0000001 >=20 > [PcdsFixedAtBuild] > + ## This PCD allows the board to select the Usb3DebugPortLib instance > + desired # 0 =3D NULL instance # 1 =3D Regular instance # 2 =3D IO MM= U > + instance > + > + > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|0| > UINT8 > + |0xF0000009 > + > ## These PCD specify XHCI controller Bus/Device/Function, which are us= ed > to enable > # XHCI debug device. >=20 > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsbSerialXhciBus|0x00|UINT8| > 0xF0000001 > @@ -47,11 +53,3 @@ > # Default timeout value is 2000000 microseconds. > # If user does not want system stall for long time, it can be set to = small > value. >=20 > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdXhciHostWaitTimeout|2000000 > |UINT64|0xF0000005 > - > - ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes = space. > - > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortBusIndex|0x59 > |UINT8|0xF0000006 > - ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes = space. > - > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortDeviceIndex|0 > x5A|UINT8|0xF0000007 > - ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes = space. > - > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortFunctionIndex| > 0x5B|UINT8|0xF0000008 > - > diff --git > a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg. > dsc > b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg > .dsc > index 02627d2ed4..6965d26721 100644 > --- > a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg. > dsc > +++ > b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg > .d > +++ sc > @@ -24,7 +24,25 @@ > PEI_ARCH =3D IA32 > DXE_ARCH =3D X64 >=20 > +[PcdsFixedAtBuild] > + > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|0 > + > # > # This package always builds the feature. > # > !include Include/Usb3DebugFeature.dsc > + > +# > +# This package currently only contains library classes. To force them > +to be built since there is no code to use them # we just tell the build > +that they are components and the build will compile the libraries # > + > +[Components] Did you test compilation for the Usb3DebugFeaturePkg? I've generally run in= to issues when a components sections does not specify a machine architectur= e through some sort of means. > + > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.in > f > + > +Usb3DebugFeaturePkg/Library/Usb3DebugPortParamLibPcd/Usb3DebugPo > rtParam > +LibPcd.inf > + > + > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibPei.inf > + > + > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibPeiIo > Mmu. > + inf > + > + > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibDxe.in > f > + > + > Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibDxeIo > Mmu. > + inf > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20