From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.14560.1665531616467265431 for ; Tue, 11 Oct 2022 16:40:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ayUbiO9Y; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665531616; x=1697067616; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4Pnm1v5n7Pxl5AiM9Cw9t448FYntik2nWGtZJXJpcoU=; b=ayUbiO9YPFrAf99aNnHiIxaKQU7T6g+PxzOsROOExP0NwqUDAdbdKhyL XLIviRFllooYqBroHGHberdapUOcdgb05g60uxvjjyOc6lcwqCyMm40HJ lCSX9BNvUSPsv31kjDEcd0uHBG54F/6FjouuTszVbf/2m+lm2VlQ4fkIi mAPuptF9hDYrQhWOjCityi7GRdlpyZmhfWM4XPAF3UbmmMhEbWqjQV0yJ zDZB6lSf6RbdpjuFBCFBpkFdvD7RSEMFc20dwN/oAlER4iOG4EKjM5zXn YZ+DQr0n0qmRHOtFYr+dJW44uy0P3cb9cwLoREvpcKm0CUz7T7NoARB+U g==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="302264544" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="302264544" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 16:40:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="577624281" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="577624281" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 11 Oct 2022 16:40:15 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 16:40:14 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 16:40:14 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 16:40:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C7dseP2qhS5A8PPtTAsmjlfZl9LK8DrHmMdC0g5jeYHy+0UXlNoADrBCWQPs1yb8SE6mu2+nvsKcDpM9vTEyp7+9/whk5JGCPv64Kabul4n5jn42myZ3XeV0Qw7ydoHyRMD3r/8EsMSZDkC0pPCd1jYPjrX420/y9ITr1ZerPbDGAXUySN8JM/WhRHKpGDaHf8Y+EiNFDpMyYJtFYCJsVBJeJlFfK94FRdPa2cnYEmN7MRZtkdBDReq+oCD+RXjCaoDP8EQYDVCkL/2Zgc3rXIfcKEiCbptnz1bkChMeJmRnLu+WcwWjXC7FtzcCA7zuh5wzW3IiQh6qgnkkizNY7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wRVekgQK1jKaLT48Es9heWUojRl2LjGaCoqLtJC5pQ=; b=YSGPcIphu/3BT8tCI6Sy8+0bqiFQcwNuf5Cd/hKudeKQXyOYdpiSRPNwqMC2fsK5wf5EG4BZWTsEINtmaZQJltPCii79NHFHwm4VCUI4bdi/cOR+U9ZxBuH04s3exli/ZCc/j7mf3msUB+SY0/nP/3LEwUvnEZaJyig+39PkkumdsRTImsE0gt9eCp5seTgMQQ3Rgv9BH97Mk/FQukh3hXoffbAThnlE4/Hr8KRG8tS2iRSC7jbQoSX0A2lGAUIxBGk6HI1QmGwS5aU8G+DrRvmUU5mCw27Y8tvXzZ896E/chjC+NsZ2o9oNB/cZbgogC9dK3r2ciT7oDE2GrMu3FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SA2PR11MB5002.namprd11.prod.outlook.com (2603:10b6:806:fb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Tue, 11 Oct 2022 23:40:12 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6%3]) with mapi id 15.20.5676.032; Tue, 11 Oct 2022 23:40:12 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" , "Chiu, Chasel" , "Dong, Eric" , Benjamin Doron Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes Thread-Index: AQHYyGl/CIFYY2gwCEKaF3t7CmR7OK4KBK6w Date: Tue, 11 Oct 2022 23:40:12 +0000 Message-ID: References: <20220914184027.1510-1-isaac.w.oram@intel.com> In-Reply-To: <20220914184027.1510-1-isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|SA2PR11MB5002:EE_ x-ms-office365-filtering-correlation-id: 0f69bd2e-2227-4aa1-3e9c-08daabe1f0b8 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TvIjy3mZUO5BJ9m9rGNTa11chCJ7w15qJ8nSRA+WluxG2gH9NBJz0bBlv4lGGvuMafJl1jzB9RKQqJFAEEaO2a6zZi1qZ9dJWBv8vBD3DcZbtt243mD4EZEmydCOd90508ktYOfPRirs2/Nqj/lAFrIyeK1mhCo1/a1DeBHDJHfPLSrf2qnAspgFY8zGrjhdXk6pSHoANnkrm0Uy9xnH+YbQr352rRRXZk7LBcrDeAAScO2tR4/Nh792STFL1oHGR7WJi4E5M1HaUIq9CwLoz0xB8fCjVLO7h6Wc37LS/xZbOb4HeK+MEDJbmprtA75/Hk0tDWYQLj1HzEvTm8JXtvd9O0UxmLBVwk4Jk4f1+vEwXH5b7AOosNSRZwAtiJOtUfaJjdHk1bX4QQOrF6aK9SyGmZAHx3mv6/6CvSePUtBcXVlkZxBa3r1bwG1vC0KaF+Xh6rKlFieJvBL3o1G6AoT3k0RWRzS33eGjgzH04sdFK+tL60qk6KFJssi0sFWw9bZjdp/SOVnrcR/FezOgzyK+qXIfttBvMV71YleC37duQTmlgt/NowSplCrJy7Lt1K10bsJF4pST6spUQKkyvTaDCF/72JscO+MXdzjQUoQnB0AKjahOM7OlDGCYK1tIQDh681/SKCrI4zTSJrOXbb+3vYxxFLVZcKVEnU98C0d3zK5lOnEJX6XhoQXv0J1TYEkIgbTYlKfj3yZs0th7GDAwcQq1cYKK/bY4c8NCcw6qgYM+2FCVsckxHZmZMg4NFfofme+Z7cLMNqHwyp4MeA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199015)(33656002)(38100700002)(122000001)(5660300002)(82960400001)(86362001)(186003)(83380400001)(7696005)(8676002)(6506007)(19627235002)(53546011)(110136005)(66946007)(9686003)(26005)(316002)(54906003)(71200400001)(66476007)(66556008)(64756008)(66446008)(55016003)(4326008)(76116006)(41300700001)(2906002)(8936002)(52536014)(478600001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RPQtow4fdloiBv+IPocc/qDMo65Bx1ns42DQM8RHbJvkQBik3RNAc6zPELR0?= =?us-ascii?Q?CcqJoA4A2cb+vebv1qjNEiPW6dM1H4BNUD/NCK2n6muDSabOU9h3DqgOCBMO?= =?us-ascii?Q?SrdeeuGRKxti688Ycc/j+tt6EJjK/gvyk4ZyI683QW1AQufe3krUUIdw1Kdu?= =?us-ascii?Q?Izk2egShbZHh5kHc/BaRnuMKBp9X53Qftu8loN4ClVDH4g0uh5udikCCIt33?= =?us-ascii?Q?dOL8i1XpsecnalKGeTRO5WjehtoyA6y/xR4CKqZQeuJDsUoudAWgve89YI27?= =?us-ascii?Q?wMo/qpqpT804Frf2M+Bg4ndnYWBKYuheMAjlK6IJzwOpU9wu+hbbooN+drlt?= =?us-ascii?Q?Mtn+0p3jDxTm1OmvbzJR6vqVF+sdUL61YqbMWDQ2xWbB7ZTvsWrRJg5ZriJE?= =?us-ascii?Q?lSyW4QURjemacgVM4mevMflerjMj8bxHaFArBzI0Nifd7lVo3KrJ7zvfcbU4?= =?us-ascii?Q?uafgmYkcPcfvtZVpz6NqBiYOUXXRTalzwONYIEP2cBpvQ5L4IaDx6ZMXv+Ax?= =?us-ascii?Q?4w+dKWjrLiO9/a60qeSGWe0mUJ2p61TuD+wvot6TB7ZqXsMO7S7ERWV4IFu1?= =?us-ascii?Q?t/vWd33OAHEoNOZH93nZ2tU1nI2Knl17EZDLOEKsDHF1iz5GzS0wKBp+ehdA?= =?us-ascii?Q?hGK5pEv2rFwsgZfMmITMw0h/XcZMb2lB5/pE7fUhKVCBXPYL3esg4p2zBYn2?= =?us-ascii?Q?7BLUgdyOrREqn7mWoyqHgqxbrOBgnh0iFRziZUkmD7Uqg6uOtZo9gCONaK3T?= =?us-ascii?Q?j5z6CMPVnvoC5dk9vq9bnNJ0A12I7JClUI1LfdQJkYnvJ3pfcxmO5tkKczqK?= =?us-ascii?Q?Ea1BKFAHX6v8x8L6jtSTWcBEgB+fNjmDcVgb9wSSX3Fz7WO6UIfuA7IT7N6e?= =?us-ascii?Q?226ikGeBEjVgPcaT1KNr91fJdRNrti98f9nXzAB4gRjSbK71Axgh2yba161z?= =?us-ascii?Q?HZ0/BR1EJf4bVnXZoMQO6PSB6LZx9vLT3OLOgRqD9Uz6HA696XuE9if8yoQ1?= =?us-ascii?Q?+yr5m7q20vgjnUsjgipvE7oxdS5s5J2wkhtVHrCHwi944xSN6l8S++/RMXg6?= =?us-ascii?Q?vkVFuPn6nwIZKR9abXLFp6Zoyw9j+40x9zjdHul4aX4IEO0DE1BznnmcCc0k?= =?us-ascii?Q?Pmo7YCRLdre7O/hVDxXaoYiVec5ecOElxCe+YCCU0eo88Bk8fdJAvNp3iPz+?= =?us-ascii?Q?WUTW71XIDscmosLDw4LaQWZLPZ/X0coerifenwG3iIKJ886ClzmE4dcRyW4K?= =?us-ascii?Q?0LUxdkPTrsvIX6sfNW4H+jlKh4i8GhCAs6srMQQkSIPtXvrg0kFuVjlXGlZI?= =?us-ascii?Q?zltY5rF6yxMqgHrtyGBFOLIXrB21sEBCyifUkrGi8d6Njzq1MSQr0getVdcf?= =?us-ascii?Q?M1bAHYbjQp0VYc+qskF5mzVLQATZuVtkIKTK+oyjYZ6gMZH8lypUrRqACHcZ?= =?us-ascii?Q?oOvQ4jP3EqDm/rO+FjVbcyHbL+VeaPmz0BUsXtU6v+6aKFF0KQtu0+V8Gnib?= =?us-ascii?Q?1+mFbPAKEj9by/xbKYjr+tMZ5kJGYEMCXYZvPR5lRLCs/PjQR3Vy2yi/Q7mg?= =?us-ascii?Q?h4Zjk6jaHnafcWjYURFOGXDyc5/+mwvsOwZ6DFD3KRwHCZ8PJ6rvSsq12C67?= =?us-ascii?Q?/w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f69bd2e-2227-4aa1-3e9c-08daabe1f0b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 23:40:12.0475 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AleWH4zYHIpWFQjaYTKH7CsB7Nb1USWY5c3BBuyCZ+p0tbHKTO/+b1DHApCIUN9L734aSK3Yf1i5/gs/FhhFqfKwsc1DrzsHsU6OVuyJGjc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5002 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the series... Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W =20 Sent: Wednesday, September 14, 2022 11:40 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; Chiu, Chasel ; Dong, Eric ; Benjamin Doron Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build = fixes The S3FeaturePkg changes in [edk2-platforms][PATCH v3 2/4] S3FeaturePkg: Implement working S3 resume Introduces some build issues with standalone package build for S3FeaturePkg= and AdvancedFeaturePkg. There are also some type cast related compiler wa= rnings. We do not currently have continuous integration testing. We do not currently have documented build testing configuration requirement= s. Therefore I am just fixing the minor issues and intend to merge both patch = series together to maintain git bisect to the best of my ability. I do plan to document required and recommended board port and feature pkg b= uilds. Note that the use of UINTN for intermediate data instead of EFI_PHYSICAL_AD= DRESS is only to be consistent with other ACPI implementations of similar f= unctionality. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Chasel Chiu Cc: Eric Dong Cc: Benjamin Doron Signed-off-by: Isaac Oram Isaac Oram (2): S3FeaturePkg/Build: Add libraries needed by S3FeaturePkg MinPlatformPkg/S3: Use EFI_PHYSICAL_ADDRESS for address .../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Dxe/S3Dxe.c | 10 +++++----- .../PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.c | 2 +- .../Intel/MinPlatformPkg/Include/AcpiS3MemoryNvData.h | 4 ++-- 5 files changed, 14 insertions(+), 8 deletions(-) -- 2.36.1.windows.1