From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.15119.1665535076839914298 for ; Tue, 11 Oct 2022 17:37:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=I4QyBu9E; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665535076; x=1697071076; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CRKLw+DpnHByXGatiqmHTw8Lw4YuaD6lc8KKt3pfDfA=; b=I4QyBu9Eqy5toxxiv8DO7/57Hn1l5cVh9C5YjMp2tbhcx4KJfuUv/3fs 6Kr1PsDIG6zoQu4JWWtjvyk1IncMaV0mmxp5Umtjz02zLbAjcrPX5HuJf akedIOnLKdj3Ap7n4YZcTQFmJIUVzwRxvA5KZZPHJ0o6vXY92DAF66kkb X5vp59XluUx93yNekWnWBqYvSciPdOfJdGXpMZjKFKmFMa7DlfAbX1nIN 0n5DnKqALsfAa5Wmfk96gtGACkMfM5RN2gWYjx1emE+Z+w6AgI7IGdETJ If/yNmNUeZcKoNlGCr8py9dhUqMZ573eSpzaRY2oBgCDJxNtLNUgWHDg9 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="304647847" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="304647847" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 17:37:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="751933288" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="751933288" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 11 Oct 2022 17:37:56 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 17:37:55 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 17:37:55 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 17:37:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dd7ia2gAv/iqYJsrP/gpmtueTy/xOeP/qQmr+vyPhMgFaeULBnRDgJAOtrDrPpyCJIOS66vTMLf9iM/q5DB20GMXZcgbImsSONHdVz6X9SsA81E22c5N26qUkSqq+cqhQCBo9baPOWlPtBsbmP9mRzb7NW4oKwD5gJA/zTl78QNycaWkk94mLdIhOuQgw0MzDif7rj7XcfEGN16CkyvENQ5J7t6Qqp427h4x64+qYH4Io+hr9d8377s7MiDRRukfEzMImS07rPQ3qkPs6I3D2Qfzg4E1MdUdMsQMq6+fnfJUfGufM1JAmfyuR3SGuljJCUs94LnD4Ivm/mpkiVg0Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QtGhrsTyNFN62Ufpe2yUrzk/w7UYny9S9qeHVi0TaUk=; b=TR60VFwz2+rhCl5myyfIttgd640Fcdi7xsp+Ukh2KtqNRDLQupftUXwQH9SzW9RlTTml9FSr+F+mfhXzgOFyF6cx94CDdlrEofZe7M1QDKmI2ult4LvCjzNZ9Z/Iab5gU654Zr2Vld5wiLVJoBUP0wVj/Dtxp+fUD7Jf+nDQ4sb8Jh0Ze4NQ61eDRde547mYjMRRlGrka7qqBJz+KewLuwkgmneQuRh2Auy+trdRtaD8sfPsj4HDfzinKRleSwgWH3hImMDS4JwqbobZUrjhlfaDKhpFeN0jNctVUAisldChn7WSd/Wou+0/HDYW2t1W4TcabEroAsQUOmQA5DF83A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW3PR11MB4634.namprd11.prod.outlook.com (2603:10b6:303:54::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 00:37:54 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6%3]) with mapi id 15.20.5676.032; Wed, 12 Oct 2022 00:37:54 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/3] CoffeelakeSiliconPkg: Fix invalid debug macros Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/3] CoffeelakeSiliconPkg: Fix invalid debug macros Thread-Index: AQHY2G/2ZM05nvRwHku/LsJDk32lpK4J87JQ Date: Wed, 12 Oct 2022 00:37:54 +0000 Message-ID: References: <20221005040648.4139-1-mikuback@linux.microsoft.com> <20221005040648.4139-2-mikuback@linux.microsoft.com> In-Reply-To: <20221005040648.4139-2-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|MW3PR11MB4634:EE_ x-ms-office365-filtering-correlation-id: b7e9e6b1-b944-4f86-00e1-08daabea003e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CLACHsiWjbmsVx+fqpXEP2DORaEJAhHslmo838+Y6eY55qQd3p+fXXTBfVb4jQOJ2oChwJ6JE70qUHHY5qo5sBxwC3JD/O7/AnsBww2TJfRnfU5XC6I3sHgXV9U6LFO0GUtJd0mQ/bvpMZsU8RTwG7znVFIlkkNNF9miA9aTlE1yC4V4hIk7AYjm7sUlSHdK0ngusiOuIatjbMt2ev/oLBmRKJ5Es5k/lwJj3AExSlGYp4n470HDntfUw1bzFHHYkcd2zPe0fLk28dqEByV9s/StuFt8ydGyFuOYss1oMFuX+1UNxSeWjpdMujysrP2m+d/i/MgSH5exdUFIlVdX3jzyNfmxtSecg4s64r4077Uy8DyWguCuYoWK/WAp9qN2FeaN5GcLFR/7mrXJ6iQr9GLLSGeF0ZxiUELGO7Nb2788Y3wVN2n9iO0HTJj3Almp9DW6AcnhBYU8LapKNN4EMqXXAsclD7iQ1WNGkhJJPDpH732GRlszidGTV3uomHfj/2MIa+Q4Q72XAv1+ByNOqORzSrfjKOUa3YZWl3Dd5hCSP9b18o2XYOCog1SxVViBOLv3GVZChI/exDqp+x0e0BVXJzIL8RaeJ9DZTlz+Mh9AeznedPO+dGIyoskEIEmzC3fmHX6JwTbBDRKnSrkyZ20DSeXVFQDvUrOV5x01NA8EMd7/J6Dtp0QeJ34CSNZXWIOfPW26n2gbZ4uxv9ffXOwEOSOw1zhf08BKQ6bkaCXViO3KZ4+Sa7FZu7pVplxIUtJbtFxZN5+A5D3MD+stFRNYudr/gqP+2hmhpQ0FnD8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199015)(8936002)(41300700001)(2906002)(5660300002)(8676002)(66446008)(66946007)(66556008)(66476007)(64756008)(122000001)(76116006)(7696005)(6506007)(478600001)(33656002)(53546011)(110136005)(54906003)(4326008)(316002)(107886003)(83380400001)(86362001)(71200400001)(26005)(9686003)(52536014)(55016003)(38070700005)(38100700002)(186003)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jJ06fig2Wu+eWmXLYsb8r2RtolGqAH9DbckG2VxUCBf2iWgSWcTkJwSrkrQy?= =?us-ascii?Q?XtCck2RKI8EFWpzrRacax9IUyFKi5ooH2jlc4wj3oGubf5Z45kPzyq26U5EO?= =?us-ascii?Q?rl7qCRzGk4r9jkzjwWcLG9ew5d59vw0PZWO64ltNXZxp/yQaIRwFwf5OrXOR?= =?us-ascii?Q?TwcYBqqS4iFav6OP8NeCiMbPmcpvg9XtyZTBe/Nvg+ks0CczLZ3zZRXOpDss?= =?us-ascii?Q?YQcbVdpsHYq7wmHHvhxrzAs1BmW7vdrWCuwE02W7Nxpr4GrpEy5yfSrRUHF9?= =?us-ascii?Q?OACRYwGZ0fwXBSS7i4991ZaF0Romz507deUoy5s4XDwcwvzh0t2RhASqURgu?= =?us-ascii?Q?Tdd5nbKTUckrpA7zAoJkeThzqGMBntQiKqX+cIEa4xEbZr8X6UMuxxcf7xrg?= =?us-ascii?Q?VzDakpSWhm9EwRDy9Uz8SkL/VxgtCyPG9lHcZs08ryqb4P1Lr7b9MJ7ZDS15?= =?us-ascii?Q?3SDypA3sbS69s4vbauWZltBJHb1kfAjgXZkbevKomiGYXH/7RcXXRTQ8mIk0?= =?us-ascii?Q?lwHas/MDvUIbyP4VUHJiRNhArsWofK48YOSP2TK3jZz/pcBYilM+sCwbYbuq?= =?us-ascii?Q?50m6GYEwbkkzJY5pyOz7z9ONvtrL5sKLrGtVh6KorFpZMFQWHtSu0QxdH2yd?= =?us-ascii?Q?aJSAZsDTx5TZbaejH6OGuBy1RPQAcaEhpuUV2IqlyWg7VlGx+rT3zRXee4Ez?= =?us-ascii?Q?R4VLa7LWKo6AHxH0JzHIzo1hDD1vUS3iN4dGAID4d4Mx3M2JFVuLbZfHCC0w?= =?us-ascii?Q?EjcimeXNxrtWX/c0ZL+DYsTnIF233qHfhY8Kpw5Q/EjKwJ1G8VZEhbVzeV2A?= =?us-ascii?Q?V0IIbVHAYNOH/SYu8mVnYXQis1ss1Olq9LVa6+064/tPM+PNvUbC/N52ghHv?= =?us-ascii?Q?JyiNyULNjecu5SDZoSy1xqFCcbLEahYdXzypfRTBjZ/fZ+NYAkPnZ8m76UXj?= =?us-ascii?Q?VtMp7wjjPNmcALkLdhSvAqfHyZkPd0ucf0/k8gphchovgRpUH8onVuWu0Pfr?= =?us-ascii?Q?Xt6lCMyxAvkoHkasP2tdeFZUVLJW7qnvHG08OYWE2YH+LQa6Xa6IR4j8bGSI?= =?us-ascii?Q?qcx/0mgGl1i3QJoZHrP3zeLMbnQJdnmsFQeW/QyceyYf5qSYg8crZWPKKiRN?= =?us-ascii?Q?gauqrmuEiLEF6NXoEFpaz/hqlpOdgLOq87zKYY9+3pb9FFmWIe4RAOuNqfAL?= =?us-ascii?Q?QqKMb3jehHQHVW5tvJN9qJ/CvfCL9vWx9sZvgY+j1eELZePpSjeSuYji4A4h?= =?us-ascii?Q?qPDEX6WhXasYbyZMDSEBsfHJGHPjqmxbAEFbAcOkqEJ+FQYGJTNrDbUzt4wi?= =?us-ascii?Q?gynKg7qCkRwzyaskNdZHAozd4qjLKhKPyEEVpB4PbWtzujGfC136+Aojv9Dz?= =?us-ascii?Q?oA9wsr2Taxr3EOSgtQj0AjoxaQ198GG+5XZaa13RTAn6xjuBMk3wN9Qy4cBk?= =?us-ascii?Q?xQo2LD+g4TGWuq+6PGoEbKKOsKlQzRdwK8HkYMHJLI2NspTc3aDeIgHOv2+7?= =?us-ascii?Q?NVvokMaBwVDPpXL/V4BGCibevdQ7f/IwSHwRxyHgQUv81TG2DNFfJ+f3VIcf?= =?us-ascii?Q?GOoB/ENcYmiuDdKv4SpIhAfqnR7Ou4lLUjUnbH3ZN9P0Cs4RafqcFUh7mnl3?= =?us-ascii?Q?Zw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7e9e6b1-b944-4f86-00e1-08daabea003e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 00:37:54.0482 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WJB3x2DKjffQVouZRIGVrYWQD7Q19reqrsAoOrxI2xSzERjtsjhSr5DxAvkmR46MiE/LtN9eg0ANH0x/zg3kQJVwfynP/7UKbv+NzZA8zm8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4634 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Please see feedback inline. Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, October 4, 2022 9:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/3] CoffeelakeSiliconPkg= : > Fix invalid debug macros >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 >=20 > Updates several debug macros in CoffeelakeSiliconPkg to correctly match > print specifiers to actual arguments. >=20 > Cc: Chasel Chiu > Cc: Sai Chaganty > Signed-off-by: Michael Kubacki > --- > Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintP= olicy.c | 2 +- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/GbeMdi= Lib.c | 2 +- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c= | 4 ++-- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciEx= pressHelpersLib/PchPciExpressHelpersLibrary.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyL= ib/CpuPrintPolicy.c b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpu= PolicyLib/CpuPrintPolicy.c > index 38cf383e8da2..2e50068ba193 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuP= rintPolicy.c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuP= rintPolicy.c > @@ -161,7 +161,7 @@ CpuPidTestConfigPrint ( > { > UINT32 Index =3D 0; > DEBUG ((DEBUG_INFO, "------------------ CPU PID Test Config ----------= --------\n")); > - DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", Index= , CpuPidTestConfig->PidTuning)); > + DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", CpuPi= dTestConfig->PidTuning)); > if ( CpuPidTestConfig->PidTuning =3D=3D 1) { > for (Index =3D PID_DOMAIN_KP; Index <=3D PID_DOMAIN_KD; Index++) { > DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : Ratl[%X] : 0x%X\n", = Index, CpuPidTestConfig->Ratl[Index])); > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeM= diLib/GbeMdiLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSm= mGbeMdiLib/GbeMdiLib.c > index e5aa10de3b7b..7df011269af5 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/G= beMdiLib.c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/G= beMdiLib.c > @@ -335,7 +335,7 @@ GbeMdiGetLanPhyRevision ( > Status =3D EFI_DEVICE_ERROR; > goto PHY_EXIT; > } > - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision= . Overriding LANPHYPC\n", Status)); > + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision= . Overriding LANPHYPC.\n")); That does not seem to be what the original author intended. I suspect this = is the intent: DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. Overr= iding LANPHYPC. Status: %r\n", Status)); > // > // Taking over LANPHYPC > // 1. SW signal override - 1st cycle. > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/P= eiOcWdtLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/P= eiOcWdtLib.c > index 22f6fb215fcc..e2014f97e58c 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdt= Lib.c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdt= Lib.c > @@ -71,7 +71,7 @@ OcWdtResetCheck ( > /// Timeout status bits are cleared by writing '1' > /// > if (Readback & (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_CT= L_NO_ICCSURV_STS)) { > - DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected.\n", Readback)); > + DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected. Read back =3D 0x%08= x\n", Readback)); > Readback |=3D B_ACPI_IO_OC_WDT_CTL_FAILURE_STS; > Readback |=3D (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_C= TL_NO_ICCSURV_STS); > Readback &=3D ~(B_ACPI_IO_OC_WDT_CTL_UNXP_RESET_STS); > @@ -98,7 +98,7 @@ OcWdtResetCheck ( > /// > /// No WDT expiration and no unexpected reset - clear Failure stat= us > /// > - DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n", Readback)); > + DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n")); > Readback &=3D ~(B_ACPI_IO_OC_WDT_CTL_FAILURE_STS); > Readback |=3D (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT= _CTL_NO_ICCSURV_STS); > } > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDx= eSmmPchPciExpressHelpersLib/PchPciExpressHelpersLibrary.c b/Silicon/Intel/C= offeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpressHelpersLib/Pc= hPciExpressHelpersLibrary.c > index dcb43285b73e..c55fa4efe188 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPch= PciExpressHelpersLib/PchPciExpressHelpersLibrary.c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPch= PciExpressHelpersLib/PchPciExpressHelpersLibrary.c > @@ -1800,7 +1800,7 @@ RecursiveIoApicCheck ( > IoApicPresent =3D FALSE; > =20 > if (IsIoApicDevice (SbdfToBase (Sbdf))) { > - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev= , Sbdf.Func)); > + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, S= bdf.Func)); That does not seem to be what the original author intended. I suspect this = is the intent: DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Seg, Sbdf.Bus, Sbdf.= Dev, Sbdf.Func)); > return TRUE; > } > if (HasChildBus (Sbdf, &ChildSbdf)) { > --=20 > 2.28.0.windows.1