From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.3890.1642042161959898825 for ; Wed, 12 Jan 2022 18:49:22 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=W/wVVOf2; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042162; x=1673578162; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zG+uGvFbBVIO/ffu/CCWrSvQ/2ZbqkmeCuEgRzo2yzA=; b=W/wVVOf2E4tWFeOOaq0U7joe2MLmNds2GzQH3TElov6MJeObjOB8VsTD jC9P9tucSpMnh385Df5FKmxDHxp0JQiu3P65LvM8wHY37ltiGw99RBt6/ NkSXO2bqC2wbMzRDLQA0SEGN7qVkmuTkuCDf5/9ERnxIzK+kjy3XgpFVC pkVggKNEg8dBFbFRCOkDe/apZK5vzmOwVFrOWYN9/fMEhac7FGjwGRMUT 35XPJ5S9ICCgEHTyWN5sEnXVlTkPKgUMr0HMnWV2xNKkAHHvap1oOvGRI 2qM7gL1Gpab1Hl7IIO8PwQlP8i3H4giVOk4b5k8EQCOoi9Yy1c3rQXZDJ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="268262886" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="268262886" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:49:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="613803178" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2022 18:49:21 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:49:20 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:49:20 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:49:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FKTWTrzKEExiCLSczPgC4GQcvQ1QQA7j9t5Y7svyyYgdX8Wfik23Z/010VAoFLqTfXjW8AipYx2Ji9S/n35b8d3qA/TeFuIygdMwdjM7Iu0Fo+pZmgwCWzQz+VzbRKouy7YeTfHWBFhgeL0LtcEcXePwRYazpdm29s5QWy0whoXdhHUbZ4GhVF7Q4yN+M9ZaA6u+DhQ8XXQGBqpLBsK2hLQeCeK4FhMUlomJkmKjUe1nxQmN8s9NSAcFuyeKOrVoPyl8fegnfLVtwPp1lNm65r0/4w9vf1yEOPAdKMuroG6qM0PsQO6s+y4RCNL/krbHv5eKe/mnf6jf/9welnB3pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YDHmgUt0Il1bQPNfwKxYyEgOQjxjPq1KTAvkkFTPDAQ=; b=HvoGX/Km+AfE0Z06fYWrRHFqeOqpxV8w8V18a/ObeG9XqAVl4BqPlkqU357eCqgrV3xU1ud2QRfVOF0bDWFIso9KlVkJ/M+G48we0PCQbpQvIoN3GUGGTFzwT7BSP1OlUJhE+Y7jeMZBD/3CCmnKxiTfAQN38OSGTIBTF+1O/u6vnm6MnNCh9PTbTeMhxybun6JpujPtc4SJZHslzrXbzcyBTVyMBeg3RUN2Ph5KLSGoBjW8RhbwaeK/4U9h6ruEfkLlvuhSLDQ4wTmi+jnftew66NAbUbygLdmPvBerTX+sUzpj4OyHBk1F0DMfM75b+aU+4JaN+AuB17ndmEPA2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by CO1PR11MB4835.namprd11.prod.outlook.com (2603:10b6:303:9e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 02:49:19 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:49:19 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Oram, Isaac W" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 09/27] SmbiosFeaturePkg: Use MinPlatformPkg build include files Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 09/27] SmbiosFeaturePkg: Use MinPlatformPkg build include files Thread-Index: AQHYB1stiH4jXkcLJ0e2VXYmuPkAUqxgQZgQ Date: Thu, 13 Jan 2022 02:49:18 +0000 Message-ID: References: <0a6aa830baf91ceb56dbd686080ac6f1406b5b24.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: <0a6aa830baf91ceb56dbd686080ac6f1406b5b24.1641953242.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1cc14827-1e01-4e3a-e52e-08d9d63f4ba6 x-ms-traffictypediagnostic: CO1PR11MB4835:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qOgeTBEp9dpYsCpKe/fOTo1E4rdqsb54DkO3tCE/1lvlNdBNKOT/9qZtRy3QBBMb7CGKgKuVLvRXvtwykPLx/gLGrOzijt7rsYK63L05anUp6OTb1PAXsKwQNUZedRPMIEh5xa+e7n4OtFQH9t550NqgiHBAdqd8AS17a8pkIss2HMhEhc2wq4AOwy3T+eMcnxY1U/bE3WEt8KRfTrAFrKPekQZXpGSoWWODeUJ2k1b+zmawAYkyuGVh84kUqrQg9xhfqER1KS1nZGu4/w86p61wm2JQAkcQkhHC8sb0v1QUyZJ4ED21KgubGeCe3rRY4OxDFjz82/ZASJGszXD6XLIuPMVLyC2qvBChTEQZacHdqxhStadHNaa344sh64dLQLnFw5zccCN8m02PN61RXBv7Ip0zxMe56StAsNIkb1B9Ckx6l3+lT0bhTn76vXuvFP0S7N/IgsakmOhb5A0uiSdC06BIUIHGtt7rLauBk7zIhqVKBIGq8LJSaUATcIV8nqODKRaKpQpwhy+Doz1kznV29LWZuN9f7hCBAnFCy8qOP7sK68/o9jXdvQkla2bAuhv8NDp1ZusMGPcu51sZo0lKwMnqwW+FxDhxjvu/rQN/65bZYwuWe3T6re3v0mOkG638dbi8vP6sPKhwzixBD8ToukG7+yT8dfKQQGR63chtyzYUI1ovceRfrh2m8or7P3Ntl7HU+98IHtIsKB99Nb0KEYrCp7KRUYbWwiOm6wkkx26X7ItAYWfshP+NJhHG/JKvPBASUh+DTNxfuXgtp92X/TYitFd3noeoyjlFh4HNUgVcbMlHJJ0HfKWqeUvDP5tiAW0RTeaKPbkGmm+URw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(38070700005)(966005)(7696005)(54906003)(110136005)(8676002)(186003)(55016003)(53546011)(5660300002)(4326008)(26005)(8936002)(6506007)(52536014)(66556008)(66946007)(64756008)(6636002)(508600001)(38100700002)(9686003)(122000001)(83380400001)(82960400001)(86362001)(66446008)(316002)(66476007)(76116006)(71200400001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NQ81lmvlgPIWuVWEXryFojBr56tm2HZwsBy1guZd2RSzOVG1KytXb0IQlWyJ?= =?us-ascii?Q?osZCqXLN+6BZ1PjxZu8ESS5HaLXGzs4Mo3DrwYQCxY5YD5dRrfPLqzf/sMz8?= =?us-ascii?Q?F/h/py5HiSceHjAnH3vAwJy0aoDUZZGQthR3p3stBmLzzCB0ogNE3HCiXSLz?= =?us-ascii?Q?V9dOOb5dbsQfrxkzO/VCJRIdCqOsg0vzxb1MppvkvOArQhpduhnZdmx123nB?= =?us-ascii?Q?ievDByS8YxUN1NtwZdNpg4pmSfLbf7bLCXCUYDQl1IhrYtlnfGrtNti4KxOF?= =?us-ascii?Q?NOmrOgd+po+NTGX7zqhu6ZOOw+W7BanDWWW2kY7bdlPoC9CJyxBZFAhi6SWj?= =?us-ascii?Q?WTgQahPFQgJy1exuYveyWhkvnUgHfyHE35vSo5GhXoQeCttLxikw1hlwFeKR?= =?us-ascii?Q?deSESK1HXYJPmSRTZj/HEcSOdtXk3yi+O6PX0QCn3zQWX0Hgl87vylvGAGvD?= =?us-ascii?Q?MBxQVpfWMmZOc69F/3VZI5wB9MZpX70AeiF9PHiSji96jQ3oy+TQf0Rh2VRG?= =?us-ascii?Q?cHSeQ/B8LHV5wBvi4MzDDeu8b+1So4u6u4oq9N5NNMI/aL1Nn+oWX9x01lib?= =?us-ascii?Q?mPaolai9RsdSltL/fAiE5CMPyB3AsxxZEJc/LRgwDCSZssQP5LI7Vro2B3Qw?= =?us-ascii?Q?+1A3uGmMLnRmh+oW3FWVOzKuFalWevvnI1olY039ctKIeIpylAl/GOUGHkDI?= =?us-ascii?Q?EvLH+3kDKfiK8xwmAb7D5wkmFk20aAkT+7TGAcVwdZAGjKzOmOxVSnNomM3u?= =?us-ascii?Q?dVi7qH9KKtL0ao2+9ini87evWdSEnfMuu94NgY9bSCbqpyPWeH8LwnkFSpTc?= =?us-ascii?Q?kfgDicm3jEGpo/OQV4/1uOT9yqdE8yGr7b6E7eASsylDDRViyehusXGOpiKP?= =?us-ascii?Q?7pJL+TekqifwM+tZnMNq+1fr9x/rWe8orwDhEAl38bgKnFwx+MPWeLgKr5ZF?= =?us-ascii?Q?1bYLgWgSzClv5qkcgtaRRCaDpaITV4DhGuvzmtFuTDBjJ5/mMLHjUzbj8fj6?= =?us-ascii?Q?jf5YFwkgi1LjYaHUJrEpXi8AUrbj991bORmQKiWDlS75sLmQqBSKjABU8uN9?= =?us-ascii?Q?tiUKmH8m6tgGjE7HpcjLjvV1xB9ZWbf3yTVzFWDsFg/q/dTY7T7memmtVVXo?= =?us-ascii?Q?PiC/9n3kitrguW557EKm26+IEYuQSy3znZmbhbhCzRVCNKQJ1/NA2tlX0UWT?= =?us-ascii?Q?G+mY7L/YB/s+Roct9bfSEv+Ycfxbf1UY8W2lFmJlxKjVKGg78A5DgKFw1cer?= =?us-ascii?Q?QUcqIE+SS3b80k38TMudBesevhX0B7HwjpRxkcZMELXW5BpyHk3+7ZHp+Mg2?= =?us-ascii?Q?/RHywH/j0Qo0QA7FlBZa8ze8oTAC9yS02tb5wUh10jc6ZXK4HD1hMCvB3b4k?= =?us-ascii?Q?CJitbDKnzAdQzGist9uioYoYKdBGS19JqC/nYY0XT7thQHpEsmu5zK/tHrdC?= =?us-ascii?Q?9ZJ5dtId8mdk49LlOVzBj9ZnzlQ6exrL9b/1gRjEeBPhZY3eAv+BEyhVJK4Y?= =?us-ascii?Q?ZABTcd3pVzlzVQS9xpUcvtsq+7t4lqwZQblisW0yGQkdhSTx3XQfCcxPUk+Y?= =?us-ascii?Q?4wFJilt3tF5pogXTQH7d7nNLRa64ohI+/IBTnRVsJnE9aPM34Esp7/yVX4fw?= =?us-ascii?Q?TUDEsV3FHVdJNZJ1wht+YSuA+8scrYMwChlQR8N4ZQxrb27mgksu8rZ0ujzh?= =?us-ascii?Q?1bl1UQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cc14827-1e01-4e3a-e52e-08d9d63f4ba6 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:49:18.9211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W/e+t8XGBpz6WAQ1GxByxEVBWrzIq2wiZNzs1YrKOoyyAXxlKQ4XdbZwOrNUjNzWPk/wdfgRVup9l2SNeKd6A5pxDUyd3qY+8gSVWA25o9Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4835 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oram, > Isaac W > Sent: Tuesday, January 11, 2022 6:20 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [edk2-devel][edk2-platforms][PATCH V1 09/27] SmbiosFeaturePkg: > Use MinPlatformPkg build include files >=20 > Use the MinPlatformPkg common core build files to build libraries needed = by > this feature. >=20 > Cc: Sai Chaganty > Cc: Liming Gao >=20 > Signed-off-by: Isaac Oram > --- >=20 > Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory > .fdf | 2 +- >=20 > Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeatu > re.dsc | 52 -------------------- >=20 > Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.ds > c | 18 +++++++ > 3 files changed, 19 insertions(+), 53 deletions(-) >=20 > diff --git > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemo > ry.fdf > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMem > ory.fdf > index c3a3e81503..d46bacfbd2 100644 > --- > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemo > ry.fdf > +++ > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMem > o > +++ ry.fdf > @@ -7,4 +7,4 @@ > # > ## >=20 > - INF SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasicDxe.inf > +INF SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasicDxe.inf > diff --git > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFea > ture.dsc > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFea > ture.dsc > index 094dd957b8..7a165f39d7 100644 > --- > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFea > ture.dsc > +++ > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFe > +++ ature.dsc > @@ -33,28 +33,6 @@ >=20 > !include MdePkg/MdeLibs.dsc.inc >=20 > -[LibraryClasses] > - ####################################### > - # Edk2 Packages > - ####################################### > - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > - > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibR > epStr.inf > - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > - > UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo > otServicesTableLib.inf > - > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry > Point.inf > - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > - > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf > - > -[LibraryClasses.common.DXE_DRIVER] > - ####################################### > - # Edk2 Packages > - ####################################### > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo > ryAllocationLib.inf > - PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > - >=20 > ########################################################## > ###################### > # > # Component section - list of all components that need built for this fe= ature. > @@ -69,21 +47,6 @@ > # generated for it, but the binary will not be put into any firmwa= re > volume. > # >=20 > ########################################################## > ###################### > -# > -# Feature PEI Components > -# > - > -# @todo: Change below line to [Components.$(PEI_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 > -# is completed. > -[Components.IA32] > - ##################################### > - # SMBIOS Feature Package > - ##################################### > - > - # Add library instances here that are not included in package componen= ts > and should be tested > - # in the package build. > - > - # Add components here that should be included in the package build. >=20 > # > # Feature DXE Components > @@ -101,18 +64,3 @@ >=20 > # Add components here that should be included in the package build. > SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasicDxe.inf > - > - > ########################################################## > ######################################### > -# > -# BuildOptions Section - Define the module specific tool chain flags tha= t > should be used as > -# the default flags for a module. These flags are= appended to any > -# standard flags that are defined by the build pr= ocess. They can > be > -# applied for any modules or only those modules w= ith the > specific > -# module style (EDK or EDKII) specified in [Compo= nents] section. > -# > -# For advanced features, it is recommended to ena= ble > [BuildOptions] in > -# the applicable INF file so it does not affect t= he whole board > package > -# build when this DSC file is active. > -# > - > ########################################################## > ######################################### > -[BuildOptions] > diff --git > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg. > dsc > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg. > dsc > index 31141c0725..e72b341154 100644 > --- > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg. > dsc > +++ > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg > +++ .dsc > @@ -24,6 +24,24 @@ > PEI_ARCH =3D IA32 > DXE_ARCH =3D X64 >=20 > +[Packages] > + MinPlatformPkg/MinPlatformPkg.dec > + > +[PcdsFeatureFlag] > + # > + # PCD needed for MinPlatform build includes > + # > + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable > |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable > |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > |FALSE > + > +# > +# Include common libraries > +# > +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc > + > # > # This package always builds the feature. > # > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20