From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.2536.1658350322938950356 for ; Wed, 20 Jul 2022 13:52:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MmKLnqkb; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658350322; x=1689886322; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=t3X/IkTK2qlLTYY9AIubLxCG7Wk97iBpmD4t1W5WBd8=; b=MmKLnqkbcPt9Bxp87OYl7cMxSv63KFYMghOzfHxZYXeEIjKfReFTlHDE 3AlhRCQIi0yAQ1Lo0xWmWARAsbUkFJgogp9ZwtgJ4XryhWtOAzFg2CDyX hVKKLpxOF9nyxAT7caawE1wy4qW8cWOOqRkf/Ty8RUOUZ8Mmsul0hG46x OHZgNVw4ywARwisuf/TmWy+ZKxvd7GYQro2YElvM2endGsh47gbfsnTKM ZpijygYHhkFN+B1W7obXBZQCH9sX3MXFle9c+1UvWdpWakNhQ7aG4s56U OjMpWJcq5tsgjBNkvukDlNorrNhoN86mbRDvucEw+WPQyzqCnhjOUjxRd Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10414"; a="286890584" X-IronPort-AV: E=Sophos;i="5.92,287,1650956400"; d="scan'208";a="286890584" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 13:52:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,287,1650956400"; d="scan'208";a="548503793" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 20 Jul 2022 13:52:00 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 20 Jul 2022 13:51:59 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 20 Jul 2022 13:51:58 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 20 Jul 2022 13:51:58 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 20 Jul 2022 13:51:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUGOdsIcYIkGVLuJSkjdZrBSH374i5NJgDq5ZVqjB4SkxJtdv0Vt1aar4Pty+JLdSgAJTmwMvziTaB3AO7DIx+5Rx+OWUnnxCn4l5C7HfbWukSFD0kfSdjX25D5gECwn7Kc0PhR16iepItmGcNjjN9Kbsqh62QuFAiktvlhMVho7rCAYi2KqmkdB2CkMUkbL2Mc35j5+iq8NHf+h4gNC3wTzzzACPKLsyQna7c0LF48EhxB4f87qv4Vx6EYfQBYykxQHbR3FYfmMhI8SusjzrXv8yqK5YMq9SyGQoEGxcW4z+ZPZHr8J3wDa+Q6k/8QjOje7PkQL+UuA+RietrGtcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P4hz8aTycPBPk6Hd0pa8i9rMPpOqGkl8OgjQPXlDEiw=; b=PfYs5xTdwVoYuf8tbKXfM5UIs5b4R9run6k+QMuUKEpUeENloP0OP2kpGuXmT/hJ5szOEbZqNYAP+vGJ2Ks1Ps7AWBbYirCadvn+egLoy5HNc64MAv+Mo8IoM/reIUzXW+KbMoMDmGiMD+LenTU+cZRxh9PWcoh7GrgoNgio5PiuTOJYetCA6EUD9GQYuPc5UVhSSVh1xABX9bjP79bgu0MsI1YmAVb05IS4DXKtLQugFNMhKcLRCvIeXVeOBErS40yqLc0PR3hBSt66OFCQeRhiMfJnyObjmdrpfde4iTqlpwAqbuzCM4ISsEaXfVVWcW3E05E8O3xdyu04JFeGvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by PH7PR11MB5941.namprd11.prod.outlook.com (2603:10b6:510:13d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 20:51:56 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::b4bc:a6b4:5832:5ae0]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::b4bc:a6b4:5832:5ae0%3]) with mapi id 15.20.5458.018; Wed, 20 Jul 2022 20:51:56 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD. Thread-Topic: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD. Thread-Index: AQHYnGs0Mx1Ru1m3YkyPxODjVssWAK2HueZA Date: Wed, 20 Jul 2022 20:51:56 +0000 Message-ID: References: <20220720190134.3734-1-chasel.chiu@intel.com> In-Reply-To: <20220720190134.3734-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f3c7994a-476d-42eb-b2f4-08da6a91aef4 x-ms-traffictypediagnostic: PH7PR11MB5941:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OF/Ohhfz7BQ/nQicHJzVB9vPMVzjxZbc3MaQR/j0KbMuj9/v+gj/W3tMnqbmOEiTNHsD8pxKK7KNNYz3QXpGQ8d3/OhMe4ZKMShZqnQfBYkjPu8VEclWS7UtY5/ZTXGpb/sUBeJtn3rTCpx+WPBUfYkRQVLs/rJoDYdbG5lVpf0P8NSxdo2J8i8mzyNpZHjey238f+ze1u50ofelmo82Idr3/lpAt2LQP2FzjNZdxgelXZUst+kHJ7xOBCth6fyzBb2LV7YZ/3hmOrvJ8jeOXG2juKD1CzFPjVhXiziWjOnaxxbYvFtqqQ3jzz3ZwzZTWW6bQMBV1i9YWRY/PxmBpVzZ2K9to75QcU0fKPw4TqdC6s8ean+y7hhV//6LYVgLEPW5ekAbr0x1CHDtaY21Olj/yFcG7Twc7dOym4kwZS0qJwbyNG824VtaZynB9UOazcMMoJORNq5/bh6evnFFpmg9TA/ZioHfuNn0fHZY+fu34CQJOMdWbF7Afoe0oxPkUey/tUJZ5xu/SiDI8v4R8YtQ8ZrWGe3YdRvhkJm+KxxzS7Nn6GZsCAQSS6Irht1wyxXuWeESraP0mWd6OayM5hOAOt0nt5piBpuTMayp+C0yTRq/0FpbwjBzfH0sV7eVLVRwIIu+PDts6lnxouyPoWEeYLMLxTbirH3HSQxAa4XXAcTBgd5ADGCQTEaoXANTlkdYOSZNrlrpLjdQvaI/AhagDEeElAAblLV5Pt2FSzHeKnapyEwFIAOa2076wXEW5fGltzRMQuoyMf6HNx/Ju2HlCHAaZs4gjkptWLzaFiwWcOs0y7uwSxbIhJNRspsELJQP4SIOGuqUIXZ3OhRGpA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(39860400002)(376002)(396003)(346002)(19627235002)(8936002)(5660300002)(52536014)(33656002)(8676002)(66556008)(316002)(66476007)(110136005)(2906002)(76116006)(55016003)(9686003)(7696005)(966005)(66446008)(186003)(38100700002)(4326008)(107886003)(86362001)(53546011)(478600001)(122000001)(38070700005)(71200400001)(83380400001)(66946007)(26005)(82960400001)(41300700001)(6506007)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dW8HZKcID3M3tNqjYHtfZ09aVIqtJ4/09cRtvvCsQkQLnQToufh7ICbWNgY0?= =?us-ascii?Q?pEAdDsqfSe6R+9cUI6OYAP2ifwOoE9eUGmU3D189GGiY+vUXnFsb79xemshm?= =?us-ascii?Q?4teUjgoOt8RgafaJJE910AIsvAWWJPBbSjZ6e0gLdinm6f50ORNTLsnvJZNh?= =?us-ascii?Q?8otIPpI2/zV0BdtwjF48NnA4HbNGVoivlGClNnOJ8npp0StQG8qHw1NkmyG5?= =?us-ascii?Q?MnXrsAIbWW9eqrBu0Xh0rCJuA9Ct+Z4aVZfyoZKapjcoyrYjVVjnTn5Mb/mp?= =?us-ascii?Q?U7Jd86PCW06x2ioLOn96zKlEpygG4JzzYYCiItWnaouVX3hsAmtGQb73/k9N?= =?us-ascii?Q?WHXB24g+iq/wfZ0V/KA9AikniIlA6MoXhIPilyHX8bYAaBK7tdPR4Ihb4d7x?= =?us-ascii?Q?ol5rLygTRmJCztJJhkLXoLTYFiVu3RMwKPKFbNU0PhZwAjwj9rbqOzpB4kic?= =?us-ascii?Q?k6tC92uT9SoWb0ebhCZm+0RcCemVs/hbnr1pfah2GejnmZmxdj/6m11RjL1+?= =?us-ascii?Q?33COeiB8K41cy5mzHWNegTGduvrNzmEgY+cLf6ZmeOxtIRjOqJ/p+6dC+jBE?= =?us-ascii?Q?ERQOs315SSHqD2y+9srBb4LLHpmJvMug7sHC9pzPRWfxAULfXg539UqaNfzM?= =?us-ascii?Q?wNT0w0bf98PaOJ/rK4i5gThtQhaol3lGDOlkOF+PtzY9cqmsV3/3e2tlxpF8?= =?us-ascii?Q?zHGG1aX9D87QbdWzfafo5yyuBOJa9RVZf9Uf8dpAXmSdr24pgCWjBUR7wcn6?= =?us-ascii?Q?bX6ermE6SVX1PL4wmYorFitI4CwKwGepiPZhGRBvH/3Q3FYPa+zk2hK3w2pt?= =?us-ascii?Q?HRgHwRdpQaiPQewjOquHcMqZ14l6DryF8gp/Xs4nAL47vC/MWzS2mCEGUfrn?= =?us-ascii?Q?xacaNawGs3msfgxETDq/ZJPNZsHSXOm8+z+4RwAzLEaljm44GGC70MktHsTL?= =?us-ascii?Q?ScCCgsZJUp2lBqomy+L2E2UvvR0VYjBZRzQcj1lgEv+r0rBl8ZrFDSi5A/J1?= =?us-ascii?Q?rCHWLgYBvqIGPW7LDoyfnUUP7+kRnHVzzFRbfVBWjc3UbWAVJtsFJ0ETnb8F?= =?us-ascii?Q?E6+YQOGN9019AlUfG4zG/jLTBGsvOEpb7Ref9jjx/mVqDRNUB53iOfq5iDEU?= =?us-ascii?Q?LTQJjByRzUtCvnke0vMx1IkkyurX0wZPaIYKPHINX0SIc9yT3UdK77zmSuNi?= =?us-ascii?Q?lgVK2WGmh5e8HcQjF8jg+BNXpHErGWr7QlL6xIw8Q/I0fo67YFCsDThRXVBa?= =?us-ascii?Q?cunmg/PCZCFfgp8JsEv9vPE7s537n/cziRjfhwbOEAxUXIamhrMWMTj5kzay?= =?us-ascii?Q?THoMtVbVAHW/DzfyK2ckMlMVNLpbdJ3cAFk/nDQiLFm2KENRYBFn5FSONnyO?= =?us-ascii?Q?y4cpBoc5dLA0Xmtpp1sBo2hVN6dkG7VqPLfMxt9nsxppF2MvB5ATt+v30F2N?= =?us-ascii?Q?Ad61kUskZ3o88bpHGetorTgJ3rswJIlk1jCiO60FegQA3u54eZVfII9Ih/K/?= =?us-ascii?Q?SYI0J7Pwc9U3dcWOgNshkqxeFimEiNTzHxf88YbWHfiLd5U80GEdMEURqvcl?= =?us-ascii?Q?jGQ8Sox1Zeg8cj8FXg0FcYny1diwUefnFONOH02dfHiMKarMv2ZmVvo3MwgW?= =?us-ascii?Q?ew=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3c7994a-476d-42eb-b2f4-08da6a91aef4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 20:51:56.3951 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OfQfMsw3oVBX9XRyk8nCJc9dyZYtNLcKn57gFOwSwlFLjnmKlHxvs0Rcf2NwZVOhN2zHHzd9UI4wC4TVRyEipJj/hf9RNycRvQcYcrQp6xA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5941 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Chasel, Please see feedback inline. Thanks, Nate > -----Original Message----- > From: Chiu, Chasel > Sent: Wednesday, July 20, 2022 12:02 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3993 >=20 > Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up, > and some comments for clarification. >=20 > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Include/FspEas/FspApi.h | 69 ++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++------- > IntelFsp2Pkg/Include/FspGlobalData.h | 2 +- > 2 files changed, 63 insertions(+), 8 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Include/FspEas/FspApi.h b/IntelFsp2Pkg/Include/= FspEas/FspApi.h > index bf46f13f73..ad5d62c385 100644 > --- a/IntelFsp2Pkg/Include/FspEas/FspApi.h > +++ b/IntelFsp2Pkg/Include/FspEas/FspApi.h > @@ -1,6 +1,6 @@ > /** @file > Intel FSP API definition from Intel Firmware Support Package External > - Architecture Specification v2.0 - v2.2 > + Architecture Specification v2.0 and above. > =20 > Copyright (c) 2014 - 2022, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -100,13 +100,14 @@ typedef struct { > /// "XXXXXX_T" for FSP-T > /// "XXXXXX_M" for FSP-M > /// "XXXXXX_S" for FSP-S > + /// "XXXXXX_I" for FSP-I > /// Where XXXXXX is an unique signature > /// > UINT64 Signature; > /// > /// Revision of the Data structure. > - /// For FSP spec 2.0/2.1 value is 1. > - /// For FSP spec 2.2 value is 2. > + /// For FSP spec 2.0/2.1, this value is 1 and only FSPM_UPD having A= RCH_UPD. > + /// For FSP spec 2.2 and above, this value is 2 and ARCH_UPD present= in all UPD structures. > /// > UINT8 Revision; > UINT8 Reserved[23]; > @@ -134,7 +135,7 @@ typedef struct { > } FSPT_ARCH_UPD; > =20 > /// > -/// FSPT_ARCH2_UPD Configuration. > +/// FSPT_ARCH2_UPD Configuration for FSP 2.4 and above. > /// > typedef struct { > /// > @@ -196,7 +197,7 @@ typedef struct { > } FSPM_ARCH_UPD; > =20 > /// > -/// FSPM_ARCH2_UPD Configuration. > +/// FSPM_ARCH2_UPD Configuration for FSP 2.4 and above. > /// > typedef struct { > /// > @@ -209,6 +210,11 @@ typedef struct { > /// > UINT32 Length; > /// > + /// Pointer to the non-volatile storage (NVS) data buffer. > + /// If it is NULL it indicates the NVS data is not available. Please add the following to this comment: This value is deprecated starting with v2.4 of the FSP specification and wi= ll be removed in an upcoming version of the FSP specification. > + /// > + EFI_PHYSICAL_ADDRESS NvsBufferPtr; > + /// > /// Pointer to the temporary stack base address to be > /// consumed inside FspMemoryInit() API. > /// > @@ -232,7 +238,7 @@ typedef struct { > /// This value is only valid if Revision is >=3D 2. > /// > EFI_PHYSICAL_ADDRESS FspEventHandler; > - UINT8 Reserved1[24]; > + UINT8 Reserved1[16]; > } FSPM_ARCH2_UPD; > =20 > /// > @@ -265,7 +271,7 @@ typedef struct { > } FSPS_ARCH_UPD; > =20 > /// > -/// FSPS_ARCH2_UPD Configuration. > +/// FSPS_ARCH2_UPD Configuration for FSP 2.4 and above. > /// > typedef struct { > /// > @@ -285,6 +291,40 @@ typedef struct { > UINT8 Reserved1[16]; > } FSPS_ARCH2_UPD; > =20 > +/// > +/// FSPI_ARCH_UPD Configuration. > +/// > +typedef struct { > + /// > + /// Revision of the structure is 1 for this version of the specificati= on. > + /// > + UINT8 Revision; > + UINT8 Reserved[3]; > + /// > + /// Length of the structure in bytes. The current value for this field= is 32. > + /// > + UINT32 Length; > + /// > + /// The physical memory-mapped base address of the bootloader SMM firm= ware volume (FV). > + /// > + EFI_PHYSICAL_ADDRESS BootloaderSmmFvBaseAddress; > + /// > + /// The length in bytes of the bootloader SMM firmware volume (FV). > + /// > + UINT64 BootloaderSmmFvLength; > + /// > + /// The physical memory-mapped base address of the bootloader SMM FV c= ontext data. > + /// This data is provided to bootloader SMM drivers through a HOB by t= he FSP MM Foundation. > + /// > + EFI_PHYSICAL_ADDRESS BootloaderSmmFvContextData; > + /// > + /// The length in bytes of the bootloader SMM FV context data. > + /// This data is provided to bootloader SMM drivers through a HOB by t= he FSP MM Foundation. > + /// > + UINT16 BootloaderSmmFvContextDataLength; > + UINT8 Reserved1[24]; > +} FSPI_ARCH_UPD; > + > /// > /// FSPT_UPD_COMMON Configuration. > /// > @@ -393,6 +433,21 @@ typedef struct { > FSPS_ARCH2_UPD FspsArchUpd; > } FSPS_UPD_COMMON_FSP24; > =20 > +/// > +/// FSPI_UPD_COMMON Configuration. > +/// > +typedef struct { > + /// > + /// FSP_UPD_HEADER Configuration. > + /// > + FSP_UPD_HEADER FspUpdHeader; > + > + /// > + /// FSPI_ARCH_UPD Configuration. > + /// > + FSPI_ARCH_UPD FspiArchUpd; > +} FSPI_UPD_COMMON; > + > /// > /// Enumeration of FSP_INIT_PHASE for NOTIFY_PHASE. > /// > diff --git a/IntelFsp2Pkg/Include/FspGlobalData.h b/IntelFsp2Pkg/Include/= FspGlobalData.h > index 697b20ed4c..cf94f7b6a5 100644 > --- a/IntelFsp2Pkg/Include/FspGlobalData.h > +++ b/IntelFsp2Pkg/Include/FspGlobalData.h > @@ -12,7 +12,7 @@ > =20 > #define FSP_IN_API_MODE 0 > #define FSP_IN_DISPATCH_MODE 1 > -#define FSP_GLOBAL_DATA_VERSION 1 > +#define FSP_GLOBAL_DATA_VERSION 0x2 > =20 > #pragma pack(1) > =20 > --=20 > 2.35.0.windows.1