From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BC533740034 for ; Fri, 3 Nov 2023 21:16:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ivDnMEBf07sDTUj7gg+kWLiWYQTJfmh3Yxt8Q54nntU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699046181; v=1; b=uLOEsxMiReDQOtlLLuvIfE92qThEC15v7mdak2WXsRLLBZBslRGSGbaqB0gXwjMP8mKURROk J4AaPstoCyKQbm5hv8wO2pKWmt/x+PjoTDe66GckcEklP0bWDhF+56Js/Y2q1RZBtD8Wtr9+558 WKYHFMJdKqYKmoBeO6HeqMW8= X-Received: by 127.0.0.2 with SMTP id TpYLYY7687511xHAOYPkvz0a; Fri, 03 Nov 2023 14:16:21 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.64970.1699046175035263975 for ; Fri, 03 Nov 2023 14:16:15 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="453324315" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="453324315" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 14:16:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="878773790" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="878773790" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Nov 2023 14:16:14 -0700 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 3 Nov 2023 14:16:13 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 3 Nov 2023 14:16:13 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 3 Nov 2023 14:16:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRajrhvDaWAKKjrEaY+ysi/SGmAyuON8+sIoaMiS/KKYRB1BeC6Gjkzyuk7YMFT5WDYGQ8r+Q379S6UZk/67qodZQHv59MVIhtYvBLrcAT77FxU+MFORpM74FimGuqDNGB70/85YIJyrxlcQHBi5pSA+2M272Mh2afYWQTbxm7y/0oLmtP2rAvF3APtBAJIAt0WMdNQePTeDtaBf9wqEKJlBpqNGpUGIM60aJBZep2h6cxulXUgVowOFXkmBBmAx5qDxB83r56HQky3z4veYsu6/OvP9On57Dk7uB9rE139WJQGGv2CdcbBJwq81Ho3Pe6vW13MzkFyf0+I/88YCLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F2qCFtpUoLc76mbHQHA+wnIG6mgsLGvw8l8xP4PfpDY=; b=cK4kR2ejg4Wz0X/viazkKQrPLHm/Zb0aalqiuejXo/tXZ43A6pxvroVPb/GSWjK/5XwEjw05q2yRWv2mKPhc/GfIAdm3R8TIwZiDt43bUyjMCNCr/XhaP9q5sPkl2FPVisN45GEQEVrPpZIxJ0DbXsrosW02V41XfH7M+DOBOLfoTbfKXFP38uj5R9+q7WuH8Kn2y1NnJyHivd2QT6uskLsQ5+4S8LUs4MUyy2flTDuKv0Fruti4X36rLuZCYfvIM1Lai2KYKOyDtlii4ePt1+FDipWZM0XqDUSjJo17xyF+GWovEO8v1Vat69SFp8O8fTmEw8PvurZiwicCcDij1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SA3PR11MB8046.namprd11.prod.outlook.com (2603:10b6:806:2fb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 21:16:11 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::c90f:1f62:c3fa:3ac8]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::c90f:1f62:c3fa:3ac8%6]) with mapi id 15.20.6954.019; Fri, 3 Nov 2023 21:16:11 +0000 From: "Nate DeSimone" To: "Huang, Li-Xia" , "devel@edk2.groups.io" CC: Abner Chang Subject: Re: [edk2-devel] [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaC8LPpRxwzET+N0WnrpUoOljpALBpHlIA Date: Fri, 3 Nov 2023 21:16:11 +0000 Message-ID: References: <20231031062338.1501-1-lisa.huang@intel.com> In-Reply-To: <20231031062338.1501-1-lisa.huang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|SA3PR11MB8046:EE_ x-ms-office365-filtering-correlation-id: 6d61cbd7-a11e-428b-de7a-08dbdcb21a8d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: g0zAG54dEG+Olkl4gxeFDG56BQ1rvnEZhs8NO+T8ZwAKmjStQzaaY2jY3U3EUNp47vrpZRFFKSHpkOHMdXH1fWy49w5lB1OsopfqerhZ4t/1towxsCOf0Qc4wpFUh9b/xGaMByH2uexidD2IVb9vMOyeprKSy9l2c+fPPFJhvsDb9jPKtnMVYI1LMKzCQkLYl26hYvGkaWvrEpc0Ya+XshczUplXrwBKuxTg+3/QPyfyIol53vLZgnwLzPq2e50RTTxc+kx7OwTFwSs0EIuEGVPSOsZ3Hb7ADz9FSoMLuV4FMSsXGGhdwcwBAx7j5cm3XioD9HfAKzqoQlQ03/jCfBuBBD2T7s8uLoAkq/Z8AdLKS/sDm2ljr7HtUNyGJ78UCcuh/PZg8FnZIW+A51cn1poMWxJbFnBP5u7lEng/W5JYiVa6pSFHG8pwSJRAz68YvO8cB7788AOzykvVvCAV7nz3m3Ye0wu3ChEEuQOeULIt7SUGwj/NR6+f25hLsvZF+gJS+hSEDx/lSqJyKdUnOwryJsFUYi4QoGoCv11qweXbsqyVZLWjMFlQvaOPsahIcIKkd+dMRQRi9EF4+Jn2//kacyZ+Ls3mn9e5d1g1E5kC1eDBN/kYVlM0qb9dNi69 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f470vXQJ5xZuXff+UkQ+M6lZnjrzOjrffRuwLYc5adnhfPUCfdSrycWbENDj?= =?us-ascii?Q?umzFYGy1a9O0unQtd7OUMQcuWBsLMHJzhxJWi0XYJ3X5XrwqOpiMpfdE5BAy?= =?us-ascii?Q?QRLJYnEH82BgKP6CQCrrxDp+6mrnE7rZAFwp6Bx18xwJY0AV8T9dyZF4kyMh?= =?us-ascii?Q?2D+46D3j+vy9MoLHOfFgrhDrx8o+S+XHuBWBadIOPfm7tkeESRlj4r4sTtnH?= =?us-ascii?Q?W7ZCa3bn4KQ+i/OVvuO3qDZbi5pkDJ6pwmN48wx58srvVyrqdrhzvT96TPqf?= =?us-ascii?Q?On70isbSOwKFCb7ZpVlg6T/g/ZrOi3xGyQ31vVF+K5Z+2INvkT0cTatpxcms?= =?us-ascii?Q?fVvqjqVNuBbO5oF4E9lpuZl6FiLOGb1fu7ED57NupRA/tzptwSo0V0tN7tNO?= =?us-ascii?Q?2D/+NeWW3bbeTl/E0UBYWasZCMC/AmD3z82Yll5uzbmpqH4DGn8qwuHIbMTV?= =?us-ascii?Q?kYtD+2j3AZozScCS6zaRNIKWAEPLwDzV8s1SNNtujkVrLg6QYDLBLo/VM1Vw?= =?us-ascii?Q?02ExZH74JhIZuk9KUX8CLa3fjejjgIA3G4F0xt5I4lL7KjGl4bhFDAL0e+hh?= =?us-ascii?Q?cJEYWhRrXAWKhxdEz+vb8YnDv7Ag3q81IzYWjJkmaNxop/hvfGIVfgVMK70/?= =?us-ascii?Q?ydOJZT5Zq7QRhfiI509SL9bFENMxr22jhSNbRuSz0nPoC4Ht48igQCDUTnEX?= =?us-ascii?Q?YZh1R9LrqfaOaiCkqjl2yIQwk9HAJ8w0J0aqg3drJNBb/IXDxjeGeTdz2FSF?= =?us-ascii?Q?7GRNCjoZjczWY6yyukDkIXeDwxhg6fK/e9n5qILWIFvyHEVAH8yTqxhly3CT?= =?us-ascii?Q?rcCxyMKl5jBJtf1Vkz7pbIvB3pZUPZ64lgz05dFqaL4THjWmqZKNa2z19xUy?= =?us-ascii?Q?USlkEcqo8fYRy/UN0Fola17XWuQFQaouxJ+IT2Rhqs5Q1DmvEjv9B07EqcTw?= =?us-ascii?Q?Am6LGD2p+vtsxC1zai3U2p/of1k+2zfE9IN67YDgg6eMNZ8EXBi13W72LSqR?= =?us-ascii?Q?heJ4nbyUmKpiNEDxzV/6pLbR2qgQ0XGG2+iQERszhmxptYOmgPslR0ORwMWG?= =?us-ascii?Q?948258Kelwas0/8SuHvmWWLh3ZFkVcpIl/bkNotyUxzmVvxggfOvE/T0QMxh?= =?us-ascii?Q?jqHtMNxpGo3fATvl9qNNinZdyffRBsYfEH1O7/iHiOsu86CQFG2MrM1vuXeC?= =?us-ascii?Q?VVh53NDS1YiPfXpHQN4NGgUc3dJJTifzWEcU/mIXFT97KUI4CrVMfdWaXEO4?= =?us-ascii?Q?fvsU8XT2g438DtPzQr9TvBdIJY+HS9XKIvz/15kMyRSPcTfOZc4s4i9aMs0d?= =?us-ascii?Q?6r/hXZQPwkhEZ4UU+iasingr0X8bQKO/U9fuU9ikdo0qUvoAqEJTZUYxf08v?= =?us-ascii?Q?E8myaZbbNbzTJYm2hAFA2nVzKt6zyaY5XZIYOMRte4BSK1gXOrdqcuzJv1HI?= =?us-ascii?Q?tMKVLENoyVZkHpz3xDEVRB4+u14hBhqKxidgq79FOmuRMBqXTvxTSN2sgAq7?= =?us-ascii?Q?9Y+qjafHsJk8C9lm6hwepwPRecEA4xo+BgZl4tgRzoP/ABHD45mASw7NqVOJ?= =?us-ascii?Q?3ZY36TGADss2HYubRgwDHpryKUC2F4x2uEvQAQriEafg8DUUgfuQX9m4YSCm?= =?us-ascii?Q?eg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d61cbd7-a11e-428b-de7a-08dbdcb21a8d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2023 21:16:11.0761 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AVpI5Aq0d33FwqamPry2TD/a/p57rjfW9HgDRTs87QsGac1eTgCIxVEWpE84lOixzeeJ/4Kp9OiVfY5eutGD+6B23WyfS0K/KXilRQIJT+o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8046 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mXbzoij6d9CY2m17kK88ZKZqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=uLOEsxMi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Pushed as 3c2f11d > -----Original Message----- > From: Huang, Li-Xia > Sent: Monday, October 30, 2023 11:24 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Desimone, Nathaniel L > > Subject: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone > MM >=20 > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver >=20 > Cc: Abner Chang > Cc: Nate DeSimone > Signed-off-by: Lixia Huang > --- >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.c | 146 ++++++++++++++++++++ >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.inf | 51 +++++++ >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > | 2 + > 3 files changed, 199 insertions(+) >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > new file mode 100644 > index 000000000000..d808e2517c99 > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > +++ daloneMm/StandaloneMmGenericIpmi.c > @@ -0,0 +1,146 @@ > +/** @file > + Generic StandaloneMm IPMI stack driver > + > + Copyright 2023 Intel Corporation.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +// > +// Statements that include other files > +// > +#include > +#include > +#include > +#include > +#include > +#include > +#include #include > + #include > + > +#include > +#include > +#include > +#include "IpmiHooks.h" > +#include "IpmiBmcCommon.h" > +#include "IpmiBmc.h" > + > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > +EFI_HANDLE mHandle; > + > +/** > +Routine Description: > + Setup and initialize the BMC for the SMM phase. In order to verify > +the BMC is functioning > + as expected, the BMC Selftest is performed. The results are then > +checked and any errors are > + reported to the error manager. Errors are collected throughout this > +routine and reported > + just prior to installing the driver. If there are more errors than > +MAX_SOFT_COUNT, then they > + will be ignored. > + > +Arguments: > + ImageHandle - Handle of this driver image > + SystemTable - Table containing standard EFI services > + > +Returns: > + EFI_SUCCESS - Successful driver initialization > + > +**/ > +EFI_STATUS > +SmmInitializeIpmiKcsPhysicalLayer ( > + VOID > + ) > +{ > + EFI_STATUS Status; > + > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > + > + Status =3D gMmst->MmAllocatePool ( > + EfiRuntimeServicesData, > + sizeof (IPMI_BMC_INSTANCE_DATA), > + (VOID **)&mIpmiInstance); > + > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > Status)); > + return Status; > + } else { > + > + // > + // Initialize the KCS transaction timeout. Assume delay unit is 1000= us. > + // > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) / > + KCS_DELAY_UNIT; > + > + // > + // Initialize IPMI IO Base, we still use SMS IO base to get device I= D and > Seltest result since SMM IF may have different cmds supported > + // > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > (PcdIpmiSmmIoBaseAddress); > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGN= ATURE; > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRES= S; > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > IpmiSendCommand; > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus= ; > + > + mHandle =3D NULL; > + Status =3D gMmst->MmInstallProtocolInterface ( > + &mHandle, > + &gSmmIpmiTransportProtocolGuid, > + EFI_NATIVE_INTERFACE, > + &mIpmiInstance->IpmiTransport > + ); > + ASSERT_EFI_ERROR (Status); > + > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > + > + return EFI_SUCCESS; > + } > +} > + > +/** > + The module Entry Point of driver. > + > + @param[in] ImageHandle The firmware allocated handle for the EFI > image. > + @param[in] SystemTable A pointer to the MM System Table. > + > + @retval EFI_SUCCESS The entry point is executed successfully. > + @retval Other Some error occurs when executing this entry poi= nt. > + > +**/ > +EFI_STATUS > +InitializeGenericIpmiStandaloneMm ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_MM_SYSTEM_TABLE *SystemTable > + ) > +{ > + SmmInitializeIpmiKcsPhysicalLayer (); > + return EFI_SUCCESS; > +} > + > +/** > + Unloads an image. > + > + @param[in] ImageHandle Handle that identifies the image to be > unloaded. > + > + @retval EFI_SUCCESS The image has been unloaded. > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle. > + > +**/ > +EFI_STATUS > +EFIAPI > +GenericIpmiStandaloneMmUnload ( > + IN EFI_HANDLE ImageHandle > + ) > +{ > + EFI_STATUS Status; > + > + Status =3D EFI_SUCCESS; > + if (mIpmiInstance !=3D NULL) { > + if (mHandle !=3D NULL) { > + Status =3D gMmst->MmUninstallProtocolInterface ( > + mHandle, > + &gSmmIpmiTransportProtocolGuid, > + &mIpmiInstance->IpmiTransport > + ); > + ASSERT_EFI_ERROR (Status); > + } > + gMmst->MmFreePool (mIpmiInstance); > + } > + > + return Status; > +} > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > new file mode 100644 > index 000000000000..170e0a8d136b > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > +++ daloneMm/StandaloneMmGenericIpmi.inf > @@ -0,0 +1,51 @@ > +## @file > +# StandaloneMm Generic IPMI SMM Driver. > +# > +# Copyright 2023 Intel Corporation.
# SPDX-License-Identifier: > +BSD-2-Clause-Patent ## > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D StandaloneMmGenericIpmi > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f00= f81060 > + MODULE_TYPE =3D MM_STANDALONE > + VERSION_STRING =3D 1.0 > + PI_SPECIFICATION_VERSION =3D 0x00010032 > + ENTRY_POINT =3D InitializeGenericIpmiStandalon= eMm > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnload > + > +[Sources] > + ../Common/IpmiHooks.h > + ../Common/IpmiHooks.c > + ../Common/IpmiBmcCommon.h > + ../Common/KcsBmc.c > + ../Common/KcsBmc.h > + ../Common/IpmiBmc.c > + ../Common/IpmiBmc.h > + StandaloneMmGenericIpmi.c > + > +[Packages] > + MdePkg/MdePkg.dec > + IpmiFeaturePkg/IpmiFeaturePkg.dec > + > +[LibraryClasses] > + MemoryAllocationLib > + BaseLib > + MmServicesTableLib > + DebugLib > + StandaloneMmDriverEntryPoint > + IoLib > + ReportStatusCodeLib > + TimerLib > + > +[Protocols] > + gSmmIpmiTransportProtocolGuid # PROTOCOL > ALWAYS_PRODUCED > + > +[Guids] > + > +[Pcd] > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > + > +[Depex] > + gIpmiTransportProtocolGuid > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > index 5df71300cbd1..73dca30caae9 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > +++ ec > @@ -129,4 +129,6 @@ >=20 > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > D0000003 >=20 > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > |0xD0000004 >=20 > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > 0xD0000005 > + > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] >=20 > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > 6|0xD0000006 > -- > 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110672): https://edk2.groups.io/g/devel/message/110672 Mute This Topic: https://groups.io/mt/102292409/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-