From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.2155.1638406143781006218 for ; Wed, 01 Dec 2021 16:49:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=BpcCCktG; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="235326048" X-IronPort-AV: E=Sophos;i="5.87,280,1631602800"; d="scan'208";a="235326048" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 16:49:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,280,1631602800"; d="scan'208";a="459452888" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga003.jf.intel.com with ESMTP; 01 Dec 2021 16:49:01 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 1 Dec 2021 16:49:01 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 1 Dec 2021 16:49:00 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 1 Dec 2021 16:49:00 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 1 Dec 2021 16:48:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/akUO3nwrIaa+mH//ro3qaZgIHuW6OCIzOXcDp+1TtdXQHczQT4K5Hu/x2v6pLq1sKG/b5WNxLOnrYfWs0faNP1U210kqkhtn56o8pOF2jTnp/qVFjzsTdcJnGOg4qaqDDmqJmRXAfqArhl+jr01RkJPHU+Fs/NcgQmgxJmS84cS6o7YdgVKZGIH0szZHe9kwUvYWZlwQMQ00VZ388Iackm8MlbP3MxjHnUZNtAVsv3xS88xqqjG4WcLfuh5pITu3aHj9LML/ghocDUYE3z6e3In4C4n1ZWGT/psA5zpiPNC4fJ9uAaUwZn1rn59qy9OKxh5i03E0fZ9yjdlJNzyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mR30svpx8Kf0hbbXNbZBQZh0q8Gsp2qQB/cbpKpAzew=; b=b3TH1UMqdAp5F+IUtRhiCiIWgDJoBXMwaMiNo0OcI33uf/1eRSCzc5HuAt7fNvAVC1ge34Gvanw2Ga0qf/RkfxGGpKQr0Pyti7YRHQ0H/M74zeRDgKtGtDrI8H1y6q33qmzIqL9QWgM4n/75ayy+n701ATSH4JkHpcURBtC8AzWDltvJiq4mfnph88AcikiRZXmxMi6pHPzkrLIK8fQmfDx5rUrujpjwIEa/8rsXp5kAFLcr/048NfrtJb0awPNuDOQTTFfb69aejrtpRuImBgIb1u7LXYcsgSNVNYDa0dKy1JyJzQZ+2C9b327HhIUGi07HwEFKoru65ckf2gudxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mR30svpx8Kf0hbbXNbZBQZh0q8Gsp2qQB/cbpKpAzew=; b=BpcCCktGvsqUXMHaeXG6WEAvQRxEtsClPtYmey92d2u3n9lfVPUv/NNGEP3UrNVr7AXM1D/ihu//HvyOZecSDBDF4CjsL7w22q9T4ovW/Y7RRP8ZuBPaLJqyhkL9bYVYedM5BkFb7RHdp/2g/CvubMrd8Emq57m2Bbe14ruY52A= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by CO1PR11MB4836.namprd11.prod.outlook.com (2603:10b6:303:9d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec 2021 00:48:58 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%5]) with mapi id 15.20.4755.016; Thu, 2 Dec 2021 00:48:58 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Tan, Ming" Subject: Re: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Thread-Topic: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Thread-Index: AQHXyv/0i/NdxMcJO0CnouQbVpop3KwelZRA Date: Thu, 2 Dec 2021 00:48:58 +0000 Message-ID: References: <20211027065653.6579-1-ming.tan@intel.com> In-Reply-To: <20211027065653.6579-1-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6b9b6a4-23a9-4d4e-1d06-08d9b52d86a4 x-ms-traffictypediagnostic: CO1PR11MB4836: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KAHHQO4RhOpuMjmtGfLLuUqOuPrqomFVIRUu86Uo8riVGRbyBJ+zdcOhDTeEK8yiSp/FXNtgQoQDvpG1ixos3IUdFzZMZeUGhfKq7NNInuZFD51YmFq0GUNlLNM3t/W9D8mMIpBQVVHTLGzzjmPIKDQHyaSnylJyobdBTVHavAASFzc9+QuDnnXmk1lbpaEmaegh53O2FBrEIOHC32M0Sp6aYkpDPLT2Q/r/aASch3C2TGP93fVZ5Jtx3oMc7uSiBUxaeymTpV/1SkMPZzFppaF/6DJRwJu/vLKhn9pDLUthbrcXEn+PySnqKx2QGV5UA1760zU+YrceLePUmYXu8citgylXo4aL5i4bjipPyZfdJp8SrwMp9DcfTUk0K1/idYBV/sgL08wwVCEHuQEr5TuS7aj/LCcaRmCZd9vRT6lznvHK2jW7ZNrZ+aInScASQN0otszTqOCh/qgETXbFDcKaQByC5aqfPeLI4k2yc4ntSBf6d+q6XX0PiZvvrlO71qu4Sj6H/9RjtRZXQHVTiFyTsaCzFE8dLS+NbreusUkCh3sluwuPpHSLtdnIFxBqJBCn6OX76iPUa6d5efQaXj6EVY+XGgToO70jb9KGfUQQK8mnII10xHrKFZ7lJo/cO0SluwTIwFVzc4dXLxL7yuH0erS7B3ZaDkRYEz45ds7bxyza3P6QrwpLE8V8AUe38Am6bQtxdgalvzYNZ+LDkLp0YFhJHUNH3GvIJiycbpP84/QSIPSczOB1ijklYbshVDNYV3ImqX06KxG7fzA/2KV8R3nN+6lkysuHc4WOi63GYPN5oIygxYnRJRUXwmKhjI4Su7ZTc3NcEkvdfMswqw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6636002)(316002)(33656002)(66476007)(82960400001)(6506007)(9686003)(55016003)(122000001)(66556008)(8936002)(7696005)(52536014)(966005)(26005)(53546011)(186003)(38070700005)(71200400001)(66946007)(8676002)(508600001)(66446008)(86362001)(110136005)(2906002)(5660300002)(76116006)(64756008)(83380400001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nAHq/Fv3j8qRidJ1y4zrUB2g7z4xOlSeDqgdd+Md2dtbZRb56gEA9VSw/kn1?= =?us-ascii?Q?Mq5+xyxVNtTXBuaZ4Hz+H5hTIgaU+fyCeGkLhdUN20qj/PDaBOBbVsJBEHNn?= =?us-ascii?Q?SU9BXOyevcDOsNuAlD2HxvabwtYRnp3wYq5FrNcMOKQDcU2pKcj1P0e1Sb5l?= =?us-ascii?Q?coJwlxouN1tf7sRhp8YJqKK+fhHmNq/nDfo1f9iyeyNRFYPP3yVGlHqF4/oL?= =?us-ascii?Q?c+Mh0qEVf+S7Qtj4UPL2pQPErtAZ2Yp5n+yO6YmGgnwiHgXgVd8LR4+eWINM?= =?us-ascii?Q?5lD3dPtQ8A4xGFKF6A9iFxDF+zXeyNT6d4lHYhGZutSJzvBoS9GPMOJujwPL?= =?us-ascii?Q?2qGNgLJ19WMksG6PIP6cN6Ki15/8VJaPMummEMeaNHk5kw4inUCcVUW8g1S6?= =?us-ascii?Q?xJW4lcIIUwUaH4NP02Ox0gRkvDSrh5Qe45DCGXcNnOKJcosUAqBgVSOLwz7v?= =?us-ascii?Q?Ez9DR4Na7oBZ0J+hwg7rgwAvG69qq81br3n3j7b3b1yG+B0Yn5c3WxCKwQnI?= =?us-ascii?Q?IjdPe2BRw0kXhfckQSUn+fAiddCUhF0TFx7WtKpAtSl6zAF7WtnpI3R7AYQ3?= =?us-ascii?Q?z0nwvW9LzKMKIYxACZlX0JquGGzWReA3Nd1grCD7DV5B3Wf8c0Ggfou/cVjz?= =?us-ascii?Q?PFuqEnLjPF4lw318JPnDmtPDNWWpr76J4/U7atWygZKrwV+2bUF/c/0Pbe+y?= =?us-ascii?Q?Rk8Jl5EFvdjPwqa+NKf8MU8grvC9TKzMy9sFjymA4TgZCAne7OieJtAN82Jy?= =?us-ascii?Q?vpQRs2V7l1vWwkF1ldQ/EUjaJTxqpp6zC45wpUDbaiXyovF+F6CuGr2iSb9h?= =?us-ascii?Q?jWLvoR2MqjpMV5tGGl8ExnClbWyyQeN9rLXVbDI84lpNysyUBCwqWer/2GuA?= =?us-ascii?Q?Xsv4q85861a5k7py70pWX4yXikPM43yRUk4VdLeBTtP93RvfuvYx7clursRh?= =?us-ascii?Q?vltpqCVAjFBSjXzWqjnELz7K1qTOitH9H7yWEi7yUBK9ioUZy+eGnn1wlJhP?= =?us-ascii?Q?74kilcqWufHj770f1xlks30w9KZTDmXjcpAqSVUKZOPBnNxQIV0i3rKlVZkU?= =?us-ascii?Q?LAaLXODAiCrah5vLGHtBiqsXGwoRO9j2dC6b4fJnVxIn5Ursrp53rs9AUWp7?= =?us-ascii?Q?exbtKYvqeaSFxF7Aj88jGW469UYO+ZGAY69V6lGIZeDkOX2bMZQ5z9NNFBrj?= =?us-ascii?Q?4CtaYzbqnoGNglHapN80s6Z845/GByLOvd/vC09fuoly+81XNF+i/xORLJtK?= =?us-ascii?Q?OK+pSjW+al6IzpwCxUpbpB61YXuE/PVjUrMeqWqGOFClcfnRujkvuyXWUvnf?= =?us-ascii?Q?PT4inHl53tJ7e05DKqsV0zOD0Rj+2kx+Q/eKa/NozQvI2uz09ojUQpxufogo?= =?us-ascii?Q?PY6YtzYisF3qij7VVmRSq959CdZLNx6C0O32v0ltuDTmawTCJNOWKTsDTL75?= =?us-ascii?Q?PuuwCZgIwVP+SX5DYWljJaK4TPCft/z9uPEx04d6zmE4jYSBgpJlwmc4EpXG?= =?us-ascii?Q?u0oHXdXfwEQkpUvcdfyxWDBWS8ZndpfPXcocgfkqYt2uw2LeTmCeIzquz6ez?= =?us-ascii?Q?S3QjjT1tD6v2TTDk3RMf/Y0dYW3sYkU7yeHjmc2qwCwr59v+T4vT9ixpMBIy?= =?us-ascii?Q?4+iL8s5sD6ZDFry7zfQ+IwmCRGZttWw7N78JPsC3uS7AQXiT4YnEZWp3lLKB?= =?us-ascii?Q?eKIiSw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6b9b6a4-23a9-4d4e-1d06-08d9b52d86a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 00:48:58.5432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6sKZhpezsQuU2n0cf1IP2dS5Fg9lLAm5PoP0qIz0dJ3qxK6STA/5Awi30w2914e/ZeblW/mEj0smSWGIFg8TndvGxGPu+O+QM3oFqS6PhGU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4836 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Tan, Ming Sent: Tuesday, October 26, 2021 11:57 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrup= t setting. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3708 The original code will cause FWTS V21.08.00 testing failed. spcr: SPCR PC-AT compatible IRQ 0xff is invalid spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device Now modify the SpcrAcpi for following: 1. Disable the support of PC-AT compatible IRQ support. Now only support IO-APIC interrupt type. 2. Set irq to 0. 3. Set the GSI to the value read from PCI device cfg space 0x3C. 4. Set PCI Flags to 1. Signed-off-by: Ming Tan --- V2: Fix a typo .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c index 86c40e90b8..7ad0c058c8 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ Acpi.c @@ -324,7 +324,9 @@ GetPciTypeInfo ( } gSpcrInfo.BaseAddress.Address =3D BaseAddress;- gSpcrInfo.Irq =3D = (UINT8) Irq;+ gSpcrInfo.InterruptType =3D EFI_ACPI_SERIAL_PORT_CONSOLE_RED= IRECTION_TABLE_INTERRUPT_TYPE_APIC;+ gSpcrInfo.Irq =3D 0;+ gSpcrInfo.Glob= alSystemInterrupt =3D (UINT32)Irq; gSpcrInfo.PciDeviceId =3D Devic= eId; gSpcrInfo.PciVendorId =3D VendorId;@@ -332,6 +334,7 @@ GetPciT= ypeInfo ( gSpcrInfo.PciDeviceNumber =3D (UINT8) Device; gSpcrInfo.PciFunctionN= umber =3D (UINT8) Function; gSpcrInfo.PciSegment =3D (UINT8) SegNu= m;+ gSpcrInfo.PciFlags =3D 1; Done: if (Resources !=3D NULL) {= --=20 2.29.2.windows.3 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82732): https://edk2.groups.io/g/devel/message/82732 Mute This Topic: https://groups.io/mt/86622293/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D