From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"benjamin.doron00@gmail.com" <benjamin.doron00@gmail.com>
Subject: Re: [edk2-devel] GSoC 2022: Add S3 resume support to MinPlatform
Date: Thu, 14 Apr 2022 00:49:21 +0000 [thread overview]
Message-ID: <MW4PR11MB58219F9645AD99A1AEA77463CDEF9@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <14513.1649442784656663109@groups.io>
[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]
Hi Benjamin,
Yeah the GMBUS I2C controller gets very temperamental if there is a protocol error. I think you have to go a full reset of the controller to get it back into a working state. I haven’t figured that out completely in my POC code yet so that is one of the things I suspect you will run into early on 😊.
I took a quick look at your proposal, looks good!
Best Regards,
Nate
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron
Sent: Friday, April 8, 2022 11:33 AM
To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] GSoC 2022: Add S3 resume support to MinPlatform
Hi Nate,
Thanks! I've looked at the basics of I2C, but I've seen from the iGFX PRM that GMBUS implements some registers and error handling the NAKs differently, but I guess that I'll be dealing with that later.
Yeah, I was thinking that if we wanted debug up as soon as possible, then the iGFX BAR and P2SB GPIOs would have to be programmed, so that sounds about right. Synchronising with the FSP's config is probably important too, but I suppose you implemented that/we'll see?
For now, I have a proposal at https://docs.google.com/document/d/1CyyerMfPwvZxkBjfE_-H1OlkZPxH98uqpmb9tBAV_ps.
Best regards,
Benjamin
[-- Attachment #2: Type: text/html, Size: 4008 bytes --]
prev parent reply other threads:[~2022-04-14 0:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 21:14 GSoC 2022: Add S3 resume support to MinPlatform Benjamin Doron
2022-04-05 18:14 ` Benjamin Doron
2022-04-07 21:46 ` [edk2-devel] " Nate DeSimone
2022-04-08 18:33 ` Benjamin Doron
2022-04-14 0:49 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB58219F9645AD99A1AEA77463CDEF9@MW4PR11MB5821.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox