From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.21920.1644376855844577796 for ; Tue, 08 Feb 2022 19:20:56 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ITiHIh8P; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644376855; x=1675912855; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EKicHaQry5ZLpGQ6ghywTcfef8iuAtQCtRmMO8requQ=; b=ITiHIh8PYMJ4ua7w5TNLvgbcem7jFtG3oMhUHnPHdkvfs4gnrtnziPnR 1ovZ5TtGSi/ZxLnytBALuK5lhFNVkvCBGM/H0Dg0DCN4WXElv8Z1G4tV6 H7gHkwPbaU5hfEHhiGSHQxGmoSoHC92pTF0kULRJRDJTZj/Nrwcn4VA9i 2U2eSKnvNZnzwmOUilMd2CTfMshkWAdWtP55MGwm6LBVLW00lHH3ZMURZ /gCVRAE03SKHlAbx8mqgkfkQMFkzxU9tbuZWIuCXbkP1twUaz6LgJzD+L YkxQS6MLSNptoClPzRaMMtTWLrzxtJurPtBdJ/df2x931Xz/53eGoPBcb w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="236515835" X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="236515835" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 19:20:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="633075305" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 08 Feb 2022 19:20:54 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 19:20:54 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 19:20:53 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 19:20:53 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 19:20:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M6w7qBm06rUeOtlGvjvR6iN5NBoXM6yvEUOyuLU+ftxGZeU46JscskKOHDs9iFj9bW8MfYlg40DJeG7AEBzfWZShmTne/5kmHQR96JwDi9nvOVdiEeBSqb0nhBtscpx1/daf6qzG1eOTlolTBjZOykBPGtDcUCHSvtEhCXiNtLF2rgV7K6UsTKINGpjJLZxXqRyO5JedZO4mbzpWyemAX87zzS5OaBRx6M4+7STKODX0QeC5Qm+PUsI9/qoINfeJBvONKrKc+0dojefj/SD1A0j8mSeKGFAk5/GqoyTb8LE222Z7d/usqgOVj2/nm08OkDnUgZPxAKisp7/DM0pBkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IYpcDJmuTsE4IDULvs9ooPX7rW9Y6KoZCijD2g541+g=; b=MAr7HHvBSgxwNPCzx1hUt3Vz4C31Oh9l1tjZ7eChMXvW8b593wDDUhkV/wkKK1vXdinAUHBgwRMrh3mlJWUL0hILYJiT0UpB0/pJ+snHX3Vve05lf2v0Kqm8W+ct5IVbeaam6JK4r+6iFdoMXU8+OUOFwuaa8kpyriHcE4wg9tp0vFLNNHRiF/FqtkF/cEEb9OIZY3ciqSltMOkQJp5uYS8gcru/qio5GwdncahAAObmtuxOrbhUcec+ccsyq6Xq7AAJvKnSGA7gXRiWWdumgAn/KSXW2eJsWkBTnhvq53cFk8k0xY+juQJAhw0DOcNMhmEgG0Qij8msfnT+za7rDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by DM6PR11MB2668.namprd11.prod.outlook.com (2603:10b6:5:c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 03:20:51 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%7]) with mapi id 15.20.4930.022; Wed, 9 Feb 2022 03:20:51 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/8] MinPlatformPkg/AmlGenOffset: Update for python 3 Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/8] MinPlatformPkg/AmlGenOffset: Update for python 3 Thread-Index: AQHYHFVTHm7jh/jJqkyyuGX/kT6ReayKj0wg Date: Wed, 9 Feb 2022 03:20:51 +0000 Message-ID: References: <661e68fa9ad9455333d989afb3171824d99f598e.1644259969.git.isaac.w.oram@intel.com> In-Reply-To: <661e68fa9ad9455333d989afb3171824d99f598e.1644259969.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af589be0-9a7d-4561-ee5e-08d9eb7b2cfb x-ms-traffictypediagnostic: DM6PR11MB2668:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ecDuMhbuerb0qoP9ru7FS9R199VHq7MG3b5u7yUk/nEW32cjb5/ovHxahrCyOos6UfDfV+zV7ijBCpzoQkFR0LrsoKnWkQkzmDY1b552Hu3VBCmtU7fQG7gCmGWMuUPFBwu6KvORTUokkByLXDpW5awRZQ3Rn44FI3PfO5LH+/eIvUr+G5Pu8PGI0NTN9em4gMnaoh9uabKbQr6QyWalf55mnsfyua86gOElhjC5sqeQuuun1L70fO3MbhL0dQXuh40Fr7YaU6Dus0Rxcuzgl1JwCx+s1G5aJwZghi7j8r6IRkTq3FbJzk99c5D56CscMhymqXjflp60zHCQ8TbE/dH7Lw7cG4ttrojdV2r4/KOgD6xIESdvRGKuaghl/ZpUfkVO7p6EePgKgqkzTmQXP2FeNkxdRYYyBYPezLzntpi2k9QSIRv05bsPhzlZ9CYqOxBKS1AMgehaRtj8NGLR12Nw5+CpEg2ZZFGgZqt7nt52ncGycZyquZLiYp9WGsX2uRLNCMr8rOLaZkjvJLm4a47HzT7Ne0rcJfd5DGh0IVzJPZMPqG2hbgw5ODNaQlR6tqTYEqzyhYkpY9wbzmT9XAmUzAeueL+OKqHTAJsmKKO4x2ZBipBCPuWxIk4ez1HMWAseLPLEFaypZJxOwCarCkSO8cGy1+5FHCWGc3LoIEGMWa9NrFQwmWUJwoykqii1koGrkWRgboZGp8hGP4ctDw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(86362001)(8936002)(76116006)(8676002)(122000001)(64756008)(66946007)(38100700002)(66476007)(66556008)(33656002)(316002)(55016003)(186003)(26005)(4326008)(66446008)(71200400001)(83380400001)(107886003)(9686003)(508600001)(38070700005)(6506007)(7696005)(53546011)(15650500001)(110136005)(82960400001)(52536014)(2906002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t3jX9ynjfiPkZHOB52H98ja+Ctm7bM4R/h9rnKv+CfGTArjxenTYx1r+BcJ5?= =?us-ascii?Q?Y6VJaadiqqMp261AYyZ3dR/mhXOb6/GGo9gMZdUbfvOeG7LMi83Tc2Iys0qe?= =?us-ascii?Q?rURqMYzx9m08hWJN8LXk2eWGikHwEZPEn3OBK11o95Lq7H6MeBW6C2K/0A/E?= =?us-ascii?Q?+T/cnJVQYy8aCuHZzW2MdPJMdzLQtZ0W1PU9AU2tTs2rWLDOSHr8Rwgtbo4O?= =?us-ascii?Q?wd1uq94viE6nUfdaPun2OFF8uZJA9EMJ0fTxwrVSd6//eUii5Ra2xt5c46DD?= =?us-ascii?Q?plG3PgiTNWkbGO6Dq2JRg7qEmcDrbI4oYNxGZHr96AdeLkWcXABniU81kYfG?= =?us-ascii?Q?kH//UzjUC0uf0eih6RDb4adTRj9whzpQnttdJ0VkTWjMoh8TGnsJ6PwytUmi?= =?us-ascii?Q?U7wJA+b0NOaw69TyeEhoPuskjeCqlGCUlKviMIEoyn6QnewEfIGUQmTKliD+?= =?us-ascii?Q?+lcP29OxNA8PNGu+dkHrqMYPnQz8QupW7rcNnz7gbuN5E+2g7kQMR2QVJUSN?= =?us-ascii?Q?dpoY/5KrLPgxoF7e10Di97gTpQ1qrkC0IOwAtrBgHRe8OpDyTfhZbTsV7pD3?= =?us-ascii?Q?2XM+NZc3PZ/V+NwARuLEL3wMb07rXoCx98kVbrgn9He9BMXTIiqmsbHet+vf?= =?us-ascii?Q?VgkGvpQH6dSNbcTROkl8i20/Cha6zhLkPKqRbWtS2FDgdiC2vqBhuMHOJb2Z?= =?us-ascii?Q?euEFbK/NHadEl04bMmzecWr0A2VPKkjfJaBxHpPr5JnjGNo7OUDkMXUtsRqI?= =?us-ascii?Q?saFcBoitETX+gNIHi6chF7iQ3srL6z3E7/u+axT7nYN2X5NMvyIfTbWkGGXo?= =?us-ascii?Q?unvKbG4qF3H0TwPC1eQz/6ixH8oma5OHdysFiq75rYeBxQ1Tgg0xMlBlEIge?= =?us-ascii?Q?P4DcU0iyeS1XmSjeUz81pLt41b9c0Fl/wfuqPzz82MS//+FWqnW5ugYeNjpm?= =?us-ascii?Q?rthF+foiHCi6aODR4JxERuK4EJN0cdZLEerdAe9EMyBgheRWPBJWvG9Dn8Xh?= =?us-ascii?Q?vrSmuRZXriibS+c/zCkJDe4zJky9bb2UZyjOzbnYlOAOFJE2WKIS7F2laBQB?= =?us-ascii?Q?PqQQL/ILb9hQ6+GmoxfeCsK3v5V63bQpWhEPLmsftP8erxp9dFu7U5svUZCj?= =?us-ascii?Q?/9flVeU8opZpn15Ibm2cGeS5ePSYl3ufvllD0EQk8AvYC1FR9HiGPP/wb/f2?= =?us-ascii?Q?I9pKyigHKRvjW8SqDAEVwrpD4dbNrVvmWtZGiTKK/gQ7DGJkir7Se53e3fYK?= =?us-ascii?Q?fuDxajDRX8Rt59EGySKp2+n5Lynre6c7I05Jx1T/bhpDEn+0i/Q5cUNAWeCb?= =?us-ascii?Q?tYgCdgclP4giP0ylAXOBv4F3hBbs2+Ch4yNev6X2I9zDlKzoui3WJJsu2w3B?= =?us-ascii?Q?SULhRu12SPizCnXgbtVco/jeaBtDY+FgijsFT2TuLeWGLfFiWtn8B0d7OAUs?= =?us-ascii?Q?k0xCREf2GkF5E7WqLsN4IaFTVd1X6WH1ssWoDfRy9FwxD4dPTspeTX5aqX/m?= =?us-ascii?Q?gNHDWRCsRbOKX4g5i4gatdXl10Al8pZUs/SXE7XsuWG3YMvxLdU1mgoNT7lA?= =?us-ascii?Q?GZns2s8cShR+BAmQs401z8ydyio9OObzUP88nBRpoAygZqZBp8/o/rlAJ04H?= =?us-ascii?Q?vsbAx3O8iGgH2X8np5OwbnmM4ax5aqWVeuWHeQ/VnB8MaGXdeIYvlkNhAuRh?= =?us-ascii?Q?3ZWEJQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af589be0-9a7d-4561-ee5e-08d9eb7b2cfb X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 03:20:51.6755 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mNC3g2VgT2/bEMCo+b0xMt55hb4DsrNpC5Kt6J9AQxSxhU3WE3Yshu56jFSGMc8YToPX1OJd/qxzN7XIoDJlksYaqoMfS0TfDlBgMdhbR88= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2668 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Oram, Isaac W > Sent: Monday, February 7, 2022 11:03 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > ; Dong, Eric > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/8] > MinPlatformPkg/AmlGenOffset: Update for python 3 >=20 > Update for library changes. > Remove version. > Changed to not open files as bytes. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Isaac Oram > --- > Platform/Intel/MinPlatformPkg/Tools/AmlGenOffset/AmlGenOffset.py | 13 > ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Tools/AmlGenOffset/AmlGenOffset.py > b/Platform/Intel/MinPlatformPkg/Tools/AmlGenOffset/AmlGenOffset.py > index e13ca06471..4799eee1a9 100644 > --- a/Platform/Intel/MinPlatformPkg/Tools/AmlGenOffset/AmlGenOffset.py > +++ > b/Platform/Intel/MinPlatformPkg/Tools/AmlGenOffset/AmlGenOffset.py > @@ -32,16 +32,16 @@ if __name__ =3D=3D '__main__': > # > # Create command line argument parser object > # > - parser =3D argparse.ArgumentParser(prog=3D__prog__, version=3D__versio= n__, > usage=3D__usage__, description=3D__copyright__, conflict_handler=3D'resol= ve') > + parser =3D argparse.ArgumentParser(prog=3D__prog__, usage=3D__usage__, > + description=3D__copyright__, conflict_handler=3D'resolve') > group =3D parser.add_mutually_exclusive_group(required=3DTrue) > group.add_argument("-e", action=3D"store_true", dest=3D'Encode', > help=3D'encode file') > group.add_argument("-d", action=3D"store_true", dest=3D'Decode', > help=3D'decode file') > - parser.add_argument("-o", "--output", dest=3D'OutputFile', type=3Dstr, > metavar=3D'filename', help=3D"specify the output filename", required=3DTr= ue) > + parser.add_argument("-o", "--output", dest=3D'OutputFileName', > + type=3Dstr, metavar=3D'filename', help=3D"specify the output filename", > + required=3DTrue) > parser.add_argument("-v", "--verbose", dest=3D'Verbose', > action=3D"store_true", help=3D"increase output messages") > parser.add_argument("-q", "--quiet", dest=3D'Quiet', action=3D"store_t= rue", > help=3D"reduce output messages") > parser.add_argument("--debug", dest=3D'Debug', type=3Dint, metavar=3D'= [0-9]', > choices=3Drange(0,10), default=3D0, help=3D"set debug level") > parser.add_argument("--aml_filter", dest=3D'AmlFilterStr', type=3Dstr, > help=3D"specify the AML filter.") > - parser.add_argument(metavar=3D"input_file", dest=3D'InputFile', > type=3Dargparse.FileType('rb'), help=3D"specify the input filename") > + parser.add_argument(metavar=3D"input_file", dest=3D'InputFile', > + type=3Dargparse.FileType('r'), help=3D"specify the input filename") >=20 > # > # Parse command line arguments > @@ -49,11 +49,11 @@ if __name__ =3D=3D '__main__': > args =3D parser.parse_args() >=20 > if args.Encode: > - print 'Unsupported' > + print('Unsupported') >=20 > if args.Decode: > - args.OutputFileName =3D args.OutputFile > - args.OutputFile =3D open(args.OutputFileName, 'wb') > + args.OutputFileName =3D os.path.normpath(args.OutputFileName) > + args.OutputFile =3D open(args.OutputFileName, 'w') >=20 > AmlFilter =3D args.AmlFilterStr > filter_pattern =3D '|'.join(AmlFilter.split(' ')) @@ -69,4 +69,3 @@ = if > __name__ =3D=3D '__main__': > if match_obj is not None: > args.OutputFile.write(line) > args.OutputFile.close() > - > -- > 2.27.0.windows.1