From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.2156.1638406573218323465 for ; Wed, 01 Dec 2021 16:56:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=bTSH5vQ4; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="297394217" X-IronPort-AV: E=Sophos;i="5.87,280,1631602800"; d="scan'208";a="297394217" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 16:56:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,280,1631602800"; d="scan'208";a="500479679" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 01 Dec 2021 16:56:12 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 1 Dec 2021 16:56:12 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 1 Dec 2021 16:56:11 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 1 Dec 2021 16:56:11 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 1 Dec 2021 16:56:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WbfLSBhcqX/BmpDpI3eY7q3nVS6FXcw80rtcNlqhlAERn2hCO3S1QVqVxx6GGk15lyonRc4QXKOhHS8KSdpeFW77Idn9tGzPpr3uN84xTOwdJM4pXPX+pwjlxRA5fhqKNCz/jey+AhhtqGb1jtgibiB0MsQTnkmWHaLC1mp8JjWs24dznMsjTAfPeE+bE20Myx4IyCDy0uVM/UR5SueznRzLU/VmAQ6BPrSFDv+pAFdDzcj/JEhqGahoNTpohY/DQcd/N/aiICL5MsvRmK+XTD8kOrfQ2yXD97gKXwWy3qcQPGF/OoDegx0mcmp9/JdrhigEaAJ9aTLAj+FP7k9NnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sOMsYboiZ2elJ8SqUfjT+Hp7USRQxUZZyn0Lh95vNwc=; b=LlUv6iGi4kmV9uGmUBdXH2t7VfE6Hcp4trCrPpBYwz5bEHOZYKNB9EIhQZhSA9n1xd4Gf+jS8g7Efgu2Nbgs6y/fN2ilvevVmyW+Y9Aub7W1inn4ViPChBC45q0xkgqvFpZ2zxJheE7QZIaScUDDjcLdyyyZuueAJ+O0rR0qbwf4zRCLnbd+H1gUzqhRl2a6V1TGh0gjhg1gxpG587Hbwc9RsfNMHuidO+1rEfYCYYLTljeM7pTCX28RVRYqyrU0naROITIyRHRp3JtYW4VlBVETDGzM9A2QTN4xQ6zn3N1dQb6RnciB1Az4Wntz+n81fcwkC9N2/H/mZ9c12F+dKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sOMsYboiZ2elJ8SqUfjT+Hp7USRQxUZZyn0Lh95vNwc=; b=bTSH5vQ4H2bqtXvcYpnLWccBla0AyafbeVVNjBPGx52k8EAv3zocx1dDr1H4HaOJP6a+DV5LGFJoyZA1q+svpHIqFO+/QLlLDbD7fIUvIBvgNkemQI/7YI5895Tp63XkGhtKsJmmFzm0/5jnsQVZEFS6TX9j3HVPWziniTr6OVM= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec 2021 00:56:10 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%5]) with mapi id 15.20.4755.016; Thu, 2 Dec 2021 00:56:10 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Tan, Ming" Subject: Re: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Thread-Topic: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Thread-Index: AQHXyv/0i/NdxMcJO0CnouQbVpop3Kwel/JQ Date: Thu, 2 Dec 2021 00:56:10 +0000 Message-ID: References: <20211027065653.6579-1-ming.tan@intel.com> In-Reply-To: <20211027065653.6579-1-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b4d7fe5-1ce7-45b7-023b-08d9b52e8815 x-ms-traffictypediagnostic: MWHPR11MB1805: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:813; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tzW8x3I6GA+fueEiJa+tzS4Oc+cz7RkD01O1jfTVg141sPQvOMU1TrEgpD5cLi4qtLMIpau3feuxRwk9FlhE0T8Zy32X+urhRbkUgbU7GnZZJiMkwgKwZAlA4Xmj8oAVIofdr9yM8TSaOTRsCS+XWARsM3nUeOU8QnjJEaZFb1nIp2QOoF2hMEl4BWovoeG1jW6PlP2ldPRFGHKU1nV7zsoJ9pvJoeWou5uyTCCKS0Cy86n08rpoAByHPySuu5RCtNufPZ6gkannpmd2RluD5+ASTRuSQC+UvnWq9iUjhuRe8T7OHEXF5edEGIsEhPYthEafNOCxi4If7jsbw+AwIrph9hmVR+J5FtooskxF4EgWGXlpAZOOd1zxw+eXXEbQwIwlALPA31p4Lhzj80ysrZjN0kDRayT+/eriBsIc+Jz4NXJIWqRKYg3NN7wAr172G86Png4kurbgMRRGHNMd2emlJF8OsGblGi2Rmya8u+L6CSZOB5Pdby61z58EDt5L3LdGFbi44AJedX8D8vmnScS8T36hYWFTGDo3R8Qek/fcWDtnhoW4xrwUlwaUy7uHPu6MDgLUECHRKWGBmMQX+Kok/7WUyXsVL4z3Mj+L+z6p9xF4ezWCtCcnyoI+Q3J5TIPIt86yb9DE36vOEonUCdaSqPdoe4+bqjGcT6PuH1YfkwrQDvFBU/6SUtsMqErRlj8jt+XfSIwpDxTzA7XQh1OqBQkkhhl8QIjBnKyEToXVVlQlp0sbSjvXaIGl1+vPBisWaf4Bng0pYCGghZ4VidROpdPfZe82/2q/6YSUxGUewx+FujGDdCW1s8Ohskc+16LOskcNr5QCbeuYdDKMvA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(9686003)(316002)(38100700002)(86362001)(2906002)(33656002)(76116006)(6636002)(8676002)(66556008)(83380400001)(55016003)(71200400001)(110136005)(966005)(26005)(53546011)(8936002)(66946007)(66476007)(64756008)(186003)(6506007)(52536014)(7696005)(508600001)(38070700005)(5660300002)(66446008)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IeltibBm9rN3z8HJRKbliYmU13VwzwF9EEiqvA2xt5W7o+j7w+zAVo2c3XLv?= =?us-ascii?Q?G2q3717JxymqyPBkNRrcTOT9zwsdUDDs26FXG8HP+rV/n3THrdF0u6gPhQMi?= =?us-ascii?Q?OawSeLw9p4MG77n8KPcCI2jDkeqsaH2oCmx7ASr1NV1dRUuXJBZBcqpvUgrQ?= =?us-ascii?Q?1i0uLDnp4f9rV9GKtSyzTEIqyJldyBi26NkLajDYSQD3Jl1OWd27s7ONs7nC?= =?us-ascii?Q?QtKZ+VgooNs5kKBo0oeVbo+FAgbZU4KbSLD3RqULU6RNZ/piwsnaiAKBynMg?= =?us-ascii?Q?CBeOwrGzQN4/1rcrCtZq2RzKs2gQvr8K7GHfA2cKcTXCC9VX5Wfrfc129+Zl?= =?us-ascii?Q?TMhOKF8jHBJDcgxXrnhtmHLmxSAEfahPeMHfrwB8JhZZkf4PZm3u+l3pNtsE?= =?us-ascii?Q?GZccrQOnrUkWrrxlKZTaX4+pWtd+lF5/9WnsNXh7QdbxKgZw3H5Y4Ej515ns?= =?us-ascii?Q?4o7UYUq3eKnTbCsI+6G/rmbRqFEc3Jt6YFd19T50MCsdxFppGpecSeAmoFN3?= =?us-ascii?Q?f5gtOZ258Yvg5r9h0raygfy/rHix3Gy1+Nfby8PQcxKblekuMEeo/fA24Svl?= =?us-ascii?Q?oHKXBJxJOGw5egxtTtpCvqm/Ker0AzLAI/WnGVUNoQyaKgl/FIHGhm+D2utV?= =?us-ascii?Q?biC3cmzKHTqWiIwj85mRnHvkAEQwLSkudywckA/S8q3pVXIaL8Baz7wdC+Pq?= =?us-ascii?Q?Egeg/dlUQbJQLq4sYL1fNyyzPRpP+6gWfgFZo1cPUVitnZW96kDB3p2Kvvus?= =?us-ascii?Q?goDm+TtaMqZZAE7jPnChfHmcgpy6g85gp0BLROwPmZRUyjQbTu9ItBxh1prC?= =?us-ascii?Q?EUEQeXE8xK3nPEI6M1ikyf3GsnNDg1/APko/yYJ/Q+amM1xZii8puYqgSk1X?= =?us-ascii?Q?a5gj8YKC6MpA+hUz5ZekVjeb3LpclByQj4bi1JxxMSuBm7l6ugAk1tYtKxVk?= =?us-ascii?Q?oCyKCUZCyVdOt8xyVxGdmygQoBirL1Dkl5dYaZXzeQTAVAMH97UFK+EZh4qW?= =?us-ascii?Q?UfDFtCO6UWJQcjALN66V/IW86dUyMoUXyX6C9KGVWjGbFDsDPsD4tFpEpwkF?= =?us-ascii?Q?K/zPslnG64KFqcM+UEWC0bWbp6zBZHoYOwsq4BnUzP/nZpc4Kc1andvskH1H?= =?us-ascii?Q?n7MRpEmlie48UgnJvcappW5LBH/OnZNSnBngCBi8NjEleC5vK3ORJ2dWlBQS?= =?us-ascii?Q?Owdki4USL+sTQS4v+4n78RPqpZRrdW12l90kOPH+FTZhP1Y9FYt5fBRz52ko?= =?us-ascii?Q?39ZYbTmzO5G8m2eWxB2O+nMDMmqm/ZyJS4YRJPyjqbw6IWAnzlXFuX0v9InE?= =?us-ascii?Q?e5pGNDhGEYbxCqg5XsntmRiS5tKFHpoxAdoEn7Ju4BITQDl4eOj8HsiA1BNs?= =?us-ascii?Q?ZUMpxUvwQ+aNJb076PSWIjGsciFWPQcFTNkkZlrvvrkRmdBzayVlgWsNcp9L?= =?us-ascii?Q?GaLt0qWW3hNxXDY/VzSuzo16OMZDrjFFPIA5dA7LxqNvrHMHZwn+BqBWAXvd?= =?us-ascii?Q?8wfhXXVwQz/2WaGBJOasknl0B5Xoi6umnDDY1TDwI/z3O5p0HT61QcA7WjSJ?= =?us-ascii?Q?T69vsP2lF/LHBiwsAkFjgq7cJC4mYw4kDymroHoJSb7ZFdeVPRhZUkHcEnxu?= =?us-ascii?Q?FVlTAOYVOgyKrfS8bGi3y+dBG4x8Zm+azaM8cHdwswbZRAgpCw4bWF82UeFg?= =?us-ascii?Q?pICXbg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b4d7fe5-1ce7-45b7-023b-08d9b52e8815 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 00:56:10.4274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kN/4Ql+Zcg1zH2GY04O7cH0SFTY3N7rEIZ8m+bnQ9awDzADhPDGtXVyGaHxLAVHbMNsA8JX7xNDI2al+45xR/yDZOlhHYek8Nta87tz4v7w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1805 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/e9149e2 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Tan, Ming Sent: Tuesday, October 26, 2021 11:57 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrup= t setting. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3708 The original code will cause FWTS V21.08.00 testing failed. spcr: SPCR PC-AT compatible IRQ 0xff is invalid spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device Now modify the SpcrAcpi for following: 1. Disable the support of PC-AT compatible IRQ support. Now only support IO-APIC interrupt type. 2. Set irq to 0. 3. Set the GSI to the value read from PCI device cfg space 0x3C. 4. Set PCI Flags to 1. Signed-off-by: Ming Tan --- V2: Fix a typo .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c index 86c40e90b8..7ad0c058c8 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ Acpi.c @@ -324,7 +324,9 @@ GetPciTypeInfo ( } gSpcrInfo.BaseAddress.Address =3D BaseAddress;- gSpcrInfo.Irq =3D = (UINT8) Irq;+ gSpcrInfo.InterruptType =3D EFI_ACPI_SERIAL_PORT_CONSOLE_RED= IRECTION_TABLE_INTERRUPT_TYPE_APIC;+ gSpcrInfo.Irq =3D 0;+ gSpcrInfo.Glob= alSystemInterrupt =3D (UINT32)Irq; gSpcrInfo.PciDeviceId =3D Devic= eId; gSpcrInfo.PciVendorId =3D VendorId;@@ -332,6 +334,7 @@ GetPciT= ypeInfo ( gSpcrInfo.PciDeviceNumber =3D (UINT8) Device; gSpcrInfo.PciFunctionN= umber =3D (UINT8) Function; gSpcrInfo.PciSegment =3D (UINT8) SegNu= m;+ gSpcrInfo.PciFlags =3D 1; Done: if (Resources !=3D NULL) {= --=20 2.29.2.windows.3 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82732): https://edk2.groups.io/g/devel/message/82732 Mute This Topic: https://groups.io/mt/86622293/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D