From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.998.1667263944574751523 for ; Mon, 31 Oct 2022 17:52:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=OWeITBBD; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667263944; x=1698799944; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/bufekCg5U30ISthytGShatqWobzoatythfW/z+4GnI=; b=OWeITBBDhDFCQo1dx6BXB9dojCl9kFOnVgjyTf85ZtvikH49cFNs5Vtg M6YTK+zmfLEyiBMV4s9BWn+QU2qK+PnR5S0B/HXtrrtthwl+vYlW7Gi4I k/ximnEDu8Ceht69HND23sDCCdjjAq9iGunnsHfi5Jv6uKf0PE1kxwChc T0gk+lZxeRpygLS6D6Y59f1AEt+TZZQ1AVYw0Kceep4SvgIvcQYAu8xh6 H2RzEhThKLU6G/OODJf/lwG9hMI2MpTCSgYqUEZtEhnc7rvEpbelpJN3u GkpqAHv0y5/BHzduwW8oYgBMb4aKtQDSM9aVM2B9gZcWDXnQLSLAtJ9/M g==; X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="306652373" X-IronPort-AV: E=Sophos;i="5.95,229,1661842800"; d="scan'208";a="306652373" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2022 17:52:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="636241372" X-IronPort-AV: E=Sophos;i="5.95,229,1661842800"; d="scan'208";a="636241372" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 31 Oct 2022 17:52:24 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct 2022 17:52:23 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 31 Oct 2022 17:52:23 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 31 Oct 2022 17:52:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XwfLy2jtmFzI3TlFPfFbTIhyfQnsJW9RggXF117xgYoK+ByMffHTjQZxEY1awx0175pFpfjiKS2iDhL6R+BgZYiXt4MEK0tA4FN1hUcvKOyZcFRNq99na1VDLwP17L7tIaLeE7vDO/O68hS14E6v2h+/q8136OYHNYHMed3Z7kjuWvObLcV20RSjuCc83obT4BYeouZY/QQtu5lXcIcMm0cS1VYQdo6Wibowv1kUbiDPc85dOE0+SFnX6tOfkZn8+J2KwOhm/pbSWWSW2ZxLtaTG43ty4HQC1luWKO9pV6dsjuD6Qlczw06RiLJ6F6RwUOW1DZdfJ7m5Q0MdaWQdGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BHOOOHoW8PHP2dADwId4naKy28X27WzlENPJ5aQOW3U=; b=mDoHdD8buF0yYEG1QGlQN+vO7PEcy1LpPG2bSq1jHfXFDiJ0/V3YuoWlEVngWDAOtKvl/xDyXvyfD5DF/74IAWXv9I4ZloTknkN8l8JHRYcNlqyehmR7OGDOWTYHcYiMNggVQLq+KdLqQQ2Uq5NapTM33xRLHuP/5bDno49YYEwuySzimMHGJPdvP59v5wzF/IQ+nZ2m3reWS4J1+YIxfCU1BtS+xjoAM8tAhlqsDOr6Kk6/et4jBTvZgkfPSDMkO4WstxYx3k2V00zZycRYDyYtXuiwelr3YxvQfJbi31MYKlzzmvRIhZoec2+sVwMAEB0GPAMDBKsy/+I80eznkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW4PR11MB6934.namprd11.prod.outlook.com (2603:10b6:303:229::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Tue, 1 Nov 2022 00:52:21 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ed07:c685:11a7:d2f8]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ed07:c685:11a7:d2f8%7]) with mapi id 15.20.5769.019; Tue, 1 Nov 2022 00:52:21 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64. Thread-Topic: [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64. Thread-Index: AQHY6nk10UOGjaXn10a/AcbZ3/gSLq4pQ1XA Date: Tue, 1 Nov 2022 00:52:21 +0000 Message-ID: References: <20221028025829.1033-1-chasel.chiu@intel.com> In-Reply-To: <20221028025829.1033-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|MW4PR11MB6934:EE_ x-ms-office365-filtering-correlation-id: 953b69c4-04d2-4037-f58e-08dabba35587 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gy0xdgWOt/Kbaw4kUFtL+68/vlXGLZUMMZtjx+W47ePCHIu6Zh7pgsC3tOHDLz8C3546FH5ZqwNUYOodoe44gXwEP9xRPO7oNW8HIrE4IOyYsWCNapW/atsTHRSV4psYIfmI/HlTd61c/k3giVx63wSTTyww5MpRyCFGabc7Ta61x6qTiDeQWM1fyCd4/t8STGPuYC+avjlkmOntXOYNsShYuiK4UIfYbIbJBrZJfxYLCbVLXXyV2MS+wPgovPqHJDdFi4Qdw/vuCrZ2T08GoSMG3B8MMW5cLLIo8NNQoI6WZgmsj+eLQNXgcQQ5HU4JniDZRBlM0Zz17B2fRuoJccAXRihjEsXZRMMdJWtIvyw3CHc+lFjc+k+6hBXPntu3p3JC5+vaG6Dpf7A7ddXJDXyHx0do/MOWrzXZ22XXXKEauld82W/QziJPcgYy9P2Gb6f7k0BpGzllHu05R5k4HvQNlnYxwwmd2Yrea8vRwyx0Lr87K6Xl24PP+N7mNO+Oej8QpWeiG405snNQj5wBHuPguhJo0nPrgfUoXsvWcS/oEONB2qX733NsWcfD32Y7DNFmHVUppZH/DdtEnxG50B8tewnRt5Ny5xnCD6LqZO30YFueSEUDLth4SjXnxT3ZvLT3nV7xYKKpa0mJzJYORRpGurgyfXX39r1RAsJhkaxHUrm4eVZJeH2iUoD4yLcugZPaEUNOY0Dskor1jcABtgoFAhq2XYO10f35H0V5bdz+obdNSmi/+8X4+oQsPeKRd4AJO2dtfbxyOP4cChHukiuKivNIGIns1bJ2pbeFVNs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199015)(9686003)(107886003)(53546011)(26005)(478600001)(6506007)(7696005)(83380400001)(186003)(19627235002)(15650500001)(2906002)(55016003)(66446008)(316002)(66946007)(110136005)(966005)(66556008)(52536014)(64756008)(71200400001)(8676002)(76116006)(66476007)(8936002)(4326008)(5660300002)(41300700001)(86362001)(33656002)(38100700002)(122000001)(82960400001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z6eXRPI3/VZ2Rr4evpH4laLCp7xNo9uMEzi0hhfULL11cn/tWQnSuAG//jPZ?= =?us-ascii?Q?RbXv/n/fo+yxb/dg7Co00Yfa6xQOBHb6yauyVqUNqfrIB325J7MoW3lDzykr?= =?us-ascii?Q?ibXiZ2efal5O+z20CO/XPscJ9S/amJcbEkuEZoxy9Ky6f6Dj+kISaRN4LHgG?= =?us-ascii?Q?EuwjQHnNg9T9cPiokOaUm9D8xnn2scWWfMRDRwRcOLIGj/F8H6pHy9lMvZ20?= =?us-ascii?Q?1qMAAO1v8hmf/CZjFaSpOhJ5QF3lXTvZEugu7vLfIIZ1gfXvnhXjLSpBrBzz?= =?us-ascii?Q?Vs24gb6fllTuHCFEWhSxTjOTLJ6ORzfqD4XZwvNhO19U9uu/qZjWhtTAUpEI?= =?us-ascii?Q?LnuUhpcJm+v1vDgH9eg2rg5j/SjpGo9uSVtR7bufYtlg5WNAL6YLuqbLIma6?= =?us-ascii?Q?yL4i7WyWMpoqhX+o7HbDz6SD24hs19Jva+AmyWiMZZYHoHkCUew3s5mXtZRM?= =?us-ascii?Q?mjfBdtmdOJM5kQvOUFp2RIrBhIS4VZgkMWAbe6k6EiBTw1H/4Qd31kClW1wn?= =?us-ascii?Q?ZVb4rmZKerSnoUtgRxaqmLPkfsy/s6ZDmfXFKHQ3eDPtF1KB1Gla7OWzD/0T?= =?us-ascii?Q?ESmqdWGwYCOIH83XL6B8FmQpJrpFqSxXbcB2l0OjAcRor7kLniSaZQEtv6Hv?= =?us-ascii?Q?WTWlZT6iZY/lO2jMwJBg/Fjs0iEQj/9seh3DwqPJ3hmRtJD2xRtJFOcweyr5?= =?us-ascii?Q?nS6+wdqR5OGXSCPJ94fjfwRDC8mT72wHSqnFwN3tb9G406i+aaQFNRKHSeEd?= =?us-ascii?Q?i5xay+nyvjc1Aw1eE/HDMMUyfNYnxbRlRPDRZR4dRIAa5cqTzbOc6ZrDP+V1?= =?us-ascii?Q?HhokTr9jcpFDjJ6gjfDzT9O7h/DJ27H9+2VwKfwb4QezD/t7f5TejWBi4hnO?= =?us-ascii?Q?ALxXrljjOtAxLpps9lzMrAoBLCC3G8dN+6ayJU2V2pIMYF73x+r+pYgmOAR4?= =?us-ascii?Q?86CCj1eQ5uF/MiL8V5Zyii57UmhQzeEiLTuvOjao1Nen/iBP9LgxswWw/9/L?= =?us-ascii?Q?B1XTlGcITNJ0uQuAgt+YjbLI5OFqEbUeiYum19IJyteA2jS1jN2ZB5w1Ky04?= =?us-ascii?Q?epORYaZ1lK3G/7sV47k4gij0ZxHKSUrmm9kRT8rRaQhluQqS3iXWYj5e2G4F?= =?us-ascii?Q?hYw3Y19n9y7mzig92BC4lV5Wys+dkFsxnUaJRJgHhA1iEzyspBsfcSTd/hlR?= =?us-ascii?Q?beck9bho0QhrBg0FJNQ8O8o6WPxjNFKWgtaXRY3bVYorlBXcrm0qRGHQ/93y?= =?us-ascii?Q?pWWqWiM6Ejdx2k2nr7dGhOvcU/gNb/XZ2HzX6ksz/RThJmMxvibIJbaK6C6t?= =?us-ascii?Q?yMtrlsPEDf5Z00nMHMAQzg49BMnUeF1fzUKGdpiAT4/smLte2qRavpnA0jin?= =?us-ascii?Q?dxGQkA4gDTvKt8t/yZv++RACiDRt1MQSKJDCGIco1xIKdalu71v39T88Nyha?= =?us-ascii?Q?CjG/q61UX+pGSwLCT/1yrP1anO6DQVCghPQQsHYmOoFkONp7MjZ8TOgwaQBZ?= =?us-ascii?Q?YXkGBePO8vDD2y17TYnpkAPalDmONGknVe5ocq+rAYH6PUyOHuLYF/IXQFrq?= =?us-ascii?Q?8JJIrxViWxRB0Ddle4khwlFr/aAdjXYXEBiE7g6Qm9hkyaK3sfvyKQZRV+EE?= =?us-ascii?Q?jA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 953b69c4-04d2-4037-f58e-08dabba35587 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2022 00:52:21.5227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aBCtbg9DWiSGkP5h5S1saGHfdHGZiIaqf7MBQS96iVKBuu28ibOZVJxrqSTE+vw/Rgjt0u8RVSIGMd9mPWoef2ke629VZdCvjrZDpvKnvWE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6934 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, October 27, 2022 7:58 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64= . >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4126 >=20 > Common functions will have either 32bit or 64bit instances which having > different return code size. Function header should support both scenarios= . >=20 > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/FspSecCore/SecFsp.h | 4 ++-- > IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h | 12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.h b/IntelFsp2Pkg/FspSecCore/S= ecFsp.h > index e84528b378..d7a5976c12 100644 > --- a/IntelFsp2Pkg/FspSecCore/SecFsp.h > +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.h > @@ -70,7 +70,7 @@ FspDataPointerFixUp ( > @return FSP binary base address. > =20 > **/ > -UINT32 > +UINTN > EFIAPI > AsmGetFspBaseAddress ( > VOID > @@ -82,7 +82,7 @@ AsmGetFspBaseAddress ( > @return FSP binary base address. > =20 > **/ > -UINT32 > +UINTN > EFIAPI > AsmGetFspInfoHeader ( > VOID > diff --git a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h b/IntelFsp2= Pkg/Include/Library/FspSecPlatformLib.h > index c91ea4a78f..598fdb9ec5 100644 > --- a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > +++ b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > @@ -17,10 +17,10 @@ > The callee should not use XMM6/XMM7. > The return address is saved in MM7. > =20 > - @retval in saved in EAX - 0 means platform initialization success. > + @retval in saved in EAX/RAX - 0 means platform initialization success. > other means platform initialization fail. > **/ > -UINT32 > +UINTN > EFIAPI > SecPlatformInit ( > VOID > @@ -37,10 +37,10 @@ SecPlatformInit ( > =20 > @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data str= ucture. It is saved in ESP. > =20 > - @retval in saved in EAX - 0 means Microcode is loaded successfully. > + @retval in saved in EAX/RAX - 0 means Microcode is loaded successfully= . > other means Microcode is not loaded successf= ully. > **/ > -UINT32 > +UINTN > EFIAPI > LoadMicrocode ( > IN VOID *FsptUpdDataPtr > @@ -56,10 +56,10 @@ LoadMicrocode ( > =20 > @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data str= ucture. It is saved in ESP. > =20 > - @retval in saved in EAX - 0 means CAR initialization success. > + @retval in saved in EAX/RAX - 0 means CAR initialization success. > other means CAR initialization fail. > **/ > -UINT32 > +UINTN > EFIAPI > SecCarInit ( > IN VOID *FsptUpdDataPtr > --=20 > 2.35.0.windows.1