From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.8816.1635322615656521447 for ; Wed, 27 Oct 2021 01:16:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dvqAjiq/; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="228857784" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="228857784" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 01:16:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="723167888" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 27 Oct 2021 01:16:54 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 01:16:54 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 01:16:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 01:16:53 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 27 Oct 2021 01:16:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayOrRKKL95loZIU5hsCisJULvM+We7Oq+K2rCL+05xzL8+ohqnY47ReEdiCxq/mqealSf8hdRlQebKP7IjFHLzEy9Dsgk7KahsdM5Q+ZlCpjQZxoQSVqLI9B8tONhTR1mQm17VM/dRHfVNurVKPuRyRZGeuu9Q2q7L/FAbj0W5kMQsKVn9frHmE6Cr+Ipc0YplohWfuFPzgoLc1viMEBTnS2X0YXU81jeD2V/xUZNB8l+lOj81/SqN5bPigPtq28/wJXoAhQXG98GMysEEXaAMqEf3EGJ/2vgrPBy6mzEK6Au6YyzuACQYtcQ3WJavcybTAwQQhNi0qQyQbIuXLm4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PtXf+qdrwEY40I+F62grj0TbdEo60rwxl4sq/GuWU/U=; b=Ogf/MKeQq4V9absJMcR8FP12qKNThMRqdlKtYnKyt+/ipW+m5+XmWyrd2KLHptRMDGA5jf4Tl7eOiAFKUTVSNFKPD6pcjGasjaZedRrhMwp+/CdKDncudTViZJmTaMacO3172Zu3e1r3RYAYqUBUDMjiM7N6NnDinrxqR3smQmYfNlPmPyx6uJ9lWoyZSomGopbzMW89Cz72q6BT0QFPXu9cdRFUvlUm2/w6j2qU5ESh9LT0HSt6T5M4JwKH1+rm4A83SDhszp5Ex0e9Km4OR3KNCgACowZHBqTN+nTDde3m3/hEbMepDYN2FCz8TZcgD7ujqZBfYoBRWH+X/l22Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PtXf+qdrwEY40I+F62grj0TbdEo60rwxl4sq/GuWU/U=; b=dvqAjiq//+ptX1A40smRopqWFXqclyImXUMwj7k+ALdoCOffXM5S2aNmddge+AQ7lJk+HZKjuBMpN2SIh6m1c+/t8saCCO4OCjkhPq0ClrANOdcoSftIPIpZcQQCyblSqwHACi2wMDgPXc+pBrgj2NFRI9S1+T4h0Jmgj9m8g5E= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB1501.namprd11.prod.outlook.com (2603:10b6:301:d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct 2021 08:16:47 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021 08:16:47 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "abdattar@amd.com" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v1 2/2] MinPlatformPkg: AcpiProcessorUid for multi-socket Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v1 2/2] MinPlatformPkg: AcpiProcessorUid for multi-socket Thread-Index: AQHXx1Pav9BL51LlkUOmFfiQh4A4BKvmgs+A Date: Wed, 27 Oct 2021 08:16:47 +0000 Message-ID: References: <20211022144746.10671-1-abdattar@amd.com> <20211022144746.10671-3-abdattar@amd.com> In-Reply-To: <20211022144746.10671-3-abdattar@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f63dfda2-13bc-48fd-0a9d-08d999221eb2 x-ms-traffictypediagnostic: MWHPR11MB1501: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: liCY6pjzJUlqdhR6FsXFMjW4L/cOJsY5j1N+1vEDRvQPmquoU4oVecf6UH3J9FQeWxHDLdxK24AEXpKW9kF2G9aJft6ZLvS4V5N2XOkvhwYnaXoQBy/5XtCl+JmYq4C+KjHFx54aOxtdcIBvZJsy6TgchYLEwTgWWP7w7+zF08PgjnJ5PLNLAsE3p9DOoSulKSIoyQRmuA6DQH28c8WvAjrfxYS9UQPNKDdldOgIr4lOzOo4IDjEwB06IuW+klkNSGXnjuMg+2zOGN7pa4xOMhCzOJMfL/aoHgZ7+zNEgnJTIxvM4EjRCJ64AqNpWJhb2DqQ2ydwpNlnT66wGh4Pami/q5jnSf3jzh1PErO6l+6A3B2hmJYGO8dhWY8i8mYPIoX9oSL+SfK0FmasHzuNmU3GnwWd6Q9lx87NikB33T2DuvrXbAmPVKq1/b1L//U+pfsw6y22YRVnyY2VgcB7ZXSp/Wu0IWEyBittL98MhElLOI/twR6WJc2+syfTWgl495Q3wU8DYJvvOllYUS9wCqDAM4j2jpKxEevxHgp01MXNp53bPLvFm/pHCPat8Vr0FadR/hCKDQsg4rMT1APeL06CdK7XUVCcKnJFOBmKd67tT74ShUtRikHP5ZFmR7aPIY8O7RcVKQ0RRiVCuhQ0jZg5juskyyGa8znwKtGNZKyGvtVvWAYftYlPdyWEpHP1WWQDs/ZeKOX4ATdfQzA6eopTomrnuMFzIwHNeMXDHb1BUJZ3dmGcijGm+11bhjxLEoQUBo99OC7aDSxLDrSmNyJk5icTxa5bIdam7dZ0QxWsZLgC6FYG1j9xuMTTL6AY0fBfsESv9IFGs+IM2RJIMw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(53546011)(66446008)(6506007)(966005)(4326008)(2906002)(8936002)(107886003)(82960400001)(38070700005)(83380400001)(71200400001)(66556008)(64756008)(86362001)(55016002)(76116006)(66476007)(52536014)(9686003)(38100700002)(508600001)(26005)(33656002)(316002)(186003)(7696005)(54906003)(8676002)(122000001)(5660300002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Iee37ND+DsPrueN7cMFrJw2aYyUssiuTJmcN+5SuaQFJbxsP6KuNZorVzvnr?= =?us-ascii?Q?pFgBFUMqUJ1CmThSOpHB0jTcrSg4HN3mDtw2Soe0uMeBebdc8ee9NVp2FGJT?= =?us-ascii?Q?ph/5VXBd1lpvvjkDnkA955ZG8x2XxquYukcqFwXrGYxlFqtRVLrPjXYe0I4a?= =?us-ascii?Q?uFhBGU9wwBsstMlU5RLLZNWRXJ240h7tw1RxPBYcLfqhBUBcfuDs0DHmaIu+?= =?us-ascii?Q?D5jt9lEky+KL6y+3lnTdxvjWDbKEwJtJqI++LMejE/eFODmaULkQnBhdqQEU?= =?us-ascii?Q?YPSS9lYMEE0r1A/hJNexnm/c4RUmR98AAe2tuGFsh4VnQU9LKBfu267jD0IL?= =?us-ascii?Q?eTrlvgxvYRkbajktr0N6eXjAgMMQFoyv7G5myPOf/GxjO9kTKdlCo7Dujkj7?= =?us-ascii?Q?Lm7ukAJRx3L4oWpDooCEZbwUP3+C448WcCPdjmg3SV0s80ow4cdkX1XABewp?= =?us-ascii?Q?V+n8HhMxj+E/k9XN8IyaLSTbplxHLFh8O6NccpMGUFz/YAauvgugyZITVN7M?= =?us-ascii?Q?9k31iSTMrILLrrmqeQ7c1YmpHXBi5L5SbqhhPBHWyvnbxk1bEbTbdjFAHaWA?= =?us-ascii?Q?saymUafjJUZ7aeNR2EaLCmtOsAfwM2a2ue+9k2N43uV0thIuKAjL8i9E5BsK?= =?us-ascii?Q?hWZUxXN/XGkHYEFirdaJ3txFBz/5f9oLzTlgEE/fvQVPdExSUrsxJNoHVPmW?= =?us-ascii?Q?/R5tVPa2ywO7VCEPNJ1G+a+XAEq7clcX+z/kzjMGg7zitweOkiTDi7MhmGLX?= =?us-ascii?Q?PwKBQn9BP6gfLXjqATdotZYEGVlNBEcKaw+Sch0OO9MWK52evKmWDLaZAffx?= =?us-ascii?Q?6319NIJ12gAHsJyWF/D/j5hR0Kjd8uVv1d9Us+IEYSFlIFONbQ5agmwthPhJ?= =?us-ascii?Q?qK4/0DEvt1r//uKi8z/qnDFTd9S8GL4KqKtuojtVGL+jINFE8bC7T9rLq3+1?= =?us-ascii?Q?wGqRmDQtE5i3UP2AEqTexe/2hQb+6rGBLOA152oSJwN20nG3nf0SpuGbqxfM?= =?us-ascii?Q?SxVBRD8HipDFGHrWLpDDJ66TExEccovs1B/RgH1SLjLKLJwdHS7VaQAe0SYD?= =?us-ascii?Q?zK5gv0fFPXydo/pGp37RsEaRKb5GPEEIWpXLJ0oRizIE3rLwRrZKrt8mGQz1?= =?us-ascii?Q?IqV5vfdAUtI1VhD5y1RraawuyjF+m8BNkapnNPPJ3fRbh+bWnao3t1LqXCUC?= =?us-ascii?Q?qxWL3BOgCF4lzT9/WwtRFybYOVu2UyjaHnqLjIp/D81Ti4OgGSKZfhIL8HMO?= =?us-ascii?Q?DcTt7WiXsw5Byg9kuOauSKGVXpsod458NyBVR92Q2npScYjn8ATOPA4eE4Gt?= =?us-ascii?Q?yMcSdTwSAZKOybox/LvVsHbdi83h7qRfQZXFAF//WeyKKFE0KY4qx6liwQVp?= =?us-ascii?Q?/n8d7JR2kePw7R3qf71P486JzEe57GE2cUgYlVpQ9w8a2bCqnwl9+V15ueIu?= =?us-ascii?Q?jhFcbXt2OtqVPs9wZZURyCRS5Em+sBN19N6xSSa7ll+cSKEgABAqvYn9yRDu?= =?us-ascii?Q?U1TdAPwOJPWDECuXJXNCY2edxlf+z3mxPyaOD7y0rN5NwxI+2sokkSVHarGZ?= =?us-ascii?Q?0uZqCcXSsRJdeDZx5B5PDpWDV7u/KtEQTFIrUU4WXFiJmBP+5n583f+8HV7+?= =?us-ascii?Q?lcvxyVpo0jpvcMZ05unkgy59nHsSeUGWUPUA2UwkmV4y7Jn7w2gZd0NQbhTp?= =?us-ascii?Q?j7a4WQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f63dfda2-13bc-48fd-0a9d-08d999221eb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 08:16:47.2080 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FNzgTO1/5H/gQoqc+9cAI381sV9eS7tdGFHhL/Wov2TQ3zo1G/d7cvKjR3oJ0kvLA5/2b3K/CwHCCuo2UbXbFdebZFhbtdNi9J6OvRki5eI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1501 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abdul Lateef= Attar via groups.io Sent: Friday, October 22, 2021 7:48 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel] [edk2-platforms] [PATCH v1 2/2] MinPlatformPkg: AcpiP= rocessorUid for multi-socket Corrects the AcpiProcessorUid for Multi socket/package. The ProcessorInfoBuffer.Location.Package holds the stale entry of the last = processor. In multi-socket system it holds the Socket/Package number of las= t socket/package, resulting wrong AcpiProcessorUid assignment for socket 0 = processors. Hence do the bit shift on stored SocketNum. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Abdul Lateef Attar --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 032903029a95..785cf4c2f911 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -287,7 +287,7 @@ SortCpuLocalApicInTable ( for (Socket =3D 0; Socket < FixedPcdGet32 (PcdMaxCpuSocketCount); Socket= ++) { for (CurrProcessor =3D 0, Index =3D 0; CurrProcessor < mNumberOfCpus; = CurrProcessor++) { if (mCpuApicIdOrderTable[CurrProcessor].Flags && (mCpuApicIdOrderTab= le[CurrProcessor].SocketNum =3D=3D Socket)) { - mCpuApicIdOrderTable[CurrProcessor].AcpiProcessorUid =3D (Processo= rInfoBuffer.Location.Package << mNumOfBitShift) + Index; + mCpuApicIdOrderTable[CurrProcessor].AcpiProcessorUid =3D=20 + (mCpuApicIdOrderTable[CurrProcessor].SocketNum << mNumOfBitShift) +=20 + Index; Index++; } } -- 2.25.1