From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.464.1635895729842110479 for ; Tue, 02 Nov 2021 16:28:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=P6VQ3Rjq; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="292225358" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="292225358" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 16:28:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="500803325" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga008.jf.intel.com with ESMTP; 02 Nov 2021 16:28:46 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 16:28:46 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 16:28:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 16:28:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 16:28:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6L0c/J8wwVN0nctZ9dq0k9FFyZT8FHxTSq1xB2jguyQFEDTcCG+bzGoYJJhNk5so9Jj+JnlwjuCEH5IXOywHb/Z4U3Uhd/HqSuEMmqOEHZo/vLhh7Q3Afku7HYqnk1fx0UO7Eo0cOAQ3aywSOdcBfL3Uzg6E8Vudilb0R08QtlijKMkkfmFs5mF7sFoaF5jLW73YXGm643AkauhTId308qO6bKUFpwLuD2yksSFTj98vAG3aFqkC4JMwWunpQ75VRWHQoEdEHmYzHt3IxH3qOl4XVMTusMlH4aQXkt8yGfjdKvLX9P5jLB68MOgUJxDg4n5BZgXSM/h1VjAaKADgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=daOOaqMzem3PPlHNOAgYlcA8VLf5Tw3bBW3ILix1/88=; b=a3q1h0EnOFjl9zRhPT9XogjuKFJPTfKhNY8ZRtQaPwGEtYsIgc9CPgUDD0mJNAUV6CODOAlg8qOeZoVDP37HLhB6dDnhf7AGsy6KmT7ax7liX43xLoiFYX967jbsFIoFXJBA2ayJ66vkDeFJ3E/cs078kqAFn2gdgH/EQdSnmhNj/Xho2SdM/G7tgC396e3yGoQDwBhV71/1MQziSdKJN1L3a0aD4UwfYXUE4S+tU7rhQ8T6qfqozjKO8+O0w9n4m5iNe91GJTvALEti7tUxdux4ABMxEKpnMKWnqSS3Lz/ndt45n0bND3Tg3nxA2zy3OuHbH34Lnkvven9iBu8nrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=daOOaqMzem3PPlHNOAgYlcA8VLf5Tw3bBW3ILix1/88=; b=P6VQ3RjqaT0MJD+oJl0Rs7QnPa1kxvVEPk0mZEzf5z0Ev2UzFfb7eLj0TwdMA6A1tRKPxZC2ghEsgsbQHbLE6gjxN70Egrfnx2LXJErN+v6uUPmqhSa3zIJNLu/FYzDzaYgRFaYh2Q2rJlVlVUpDgry/5eSTn1uPYs06z+PpE9g= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB1247.namprd11.prod.outlook.com (2603:10b6:300:2a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17; Tue, 2 Nov 2021 23:28:45 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46%9]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 23:28:45 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Chaganty, Rangasai V" , "Luo, Heng" Subject: Re: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol Thread-Topic: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol Thread-Index: AQHXzEjDVuw/olstJ0u78F3VN8JdL6vw6iyQ Date: Tue, 2 Nov 2021 23:28:45 +0000 Message-ID: References: <20211028220846.753-1-mikuback@linux.microsoft.com> <20211028220846.753-16-mikuback@linux.microsoft.com> In-Reply-To: <20211028220846.753-16-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 42e2cd1e-2e93-44cf-6d2f-08d99e5883a8 x-ms-traffictypediagnostic: MWHPR11MB1247: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ql7atG87BjFcYq1+IkLsa2mCSszXbEWXS7B1/zI0DevCHIu/j3yEJVwPm9SDm8eyQLgRteiyDKd5jQkrlXIhoMoQmY5g29/JNTRk+z7NtDQfdwmRCVhRrgC6w+na3KBA5Hzdm1jz9YbyfZPmq2Jk6qNIAusPmdsDZ3CeX+NeEJ+tLDURpQJwhDgN3z5pLEex8iev6lJY4s04AeDtSZytpBr/FY/J2neYWchpQfwEU+zAeQ/qWYPTgL9yyxjDi/TUJheMkQJd3sRiN19zMnbJG6nFOLsLtG4wa6GIjBx/1USwykAsfA+fwvUugs1D0qmjqaB9E5euXJlx+ho13piHQJI+r9Jsw42+tC81bIeaMzhUBGkAfCqJ2nblcinwai6DdVm+WsAFoAxRQtkc0hOx0LtJ6uQAq0mppdW6meMbUzX7e68Lh86T1FaWq+LCd/+e7iDjiThBLmREzv0iGGrmSTTYJzeFZKswwTXeZd3HGUywNkMO1vdbM637yoDPP2gr9EJlUK2FoNfN24mBZLn2njUm34XW2zTXmiOm3R2E3oqMthz2w7iuXeUDhqHOU89t+uj9psqSgp6ZPFjdesapO2E9jtSDJobQ9FlutbP6DuMg1D0+4XpatgIBsFisj2tCm26pyylIpdqCZfMshtAu50djmJR4ftRtoCltQda3EMPNbVIdt1PtHvK2m7K57jXVReiHozGocQJkXZ/Xru2cO2Z1PnDcBtT1bgUW3izx1/AfiyombQj4X6NVttO02Kce5av4oOyq23so4vbRS/n7vJwOe/QpvjGYecADT99wtdFfVAFYyBcQF6ilYA4x2PI34vx0MI32GTuk0S3UiJY+6Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(966005)(53546011)(186003)(6506007)(110136005)(66476007)(76116006)(19627235002)(5660300002)(66556008)(66946007)(86362001)(38070700005)(2906002)(9686003)(38100700002)(122000001)(82960400001)(66446008)(8676002)(15650500001)(55016002)(52536014)(508600001)(64756008)(54906003)(4326008)(316002)(33656002)(8936002)(107886003)(7696005)(83380400001)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j2L0urndN4VhGoYwLuqSZWl3YR17q8qcuFRTHW9Wf/cFT2i2Q0FiUdCuUA1p?= =?us-ascii?Q?T4s0AhjljLDLeHy4vOi81uRlI8TNTu5wILvKRSmabCVgOp95aMZufP8qDsGb?= =?us-ascii?Q?DUSDnHqCAh1bwiW4v/nmTsgw3C5pbsg6ImNwWhUxuKo2q0cqhk3aEBfoZW9Y?= =?us-ascii?Q?8t2VVyhnEi1pUA0/PkHyRKFCp9gJbsNNP91F6COQDPCc8EVut0BMoRBhLxV5?= =?us-ascii?Q?zGZ51jmGG661dVUjyY8I7CEw/qoBAg2tyN7uw3HW4ctfb+rbmIc+bn4F7ERk?= =?us-ascii?Q?Eznzjd8/vT1hmaRjPf21o+LYD3h6K4Kbj49io1tKD4le2svNigffAUf7YRgU?= =?us-ascii?Q?dZQgv/IXTv7TtbloiXjgStsJl8Hm/BlYYYYs+lV79Uqc2evpFit6jtwhHKkf?= =?us-ascii?Q?ZuoHSYa+Vt5T/zxPOazOP5kpX7NkfBYudFzUwcFxrQ6rI4/EX2+Pj1wGOO9h?= =?us-ascii?Q?Dmupm+Ly44WhO9BNZIXeyqGDxSn2taHMZ6SYFi3A5cKfEOnmngrFLvgISVAl?= =?us-ascii?Q?IQLnW5SRJ/6o452uG8s2+mBB8jjFneaKiMlv9v9dewcxCNKmNDOrrIIvFg28?= =?us-ascii?Q?E/Tfzt+g/nhQP/RKFvjQLZMremosouZLDgZ/DWUBewC4Txwpdi/0qQEqwB37?= =?us-ascii?Q?/WoI/yk5be5cEVl1Mn64a6wlW5IKEZf06pEq0yXKrh1jRKP5Xp8CrTOJDHEg?= =?us-ascii?Q?zn0rypGUyR5yl7Tg9d4iQLCn/HjAjuZMy6d/dekqsxEqfrG5e2q+kAleSAQm?= =?us-ascii?Q?SNFYbLPbRiYvUOutvMiw9BRz+5Aaj0HQn5kQQCfepZoSWUQkbJmXHLmKLWWh?= =?us-ascii?Q?qZ/mMsFxjfHTEUOh40708Jg1nL7sl1xMU9JoOTo5BYweFGihBPAmPEHClV6H?= =?us-ascii?Q?/Gb1ZR/1HnOLJsxwPAANzuQmlNaWqSfmqZPZjyeinZ22OoUv39cYvHDe41ID?= =?us-ascii?Q?7jevncVymOcU1BGSg24W8C4vrfbIXsHfTl9zD5dzFHU+FOwggu4IwcbYvEyh?= =?us-ascii?Q?ApWa/8M1+rw/8OJk39HfHDRTwSZUDP2kc/LSe9jsdd8iIhJC1ZdfFGt/5/+g?= =?us-ascii?Q?CvVgCH2l5zXOBpd1hrpIhA4S7oInuXoF4qAOtuEfJCVlvttUoUS85+6pd7K5?= =?us-ascii?Q?CkeNGvDLqGjjddUznCEkt0h6KE+7VXVQuoS+/0AWJ5aBWaM500YWH4E5AaN3?= =?us-ascii?Q?Q1qbhRWMV2CI0XhZAu6ohiirhR6e4+yqUFJIzfFiw8uhYRWHNYDyT4/xkbqN?= =?us-ascii?Q?racGEqTHTPZVsoIVrUBsXy076J4b5scBzIroO+xvhGQ8CDcHbVGw0A//ZYOq?= =?us-ascii?Q?2mgs0/touBciJdCZKupZuxpfvkxat4MIhC2YucZs259cQDJHMPUIevu4h5/b?= =?us-ascii?Q?PCFCgcd3p6m5kcvTcGr1MXsv3UROBUfyi9HyT440Aj92kePTdRd8yaeNYcp7?= =?us-ascii?Q?GXnlV1kM8eGK9LP+V6ltF8GG5P76p/+PGHil5SOYFCoF9H6GcDmZGvBms+DM?= =?us-ascii?Q?7SSiK8yj7LhNHOJs5dyfimJ0jwBdd3PNNWvkw/yDH6x82hphGX1UwRplz53z?= =?us-ascii?Q?ny0Cwi3MiRRVgLxLg3llyIHJerRUiSkuc/QXCYbzsYzFBQ1AO0eCAW2B0uSH?= =?us-ascii?Q?0L1gAV3helevAT6BkXsote3nxFI5lUX5Fkb11X1G2DG/if7DnzF2Do0Umoiq?= =?us-ascii?Q?IXXnHw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42e2cd1e-2e93-44cf-6d2f-08d99e5883a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 23:28:45.1395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LjlhBJS+d6nA1FhkGp/FPqc1vaT5K0JGdc1EIRmVrFip00sW6rgZ0qwAYIvAfebfavl1EDY/xXuVKs2pvQEOw3mxPM9xEsmh+93EQMBaJqM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1247 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathani= el L ; Luo, Heng Subject: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update f= or SPI2 Protocol From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates references to the "PCH_SPI_PROTOCOL" to instead refer to "PCH_SPI2_= PROTOCOL". Cc: Rangasai V Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c | 10 +++++---= -- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c b/Sili= con/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c index 419eddaff38d..a55cb37c4faa 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c @@ -13,7 +13,7 @@ #include #include #include -#include +#include #include #include #include @@ -45,8 +45,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED UINT32 mSpiR= esvMmioAddr; - Documented in System Management Mode Core Interface Specification = . =20 - @result - The SPI SMM driver produces @link _PCH_SPI_PROTOCOL PCH_SPI_PROTOCOL @= endlink with GUID - gPchSmmSpiProtocolGuid which is different from SPI RUNTIME driver. + The SPI SMM driver produces @link _PCH_SPI2_PROTOCOL PCH_SPI2_PROTOCOL= @endlink with GUID + gPchSmmSpi2ProtocolGuid which is different from SPI RUNTIME driver. =20 - Integration Check List\n - This driver supports Descriptor Mode only. @@ -108,11 +108,11 @@ InstallPchSpi ( return Status; } /// - /// Install the SMM PCH_SPI_PROTOCOL interface + /// Install the SMM PCH_SPI2_PROTOCOL interface /// Status =3D gSmst->SmmInstallProtocolInterface ( &(mSpiInstance->Handle), - &gPchSmmSpiProtocolGuid, + &gPchSmmSpi2ProtocolGuid, EFI_NATIVE_INTERFACE, &(mSpiInstance->SpiProtocol) ); diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf b= /Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf index f64b84880b31..40feab02d3ef 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf @@ -39,7 +39,7 @@ [Sources] =20 =20 [Protocols] -gPchSmmSpiProtocolGuid ## PRODUCES +gPchSmmSpi2ProtocolGuid ## PRODUCES gEfiSmmCpuProtocolGuid ## CONSUMES =20 =20 -- 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82871): https://edk2.groups.io/g/devel/message/82871 Mute This Topic: https://groups.io/mt/86664084/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D