From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9E99CAC1B92 for ; Fri, 17 Nov 2023 19:26:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uKO99lRxkXUXAuMFLlrqPDAqB7jANBtV4izbW6+pF2A=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700249164; v=1; b=cgMYfH4oWMipOCLZC29uDBMD92+lBj+Io3SRDYWiU/KvzHfZhEOLk8xoWd+H2kYmEkJkMFg+ xNI3JANvLPy7832GQxZ+kTfL3E5X4SjKTLDY9I9jFWfOgaqyXfOgkyosg2QZ1zbCfVmdmJKFCEf kVDZ9yvg9+Zvx+VIiIbVA/Dc= X-Received: by 127.0.0.2 with SMTP id WaYHYY7687511xeRgljUCIq2; Fri, 17 Nov 2023 11:26:04 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.4342.1700249163655350811 for ; Fri, 17 Nov 2023 11:26:03 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="388506326" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="388506326" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 11:26:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="883204569" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="883204569" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Nov 2023 11:26:03 -0800 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 17 Nov 2023 11:26:02 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 17 Nov 2023 11:26:02 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 17 Nov 2023 11:26:02 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 17 Nov 2023 11:26:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RRGjsGZsYsEXsdkoP1PoS9SooLqxzJI2gsPGcpwnyNeAzCS7eChaLadmV3nRKEkK+bPcepJi7Nxtf19GV+8Wd6XT3cKZAdE+WvwR/BFMCITq8nhWBeeCiDuSPK6rrLcfqkXMFw3OF+G+INMs6X1vCCIgQFlASxKqDNvxececNBM5kZ6I7MDUPNPCtKBq3YT9C4X9nxXIuTGOgCCK7lBKmEorlDMBDhtXdxupWom1yQgn3ZjyCaBgroG26OpvuJrkT6zDeqEN+b/2ouTUKlQIDJblYTNHr1208Mw8HIJdu0b6/PxMJqkftBTMJ2p5cX33vFgMefGkR7me+Tep6lVhug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bM1q8JZ4BY0/X86CAoS/NYSGIGKZj+LGV8JMrdY2o4I=; b=h6X9J1SfWdulfRGKtZhsvzIr9SrgZtMDdvCWk4KYU2A5HXjGjZON9/F/NTLlZhXtFeW+HaRFoPsIIQr4Ery/fvP5Wmppoao33V147NiRkaD8c0CWrNuVich/KuvqvSAJhvn0jC8ggkQbs+9YJ7yVDqyNQzhGXPzHWpv8IXVQR8BNMlCodgoB+TC7frqYY1hNCbZSWb7pnABi0cQ0lcbqIUzsiB30F7/UWZ78DKJEgdyZKagVVdMhMaCpVjf56YNqP707XOeJi4quNc54hyd7M87tw9ouRdpbv2qbNyAS3gaT7RsM9yF2jGYnFTES3bFtDbJ/koB1AccoMXi+GpOaZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SN7PR11MB6825.namprd11.prod.outlook.com (2603:10b6:806:2a0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 19:25:58 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ced7:2db7:4cae:ab0]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ced7:2db7:4cae:ab0%6]) with mapi id 15.20.7002.019; Fri, 17 Nov 2023 19:25:58 +0000 From: "Nate DeSimone" To: "Gong, Zhen" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback Thread-Topic: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback Thread-Index: AQHaGOaig/BwjzHDHkSz/axG02YEw7B+5eEw Date: Fri, 17 Nov 2023 19:25:58 +0000 Message-ID: References: <6bc749b44eeed932426c046838c0901d15181a64.1700177884.git.zhen.gong@intel.com> In-Reply-To: <6bc749b44eeed932426c046838c0901d15181a64.1700177884.git.zhen.gong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|SN7PR11MB6825:EE_ x-ms-office365-filtering-correlation-id: fc5f7b15-767b-4396-c661-08dbe7a306a6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2gdfd4cdU8+sRMnSpgZCoazYlkcpEVm/l9+/ds6QksxJPLIurzrobQdJfJHAI7IEpAj9eU4CaVWq72hK5poUiG9zd+6iNFW9trFg5423w+lo7fxhyFGkOPXIsweJ49836qBtWUk83EWEf1gu/vrxTyiDEqTWyOAkY8Od81d+voEpLiN9pNP2ZPATCf814nY+EjXGulXCSidJh7vGnPvoRF1VIv32yHNXEtsdpRWgFMSmE5mQ7/JnZwC/fgLTYGX2mGCr93JruPq3A33EKumqLIxCFVZLaTEaogbpx1VuJOUVqhZBp6k2/PaSu1GTKnnSC9gJlXLd8Udc9ZNjHUHvgwmulCSC/KhWXUaEhRo7i+nChR2XBudecNDCrh9XqHz3rL63gXPF+HXC8ObAqSHGjGh5cAYUs3HPngMdJxDE6f0ZYY6gHuW3F3Suz3x3i/q5N6yTzw3q7LjvXveAFhaOw9rA5AxsNHcJPiDfA+6oaRCuN/gXUf+x/Xh/6xqcw/URbog6Lh85yHaGfP2Sln/elPJdn6O7lou7lCl/jAI692H01qcz5/dhBgurafdVQtQIe4inXB6ABuWpi/w5jFvzLJ1CiqUqWOiDh1KwSuYLRN+LQY+MvTL/+dQWL26ZUf5+ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NkNExfU+wBd8ehJbEjAa0YTSwp8JOpnxAzAdzT76ZocgrxPqYSSw3mq84BHH?= =?us-ascii?Q?kjzk4RmnTxUnsg74q9MDGRSYEndV7EJn/xuo0WiCzZQq7SSNBfnkaBucNF17?= =?us-ascii?Q?RHvbzHzlpGPhmkMwar/nLr5WkG76khJ+NsLC+HqngRTX2BdP6fmpo78cCLC/?= =?us-ascii?Q?s4V7CgeKv9vhV3yBPGhl30Iw5t4cGT3mi8T+yuXAMTtjJa6W6KvB4zejx0Jl?= =?us-ascii?Q?tByY65pVGnMt6GF/3dBGDA58BpsjWLZl7nP7AWiaz3/r5pYd44kKyajN7+Oe?= =?us-ascii?Q?O/3kBlvDc9C7m2SCGw65fEijSau1g/DSt8h1cikfhY5YPdn22U1ioYjbIy6k?= =?us-ascii?Q?bn6Rr3RDefr6oVljwqLASZzCKyDhxK1+1C0/C29v1/SO+ved/JkJU5JYuakj?= =?us-ascii?Q?W0CoWj2BKnbASyKBeAsC1oR88cIFVoxY1jCK1oWQkb5/OelrMTw0Vhcf6ONY?= =?us-ascii?Q?odbZxh2Ui60816kNH3DTOhEB6aH/DaI9U0ym/5s2gsUGCW1X1YigAK9fJ5Ht?= =?us-ascii?Q?gE2KUXCEr0HrxfAeyivN2LAD0w3MVaAfenIS3i5/nO0ObVXIWNMPhVZTeYtt?= =?us-ascii?Q?1gppqGBMPPbpiRRuCgOZ0l5JoOGgk0CLzwIhKvYW+0vnIiArc9QkJRyn7QjW?= =?us-ascii?Q?97U7QghB+E1flp7/ZGtsAuF3xUHSRU/2We7uYLRXXdaYVYIhGGGRR9B2jh+a?= =?us-ascii?Q?gvUkr2wA6djoiAlwRdSPwBCWB8oUF2SNuNY9QvPlWyrPkICArgLP38fTPdVe?= =?us-ascii?Q?8MzFZgFd5briyulcB6ml+HlnN8HrAnxY32MIQhojAXnW+4h8wWe4N93dU2M4?= =?us-ascii?Q?nEHoC/zC+IWKyC1hLGvT9SfI9Qt1iCM0RvvPr3Kr0b72LBASmq6yT8g0HL0H?= =?us-ascii?Q?UvAD5XG2KS80Bvzfqznx7p7ELCkoHMXi0CYMgPFII8oIeFyjO7Lqb4lf6MrB?= =?us-ascii?Q?ufUKDk+5Z8RhgVdQHS6IKYCCQI64bs6tUurnD97EHxadYU+wg/eMp30zGpwy?= =?us-ascii?Q?M9d0udxQZ/Jqplj3ikXTRrkksd+sv19Y0scm4tTSNXZgGIeAJJXSZrAe5Mfi?= =?us-ascii?Q?BbO/p/ZMJo9ZFP0AwoFz3VzZo5zUSHVeiSwllujf4IxYk3GTm9VCGxW1Fu6c?= =?us-ascii?Q?C4da8ncMH26c2jL235rguqoGahJTT/guwiQYYiaFquOTcuTZVjUtN5iPUv2w?= =?us-ascii?Q?4A2CnfnOCGS2Xn2WM5Uq5GzBe98JSoThZO8A91EJNz9lQeXtn0UugXQGJ4Yq?= =?us-ascii?Q?ahOF67RuJbTBHi7/ewokeupqz/ke8/msjRrW0nr0uK3kllCK4GtTNrOK62iv?= =?us-ascii?Q?fXBlru5j9K/f5dIrx5jRm3LSWxe3Q/jB6DS73mdsDbcIPtlQhjg7GmMbP+Zl?= =?us-ascii?Q?LB2kRcvlYAmxIcVa2KOkxj3UmDVfJRjz1Lm4J38mdl2sxuLRYSonUU4GLgYp?= =?us-ascii?Q?5q05Z5EqLhRuYH94TKlE01PIUG8PWJo0C52JxzxFn8ISeiRt7sjfw8bumE4g?= =?us-ascii?Q?xWUtlgYfNjACE1vbf/53YF/O+ls5W72/ExiRcQeeDGUo62pMJh4ZdalL8sgR?= =?us-ascii?Q?RQRtFriokU9L6L+jDQkQM2QxeNo/iHpTdTF3Z58EjWrZuX7ky9I2Xpa2Ws+a?= =?us-ascii?Q?iw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc5f7b15-767b-4396-c661-08dbe7a306a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 19:25:58.0288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2f+ZR0HfdLF3kTZ+VmyNhRw5hG3XPx4OSrhBZiaHr7SfNzUD7gYY7vxclsIUPpWR7ry6zMSI3BM0QimEXGBwPraKDTgfLv6PG6h0E4eNHbc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6825 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7ri6gsfg2BQqTEKBJacjJAAFx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cgMYfH4o; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nate DeSimone -----Original Message----- From: Gong, Zhen =20 Sent: Thursday, November 16, 2023 3:42 PM To: devel@edk2.groups.io Cc: Gong, Zhen ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to = AfterConsole event for callback Use AfterConsole event instead of ReadyToBoot for callback so the driver c= an update SMBIOS table before booting to setup menu. Cc: Nate DeSimone Cc: Liming Gao Change-Id: Ife697f4c78449b90f17ffa7b7bc5a6a5f77d9436 Signed-off-by: Zhen Gong --- .../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf | 3 ++- .../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h | 1 - .../IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c | 16 +++++++++------- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru= /IpmiRedirFru.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiR= edirFru/IpmiRedirFru.inf index 24fbc94128da..814f595b5abe 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRe= dirFru.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Ipm +++ iRedirFru.inf @@ -25,6 +25,7 @@ [Packages] IpmiFeaturePkg/IpmiFeaturePkg.dec MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec + MinPlatformPkg/MinPlatformPkg.dec =20 [LibraryClasses] UefiDriverEntryPoint @@ -32,12 +33,12 @@ [LibraryClasses] UefiBootServicesTableLib BaseMemoryLib MemoryAllocationLib - UefiLib IpmiBaseLib =20 [Guids] gEfiIpmiFormatFruGuid gEfiSystemTypeFruGuid + gBdsEventAfterConsoleReadyBeforeBootOptionGuid =20 [Protocols] gEfiSmbiosProtocolGuid diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru= /IpmiRedirFru.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRed= irFru/IpmiRedirFru.h index 9fd0067973a6..b5ffe1ad0518 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRe= dirFru.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Ipm +++ iRedirFru.h @@ -12,7 +12,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include -#inclu= de =20 #include #include diff --git a/Features/Intel/OutOf= BandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c b/Features/Intel/Out= OfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c index bd4b35ba5793..9c63fae42678 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmb= ios.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Fru +++ Smbios.c @@ -454,15 +454,17 @@ GenerateFruSmbiosData ( =20 mFruRedirProtocol =3D This; =20 - Status =3D EfiCreateEventReadyToBootEx ( - TPL_CALLBACK, - GenerateFruSmbiosType123DataNotified, - NULL, - &Event - ); + Status =3D gBS->CreateEventEx ( + EVT_NOTIFY_SIGNAL, + TPL_CALLBACK, + GenerateFruSmbiosType123DataNotified, + NULL, + &gBdsEventAfterConsoleReadyBeforeBootOptionGuid, + &Event + ); =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): EfiCreateEventReadyToBo= otEx failed with return value: %r\n", Status)); + DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): Create AfterConsole=20 + event failed with return value: %r\n", Status)); } =20 return; -- 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111406): https://edk2.groups.io/g/devel/message/111406 Mute This Topic: https://groups.io/mt/102638229/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-