From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B1ED8941C95 for ; Tue, 19 Sep 2023 20:08:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Vtn5zBdBhgg7Xk7NLO6Lk+Po78lBMZABqQ2rYCp37gY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695154082; v=1; b=Y+RXdyDLYSKpDSHqfn0+WJb2IPAPbkEdafWwQusrM/vK756GDOSMPIrmqfOFXCFbreS+JqKk 5Uc1sGhq9e4asSAeR+8/6sZevrpRO/2v31yyBtfQiQrJaidXFlfjAeqC82Ult5lK/dZykQM21RN n31f3WqBq5ETUzcTzIrxvOoI= X-Received: by 127.0.0.2 with SMTP id 9ghfYY7687511xEFVCWDtVSP; Tue, 19 Sep 2023 13:08:02 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.20176.1695154081783107233 for ; Tue, 19 Sep 2023 13:08:01 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="446514524" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="446514524" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 13:08:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="739871448" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="739871448" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Sep 2023 13:08:01 -0700 X-Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 19 Sep 2023 13:08:01 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 19 Sep 2023 13:08:01 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 19 Sep 2023 13:08:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UucIlQvpBFxbR56tkxUfId0s/4ISbw/qCXKbWQt1mFk4cJoTxbpCbVF4w942uZ1CzNzo7twIv4VUKFjTCQ5Xa8iI23iBLm3GB34MSWuPI7i/86yFyk2VqDHa+5feA4PYYE2tM/ooHAptWnPpgyjr5YQsxFJxr+k5IJDu06E/4GSzJN2RwQIw/2pnV9jZnOL9itCTAauyKBWdpPKhqmRU/39hdo3aNM+EOaoz25oWpz6x6sd2HFhAkipJxMZioKQjLxr1ecm391KO4kWOlqLyyyETjSPUy5k25/q4JoI3x82GJSFZesyyPwPH7TXRzGf1mcMP/iTrTkal9yoa1pmyxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2qM8Ao9rRf+mfNDS9AW2kCbKtor6OGgtM/SZNRv1xww=; b=dBFh+wuzy4SfcwZamZnESFB/CsK8Xew38R7dR0oqfj8zTzptoUaadxLF9pS8M+wWt0XcPD21YEMT+zLMUsWbPHTbOZc4MinKajgk9ep0HyX27ENOhaITyebi5uNB7ghPN0lMBd+6yc6zV/dekvO1k0NW9SC8g8RjlNyPdVDkFPMFtYILPBrMaGUQa760YgJrxwe5PXyX3pXekeF2/KT4gPP/cLny7GfivMjVDfxBw3WVUiYZZJKjua5Kl2AQphnDd2Kr6Xj7wO+M5Kc0p+G0GiuChMeEZQj/T7uYS6/es4j0bMOXnCpLvPBixXx7YQrPDUeiEXlpZTyq238FcGTipw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by CH3PR11MB7865.namprd11.prod.outlook.com (2603:10b6:610:128::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Tue, 19 Sep 2023 20:07:50 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::89db:ecf0:29f5:9f3c]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::89db:ecf0:29f5:9f3c%4]) with mapi id 15.20.6792.026; Tue, 19 Sep 2023 20:07:50 +0000 From: "Nate DeSimone" To: "Huang, Yanbo" , "devel@edk2.groups.io" CC: Isaac Oram , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report Thread-Topic: [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report Thread-Index: AQHZ4GiaQELj/pz2sUGDZsHzaZ1woLAiqL0g Date: Tue, 19 Sep 2023 20:07:50 +0000 Message-ID: References: <20230906021913.54945-1-yanbo.huang@intel.com> In-Reply-To: <20230906021913.54945-1-yanbo.huang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|CH3PR11MB7865:EE_ x-ms-office365-filtering-correlation-id: b54a5b44-6a05-4b60-a73c-08dbb94c19d7 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1EEpxaeFds/+Js0r5T5cYU8q4DYrzt733Nri8zRYu78XqQOvnufeTTrMe0u4RwkMsH8bBO3NeudR3qWuRmSzPDE1s2RGS8yVaIIy6LdwzDtxRkSNfGdNz34mwGQaOdbXgP6M0H12aRqLyc1UHpnHdaCjt+cz/XCPnw4o9h5C6MDECWUoKAnazigwTNyMIJFxAfgYaoH9WTceOEmuxYE0ZaK217YDuzpLW7bL3CITPdn2Fkw4xLqOAKOWZppeVS8Qmcevtqu2uwezv4bmpP0VsUV1x1DwCBTv75N5JETiXwTecsK2eGaq2YNrs+/14TQn5aE7dzqRBnKV5IuTHtmV4kYwN6KIn3p7mmB7l8U9z4pJaav8xZqEQqPJOynhZLFhbIIC7mXhWaeDnBSJS5HpRJIVHu5z6fSaaRbUvc65/05EVEdz3/kIkb2VfFl6hGnLbWTKGA0GHIRU9RdIwzOe8zqkxxi0GlmObameZkakiU4kX+I7E64PeRkR7Reh+vMBX0C/QYwQS8iU2ZuidiuzxNj0cS4F0vl4lJMQH2qw58VWW0/LISoueBV55lP0X2AkCnAv7zy59VM89lWm7TS0YIwqlZV4sODp/JDWja/yo0V4jmUa03lichPkY8HG6CBM1EgAswcVWLcYTji5WF/qxw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+1ht3D6PMXuLkv2h3w1D37FD/t+6kcTcQzECwgELo5YYiVFBq9ZM1bpOGDCM?= =?us-ascii?Q?iHZDZZiPpj28ZLcmmcN8sTG4+eVPPkgd6jg0Yms8qpOaK3dIRAj03PupqGuA?= =?us-ascii?Q?ipmpipP6ndI0G/hoEVR45Lnj97B8L5/kSDqDC6BzAdVyMb2UDShYgjrFlko9?= =?us-ascii?Q?btswEVZMKBzxB7j+DxpBb64mJGzIv/CA5FegdtJAsHCJBpNxk408K4JUKngp?= =?us-ascii?Q?OA4OPy/wt1doEzv/jvc9nz6ZRu+7Idbfj9Cp9Ki1dqZjolbIZV7mdgN3sTfp?= =?us-ascii?Q?mjQ5qDxt0O2PSINYf9Xk3menEijDt829HzGrAtYBLV4R2qDKnfHFO7QBEVEB?= =?us-ascii?Q?UsqzYGdXmLnQ+URi3dloZwOzMrp5hAHwxXrJl/4547U4U9oG5tzbdom1nB1m?= =?us-ascii?Q?LWkNAJAqtP2wztaaDXFqwoSfruFJA9S0wvaUfBWOOgkPRw03fhU+kvTkSygP?= =?us-ascii?Q?lfQNYMe8u662PFuj18Mvl+vIh3wby0oXpmKyEctYcWAHf81c+UVTvHO7UvVF?= =?us-ascii?Q?xqNhF9LyLqT8ES5CbxcTwErtazyLSDO1lkZOEeGa/ChyUP4iC5rdKuFB5jJk?= =?us-ascii?Q?rZT9XwhJxVkeXCj3Y2BKHoj2XvyeDClU6qiCSsSvNJb6i7fVjrMcKiOqOgaf?= =?us-ascii?Q?z8uxbDLQzva62nvMFjZtkSCNg9A07OkKjPJt0spRSTNyiSjv+U7Fk9+bmIBF?= =?us-ascii?Q?VkkFIJiGtVLPZYB7PibPmUp5RjZriGRlRHczTPCmCYtN6z8LmHifel2kE7oH?= =?us-ascii?Q?w+osR6ycD9GoL2oxjhE/UA2cS6bVnbH5ypxdc3dtW0I+JMfsom68TsuEkaZu?= =?us-ascii?Q?k8MnbMJiD20yC2or2gBCoFEvoM5drs8uJzgn+r7sB8fZ6wEVO41r+OIArUp5?= =?us-ascii?Q?5gr3K7m649zQkkZgPI3ASYXedtFQS2oGgXjeOt6Zsl/f97ByTRmCxWTN5BqZ?= =?us-ascii?Q?OR1hKdVDMxiG/LylGepK5EkOJ4MHuNeynj7CHc6nmem/jV0Vqoip8GSpdG9M?= =?us-ascii?Q?/pFKRso884SW/YeUj4mKmClgkx6NI+f7Efgkjv+GekI86frwtVE8l6Pv+aDJ?= =?us-ascii?Q?swstURVi/AuxPBs2O/zQG5VHcmKD8BMPNlX8zpeynasMA9/ISvNjEbrM3I1j?= =?us-ascii?Q?GBfF8/qEt5TcsdP41SYfo83wzDqQGVMGjQyFUp7ZfczwH/BtcvvOI52oACUw?= =?us-ascii?Q?yZP5S5p63x+q49iaRIJsoHmbrKOe8lAP+jYpjEZoVWePyeTkfHT4PnWb3vwe?= =?us-ascii?Q?hS5Mfty8jWFd3tXLCTselbBmojSDtD8HdKtufeUfqnZWYT2e/5/wSIPWODyC?= =?us-ascii?Q?4kHzUBk7rE9GN0vWnKNNPjem8cAQcS2BkTMjbwkiEk8+XRYAImRSykDWefvn?= =?us-ascii?Q?hN6UqRhwYuangoi9sFkDn35Yk39pzG8UgUP0LRr4I6c00sMEBsNScCwdxaxn?= =?us-ascii?Q?VuSqMwIo+TT7fQ3mMZpzVSQZx3qHlXY37MVDbzMpVIdH5633PhDVhjJwgQdQ?= =?us-ascii?Q?zJFBdIGh+RGvI+tSGPbJRJXmufh5ejeUykbFU9rUHL0GHaTawEKUfVAI39Kp?= =?us-ascii?Q?rAqJmUcnSrZjZ4HFLek95ZnzY4jXiAE4fwP1GY41D1mLOPAv9ZUE/FCilM5i?= =?us-ascii?Q?zw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b54a5b44-6a05-4b60-a73c-08dbb94c19d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2023 20:07:50.5086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aRqEQgtj8l8D6Cc9yzRlZ1b139qundYIL+mRqDJx8UUPJT40BJP27meT/HwohMDi4uKcU8Z05Hk6aN3d+YIcZC6QFqEENswBa4F4xJ3hHaY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7865 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: usEVik0SphJpukeHDGKc7MOtx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Y+RXdyDL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Pushed: https://github.com/tianocore/edk2-platforms/commit/cf8a716 -----Original Message----- From: Huang, Yanbo =20 Sent: Tuesday, September 5, 2023 7:19 PM To: devel@edk2.groups.io Cc: Huang, Yanbo ; Isaac Oram ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4522 "if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) {" will not be execute= d in current code, put it within "case SysInterfaceKcs:" to avoid this issu= e. Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Yanbo Huang --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 36 ++++++++---------- .../GenericIpmi/Pei/PeiGenericIpmi.c | 36 ++++++++---------- .../GenericIpmi/Smm/SmmGenericIpmi.c | 38 +++++++++---------- 3 files changed, 49 insertions(+), 61 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 7113556df8..82f6d2a661 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ +++ IpmiInit.c @@ -630,8 +630,8 @@ InitializeIpmiKcsPhysicalLayer ( // Check interface data initialized successfully else register notify = protocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInst= ance->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -646,21 +646,19 @@ InitializeIpmiKcsPhysic= alLayer ( mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Bt.InterfaceState = =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ssif.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ssif.Interf= aceState =3D=3D IpmiInterfaceInitError) { @@ -669,12 +667,11 @@ InitializeI= pmiKcsPhysicalLayer ( &mIpmiInstance->IpmiTr= ansport2.Interface.Ssif.SsifInterfaceApiGuid ); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.Interf= aceState =3D=3D IpmiInterfaceInitError) { @@ -683,9 +680,8 @@ InitializeIpm= iKcsPhysicalLayer ( &mIpmiInstance->IpmiTr= ansport2.Interface.Ipmb.IpmbInterfaceApiGuid ); } - - break; - } + } + break; =20 default: break; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Pei/PeiGenericIpmi.c index 1d8266a0b1..ebc9e7085d 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ +++ PeiGenericIpmi.c @@ -343,8 +343,8 @@ PeiInitializeIpmiKcsPhysicalLayer ( // Check interface data initialized successfully else register notify pr= otocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInstan= ce->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2Ppi.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -359,42 +359,38 @@ PeiInitializeIpmiKcsPhy= sicalLayer ( mIpmiInstance->IpmiTransport2Ppi.Interface.KcsInterfaceState= =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Bt.InterfaceState= =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ssif.InterfaceSta= te =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ssif.Inter= faceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D RegisterPpiCallback (PeiServices, &mIpmiInstance->I= pmiTransport2Ppi.Interface.Ssif.SsifInterfaceApiGuid); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ipmb.InterfaceSta= te =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ipmb.Inter= faceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D RegisterPpiCallback (PeiServices, &mIpmiInstance->I= pmiTransport2Ppi.Interface.Ipmb.IpmbInterfaceApiGuid); } - - break; - } + } + break; =20 default: break; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Smm/SmmGenericIpmi.c index 350d6afef5..2349373317 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/Smm= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/ +++ SmmGenericIpmi.c @@ -210,7 +210,7 @@ SmmNotifyCallback ( &mIpmiInstance->IpmiTrans= port2 ); } - + ASSERT_EFI_ERROR (Status); return EFI_SUCCESS; } =20 @@ -335,8 +335,8 @@ Returns: // Check interface data initialized successfully else register notify = protocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInst= ance->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -351,42 +351,38 @@ Returns: mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Bt.InterfaceState = =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ssif.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ssif.Interf= aceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D SmmRegisterProtocolCallback (&mIpmiInstance->Ipmi= Transport2.Interface.Ssif.SsifInterfaceApiGuid); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.Interf= aceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D SmmRegisterProtocolCallback (&mIpmiInstance->Ipmi= Transport2.Interface.Ipmb.IpmbInterfaceApiGuid); } - - break; - } + } + break; =20 default: break; -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108858): https://edk2.groups.io/g/devel/message/108858 Mute This Topic: https://groups.io/mt/101185487/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-