public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Hsueh, DoraX" <dorax.hsueh@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Chuang, Rosen" <rosen.chuang@intel.com>,
	"Kasbekar, Saloni" <saloni.kasbekar@intel.com>,
	"Lohr, Paul A" <paul.a.lohr@intel.com>
Subject: Re: [edk2-devel] [PATCH] PACKAGE_GUID duplication in Intel silicon folders
Date: Thu, 2 May 2024 23:52:06 +0000	[thread overview]
Message-ID: <MW4PR11MB5821B49CC779E1C8A495EFE8CD182@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <c32cd297851a075874d440ddba44b12ceaeb06fa.1714629746.git.dorax.hsueh@intel.com>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Hsueh, DoraX <dorax.hsueh@intel.com>
> Sent: Wednesday, May 1, 2024 11:21 PM
> To: devel@edk2.groups.io
> Cc: Hsueh, DoraX <dorax.hsueh@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Chuang, Rosen <rosen.chuang@intel.com>;
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Lohr, Paul A <paul.a.lohr@intel.com>
> Subject: [PATCH] PACKAGE_GUID duplication in Intel silicon folders
> 
> From: DoraX Hsueh <dorax.hsueh@intel.com>
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4759
> 
> Modify PACKAGE_GUID duplication in Intel silicon folders.
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Rosen Chuang <rosen.chuang@intel.com>
> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Paul Lohr <paul.a.lohr@intel.com>
> Signed-off-by: DoraX Hsueh <dorax.hsueh@intel.com>
> ---
>  Silicon/Intel/AlderlakeSiliconPkg/SiPkg.dec  | 2 +-
>  Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec | 2 +-
>  Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec   | 2 +-
>  Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec  | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Silicon/Intel/AlderlakeSiliconPkg/SiPkg.dec b/Silicon/Intel/AlderlakeSiliconPkg/SiPkg.dec
> index aafce7a6..d6dc6eb9 100644
> --- a/Silicon/Intel/AlderlakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/AlderlakeSiliconPkg/SiPkg.dec
> @@ -10,7 +10,7 @@
>  DEC_SPECIFICATION = 0x00010017
>  PACKAGE_NAME = SiPkg
>  PACKAGE_VERSION = 0.1
> -PACKAGE_GUID = F245E276-44A0-46b3-AEB5-9898BBCF008D
> +PACKAGE_GUID = 1CAF6538-7B9C-4188-B928-17F7DD953DCF
>  
>  [Includes.Common.Private]
>  
> diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec
> index ca3e83bd..d96ff820 100644
> --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec
> @@ -11,7 +11,7 @@
>  DEC_SPECIFICATION = 0x00010017
>  PACKAGE_NAME      = SiPkg
>  PACKAGE_VERSION   = 0.1
> -PACKAGE_GUID      = F245E276-44A0-46b3-AEB5-9898BBCF008D
> +PACKAGE_GUID      = CA5148B1-3BB0-4D2D-AC3F-5497C8FEFB3D
>  
>  [Includes]
>    Include
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> index 6c9af567..83c4beb4 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> @@ -12,7 +12,7 @@
>  DEC_SPECIFICATION = 0x00010017
>  PACKAGE_NAME = SiPkg
>  PACKAGE_VERSION = 0.1
> -PACKAGE_GUID = F245E276-44A0-46b3-AEB5-9898BBCF008D
> +PACKAGE_GUID = 3043D26F-2A8C-441F-AFD9-8E80B7D65C7A
>  
>  
>  [Includes]
> diff --git a/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec b/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
> index 991ca155..5fc4099f 100644
> --- a/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
> @@ -11,7 +11,7 @@
>  DEC_SPECIFICATION = 0x00010017
>  PACKAGE_NAME = SiPkg
>  PACKAGE_VERSION = 0.1
> -PACKAGE_GUID = F245E276-44A0-46b3-AEB5-9898BBCF008D
> +PACKAGE_GUID = 0DEADE0D-B5F7-45D0-915F-77DB2497D270
>  
>  [Includes.Common.Private]
>  
> -- 
> 2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118545): https://edk2.groups.io/g/devel/message/118545
Mute This Topic: https://groups.io/mt/105858243/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-05-02 23:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02  6:21 [edk2-devel] [PATCH] PACKAGE_GUID duplication in Intel silicon folders dorax.hsueh
2024-05-02 21:32 ` Giri Mudusuru via groups.io
2024-05-02 23:52 ` Nate DeSimone [this message]
2024-05-02 23:54 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5821B49CC779E1C8A495EFE8CD182@MW4PR11MB5821.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox