From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.3728.1642042225728908003 for ; Wed, 12 Jan 2022 18:50:25 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jla4qKNW; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042225; x=1673578225; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2Gdc20dfAOimm4nm/2ugEOszLQFblyDb+H8ORZHbfKk=; b=jla4qKNWmIx1yGykUHcVQtT9QeldHa/+9A3/U/BxLS0wyrY33lSm555E zoqT/V5A8u8hslLBoZd7qFMKs7wuwOFoF0gqDCie/uTyYKY7VUpSDwGZC gKeLhXB86muzJxxiDoK1+9tskvJP0RkhmzL/q3HjIoFu0Rg+Y5UtqWxZx QJ76rIiqXyRSJpbVBNt8STuYPVrat+vDsmfG67wRZ+e84EZvDoQVZwVod 3G/bDoHDPXKQOtg0pwjlf5HugOCzp5zEQJVzR4roppqx8mZ8qD4YrGRWx cLnetR581J3TQMIh1OeTsT6cV8FeCoJhDntHnYpXP/LjJH7d+O/NiOofL w==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="244117818" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="244117818" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:50:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="515753982" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 12 Jan 2022 18:50:24 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:50:24 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:50:23 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:50:23 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:50:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Op8WP3h+on4Nnumv0dJU0evpjlv0cdDxP3rF7oQc1cBfRsNXSnwcn907gWFYFKUMY/1wGhoq6sOMxtoIP1zI/fVEJFVouVhNTciIsKoSuCnLCoMTpK1MEumSklYsg0JhkVjcAH3ukrAvQGylKujYB2u5hmOLipPmuGG4ACOt6atLQNWv/7ttdXz3mG/3TgIRo/D5y9SiSSbOGpKZYLS/jNvxO9/e8sdFwPqRr31N/vsA5g+x5UIrucyilmtGn7PysctiiX2ERpUO4WUxo73Dyu6nhEFbWiF7K05HoiEx/SkgK4kj32y5lluJaOWYndRzi5vQZkL4BHMq3cNjE6i34g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tZev8bsK1CyINFK+yhtGe5qzRwnY8ZVrU9atLiC3k8I=; b=WYmo2QP3gFtqJRTdoxhb26EvYjk9WgI/5QRl4lZZY06Bzmaein/7emD1A8i7imRjuQrf19iYmh6dlfoUlFYvc76We1k2C84M+0rt7w37S1G8y4VBfyVxt0vcMDAaHu+2EJmOsRPB9CGrAgw9lC5yf+P3STkQ2r1jhvd1JfqVbuEvWIXCBcDkUY+shBDv2bRj7BA5zs2fpAAUycRq0Ckp8gJ+3NZ8+FpFBWgC0jnS1eAIq9QyPopA4W2s2/KrFlhjZqLRePIJWoEThRzvHmxsAYcdyBilq3VPVT7NY2JsoBRtdwpWS04xhjYxNhASgb1e/TsjbjP/jrd00aCBm7C/Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW5PR11MB5764.namprd11.prod.outlook.com (2603:10b6:303:197::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 02:50:22 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:50:21 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Oram, Isaac W" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use MinPlatform build include files Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use MinPlatform build include files Thread-Index: AQHYB1sqH1zzt+TKZEStvb5oAsUdmqxgQeMg Date: Thu, 13 Jan 2022 02:50:21 +0000 Message-ID: References: <9fe41786a6142a31b8724632f37eab047e3d9deb.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: <9fe41786a6142a31b8724632f37eab047e3d9deb.1641953242.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 934fee18-7209-4e0d-a66b-08d9d63f712f x-ms-traffictypediagnostic: MW5PR11MB5764:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N9DKRgGS3jsQHi5YWsfaRsRVyq402wRRRwiZi8gdC675Hc06xoRsGVDnm2g6mA2+8tp6Y4RwydGun0tsBQW0cPTy1S/C2fm42jiU57EHnZlUmxn2FLY9SLKp57sFd3L7yAqtI+4O3xVEq7pB/wplo7r0KJnQSnEhRub7/q+gBPkVuFLU6CXzHC1wqEfefjEh5Zr2hzmPnaEIr+x2FPQ3WKOB5mmai/dwEaaqNdcq2rW9/ocvO2kiKvtB4sG56OylJoHsmvpiv//lgMRMO+yMUNlqM/WsCB0bk+5MXHJlolGEhGJnHILUboOE1x/Yhxk0YWU0/MdU1fyAeAVlWXHl/TGNaDImARY5WcfinBB1vtIVJdHuRwn1WxJ0MH0qT4dESHPzwsf/S60MXaIiESEbXgDpFqLdBrxZoHEQITZ1Ykgj5bb4Xx1SGMxY+2OjxLVqc/e0PLAUrGzwldTC0liz+1humDDDmJ2V6/S2CeS7gBWiy2vx7Td9xN61SQYrWD6fNHoTnhStujTnlU6nJBXsCh27AGM1U1l2xqlWSFT4JDDCsTzwi3lfeLThYb8MhgMKDBYZ2MCQ95JwiNO8GHBGKJt6xjDQ5A26FgPTLGPq6cb3TB0ODmFVgjaSc9agFu6VsE5zKg1iIYgYvWb+qwb7SOoRX1oQ1GdsccfNUZj2r/W8qjaKSfjrPv8Dgfrwo2tzk6y5ZXviAtFkI8hAP9MbfyPpij7SwIQs+fD7/ZglzxSC83oS7/s+FbPB7bcOr7QtBhtsVTKeypA9nk8H+WeKnuBmi5498VIuB4vQGhhY7fCKVXk+T3xr/nz0aHQ9B+/o3puF4bAwxCdwf8D6EmWpoA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(71200400001)(9686003)(316002)(52536014)(26005)(6636002)(54906003)(33656002)(38100700002)(122000001)(38070700005)(110136005)(186003)(55016003)(7696005)(82960400001)(8676002)(508600001)(8936002)(83380400001)(30864003)(86362001)(5660300002)(76116006)(6506007)(66446008)(64756008)(4326008)(66556008)(53546011)(66476007)(966005)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8Bv32rOEX93zyJeHEs4qPPooQFckxTwv0in+HmNtaFz3cAwuNoybHg5ufGYE?= =?us-ascii?Q?XxNiq7+ExWKYEhBSnGg54RCCmEFj+XlxkH8WPtPlu01Th7s2k6qwJ526nUIf?= =?us-ascii?Q?nbk3u5AENRildO9V2BRCm2E1XmSBfWtQRmMkqLOdZt+OSturqxbajDqk/KjC?= =?us-ascii?Q?YyLkKvZTW0AyW48dasijkFywB+4VpYUjfpnYPge5+wk9YXZvV7O8LCYLr/xi?= =?us-ascii?Q?86VjWGMnEEWQ8ahW1ZgLBGtGGta03Kbx3z3u8BI+116gdXNXpdIhFN4rSDRC?= =?us-ascii?Q?l3UZe5C1UnqHZBCO0ZrDJqd56Ihmyydxh6d/DQmX9sXOfNvSNuK23TiS+SDk?= =?us-ascii?Q?TeJcl8fxC2ACo58aGY4hRYTFIQJoGCX331iIRvWy6rtg/1XRFzzVCQUOVj4S?= =?us-ascii?Q?kmzJudPqrViZC+6ugT7G2llOd+uF/v0tPlc+0ECBV+tM8rETVT0EjnjRDqNk?= =?us-ascii?Q?9Xj6Qoz3bDzI71AL+xVs2IAdWl+DG+SoFdzoDqBgk1lhPOK3JlhYoJJT8ihP?= =?us-ascii?Q?x85hQ2j0w1EFntIv3bCTjsKtGQkkB1SMr5HADyjuOQet2CR29Z6wYqrK5N/l?= =?us-ascii?Q?r+D1K+W1IssSigUZF7CUKtDiwWrvcqU5CCmmworxr5Yu90s+is46LqmYe1HC?= =?us-ascii?Q?fBlP8uDPp+tx4jg/xT1g9V9e6y3iPS+CcXWJauKo4HV+Im9UQlFPlRe8L2ay?= =?us-ascii?Q?DtLa7hqkgbSP4Hy1FFs3tsUlTIQC8UTbmhCxiHgYOM1Ve0nQakjnmKRGBRQK?= =?us-ascii?Q?HVxBtpfBKY1ibwa4SgrVOr6bax/3XqPK/OLM5oxTuYj65CMZhTh4txq++t8M?= =?us-ascii?Q?VzO4mYlEjEt1svS5gIKERlMnfIzRuEIJXi7QJvp9Eovc4pIFfq2WUdYZUhpm?= =?us-ascii?Q?dqyLrpJIg8e+EYdwSvpCH+cV3LW98WXyDx9RKdeX7vF+NbGxNoOuarF1XhXJ?= =?us-ascii?Q?5PjFSCCQ3fjchj/E73RTp9tfHDE5bVBsiAzPvR3qpHevJ9AL+ZHADH2J0/dz?= =?us-ascii?Q?aEWrmfg9CIt1523Cg5g9X5AHX3uY9IcHKsCET3+Mj5AXw51U4flcxvLAKrbz?= =?us-ascii?Q?SE4FsAAyRlE4qphYuJO9STw8nJVOA+xvLj48k6WJwlFIBsVaSb5SYF4NqQs0?= =?us-ascii?Q?djZs5Klbq8K9vKDJjSRWqLVSgT1N6thqLbTPni2atgDxqVp3wm+C9RETve1Y?= =?us-ascii?Q?ZOAaVblmJ9DhscONYp9b548yPNoE/kgkpu+EGvREJhKI4MO/fYvk3qHkRmkP?= =?us-ascii?Q?SgRkpCVbpAPAC0/HvGQSSzVSXr8m0zrMzx8P6QNovBWTfH/f4psWbZp2b3mh?= =?us-ascii?Q?4hFEy3ZNazFqqdaE94cGZiopKzJ09zWjCVZxPlUhbFjNyv6xOKgueHn3tlUJ?= =?us-ascii?Q?XRQcEVlYFOPfCkHUo6wgDRSpX7SZSuhH00QP1sXhSFDUaxmwxMvMsNctNWWi?= =?us-ascii?Q?lRCI2/gvJEY8B0UnehEOFZJMkimeh3QnqsVpkppGxiOasCNv4kE9+ajTdfOq?= =?us-ascii?Q?THqjPXQZ6cg9B3rZ5VUy691J9D2qPgE7lW9LjuCZfF6yHqVQt40Ik/Sns6Y2?= =?us-ascii?Q?FipneRO0bE83j20jTNwyNI3AVOCczR9pWBhCzoF/yOgV3dL03BV9ixVZ6N9I?= =?us-ascii?Q?LIJke6qPM0IziEK3O1VnmqcLRWA9uoYGbQgWCNCxW5AUjzbx9wJlsI6vr0WD?= =?us-ascii?Q?HwqfDQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 934fee18-7209-4e0d-a66b-08d9d63f712f X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:50:21.9242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kM0YYyGqaHlUQwbkbqjWdDmw3gFPS9ah1p3TxcWV8JLZ9YZTyEith9U949aBo+gZhvdQRVihnJe1/q/mdAxS/MAFUEEkhUElY28d6wjGnMU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5764 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oram, > Isaac W > Sent: Tuesday, January 11, 2022 6:20 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: > Use MinPlatform build include files >=20 > Also added feature enable flag >=20 > Cc: Sai Chaganty > Cc: Liming Gao >=20 > Signed-off-by: Isaac Oram > --- >=20 > Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/Sp > crDeviceLib.h | 2 +- >=20 > Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMem > ory.fdf | 13 ++++ >=20 > Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemo > ry.fdf | 11 ++++ >=20 > Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeatu > re.dsc | 62 -------------------- > Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md > | 12 ++-- >=20 > Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.de > c | 6 ++ >=20 > Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.ds > c | 18 ++++++ > 7 files changed, 55 insertions(+), 69 deletions(-) >=20 > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/ > SpcrDeviceLib.h > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/ > SpcrDeviceLib.h > index 947813815e..2e50270ee6 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/ > SpcrDeviceLib.h > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/ > +++ SpcrDeviceLib.h > @@ -12,7 +12,7 @@ >=20 > /** > Get a Serial Port device used for SPCR. > - The caller should call FreePool() to free the memory if return value i= s not > NULL. > + The caller should call FreePool () to free the memory if return value = is not > NULL. >=20 > @retval NULL Can not get device. > @retval Others A serial port device path. > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMe > mory.fdf > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMe > mory.fdf > new file mode 100644 > index 0000000000..f963f567c2 > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMe > mo > +++ ry.fdf > @@ -0,0 +1,13 @@ > +## @file > +# FDF file for post-memory SpcrFeature advanced feature. > +# > +# This file is intended to be included into another package so > +advanced features # can be conditionally included in the flash image > +by enabling the respective # feature via its FeaturePCD. > +# > +# Copyright (C) 2022 Intel Corporation. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent ## > + > +INF SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMe > mory.fdf > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMe > mory.fdf > new file mode 100644 > index 0000000000..3c461e7fbc > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMe > mor > +++ y.fdf > @@ -0,0 +1,11 @@ > +## @file > +# FDF file for pre-memory SpcrFeature advanced feature. > +# > +# This file is intended to be included into another package so > +advanced features # can be conditionally included in the flash image > +by enabling the respective # feature via its FeaturePCD. > +# > +# Copyright (C) 2022 Intel Corporation. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent ## > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFea > ture.dsc > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFea > ture.dsc > index c51e552df5..b06ddf4fe6 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFea > ture.dsc > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFea > t > +++ ure.dsc > @@ -25,40 +25,9 @@ > !error "DXE_ARCH must be specified to build this feature!" > !endif >=20 > - > ########################################################## > ###################### > -# > -# Library Class section - list of all Library Classes needed by this fea= ture. > -# > - > ########################################################## > ###################### > - > -!include MdePkg/MdeLibs.dsc.inc > - > [LibraryClasses] > - ####################################### > - # Edk2 Packages > - ####################################### > - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > - > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibR > epStr.inf > - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > - > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry > Point.inf > - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > - > UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo > otServicesTableLib.inf > - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > - > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf > - > - ####################################### > - # SpcrFeaturePkg Packages > - ####################################### >=20 > SpcrDeviceLib|SpcrFeaturePkg/Library/SpcrDeviceLibNull/SpcrDeviceLibNull.= i > nf >=20 > -[LibraryClasses.common.DXE_DRIVER] > - ####################################### > - # Edk2 Packages > - ####################################### > - > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo > ryAllocationLib.inf > - >=20 > ########################################################## > ###################### > # > # Component section - list of all components that need built for this fe= ature. > @@ -74,38 +43,7 @@ > # >=20 > ########################################################## > ###################### >=20 > -# > -# Feature DXE Components > -# > - > # @todo: Change below line to [Components.$(DXE_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 > # is completed. > [Components.X64] > - ##################################### > - # Spcr Feature Package > - ##################################### > - > - # Add library instances here that are not included in package componen= ts > and should be tested > - # in the package build. > - > - # Add components here that should be included in the package build. > SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf > - #{ > -# > -# > SpcrDeviceLib|SpcrFeaturePkg/Library/SpcrDeviceLibNull/SpcrDeviceLibNull.= i > nf > -# } > - > - > ########################################################## > ######################################### > -# > -# BuildOptions Section - Define the module specific tool chain flags tha= t > should be used as > -# the default flags for a module. These flags are= appended to any > -# standard flags that are defined by the build pr= ocess. They can > be > -# applied for any modules or only those modules w= ith the > specific > -# module style (EDK or EDKII) specified in [Compo= nents] section. > -# > -# For advanced features, it is recommended to ena= ble > [BuildOptions] in > -# the applicable INF file so it does not affect t= he whole board > package > -# build when this DSC file is active. > -# > - > ########################################################## > ######################################### > -[BuildOptions] > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md > index 0a5d48876d..66138ee0f6 100644 > --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md > +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md > @@ -22,10 +22,10 @@ Platform can implement its own library to select the > serial port device. > * SpcrDeviceLibNull >=20 > ## SpcrAcpiDxe > -The main driver of convert the serial port device info to ACPI table. > -It will call the function GetSpcrDevice() in the library SpcrDeviceLib t= o get the > serial port device path. > +The main driver of convert the serial port device info into an ACPI tabl= e. > +It will call the function GetSpcrDevice () in the library SpcrDeviceLib = to get > the serial port device path. > If the serial port device path is not NULL, then use gEfiPciIoProtocolGu= id to > get the PCI info, and use the gEfiSerialIoProtocolGuid to get the serial = port > info, such as the baud rate etc. > -If the serial port device is PCI device 00:16:03 (AMT serial over lan PC= I > device), then will set the BaseAddress. > +If the serial port device is PCI device 00:16:03 (AMT serial over LAN PC= I > device), then will set the BaseAddress. > At last fill the ACPI table as Windows required. >=20 > ## SpcrDeviceLibNull > @@ -37,19 +37,19 @@ Fill the serial port device info used for SPCR to ACP= I > table. >=20 > ## Configuration > There is not special configuration. > -But the platform maybe implemente its own SpcrDeviceLib. > +But the platform may implement its own SpcrDeviceLib. >=20 > ## Data Flows > GetSpcrDevice() -> serial port device path -> get PCI info and serial po= rt info > -> ACPI table. >=20 > ## Control Flows > -GetSpcrDevice() in SpcrDeviceLib -> SpcrAcpiDxe. > +GetSpcrDevice () in SpcrDeviceLib -> SpcrAcpiDxe. >=20 > ## Build Flows > There is not special build flow. >=20 > ## Test Point Results > -* Check the output ACPI table. > +There are not test points implemented. >=20 > ## Functional Exit Criteria > * Check the output ACPI table. > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg. > dec > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg. > dec > index 03776abf06..b084fad892 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg. > dec > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg. > d > +++ ec > @@ -21,6 +21,12 @@ > [Includes] > Include >=20 > +[Guids] > + gSpcrFeaturePkgTokenSpaceGuid =3D { 0xe978c988, 0xeeba, 0x4671, { 0xb8= , > +0x0d, 0xcc, 0x8b, 0x89, 0xb5, 0xd1, 0xef }} > + > +[PcdsFeatureFlag] > + > +gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable|FALSE|BOOLEAN > |0x0000 > +0001 > + > [LibraryClasses] > ## @libraryclass Provides an API for get SPCR device. > # > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg. > dsc > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg. > dsc > index 82d2d3ac73..2ee874a58e 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg. > dsc > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg. > d > +++ sc > @@ -24,6 +24,24 @@ > PEI_ARCH =3D IA32 > DXE_ARCH =3D X64 >=20 > +[Packages] > + MinPlatformPkg/MinPlatformPkg.dec > + > +[PcdsFeatureFlag] > + # > + # PCD needed for MinPlatform build includes > + # > + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable > |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable > |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > |FALSE > + > +# > +# Include common libraries > +# > +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc > + > # > # This package always builds the feature. > # > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20