From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 07455D800F3 for ; Fri, 3 Nov 2023 21:14:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dGffUb4WkCUqB/XfNHERj01eRz49yJPxyaWtlua1Fl8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699046084; v=1; b=RHhtVQ7AcDg5wVmyK4pIeZKxrgeCosg6V534XF3xE+cFSy2W2Bp9tAFfOYjGbkHKNjWCDVnS +kfPZCqwRLDiemgS1CE5CZbveIW803apT2rECHVMzYPiLswHwQWEkWjB318VSFW60Ho9rFJEVp/ 6hGdLks9nm7A0nhSLSWmu09c= X-Received: by 127.0.0.2 with SMTP id eAGmYY7687511xZHazECmBuJ; Fri, 03 Nov 2023 14:14:44 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.64937.1699046084060481581 for ; Fri, 03 Nov 2023 14:14:44 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="392913078" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="392913078" X-Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 14:14:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="3031813" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Nov 2023 14:14:42 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 3 Nov 2023 14:14:42 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 3 Nov 2023 14:14:41 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 3 Nov 2023 14:14:41 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 3 Nov 2023 14:14:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CBw/39ZGS2xCjiHW26tc70qnvy1DjBaKsRCgqEjkldZk4N6Iv/gm+bfWBfgPmivYZeeAJbmRBZkeqlkWHXEoKGIHZOm1TviQfKFhBg3LTNNnLop7L1dcijctAfS/lzZyANFqKcOzUBc8p3PD+i0VYgHVvxPxiZaRHb6SEZ2DGb8nWfLfuSlSRtKNLbr3xENTNIA8Y2GFGptI04GSb+aaOPglVkJqbQxoCXPiqNmrBuAIw8h7nkWdGtednAhXrK/Kz3VMLXqTV5q/BBewpA4iFcDnXmAp62vl8D5TWNi+xnxu29V0i8yP6fEIjyEKb3VJtLy/g7QTJk/PRyVkmEbqwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nKAfDd6fBR9p9T5XMW3NK+7U6lY67suPeQZuycWyoMc=; b=PWB7bGgrbo4qTD2P+sQfVF4Sxe0NDPq7fRPvou1dGOczdmVXlKOfmU0gVyeXLIhQFynJ1+wueIx/IpUoIuigaIaZ7X+2CsjbWR9VjPJoS+uGp4sRY5bCd0qhWjc8fsdl2Xu2Ck3R558YVZXZHxtFOPadC28DCKicZwzodFZvQhxFg4z+MQzEIAU0ocavxf+L86AIM2kRHuYToJThEM9ISzMygbuFPkixQkPYnh1ZkGru5/J32QhNZ802dzbC/AosVxMjFewGgQgeTCt4xRz10oTKMX/bhPBHhs84Vwy25fUDsInFtXplqfT63YlgjbQwF0PEKK2Jhd7Qltfb2hrdkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SA0PR11MB4672.namprd11.prod.outlook.com (2603:10b6:806:96::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 21:14:39 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::c90f:1f62:c3fa:3ac8]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::c90f:1f62:c3fa:3ac8%6]) with mapi id 15.20.6954.019; Fri, 3 Nov 2023 21:14:39 +0000 From: "Nate DeSimone" To: "Huang, Li-Xia" , "devel@edk2.groups.io" CC: Abner Chang Subject: Re: [edk2-devel] [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaC8LPpRxwzET+N0WnrpUoOljpALBpHePA Date: Fri, 3 Nov 2023 21:14:39 +0000 Message-ID: References: <20231031062338.1501-1-lisa.huang@intel.com> In-Reply-To: <20231031062338.1501-1-lisa.huang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|SA0PR11MB4672:EE_ x-ms-office365-filtering-correlation-id: 9f50fbd7-8f41-49e7-2b67-08dbdcb1e3db x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: K7/nXfyWRq0cHVMIzwrzzkOqMhyRxXVIQy+aV+rrOoe7z0iF7dWSpirrJFe2lgEFT27dJXH+CqeeyTZRd1FtoK/B07dv18eIdrL/szHkGx5QqCTwM259fVJysPn9vHHMCBEP5zZ+/OgsKe/8quBnHAXOGNAfkpQnKzAJ6VmRItjUAYk5RbTgqvtvPCzu4o/fYcQ+VazZ1azEUocvikH7Z7C3qBUeiKTDnyEAycV51/P+ppQu1AcOcggifVy3FrTQwfDHBwguWXgynDPd5WrhkPrDCa2C19yX8GVupGwDEgTQOFRaU1jBycvzjqtWzFrZsB6deISkYYi8g/Kyt4xQJJEGG1j6m6+fM7oZfkA2pgv9zvZ5hAX9uckJB7TDG+9WGggsgnuQdzB1LdhxYsFTGON5vci9gRHcFCkHwvrKPjwCu9B/LyAzcj5XgCa3GKz88ceaWMJq7moCnGx7+WoTIKTR30bVHBVpiEgiiRyxLwtzeFD7iIRjDvF/dbn3SqMqMrfp6ZQs6SncLx23ffE3YluoBgAxW4WdoyAjhmL6DTilEoBjD44yAJn5/XMevhVi+UXvS/zFQ01jCWDCZfmJhiBXRDwjTMXjogdCkBLrd+HjBPaUYxi+L3nHGRH5ogXL x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZA/Y5UPNRys+0pbPECjNeUnNMgdxQlVa+sdalXsw4bbBYduj9QtlIM/RFbYt?= =?us-ascii?Q?YxUKRaMDdLfrQVcnShHk/IrnVpi8mnJQjJe6QOaOZT7ubtwe597FqmQejTOG?= =?us-ascii?Q?LbOSdIaanUogP9MWyk6PZXUreB7DbugNVYymkLvMmuWCKlneV0IMJLK0s2v/?= =?us-ascii?Q?yfULkThl4jmKXroK6ibL27AT4wcn00Ir0St0p8xaaZRIZyTtpbWpES300E+d?= =?us-ascii?Q?ADZE1eBhJa2ujlU5TWcUl/Fzw26cpDlioiY6H+wuerQ+31Btp9iN6uM8C6dr?= =?us-ascii?Q?BZ54lqZIZ9YvcsAN7dL8JcL7awgV7GQhoIb7XpykNd/g1GjzEe49Cwd89Ncw?= =?us-ascii?Q?/BW86P6V3lfxhLZWwFB0hAKtpNNhSyoqtzypXCY38Yoyyo4iLZieFQJpznE1?= =?us-ascii?Q?wbA6xCdlxZIvtyOWpXS5OU4cntAvsd1LBIe6bT9gK9I8ZY9huqX2YJK5FEgZ?= =?us-ascii?Q?eYdHgFENOXNuq0jmbI7q5DjmAAgfc5FyR8xMWIE8Gm2cJX/pIaIIBGR41lTp?= =?us-ascii?Q?pGxhFtE98Nwbr6+GFFTaiHoQo0kcc/tCB3k+2XoZ1dbJtAtW91Z8Wch/Qlrx?= =?us-ascii?Q?VLzTLlMTGdHSHPlPkV+HGfDzRh1VzuxzFksGEElgh/cEuhkPgNZIHSaHPZNT?= =?us-ascii?Q?pBTMQg9of0M01IT5jeekqEaijDoUz+CGb8pPDwHydduKpHwB9MaDZOT7nXh1?= =?us-ascii?Q?YOdXaXbKt6rho3UsIs0dO6GpFWoShNBtTe9TwojJo9C7UrltLQ6JksSn4oyN?= =?us-ascii?Q?F4sAPucSeXCMO3l085DTpYjInrTYXC7vIYzYASaC1H/yX9mSm7lafLIGmat7?= =?us-ascii?Q?ULof3sd3K8x2Pzh8yOYSZtAWFKLPTRe53YxDoU+p4WRJCmfagUc96RN1dDpN?= =?us-ascii?Q?Q6Q65pzissYlA1ZUHPucIZIE4k3afrxtziOUV16QXMRxCjRpCrKHBINMdZOZ?= =?us-ascii?Q?3NQvOBjbizdC715CYplDxzOIUZPqw6mp/r5iyu5TTxc+fpg3OyhBiGng5WtL?= =?us-ascii?Q?rw9RDDhlYEGpzAq8Be288iilOycFbMjc6MMHjj7Pv8FWk7XUi3K5T/HYgA5u?= =?us-ascii?Q?+IKhkD7Hmbga98Q/NMr/PjVFwzAZ/NdRs9zJ76nF8J7cPRODGV7VZyTDx1mr?= =?us-ascii?Q?lZUIUXjH6l+Jq8CVp/SGJMWc7cMEzqdX/Z5rcQSL15FU+ML5mI9iZQEyhQ9i?= =?us-ascii?Q?3OOoqJrrspdy9XjcdOlke3yX2k0KnR3sy2Wr9sEEbEz1zx6ZKIx2v34mTALs?= =?us-ascii?Q?v8Hz0crFtt6YNwiBm9It6LE6Nm+QgY8BeadSAw7looNCLH+DHCv+PvV925Xd?= =?us-ascii?Q?UKT0UT2dcsaoUgfyeY0WNYPaFTidvlfhUAB/0iKlQppMSGSBO5SWNeFn9Vel?= =?us-ascii?Q?xTDUIrVggNQJnFWKfwqlEsWU1MbDq1f2GfPz86YDkunQaubv4p16MKxyIfPP?= =?us-ascii?Q?PEsDKjga+G9H3O+zCpBf6gHVTExhYExbcwwA59xd/mky9CHmdzYOhVFagV8d?= =?us-ascii?Q?BFa+kByNXa/WZ3IPwb+SJK2mi1rzhx1w8liilmgKnH44yT/KQyu62RQ7bmLl?= =?us-ascii?Q?1gaq4UprGJEWQDqQqLf7pueknPORbWxdtMAI22s7f3dCOtjm/T/oysgv32Y7?= =?us-ascii?Q?NQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f50fbd7-8f41-49e7-2b67-08dbdcb1e3db X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2023 21:14:39.2788 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XuIe8znUcP47tmywbQz1+Q0xCa9S+cCco67U40GOLIn6PTHQR0Mh3THeSeDnWkuTSdlt5BJOTFXQpviPqtohD/vFVAziinU09m2mQd66grY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4672 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VLLx9m02MKniVEPUm6O2LHgYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RHhtVQ7A; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Nate DeSimone > -----Original Message----- > From: Huang, Li-Xia > Sent: Monday, October 30, 2023 11:24 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Desimone, Nathaniel L > > Subject: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone > MM >=20 > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver >=20 > Cc: Abner Chang > Cc: Nate DeSimone > Signed-off-by: Lixia Huang > --- >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.c | 146 ++++++++++++++++++++ >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.inf | 51 +++++++ >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > | 2 + > 3 files changed, 199 insertions(+) >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > new file mode 100644 > index 000000000000..d808e2517c99 > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > +++ daloneMm/StandaloneMmGenericIpmi.c > @@ -0,0 +1,146 @@ > +/** @file > + Generic StandaloneMm IPMI stack driver > + > + Copyright 2023 Intel Corporation.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +// > +// Statements that include other files > +// > +#include > +#include > +#include > +#include > +#include > +#include > +#include #include > + #include > + > +#include > +#include > +#include > +#include "IpmiHooks.h" > +#include "IpmiBmcCommon.h" > +#include "IpmiBmc.h" > + > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > +EFI_HANDLE mHandle; > + > +/** > +Routine Description: > + Setup and initialize the BMC for the SMM phase. In order to verify > +the BMC is functioning > + as expected, the BMC Selftest is performed. The results are then > +checked and any errors are > + reported to the error manager. Errors are collected throughout this > +routine and reported > + just prior to installing the driver. If there are more errors than > +MAX_SOFT_COUNT, then they > + will be ignored. > + > +Arguments: > + ImageHandle - Handle of this driver image > + SystemTable - Table containing standard EFI services > + > +Returns: > + EFI_SUCCESS - Successful driver initialization > + > +**/ > +EFI_STATUS > +SmmInitializeIpmiKcsPhysicalLayer ( > + VOID > + ) > +{ > + EFI_STATUS Status; > + > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > + > + Status =3D gMmst->MmAllocatePool ( > + EfiRuntimeServicesData, > + sizeof (IPMI_BMC_INSTANCE_DATA), > + (VOID **)&mIpmiInstance); > + > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > Status)); > + return Status; > + } else { > + > + // > + // Initialize the KCS transaction timeout. Assume delay unit is 1000= us. > + // > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) / > + KCS_DELAY_UNIT; > + > + // > + // Initialize IPMI IO Base, we still use SMS IO base to get device I= D and > Seltest result since SMM IF may have different cmds supported > + // > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > (PcdIpmiSmmIoBaseAddress); > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGN= ATURE; > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRES= S; > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > IpmiSendCommand; > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus= ; > + > + mHandle =3D NULL; > + Status =3D gMmst->MmInstallProtocolInterface ( > + &mHandle, > + &gSmmIpmiTransportProtocolGuid, > + EFI_NATIVE_INTERFACE, > + &mIpmiInstance->IpmiTransport > + ); > + ASSERT_EFI_ERROR (Status); > + > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > + > + return EFI_SUCCESS; > + } > +} > + > +/** > + The module Entry Point of driver. > + > + @param[in] ImageHandle The firmware allocated handle for the EFI > image. > + @param[in] SystemTable A pointer to the MM System Table. > + > + @retval EFI_SUCCESS The entry point is executed successfully. > + @retval Other Some error occurs when executing this entry poi= nt. > + > +**/ > +EFI_STATUS > +InitializeGenericIpmiStandaloneMm ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_MM_SYSTEM_TABLE *SystemTable > + ) > +{ > + SmmInitializeIpmiKcsPhysicalLayer (); > + return EFI_SUCCESS; > +} > + > +/** > + Unloads an image. > + > + @param[in] ImageHandle Handle that identifies the image to be > unloaded. > + > + @retval EFI_SUCCESS The image has been unloaded. > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle. > + > +**/ > +EFI_STATUS > +EFIAPI > +GenericIpmiStandaloneMmUnload ( > + IN EFI_HANDLE ImageHandle > + ) > +{ > + EFI_STATUS Status; > + > + Status =3D EFI_SUCCESS; > + if (mIpmiInstance !=3D NULL) { > + if (mHandle !=3D NULL) { > + Status =3D gMmst->MmUninstallProtocolInterface ( > + mHandle, > + &gSmmIpmiTransportProtocolGuid, > + &mIpmiInstance->IpmiTransport > + ); > + ASSERT_EFI_ERROR (Status); > + } > + gMmst->MmFreePool (mIpmiInstance); > + } > + > + return Status; > +} > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > new file mode 100644 > index 000000000000..170e0a8d136b > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > +++ daloneMm/StandaloneMmGenericIpmi.inf > @@ -0,0 +1,51 @@ > +## @file > +# StandaloneMm Generic IPMI SMM Driver. > +# > +# Copyright 2023 Intel Corporation.
# SPDX-License-Identifier: > +BSD-2-Clause-Patent ## > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D StandaloneMmGenericIpmi > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f00= f81060 > + MODULE_TYPE =3D MM_STANDALONE > + VERSION_STRING =3D 1.0 > + PI_SPECIFICATION_VERSION =3D 0x00010032 > + ENTRY_POINT =3D InitializeGenericIpmiStandalon= eMm > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnload > + > +[Sources] > + ../Common/IpmiHooks.h > + ../Common/IpmiHooks.c > + ../Common/IpmiBmcCommon.h > + ../Common/KcsBmc.c > + ../Common/KcsBmc.h > + ../Common/IpmiBmc.c > + ../Common/IpmiBmc.h > + StandaloneMmGenericIpmi.c > + > +[Packages] > + MdePkg/MdePkg.dec > + IpmiFeaturePkg/IpmiFeaturePkg.dec > + > +[LibraryClasses] > + MemoryAllocationLib > + BaseLib > + MmServicesTableLib > + DebugLib > + StandaloneMmDriverEntryPoint > + IoLib > + ReportStatusCodeLib > + TimerLib > + > +[Protocols] > + gSmmIpmiTransportProtocolGuid # PROTOCOL > ALWAYS_PRODUCED > + > +[Guids] > + > +[Pcd] > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > + > +[Depex] > + gIpmiTransportProtocolGuid > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > index 5df71300cbd1..73dca30caae9 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > +++ ec > @@ -129,4 +129,6 @@ >=20 > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > D0000003 >=20 > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > |0xD0000004 >=20 > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > 0xD0000005 > + > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] >=20 > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > 6|0xD0000006 > -- > 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110671): https://edk2.groups.io/g/devel/message/110671 Mute This Topic: https://groups.io/mt/102292409/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-