Re: [edk2-devel] [PATCH 2/3] MinPlatformPkg: Update the comments of GetInformation function

["Nate DeSimone" <nathaniel.l.desimone@intel.com>]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Shang, Qingyu <qingyu.shang@intel.com>
> Sent: Monday, April 8, 2024 2:47 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>; Gahan Saraiya <gahan.saraiya@intel.com>
> Subject: [PATCH 2/3] MinPlatformPkg: Update the comments of
> GetInformation function
> 
> Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND to
> EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation().
> Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol should
> have a provision for IHV to return no data.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Qingyu <qingyu.shang@intel.com>
> Signed-off-by: Gahan Saraiya <gahan.saraiya@intel.com>
> ---
>  .../Test/Library/TestPointLib/DxeTestPointAip.c              | 5 ++++-
>  .../Test/Library/TestPointLib/SmmTestPointAip.c              | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip.
> c
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip.
> c
> index a7fe9530cf..f2c44afb50 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip.
> c
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPoi
> +++ ntAip.c
> @@ -12,7 +12,9 @@
> 
>    This function returns information of type InformationType from the adapter.
>    If an adapter does not support the requested informational type, then
> -  EFI_UNSUPPORTED is returned.
> +  EFI_UNSUPPORTED is returned. If an adapter does not contain
> + Information for  the requested InformationType, it fills
> + InformationBlockSize with 0 and  returns EFI_NOT_FOUND.
> 
>    @param[in]  This                   A pointer to the
> EFI_ADAPTER_INFORMATION_PROTOCOL instance.
>    @param[in]  InformationType        A pointer to an EFI_GUID that defines the
> contents of InformationBlock.
> @@ -22,6 +24,7 @@
> 
>    @retval EFI_SUCCESS                The InformationType information was
> retrieved.
>    @retval EFI_UNSUPPORTED            The InformationType is not known.
> +  @retval EFI_NOT_FOUND              Information is not available for the
> requested information type.
>    @retval EFI_DEVICE_ERROR           The device reported an error.
>    @retval EFI_OUT_OF_RESOURCES       The request could not be completed
> due to a lack of resources.
>    @retval EFI_INVALID_PARAMETER      This is NULL.
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAip
> .c
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAi
> p.c
> index 84c3f8292e..96fadb6f6f 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAip
> .c
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPoi
> +++ ntAip.c
> @@ -12,7 +12,9 @@
> 
>    This function returns information of type InformationType from the adapter.
>    If an adapter does not support the requested informational type, then
> -  EFI_UNSUPPORTED is returned.
> +  EFI_UNSUPPORTED is returned. If an adapter does not contain
> + Information for  the requested InformationType, it fills
> + InformationBlockSize with 0 and  returns EFI_NOT_FOUND.
> 
>    @param[in]  This                   A pointer to the
> EFI_ADAPTER_INFORMATION_PROTOCOL instance.
>    @param[in]  InformationType        A pointer to an EFI_GUID that defines the
> contents of InformationBlock.
> @@ -22,6 +24,7 @@
> 
>    @retval EFI_SUCCESS                The InformationType information was
> retrieved.
>    @retval EFI_UNSUPPORTED            The InformationType is not known.
> +  @retval EFI_NOT_FOUND              Information is not available for the
> requested information type.
>    @retval EFI_DEVICE_ERROR           The device reported an error.
>    @retval EFI_OUT_OF_RESOURCES       The request could not be completed
> due to a lack of resources.
>    @retval EFI_INVALID_PARAMETER      This is NULL.
> --
> 2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117504): https://edk2.groups.io/g/devel/message/117504
Mute This Topic: https://groups.io/mt/105398062/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-