From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 738E67803CE for ; Mon, 8 Apr 2024 21:11:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4+zdB1jG4yLg769RqzcKKHi17gq6/QjLSHOi4IUOn2I=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712610692; v=1; b=JbVdWxm6aX1cHKIgrArwF8ekHYYTorZTVFSa4ReZwu2q1XkdiDLEiSRABzBbqixr2JtlwRla mCP4uaZS2BXfq4vXB+DF0v4GtyWHI4e7ReLSC6bS09kEL6bOQ/NH7N7EEyyhmVkoeFkqMpHJ5Ai GGXtmBz3zMK/A7dzD3W9HKPgL50Vf8enDT4tXkE/xr5BUHU/UtC5NTYBFXcblLnvGbFTUAHVvQi lpDkb+YCoem7NmbE2Yc34MSItAh0v9kgWyEts0+QdbHXLM+uvQ9od5xtXY7VsStDks8pM4a97iD dEz9uJeWmfMdUe76XawwrPiA3Wg4oQEjzmSSPqCY9mBJA== X-Received: by 127.0.0.2 with SMTP id gEj2YY7687511xzThg0N1sxY; Mon, 08 Apr 2024 14:11:32 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mx.groups.io with SMTP id smtpd.web10.120175.1712610692222398059 for ; Mon, 08 Apr 2024 14:11:32 -0700 X-CSE-ConnectionGUID: V42zxxrwSAuLn3430rVk0Q== X-CSE-MsgGUID: HzsXdRsvTKW2Uhpj4gUSfg== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="7776114" X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="7776114" X-Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 14:11:27 -0700 X-CSE-ConnectionGUID: HkmxJi9kQrKi3Joa5QveCg== X-CSE-MsgGUID: LXiEg+jpTzmeafsfC2Fjlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="20443578" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Apr 2024 14:11:27 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 14:11:26 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 14:11:26 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Apr 2024 14:11:26 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 14:11:26 -0700 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SN7PR11MB6704.namprd11.prod.outlook.com (2603:10b6:806:267::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Mon, 8 Apr 2024 21:11:20 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2769:a1e8:3236:e5a1]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2769:a1e8:3236:e5a1%4]) with mapi id 15.20.7452.019; Mon, 8 Apr 2024 21:11:20 +0000 From: "Nate DeSimone" To: "Shang, Qingyu" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" , Gahan Saraiya Subject: Re: [edk2-devel] [PATCH 2/3] MinPlatformPkg: Update the comments of GetInformation function Thread-Topic: [PATCH 2/3] MinPlatformPkg: Update the comments of GetInformation function Thread-Index: AQHaiZnrC/TKfF+diUitux76+TTl67Fe30oA Date: Mon, 8 Apr 2024 21:11:20 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|SN7PR11MB6704:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 23NN4epgEK2RhTQCXIOJW050m/owJY6+a9Dk4t78eq2dabLUZBZ7y8IAmxjqQjmGzlSo9r6kypuQzBjwKf2Boo2TElNnzxUB5+n7heH6eiY2YK0Z82YlgqMWljrl9tXMhXtoUbqWDH3G/21zzTjKzLmGH2PFvUgQunnnCJzd5av+3tLboFm2uODk2eizi9tK91hZBdJTmVVbIMu/WZkAxteLX3kP6Jo6Sv26Y7Bvpq67SueB0T8mT5YKizO5ADLiqtn/1HVUTIgislvKR21PJOIyNuPyw/i7t6zo571ynVnc3GLEXEuF5nZ/qsQMW1L5r7nA13z6+IY8jFTmvdt1aZAdEzde15GqSwOH1ecywqYfIv9RgO580Rx8bep1HvafXuvye8ygZ36p0SehSJ5qNAjxkbapcS5D0kMCmFmPruitYPf1CY25qk3a1VAjI4qOTXaLDFKK5hwXbTRHtfwKpSY7ki0SnVGosIkhKqJR56oGcRYCvVPvZxSHLiUWBRXO0bJQ3Ka0m1ZHXTdpFwApUH/4IQXkxzCNM9GcgM4ho92+fmI+BbhiuBo3GQBDbYnwMFUEI3NkdH0CHdVwfdfnN920QdJc80fsN+ojqAiOpnfXOSUiSrr6ggIgj4HN8WEsKQP7xbgRVTkLnzjwxRerQqHcHgkdvfHE1qiSd+GzqUs= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bloHzBC6qe+06SuxTSj3xOwJTaUNSKQu8RkB5VyoU6POcq34AlWG6AKV/Joz?= =?us-ascii?Q?k00a248WLiVN4z35Qa+beJ0pgSiu1eKN9xLMwYbVCzNrABaIdcSNxCoo1YJk?= =?us-ascii?Q?knJg6ocA9VDlTUjsq/K12pIuz8znqVxxeReMJO5dZeTmU4373bhxEyQgnndi?= =?us-ascii?Q?wVw6/5xq7FPF9tD89jsZuu8cCp8s4hnQ6RQfBolddTWgR2Wn2MFhqouZVXYZ?= =?us-ascii?Q?iKXDZNgCkgUjt73LG4b90t9LymMwkNG5Wg1GI6+jBV7M4iJskYMM8JZM1mTP?= =?us-ascii?Q?7pErtBeH4qGUz9Iu19vXgNgkByIAEG1G1qGGHXUltVnagTA2F/yZUhwUbXZO?= =?us-ascii?Q?lvd2kJDU5Nk0MMirH+B1cdUwfjLwyzs/XsLR0Y8XyXmCRnwMYp45pB72PTP+?= =?us-ascii?Q?yTkxp6RVWCkY30Q+Q77m8mD74zmk41HPWN9meUwmdAUivvWS1ynIfizFuHAs?= =?us-ascii?Q?MPRBRd9ZO5OJqIbKdz2sbe1nCZ2Bv8OkpwMJBpEdkIl5y0ROrDma+4ehG/Ut?= =?us-ascii?Q?xyG3mRbkDiHFAqR3rsmgHDywYv5ZbGRLS0Nd1tlVEMLmpLP1Pd0AWzuCVQ7+?= =?us-ascii?Q?S7158X6vm8q0shq7KybLlLCXZGSNp3M1CpPt/VCtWSTggEoTy74eQ+qxCVwE?= =?us-ascii?Q?18rR3wFrFbiYr2Dj1pzNG46GBy9SKKy/G3pb1uxRBX75PbH0c6dJMrG8/UtT?= =?us-ascii?Q?FaYxpBp0dN5uAp58yGYMr5gMG0SrfnnJyLAD0/n+/1l+g88fI/73uv7zFa+A?= =?us-ascii?Q?GDLlpmCCfMDb3EyoZxMrPk1y1MGFABuA6q7yz7atHnUtcgu/4m1ZrqvAyNnA?= =?us-ascii?Q?LI/cT4Jfr1fccm3GFACb+wwTx4G4HDEhz45/hyypz/HXYyQ8jbj0AkjipuPL?= =?us-ascii?Q?z7p/kGFC6pcSfYYpCfrfqv31F4ZTjfE41elg78aE+MqMwq5hfKORb0R/dRzk?= =?us-ascii?Q?eC/l02/oGOjyo0H75+RALl737Qa2JbEsOnx9v0QS2YKFg5vAJpI6cY0kqNbc?= =?us-ascii?Q?o7nfvVeK9oG7r4IbIwQ425mdHTFH6R+KI9qFmuKOizxj2yCQULX/c1odMD6u?= =?us-ascii?Q?m+tbYC+ZE6PoKrEhuvM8OdYjVIBfIHLx/yQFrp9e5fc3qHNmJAFZweaSwsZx?= =?us-ascii?Q?rqAzSmSxU1u+j3RjbJCa15aMgk0L/fJy27HHIMqQOxlueonDtaaLyeLTGCWx?= =?us-ascii?Q?LDNL815Qd2PLs2dVhFQ4X1g2+IrIhurzLZ56nRPAqsesKte0vaK9PZYiXRCm?= =?us-ascii?Q?zWvHqGT4UYF+W8w7zRg81Q/gNKvWmBsjwGu9Pq53lrh1jUlNRetuAl2Glbva?= =?us-ascii?Q?cNJ6sgt14nwN2CLhNlEM72LIuwYgUvkamcoe5+r9VICxGGtzpZwY1O3XMFtg?= =?us-ascii?Q?MXUiGxf0TABd++jxoT+Fd5jRATdTAzsZS8Q5k05D5pYmt/ji6PI/v/lO2Rjc?= =?us-ascii?Q?ef9K+/w+2C2iKeRe5O+lSt7oAzYSx8yabShFWnwZreROkixo9v1SWm5mOJAG?= =?us-ascii?Q?3DNAYKxj09jZeo8AeVa0pTZZo6NrX9XryQcfXdvk9usoUC5dGYVrW5BRDtuf?= =?us-ascii?Q?Om5zANnjBwx97SmNt0gCeAS8l+DZL2MBnpyDQsVeI1w7WXSBb26s5QjBS8w3?= =?us-ascii?Q?tQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d31f6d1-e7ae-4215-6849-08dc58107041 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2024 21:11:20.5469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cwQK9mWmoD5Fm0fjybmZLH9xFqn/jgy+Auw9sK/cwpRK7xChgr2jCLbPk4WJmWLmEBjKAwHDP/2txf91hb5fFpLHvnFRd+pF7okQWITWC1s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6704 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 08 Apr 2024 14:11:32 -0700 Resent-From: nathaniel.l.desimone@intel.com Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3icB0DWPaxaEkVNpy4qR2igCx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=JbVdWxm6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nate DeSimone > -----Original Message----- > From: Shang, Qingyu > Sent: Monday, April 8, 2024 2:47 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric ; Gahan Saraiya > Subject: [PATCH 2/3] MinPlatformPkg: Update the comments of > GetInformation function >=20 > Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND t= o > EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). > Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol sho= uld > have a provision for IHV to return no data. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Qingyu > Signed-off-by: Gahan Saraiya > --- > .../Test/Library/TestPointLib/DxeTestPointAip.c | 5 ++++- > .../Test/Library/TestPointLib/SmmTestPointAip.c | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip= . > c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip= . > c > index a7fe9530cf..f2c44afb50 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip= . > c > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPoi > +++ ntAip.c > @@ -12,7 +12,9 @@ >=20 > This function returns information of type InformationType from the ada= pter. > If an adapter does not support the requested informational type, then > - EFI_UNSUPPORTED is returned. > + EFI_UNSUPPORTED is returned. If an adapter does not contain > + Information for the requested InformationType, it fills > + InformationBlockSize with 0 and returns EFI_NOT_FOUND. >=20 > @param[in] This A pointer to the > EFI_ADAPTER_INFORMATION_PROTOCOL instance. > @param[in] InformationType A pointer to an EFI_GUID that defin= es the > contents of InformationBlock. > @@ -22,6 +24,7 @@ >=20 > @retval EFI_SUCCESS The InformationType information was > retrieved. > @retval EFI_UNSUPPORTED The InformationType is not known. > + @retval EFI_NOT_FOUND Information is not available for th= e > requested information type. > @retval EFI_DEVICE_ERROR The device reported an error. > @retval EFI_OUT_OF_RESOURCES The request could not be completed > due to a lack of resources. > @retval EFI_INVALID_PARAMETER This is NULL. > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAip > .c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAi > p.c > index 84c3f8292e..96fadb6f6f 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAip > .c > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPoi > +++ ntAip.c > @@ -12,7 +12,9 @@ >=20 > This function returns information of type InformationType from the ada= pter. > If an adapter does not support the requested informational type, then > - EFI_UNSUPPORTED is returned. > + EFI_UNSUPPORTED is returned. If an adapter does not contain > + Information for the requested InformationType, it fills > + InformationBlockSize with 0 and returns EFI_NOT_FOUND. >=20 > @param[in] This A pointer to the > EFI_ADAPTER_INFORMATION_PROTOCOL instance. > @param[in] InformationType A pointer to an EFI_GUID that defin= es the > contents of InformationBlock. > @@ -22,6 +24,7 @@ >=20 > @retval EFI_SUCCESS The InformationType information was > retrieved. > @retval EFI_UNSUPPORTED The InformationType is not known. > + @retval EFI_NOT_FOUND Information is not available for th= e > requested information type. > @retval EFI_DEVICE_ERROR The device reported an error. > @retval EFI_OUT_OF_RESOURCES The request could not be completed > due to a lack of resources. > @retval EFI_INVALID_PARAMETER This is NULL. > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117504): https://edk2.groups.io/g/devel/message/117504 Mute This Topic: https://groups.io/mt/105398062/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-