From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.12393.1635546149606220961 for ; Fri, 29 Oct 2021 15:22:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kziz0dzP; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10152"; a="211534735" X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="211534735" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 15:22:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="448269785" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga006.jf.intel.com with ESMTP; 29 Oct 2021 15:22:24 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 15:22:24 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 29 Oct 2021 15:22:24 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 29 Oct 2021 15:22:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ldr4IzseOUGjHeCfPuR9V1uO2Cei7w7dSyhFOBZ4J8L2HEBtEMj1QyAW9HWdT3twLjM/Eh5zMtb8k2w85btgTex3+m6A6PmtDAjGrVOKWvWEkRUsarN2lvKpOd8zQBRPKkPp0YeFhokHX1PulD0UoSrTouWs7Fk1gxcDhMbt2eXH98ABzgWVcsk3qVysZooIcOZL1LlKDZx3YunSwmcjzQmgKmql9zJIxrGe/PZ+ANAMFYKAinUlNeBDfap2RPOnOlRxi1UNRL+HqKAKSDZ/DRzos9NUQGl4VkH6GOrssL4lNkgG5n9h2udiS+b7Bi+fLwvaq6V8nFsDFU/hHX7/nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W3djq3wUq4G/wNOKIa6nZEdyDZxuXKyV2+CTMWsYXDY=; b=Pu4Haga9VGY9fGc37mORNJJ9OlpG2mSkkVm3KnMf0GFhfEcOTCRRTlKdPFRNSBj+eUeV0x/E5p26sEv66Y37tfaLVsv+I6PrhJY3xNB+Bqt8zOZH4m/DscfIOp+vIqb/NEnbM5iH8AvV0Guu5ggv2N7RACDk4g9qjkEnjnhSfixesJiO2KU/D/muqMAH3h+3oBDOdXBVdVOlVT2CIW1AyNrUBmiuAaxgW/kUiGix3UOpP+rtrxa9fl1VEqd3hST/tXl9Bjjm42qv5ARd5+DN5gjj7hI2fTJ/t4ef4H0DPXxltShemPZm0aLp0sX1+/4K2bu7mWqdR9nZ+O9QFDmKVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W3djq3wUq4G/wNOKIa6nZEdyDZxuXKyV2+CTMWsYXDY=; b=kziz0dzPqHd0IShaCRctRv5gfdH7g3LbK6jgZmWlHv32w5hzOickBK9wY7knCQU+19CRgiOqsLqzrm/Hm2yV2B7tlsO6emaJtacz4JdH1IMHu8F5cSEcguZOIs3m5dBPoyo6zL9RCPxFGQw8hvjJT0UcZAS6iFNnZdM3A9vOYLY= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB1565.namprd11.prod.outlook.com (2603:10b6:301:c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct 2021 22:22:23 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46%9]) with mapi id 15.20.4649.014; Fri, 29 Oct 2021 22:22:23 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" Subject: Re: [PATCH v6 06/52] IntelSiliconPkg: Add PCH SPI PPI Thread-Topic: [PATCH v6 06/52] IntelSiliconPkg: Add PCH SPI PPI Thread-Index: AQHXzDyezIZTP+6XNkejSLI38bFPRavqjU5Q Date: Fri, 29 Oct 2021 22:22:23 +0000 Message-ID: References: <20211028204326.645-1-mikuback@linux.microsoft.com> <20211028204326.645-7-mikuback@linux.microsoft.com> In-Reply-To: <20211028204326.645-7-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f5c1344-9ea2-4aa7-9b1d-08d99b2a946c x-ms-traffictypediagnostic: MWHPR11MB1565: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QQMe6VZreXlBXekVV7U2e9orAZTpaSnS4MHSwLx55jTg+w/pUTSFENZmNwBDxA/4B3lloDKCY8xNjgwok273SX259SSa/2PX2wtL6MZEfQ0T0hk207C0lQFO0rKUqa949E9pQ3Q/qqBwvnYGdMoIhIYXFst4YuzLFEPR99HF1i/dIA8q9OUTkpxjX/l/D2cQ7edWprTymMULTOMq4W1s8BWWyE+FgmUudCXBT6lu4DZL1Gre884R//iSqGKOYLYQO3R6qPFGbHre13hlD8BmTVgbSsV0XYgjANkgLhNI5fntXWIRVjC9kH4TIv0NAtz6VBv2UBJBiIBvtXjlwC0xka1X+gMQpWkx4X70mv9X95pCmsxH/Kb3dwfSBbIDXUNf1V6bdv2odoHAx8XKBm0OycmC1iVBXNrogPUI4Sh0gRpcOLYk1TbtuoG/00QBtelGCn4Xxv1RMZ1VFHegnvWrVy7HioqAmouCn28xTq/2m5ti9ogSBEneCeY8+skO08d5Di/bfCXCJbzs3fLzgU90yG5najmZYELJ6f3VYey/MWCbYLbCOPqnq2RO9i1mPcUJt3nv6tYnFTiajrlGcFI2x+JpkVPDjwr/FVlWxU7EHXpd/3i0zhMFF/iZ9hrkcY6umshR3PnXG4m4smLVNGzl1TVdvpSugXj5WUENNF9ZuBcYm+wSIBcb75Kk66DIYRbqqELDUmYGwOBieipJ6jjXIC6J+dHFhqnkarltpVjx1D4E3Qix7/Q7UOqUcaP+/8AkpvSRWyt1nolR6r/lrIRlh/yBMKdCQyB2KNv3MBgD/z4VKUqgTciIoYMxNwAAWBZA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66946007)(26005)(5660300002)(66476007)(76116006)(64756008)(38100700002)(71200400001)(7696005)(66446008)(86362001)(4326008)(6506007)(33656002)(8936002)(38070700005)(8676002)(82960400001)(110136005)(107886003)(122000001)(53546011)(9686003)(186003)(54906003)(55016002)(52536014)(83380400001)(508600001)(2906002)(316002)(226253002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mFu51LkqwpfAVXEzKzE5jhbaeBg6U1MmFzcp/Xf0gBLLl0a24giGBrMwcLyn?= =?us-ascii?Q?PisNpdGVii4+8p1WGKaxMbnf8KBP6HrtNF/qhsUH3s5wD5wzOg+u0wqEf6lV?= =?us-ascii?Q?RtSUP30IrVGvliAa9ztq96YvRnWPvp/OGzjeQJiVtDlBtPBvzvcwSeRy/4G7?= =?us-ascii?Q?/enE5weKljrqRARMHjIZbub7ivZQAtIPmiMvspXLXuQiqK035+papqLgcuYC?= =?us-ascii?Q?1v8pVpNjedpxr89X62e9orLjhFohK8YhHfCoSCQUnDMnfzMhmbkrQGC2KA08?= =?us-ascii?Q?S4AyNSw/tMD34/Yxazgqf3kNnYCMDGARUKLc+BYEmOoQ3IU2eBv341SknKPR?= =?us-ascii?Q?0HOCFQoVPCFQIT52mPqe8ihQqjkQdQwSessqqvvFlIc6E9/4qnjwoaYWXo0b?= =?us-ascii?Q?z4w2ifKeSykWPCkRJpXLDRZcOjKfeyJs298sidZkhJ3ai276NJEvh94+i4M6?= =?us-ascii?Q?f+O3KKZz5qYPebcXUdrO8fBiH8zfvr54NUOxoofq8Vw+gkTQ0zjyUQfEu7Je?= =?us-ascii?Q?PLN/+eZ1XN3ZZnXvaTX4ysJ7wRLX8teJP88a1MAhkCaFethjL1uQ6GDZE65F?= =?us-ascii?Q?xRtWlcAQzjkKjIyTh2aJEW8VRL0quUMdvzhiyF7AaZZU53wYcvjaCdvQsNB+?= =?us-ascii?Q?zxcDtOimX4guGMKWhMSJnIwJHmDnXeu/5Xr1QTr50SwJ1LsaaLfoRXqm2BBM?= =?us-ascii?Q?0/PyKmUqmMoV4G8XcJ+q92WT0Fwf0cWsbiZPiK5CXoghlV+Pm+AU+5HgRCpP?= =?us-ascii?Q?LxB6q6l/kNBja9r97AIPunb4svYSTLx8QbfJTWYGIvuYPzLthyTM09qOST2o?= =?us-ascii?Q?f5AQ2Soq98lhTGl1o+mnNostyjURRPynxTM8hA927gUN9l8GYGYkj8siGUqH?= =?us-ascii?Q?mr6GvKZOPw6/qKMArxSiCYj9dnB7g9vYkWvA6sDvBeqxPbRTNrOhf3DxFL3I?= =?us-ascii?Q?6jWQZBEVf4j/VJEx6PCroWtdIyRRLuid1Egi3i9xykDYz1DTzDku4Gt8FobP?= =?us-ascii?Q?5SKdNyJDJUuF3RHGgPQ+/QYymsK36jWTFsucZ01ZLR2G6Suni4dlBeOVijGa?= =?us-ascii?Q?NZlSUxoo9TY4bGMjcixGIYqiNPgrKAbKFPNmFViwR+1IqNnGeLY9viuPKfYe?= =?us-ascii?Q?++x2IEd2kspLQw1J6g0CEmyen6iotOrGpVvHpcPZChcuBFPVpfQVqZPiAJwH?= =?us-ascii?Q?sVUcfhzxE9hoqPP1o37rq6CIGZj4AGOD/crTHVi6Bk9kDy542X8X6lSHNPbQ?= =?us-ascii?Q?0izqrX8bSc3IhBnZJmOvK4HMKjbXd4n6Azp2Rlp9QeE3H1OLaSF8vlp+6FYn?= =?us-ascii?Q?M81IfT6P/yf8/YZq1jgZvh09dJBP5+Z5LxviTOfJHYU+WcbiSXyJ+y0sRuar?= =?us-ascii?Q?XhAiksO5XOMk7oa0YXTTW6qGPAHq8fvxZqlNmwIFJvGJNTG4rjyGcN6cgZXo?= =?us-ascii?Q?9h10vc8TXgsnKgZ+vpx8Hx8xZTdLV99sBB4P1eU9m5ORkoiRzcq1QigDf5wU?= =?us-ascii?Q?pb2/+hcu6CHdO/Gpht98k8gsM/mfzkjnKcTWeUljzzrg4KSmCj7aed4qouuW?= =?us-ascii?Q?MgRcQsazFZ1qpYmFuHlvd30eKLi+QYOs0RynofottGCS6zLje40SSAyyrF7u?= =?us-ascii?Q?FiNY6h1Ox+43rcP/1g6nlAVwlp/qpo3vD1DzuIIlCoPALLHAvZm29QMlLlqJ?= =?us-ascii?Q?EeObJQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f5c1344-9ea2-4aa7-9b1d-08d99b2a946c X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2021 22:22:23.0394 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uQHfrkUJQeKed9njagAKpNfGqtEov2msTL7Be/O1jQ4bozoHU4fuYg7kb9b4pNprAr0h/Ril5XUeUgZB7z6Q3k0HZJwGhsF/ELhysO6yNmE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1565 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Looking at your new patch series, now that we have the new PCH_SPI2_PPI, th= ere is no longer any need for the existence of IntelSiliconPkg/Include/Ppi/= Spi.h. The PCH_SPI_PPI will always be a silicon generation specific protoco= l. There is no need to promote that protocol to the multi-generation IntelS= iliconPkg. Thanks, Nate -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [PATCH v6 06/52] IntelSiliconPkg: Add PCH SPI PPI From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 This SPI PPI definition is intended to serve as the single definition for I= ntel platform and silicon packages. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by: Sai Chaganty --- Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h | 25 +++++++++++++++++++= + Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ 2 files changed, 28 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h b/Silicon/Inte= l/IntelSiliconPkg/Include/Ppi/Spi.h new file mode 100644 index 000000000000..b2410bd17300 --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h @@ -0,0 +1,25 @@ +/** @file + This file defines the PCH SPI PPI which implements the + Intel(R) PCH SPI Host Controller Compatibility Interface. + + Copyright (c) 2019, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent **/ #ifndef=20 +_PCH_SPI_PPI_H_ #define _PCH_SPI_PPI_H_ + +#include + +// +// Extern the GUID for PPI users. +// +extern EFI_GUID gPchSpiPpiGuid; + +/** + Reuse the PCH_SPI_PROTOCOL definitions + This is possible becaues the PPI implementation does not rely on a=20 +PeiService pointer, + as it uses EDKII Glue Lib to do IO accesses **/ typedef=20 +PCH_SPI_PROTOCOL PCH_SPI_PPI; + +#endif diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/In= tel/IntelSiliconPkg/IntelSiliconPkg.dec index fb8391000347..1fa447f37722 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -71,6 +71,9 @@ [Guids] gEdkiiMicrocodeStorageTypeFlashGuid =3D { 0x2cba01b3, 0xd391, 0x4598, { = 0x8d, 0x89, 0xb7, 0xfc, 0x39, 0x22, 0xfd, 0x71 } } =20 [Ppis] + ## Include/Ppi/Spi.h + gPchSpiPpiGuid =3D { 0x104c7177, 0xc2e6, 0x44f0, { 0xae, 0xe3, 0x9d,=20 + 0x0d, 0x9a, 0x52, 0xca, 0xdf } } + gEdkiiVTdInfoPpiGuid =3D { 0x8a59fcb3, 0xf191, 0x400c, { 0x97, 0x67, 0x6= 7, 0xaf, 0x2b, 0x25, 0x68, 0x4a } } gEdkiiVTdNullRootEntryTableGuid =3D { 0x3de0593f, 0x6e3e, 0x4542, { 0xa1= , 0xcb, 0xcb, 0xb2, 0xdb, 0xeb, 0xd8, 0xff } } =20 -- 2.28.0.windows.1