From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 65AB178003C for ; Mon, 8 Apr 2024 22:14:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QFuGiOwZJ9j0pg8YhjrcVz5ONAW+fxv3KwSiOgb1jgQ=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712614445; v=1; b=RmcNIxjboNP3ZWCTnjz0HIOVqgu75ceR3JkzpatzNiGrkSCgE9KNmKsxrlLScgLIRPAHeB4D iEw3ZiRz1K+FmVnKzPZyCGT7SsPGs35mgCGHkV6Y0dkAisjvAcMzZsRgo6i0uEKxzZq/FRaT2g0 wGK217dCb8fA5PW7mylqVzR0s/HWxct32YDbsbNPb4gzxNzlPSfsAkwCZmlf4PmsNHNttfSnDoC Vn5qNpHLuAA9SSSrXViOU5JVIyUJ14UnmOHi2bDnIaK2bSuB8AkmCEEFwKw9KAcLAVGiAoxMuu6 i9sj3zclzRBsfPNRzDote5PyW63IK0FTPkUt/4tyscGKA== X-Received: by 127.0.0.2 with SMTP id XzyNYY7687511xrtCq7cJNbB; Mon, 08 Apr 2024 15:14:05 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mx.groups.io with SMTP id smtpd.web10.121706.1712614443957450889 for ; Mon, 08 Apr 2024 15:14:04 -0700 X-CSE-ConnectionGUID: pQbgUQpNQ/6GArcfN3xI3A== X-CSE-MsgGUID: bAi8KS/9S7OH/I5wJEsL4Q== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="7779722" X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="7779722" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 15:14:03 -0700 X-CSE-ConnectionGUID: CTvEA9SFS1+ZU5brsOl+BA== X-CSE-MsgGUID: NaAcwTv8T/iUQaGNxwscDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="24655826" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Apr 2024 15:14:03 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 15:14:03 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Apr 2024 15:14:03 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 15:14:02 -0700 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by PH0PR11MB4855.namprd11.prod.outlook.com (2603:10b6:510:41::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.21; Mon, 8 Apr 2024 22:14:00 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2769:a1e8:3236:e5a1]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2769:a1e8:3236:e5a1%4]) with mapi id 15.20.7452.019; Mon, 8 Apr 2024 22:13:54 +0000 From: "Nate DeSimone" To: "Shang, Qingyu" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" , Gahan Saraiya Subject: Re: [edk2-devel] [PATCH 2/3] MinPlatformPkg: Update the comments of GetInformation function Thread-Topic: [PATCH 2/3] MinPlatformPkg: Update the comments of GetInformation function Thread-Index: AQHaiZnrC/TKfF+diUitux76+TTl67Fe8NOQ Date: Mon, 8 Apr 2024 22:13:54 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|PH0PR11MB4855:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: JnUCP7DCFdWy8O1X49SRqovUKhUVdL9Vrhs7cOGmRvJF6lVCLI1KCJowusz8X9ECRn+IO5wx2W+A7DL4sj6L/uAkvB/fQSQHYiE2E3/+exfGiTwSjAnRuf7yzzqlGCqtSYoGH6lNkaNADACPoW4YSufpihWTzJeAeF+c51td/cd5UT/Kpl3G8VKsrDpG0SVT2bJuoGUmj/9w5N+X8Xdw44M43RfYR25t45ZhU6zfHAfje91ll+HqXl+RwFB1t5O54IqKez7waf0S3hKbB5Tv5lP14oR4QCLk6QZ6lUyRn6BYmZxLUHrJ8TfGy+tQLpJwbFSOOml53AnintoAbLn4Cjz/LefRzX4TGxIxEuTFIUSI0q5ppP7dLJCSO3XmIP7NVICbSHaWjfazP3cJXiwOWL9faVBXAlBzFV8XDY4C8tfWmoZoTIqslMVwBPQCfdJaXmnuVhiKXXLINQeJ8+BhD13thc5uacFzvpUUj1SbSba5qsRxjaovz6qDFe7gqQovoV8Nkxm6+WbBcUAFjdlZizu/qENiYPTlwqeEaERXbPntdpEat2hrzryvpVeMI6r+k6ZXs5Hp0eJhl9NyNcCpP7nVb5sSaooCYW0HxifOA1bVe/vkghQekxFLbEX2EImnaaAdYCx0Ut54o/GAvI9qQaFYzcadZIIyKpCulpfkERQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MWqvKrn7toEf2oDVYb6qbsrvY9X1egISlINo8aPjHo3tlMb2qw3+cgLVkxTN?= =?us-ascii?Q?YjOhQLhqS3AVAK4G2Ex+57/SsuwbEfB4KeSmhLZ1OaozHx4k2707TfTrwhTL?= =?us-ascii?Q?JsR33b+q3dIa6bwNNOMvDDpC1vrUCdm9qFEMdtHu0kj0GLJYlvCwA31ozuu/?= =?us-ascii?Q?xacxEZO8gfPVqVwd0GvbWmFsOb+1qW0lx0ZMGBux3v//zc75OrNEG3RrAsGw?= =?us-ascii?Q?ZZ89FHnX+duLQSvvwXPlPQFJir3/r/6KXnYNWsY5aBCsUDCIni30SKiF3znm?= =?us-ascii?Q?V7IZ/04dMyYQPqCOIZmZlqYnad9ZYtsFA92uDV1LB/6rBEslFzxSAaHryDx8?= =?us-ascii?Q?Y5n1sNnrbWgDCPvEeKjsnj8+DQB9f/UB4eJ67McZ/14OZKc+m2i1TDpVa2v9?= =?us-ascii?Q?1hTI+bP0e5UYZu1mYlyQo/M4USBJOWd6A7921mcJXXdSxvT97IbssoIjwCFh?= =?us-ascii?Q?weUItZqENZ7JI/MjDxtHoV9VuIvtfXq2TL5tyQEdgPmvxudczLVPDwit1SBy?= =?us-ascii?Q?VNjmYZ/BZYwM10a/0jr5u1pmMDDg5vWV6lcw6nwR66If/Yh5UEynhj3oZwmp?= =?us-ascii?Q?z/GKeClWxREHoznl1MPRjAFrPRfNVuVHpbeK24p1qS+3gPbBkJK3S7uoIvGb?= =?us-ascii?Q?E945OcGcagu9lU80iD2O4TEO0XaqAcmvGBBlAd52/HUeCtHHzpsCXcu7nWVK?= =?us-ascii?Q?4+4y7pVGk1LGo95ys3yYsgTzs4EliXXS5NSAB5Wu1f2Mmq8cwei8++aV+mTT?= =?us-ascii?Q?NDhUT9fHDO//VnfqloTzCpsNLzGQCJzIqTfqhVqRItwk/EXsaACXVQkVEwTe?= =?us-ascii?Q?0IbF8x8EXAh8eWCtbYUd0lPXbM6pVVp9g2Pj6sxkBj4PhklhneHxZ06jGox6?= =?us-ascii?Q?Pde0GhwyMG62UAMQR0LjjlF0qG8YGtzkeaszWmFa4sUADmtv9kmJhEpUv/sC?= =?us-ascii?Q?/atjEhUcPERCA4Q1vRkl4nBr6NmI4QBxIAR9/yILfHGGxeJZy6a2FWaHYdj1?= =?us-ascii?Q?ycFq8nlKummSLLki3Ldj9V0hQ2YJi7ltpov5QlN6S7B3CQBwzBO8O1uh/D8E?= =?us-ascii?Q?ohKW4LNKrXW7rF1LxsM8uGhcvBAkt24RYT7dGo5ePN1NqZGSOhGIqj9lvYs+?= =?us-ascii?Q?6WEKoAKXE6G7GgcNmpXcZbUsk3buNNA7TdaUV4iAxdOMaiKDP3Spi1nxk7n+?= =?us-ascii?Q?EiHYW1uywej9t+XNrdDWxAbEai0OfX8bG7qYGaE3jymLu/JjH9q6YAKgZUth?= =?us-ascii?Q?hUAgXEP0Yky6QPHpBaTFqf4OaIZ/oaa/ZOaxcCqFz3KeA7wiHTE6Qjtnca/S?= =?us-ascii?Q?CEQ1YwA2EqkANbCf/QpI6z7kMTNalO+GcH/MjrWPnIoQCf6lA6EZG7V6uWzK?= =?us-ascii?Q?sutWG1BIkZ+0MTPos/PQ4wQMnkJDWzYRziWdzfAtDBSRlv+dK3LyPIx2SJ0z?= =?us-ascii?Q?mZmtXwajjM++Dt4LIipkXklcIuA8bSlZyLapu8eJIrvWwuYTnVUx5ag9304c?= =?us-ascii?Q?ScfecDP+d1eIXVVHr46tJPiIGackz7XWApWUAX+/8A0fpTwIs0WdwwGl1y0a?= =?us-ascii?Q?GiCk16vdz/lV3IleMJ/y/hw8rygkWrnp0WcB/Cf9IGboHyEPbIN9IbewcPvx?= =?us-ascii?Q?6g=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 998d7447-108a-42a7-2c7e-08dc58192dde X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2024 22:13:54.6625 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NnddotnzZ1Pkz/fMQaz6mrOaejXQXhPq4E+evKmwJGoyiJjp4JTqrQ4DcYS7j2zUL7lbVCKAfig8Au0u3LOtCRNVgsrguxyhSwUiSxGq/40= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4855 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 08 Apr 2024 15:14:04 -0700 Resent-From: nathaniel.l.desimone@intel.com Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8iUT6U3qCbjOmoFrxlKWnruPx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=RmcNIxjb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Pushed as 1c41906 > -----Original Message----- > From: Shang, Qingyu > Sent: Monday, April 8, 2024 2:47 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric ; Gahan Saraiya > Subject: [PATCH 2/3] MinPlatformPkg: Update the comments of > GetInformation function >=20 > Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND t= o > EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). > Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol sho= uld > have a provision for IHV to return no data. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Qingyu > Signed-off-by: Gahan Saraiya > --- > .../Test/Library/TestPointLib/DxeTestPointAip.c | 5 ++++- > .../Test/Library/TestPointLib/SmmTestPointAip.c | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip= . > c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip= . > c > index a7fe9530cf..f2c44afb50 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointAip= . > c > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPoi > +++ ntAip.c > @@ -12,7 +12,9 @@ >=20 > This function returns information of type InformationType from the ada= pter. > If an adapter does not support the requested informational type, then > - EFI_UNSUPPORTED is returned. > + EFI_UNSUPPORTED is returned. If an adapter does not contain > + Information for the requested InformationType, it fills > + InformationBlockSize with 0 and returns EFI_NOT_FOUND. >=20 > @param[in] This A pointer to the > EFI_ADAPTER_INFORMATION_PROTOCOL instance. > @param[in] InformationType A pointer to an EFI_GUID that defin= es the > contents of InformationBlock. > @@ -22,6 +24,7 @@ >=20 > @retval EFI_SUCCESS The InformationType information was > retrieved. > @retval EFI_UNSUPPORTED The InformationType is not known. > + @retval EFI_NOT_FOUND Information is not available for th= e > requested information type. > @retval EFI_DEVICE_ERROR The device reported an error. > @retval EFI_OUT_OF_RESOURCES The request could not be completed > due to a lack of resources. > @retval EFI_INVALID_PARAMETER This is NULL. > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAip > .c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAi > p.c > index 84c3f8292e..96fadb6f6f 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointAip > .c > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/SmmTestPoi > +++ ntAip.c > @@ -12,7 +12,9 @@ >=20 > This function returns information of type InformationType from the ada= pter. > If an adapter does not support the requested informational type, then > - EFI_UNSUPPORTED is returned. > + EFI_UNSUPPORTED is returned. If an adapter does not contain > + Information for the requested InformationType, it fills > + InformationBlockSize with 0 and returns EFI_NOT_FOUND. >=20 > @param[in] This A pointer to the > EFI_ADAPTER_INFORMATION_PROTOCOL instance. > @param[in] InformationType A pointer to an EFI_GUID that defin= es the > contents of InformationBlock. > @@ -22,6 +24,7 @@ >=20 > @retval EFI_SUCCESS The InformationType information was > retrieved. > @retval EFI_UNSUPPORTED The InformationType is not known. > + @retval EFI_NOT_FOUND Information is not available for th= e > requested information type. > @retval EFI_DEVICE_ERROR The device reported an error. > @retval EFI_OUT_OF_RESOURCES The request could not be completed > due to a lack of resources. > @retval EFI_INVALID_PARAMETER This is NULL. > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117505): https://edk2.groups.io/g/devel/message/117505 Mute This Topic: https://groups.io/mt/105398062/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-