From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0D264AC1B3C for ; Thu, 2 May 2024 23:46:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=eyO6x8a4p30+/olU5dvB22fTDbK94IBMgW/dWEikGGs=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714693564; v=1; b=EklrvQRlCDg9gnbp4+veyX1xO7JlHgWpBgWvcEyUYGNYH+GXdudc6qa6Ea+5LMZiNf9UWbhH F4fV81CK8uSqLnKT2mT7czS74/u03lJ56b4lH9Tgz7imCGngN89NBaPYdyRwMLRQXVuhXdLNK2T R0scWfY+cPRyOwSoWC571GPdE/5CvG4SnzxOQl6ZzJJMakICX3a5+wQ6tjQTn83VuxhWY/Orc3s R+oWybDIrGAykHV+jKTvESg68zz+H8Z6Cz9sA39xP96yGFyJsgYmVSoZko2fCk6h3EFdt3TGZEn wzXztzZ4eVxfttec6+nqvGfCtqs8n99dk1sTsyUCkFkBQ== X-Received: by 127.0.0.2 with SMTP id MHgVYY7687511x3jlFcFaHDM; Thu, 02 May 2024 16:46:04 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mx.groups.io with SMTP id smtpd.web10.1076.1714693563746478780 for ; Thu, 02 May 2024 16:46:03 -0700 X-CSE-ConnectionGUID: jCrxIN8ER9ujIUfRv1+HTQ== X-CSE-MsgGUID: hZjOvNldTFeDIfbs6RjjdA== X-IronPort-AV: E=McAfee;i="6600,9927,11062"; a="10342750" X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="10342750" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 16:45:54 -0700 X-CSE-ConnectionGUID: aYrgpKRjT2aVlspVsqJGKA== X-CSE-MsgGUID: YzRhUPvPT3m7EG9gKUlFzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="58183740" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 May 2024 16:45:55 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 2 May 2024 16:45:54 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 2 May 2024 16:45:53 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 2 May 2024 16:45:53 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 2 May 2024 16:45:53 -0700 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by DM4PR11MB5972.namprd11.prod.outlook.com (2603:10b6:8:5f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Thu, 2 May 2024 23:45:51 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6c2d:9d64:aa3c:321f]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6c2d:9d64:aa3c:321f%5]) with mapi id 15.20.7519.035; Thu, 2 May 2024 23:45:51 +0000 From: "Nate DeSimone" To: "Hsueh, DoraX" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Chuang, Rosen" , "Kasbekar, Saloni" , "Tang, Haoyu" , "Chiu, Chasel" Subject: Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. Thread-Topic: [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. Thread-Index: AQHalJC+Ptt+0b+580GYb+r62H7farGErE7Q Date: Thu, 2 May 2024 23:45:47 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|DM4PR11MB5972:EE_ x-ms-office365-filtering-correlation-id: 6e04143b-da75-42ae-06a9-08dc6b020007 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?RIHHdg+gSek8LHc/Rkwj8fpNnW+i+Na6OjDzb32MD3aaoUvoHx56Jw/Qad8+?= =?us-ascii?Q?f24im//Rk17Qlo3q6uiqxmwuoN58o9WyzQFKTxDrdVDEQ6vUQd6qZhW10ku9?= =?us-ascii?Q?1LQ+v69ce6qp52tkRRw39t0U4o9Yb0agFeouFZEMdAlqubBXZ0D0NoYSM6O8?= =?us-ascii?Q?asBbBvEoOhA/NjwmQsjAHssnzMm4RgBPEgiQP1KVTah4V2VG0CZCB9CaZOhJ?= =?us-ascii?Q?kMRMv+3sH7errjA1dr0p+Fipaw28awl0c+xj1kGVWvPcwrlJsKNYkWYXq7k9?= =?us-ascii?Q?nOzUzslsN+sG80m+erFCKToSnk7OVR2TD+tEgvrxLSIW9/MMJ+RfPVUnKUhM?= =?us-ascii?Q?gryQZhNX/WijJIAGdzFyYBsCzsLrbgZcFUDBkiug7VfyGpUaFmD9+ZeT/bo+?= =?us-ascii?Q?Yg9cTiQLdUPcXTCu5eaw0tKohbLInr3mP8fvQNitGjQL6b26A/W7Gbzl+a1B?= =?us-ascii?Q?OxO0DifRzQrFzftjpHduu7XZ9hlipl8E066hDr6/X3KovIuqmxiI+pLFmy8T?= =?us-ascii?Q?/c93Z0QH8myX7bGxKPzjFabV5oHtC3pk2bIyHdYuqpo5A5u0UmOAs1qfGq7N?= =?us-ascii?Q?jLlRwP22/LGkfmpmFPnaYy4L4WNsc9nRy8TthU6d0SuSn/A3mPFIXKlpy2oT?= =?us-ascii?Q?yVjXpYXj6nYu59bSIwqFwMtvVMsJb6UdIJu3Eme0fTNM3i+XUAxQQlX2135i?= =?us-ascii?Q?VT44ab1j5aBUjqmXZZru64L4AsWWdUbGrX5yfKiuxlzBId42POIqQPC3lfBI?= =?us-ascii?Q?fRtrCFTVXIL3DdGyLJv7JWQW2tw6yyw5vPmlyW+HX2R26hnIRUkmnez6hPrs?= =?us-ascii?Q?kT92v2RmF8XB1COVZ0P9zlyxYL8HOXWZENekdgURwshcfwAT2wAhQ6Y36SYA?= =?us-ascii?Q?TIsDcV3ggJg2iMT+7j9Oi/9efyaQAG3uNX+cqV7Eqgn5+PxzkpzL62sJZwEQ?= =?us-ascii?Q?TMJj3UlValSFHw7hxyM1U05PGNnLD034k1msRW/0zJ1OhCXsXb7BPxgmR2Ye?= =?us-ascii?Q?utUSrqyrVzZARr1zDMCuSYb5GQIRY77RTX+kJLVonTq3WGYa4RSOkPIwQgLx?= =?us-ascii?Q?ZmG+edwsr/+1RdaGZ1d1nQLmlVvzuRDJfFrIXGno5K3WeamcXl4KsLaAajT+?= =?us-ascii?Q?LAVtJVpYB4ebogr08yg3wb+hlEx8G1tO7tlfV3ehgiMt1HsYLd+TxcZe9LXW?= =?us-ascii?Q?fMDeJxpt53nnh8hFmJNbncV1fq3xDPSBsXg+HedqKPAaZrWnfPYqsNguob0P?= =?us-ascii?Q?TcjdfhH2YKaZ5givZj8gKne2QghAh5LILM44xS805A=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qJ0EmU6Uh2Ef1F3BuMlDbQ4uJ4FHmvwjqAwkgccpFVNVFqwMacSqS1znN+k1?= =?us-ascii?Q?gEv1xmvrtG4UZqnBeEi9ulq+lv0qoox/VgWYyt3z8Mz3GD2+75bWiWGapW0I?= =?us-ascii?Q?cNGifjgBJZuuYQkjktijM8dGhFLVVYilgRHSFClUP4oTWveJ1rZouTIanlbS?= =?us-ascii?Q?szR/whgiXWPkT/YpWyzikyw7hVZLC0BmoMgTixjrgXaEE/D9SKK0aL9RpYcH?= =?us-ascii?Q?9BToFjUAmFXEReD4OeKezMqB+nyzWWr0dkbSDIVZy/8TZdU8dLVFJYmu0dNH?= =?us-ascii?Q?m31OdTeypTgaZBIBV69qTLNe/Bx7zfZTEE1ewrHo+CRcMQxt4UGiu7D+Z5s8?= =?us-ascii?Q?P0mENssKNe+pJOXhsF3n24rYSXP7NlIbDfYSEeIIAOcVdIGvoJKLZE8keY3/?= =?us-ascii?Q?IXV+SOX2eYfMF+fdVSQaW0EPRFGHS/J1usKO0KMVoZR6IIacFKZvSNgpxIsn?= =?us-ascii?Q?gsCFwfIZ318cSRrR0Z1lL3b5A9T0D0JHw+uxqfsNRmayTpiVitQBxkgGU60v?= =?us-ascii?Q?2qC5YRhqpM4sEYHhZdbtwr8qmLI3H+bPwELN7ijhMIEve2WY7rdbg96fClSm?= =?us-ascii?Q?qGsYEM4A5yq+gZZWa5w2QCp5V8aJxTn6FnoL99i84XZhyVCIcPg6eOqUR3mM?= =?us-ascii?Q?FuKE4lcwtCnBwq7+fduEQHWWpo9ElN/CeLrOmWheXTpXtvm8ZgJkfH13z0tN?= =?us-ascii?Q?AYi49XmTmZB92DPHhbLo9WINcMbG7qRbvEB8LkRH1Nuw06/HW6gglE8Z13XF?= =?us-ascii?Q?i8TTCIpBcIWciNHKLafC8pIScGh4UFNzXDkLIqpyNb+Sik/dFuCrMS1tqc9H?= =?us-ascii?Q?BMhLrgFZVND7ZfYd4rcNA7TwB8hoLYC3JYcA99T2yIjpYIDVOUUfsyHGUXX/?= =?us-ascii?Q?Czh4UqX3V5anNucEquWSb/wGMJLe6W1qPjaGZzADgCsQG1p3VVvXQOd8AZvW?= =?us-ascii?Q?ekDIJwurrqQfePQk0ADFqCBr3C+AeCY1joe3WxetufeXB+g/x9sjkEtqxMX5?= =?us-ascii?Q?o6+GHOD9UuMBqotqzn1QHkgX4RgVRXSDAAE0ynfKsTPNhmzrClXqLHoJmEVT?= =?us-ascii?Q?ib3fbikq8oZ394zQhyLWU9zi6OZAuoHL9fguLQZu+FY2Oa+FNRD81sTCQYgG?= =?us-ascii?Q?P1mptbQnL88hEPY6aCNvyKLLm6yzpapfXQP8pFeGlp7dhTpgp9tUcxiuhn7I?= =?us-ascii?Q?7k7CEAr9pnsBT+ugTPWB+ZF/TokA7tuXbJ4fIQkw659ELqZVkEsAAgwdCSVd?= =?us-ascii?Q?B0PpRUQKQomR3P2k3TP6p9VAu2aVTwnCeKWehe5ob2kkpkOirkuVbDTgwRMU?= =?us-ascii?Q?0gjXsNrVC9XKOekEeUUd1EkEmRXKOMgfH/6kDBnfAC2HlDsimeMVqyE7dhmd?= =?us-ascii?Q?us8mNgu9KRG0mcvTxp4j0aufRMy1TTQHXygFK6MJvse5rbclvag0Aic3UE1L?= =?us-ascii?Q?xqeFQnnxwdJRZCqrzqB1QEnoZpe+xoiwvrwR/jd5958YYeQbBZNDJMtz5oIQ?= =?us-ascii?Q?WedQC8az5XbMBoq+3k9j92qwhPnAZXehI1ZsHqwVqoLQft5+hYjnpkC7MykA?= =?us-ascii?Q?SOsYa3Wlbvzcz+T6W+14PaAll4w0/qMKDdRdCnZ4a3J2VbA3Vu0KUlRwihUR?= =?us-ascii?Q?EQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e04143b-da75-42ae-06a9-08dc6b020007 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2024 23:45:47.8077 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /FwyLKf9UsvR9pok5mnPAOBhAh/qe0OupCxQzio+y6I9axtJHmTSnqhd7PteY/RYiCy+NVH0UCdtTXUQFCOD3OvQv9WT3J3h8oAcs056UKc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5972 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 16:46:03 -0700 Resent-From: nathaniel.l.desimone@intel.com Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2mfzMiv3s3aKNAneRoLlSlbHx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=EklrvQRl; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Pushed as 0eb01a2 > -----Original Message----- > From: Hsueh, DoraX > Sent: Monday, April 22, 2024 1:40 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. >=20 > From: DoraX Hsueh >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4761 >=20 > Halt the TCO timer to fix release mode hang. >=20 > Cc: Sai Chaganty > Cc: Rosen Chuang > Cc: Saloni Kasbekar > Cc: Haoyu Tang > Cc: Nate DeSimone > Cc: Chasel Chiu > Signed-off-by: DoraX Hsueh > --- > .../AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc | 3 ++- > .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++++ > .../SecFspWrapperPlatformSecLib.inf | 1 + > 3 files changed, 11 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoard= Pkg.dsc b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.d= sc > index 59350f06..ea92ec75 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc > @@ -233,8 +233,9 @@ > =20 > [LibraryClasses.X64.DXE_SMM_DRIVER] > =20 > -!if $(TARGET) =3D=3D DEBUG > SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF= lashCommonLib.inf > + > +!if $(TARGET) =3D=3D DEBUG > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/S= mmTestPointCheckLib.inf > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNu= ll/TestPointCheckLibNull.inf > !endif > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecF= spWrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/AlderlakeOpenBoardP= kg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c > index f7ec4f9e..e930c9c7 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/PlatformInit.c > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/PlatformInit.c > @@ -12,6 +12,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include > #include > #include > +#include > +#include > =20 > /** > Platform initialization. > @@ -28,6 +30,12 @@ PlatformInit ( > IN VOID *EndOfRange > ) > { > + > + /// > + /// Halt the TCO timer as early as possible > + /// > + IoWrite16 (PcdGet16 (PcdTcoBaseAddress) + R_TCO_IO_TCO1_CNT, B_TCO_IO_= TCO1_CNT_TMR_HLT); > + > // > // Platform initialization > // Enable Serial port here > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecF= spWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf b/Platform/Intel/Al= derlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWr= apperPlatformSecLib.inf > index 3e51cb36..abc84057 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/SecFspWrapperPlatformSecLib.inf > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/SecFspWrapperPlatformSecLib.inf > @@ -89,6 +89,7 @@ > gIntelFsp2WrapperTokenSpaceGuid.PcdFsptBaseAddress ##= CONSUMES > gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ##= CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable ##= CONSUMES > + gSiPkgTokenSpaceGuid.PcdTcoBaseAddress ##= CONSUMES > =20 > [FixedPcd] > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase ##= CONSUMES > --=20 > 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118544): https://edk2.groups.io/g/devel/message/118544 Mute This Topic: https://groups.io/mt/105665490/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-