From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Gong, Zhen" <zhen.gong@intel.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server management features
Date: Thu, 2 Nov 2023 15:47:11 +0000 [thread overview]
Message-ID: <MW4PR11MB5821DFAAA2235B604304F7D4CDA6A@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <cover.1698610713.git.zhen.gong@intel.com>
Good work Zhen!
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhen Gong
Sent: Sunday, October 29, 2023 1:28 PM
To: devel@edk2.groups.io
Cc: Gong, Zhen <zhen.gong@intel.com>
Subject: [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server management features
This patch set adds serveral IPMI features to support server management:
BmcAcpiState: A DXE driver to notify BMC of S0 power state.
BmcAcpiSwChild: An SMM driver to notify BMC of ACPI power state changes and add SEL records.
BmcElog: PEI, DXE, and SMM drivers to support BMC event log functions.
GenericElog: DXE and SMM drivers to support generic event log functions.
GenericFru: A runtime driver to support generic FRU functions.
IpmiRedirFru: A DXE driver to support BMC FRU functions and generate data based on SMBIOS data.
ServerManagementLib: A library to provide essential functions for server management drivers.
Notes:
V2:
- Rebased to resolve merge conflict from upstream changes
Zhen Gong (4):
IpmiFeaturePkg: Add Elog drivers
IpmiFeaturePkg: Add ServerManagementLib
IpmiFeaturePkg: Add ACPI power state drivers
IpmiFeaturePkg: Add FRU drivers
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 10 +
.../IpmiFeaturePkg/Include/IpmiFeature.dsc | 13 +-
.../IpmiFeaturePkg/Include/PostMemory.fdf | 10 +-
.../IpmiFeaturePkg/Include/PreMemory.fdf | 1 +
.../BmcAcpiState/BmcAcpiState.inf | 40 +
.../BmcAcpiSwChild/BmcAcpiSwChild.inf | 39 +
.../BmcElog/{BmcElog.inf => DxeBmcElog.inf} | 19 +-
.../IpmiFeaturePkg/BmcElog/PeiBmcElog.inf | 43 ++
.../IpmiFeaturePkg/BmcElog/SmmBmcElog.inf | 44 ++
.../GenericElog/Dxe/GenericElog.inf | 38 +
.../GenericElog/Smm/GenericElog.inf | 38 +
.../IpmiFeaturePkg/GenericFru/GenericFru.inf | 42 ++
.../IpmiFeaturePkg/IpmiFru/IpmiFru.inf | 36 -
.../IpmiRedirFru/IpmiRedirFru.inf | 51 ++
.../ServerManagementLib.inf | 35 +
.../ServerManagementLibNull.inf | 38 +
.../BmcAcpiState/BmcAcpiState.h | 26 +
.../BmcAcpiSwChild/BmcAcpiSwChild.h | 82 +++
.../BmcElog/Common/BmcElogCommon.h | 144 ++++
.../IpmiFeaturePkg/BmcElog/Dxe/BmcElog.h | 42 ++
.../IpmiFeaturePkg/BmcElog/Pei/BmcElog.h | 44 ++
.../IpmiFeaturePkg/BmcElog/Smm/BmcElog.h | 43 ++
.../GenericElog/Dxe/GenericElog.h | 194 +++++
.../GenericElog/Smm/GenericElog.h | 216 ++++++
.../GenericFru/GenericFruDriver.h | 178 +++++
.../Include/Library/ServerMgmtRtLib.h | 147 ++++
.../IpmiFeaturePkg/Include/Ppi/GenericElog.h | 84 +++
.../Include/Protocol/BmcAcpiSwChildPolicy.h | 31 +
.../Include/Protocol/GenericElog.h | 99 +++
.../Include/Protocol/GenericFru.h | 103 +++
.../Include/Protocol/RedirFru.h | 81 ++
.../IpmiRedirFru/IpmiRedirFru.h | 149 ++++
.../BmcAcpiState/BmcAcpiState.c | 93 +++
.../BmcAcpiSwChild/BmcAcpiSwChild.c | 189 +++++
.../IpmiFeaturePkg/BmcElog/BmcElog.c | 236 ------
.../BmcElog/Common/BmcElogCommon.c | 465 ++++++++++++
.../IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c | 287 ++++++++
.../IpmiFeaturePkg/BmcElog/Pei/BmcElog.c | 297 ++++++++
.../IpmiFeaturePkg/BmcElog/Smm/BmcElog.c | 288 ++++++++
.../GenericElog/Dxe/GenericElog.c | 576 +++++++++++++++
.../GenericElog/Smm/GenericElog.c | 558 ++++++++++++++
.../IpmiFeaturePkg/GenericFru/GenericFru.c | 68 ++
.../GenericFru/GenericFruDriver.c | 513 +++++++++++++
.../IpmiFeaturePkg/IpmiFru/IpmiFru.c | 67 --
.../IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c | 469 ++++++++++++
.../IpmiRedirFru/IpmiRedirFru.c | 479 ++++++++++++
.../ServerManagementLib/ServerManagementLib.c | 696 ++++++++++++++++++
.../ServerManagementLibNull.c | 144 ++++
48 files changed, 7237 insertions(+), 348 deletions(-) create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpiState/BmcAcpiState.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpiSwChild/BmcAcpiSwChild.inf
rename Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/{BmcElog.inf => DxeBmcElog.inf} (60%) create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/PeiBmcElog.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/SmmBmcElog.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericElog/Dxe/GenericElog.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericElog/Smm/GenericElog.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericFru/GenericFru.inf
delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLib/ServerManagementLib.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLibNull/ServerManagementLibNull.inf
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpiState/BmcAcpiState.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpiSwChild/BmcAcpiSwChild.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Common/BmcElogCommon.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Pei/BmcElog.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/BmcElog.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericElog/Dxe/GenericElog.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericElog/Smm/GenericElog.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericFru/GenericFruDriver.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/ServerMgmtRtLib.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/GenericElog.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/BmcAcpiSwChildPolicy.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/GenericElog.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/GenericFru.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/RedirFru.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpiState/BmcAcpiState.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpiSwChild/BmcAcpiSwChild.c
delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Common/BmcElogCommon.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Pei/BmcElog.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/BmcElog.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericElog/Dxe/GenericElog.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericElog/Smm/GenericElog.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericFru/GenericFru.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericFru/GenericFruDriver.c
delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLib/ServerManagementLib.c
create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLibNull/ServerManagementLibNull.c
--
2.39.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110559): https://edk2.groups.io/g/devel/message/110559
Mute This Topic: https://groups.io/mt/102279904/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-02 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 20:27 [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server management features Zhen Gong
2023-10-29 20:27 ` [edk2-devel] [PATCH edk2-platforms v2 1/4] IpmiFeaturePkg: Add Elog drivers Zhen Gong
2023-10-29 20:27 ` [edk2-devel] [PATCH edk2-platforms v2 2/4] IpmiFeaturePkg: Add ServerManagementLib Zhen Gong
2023-10-29 20:27 ` [edk2-devel] [PATCH edk2-platforms v2 3/4] IpmiFeaturePkg: Add ACPI power state drivers Zhen Gong
2023-10-29 20:27 ` [edk2-devel] [PATCH edk2-platforms v2 4/4] IpmiFeaturePkg: Add FRU drivers Zhen Gong
2023-11-02 15:47 ` Nate DeSimone [this message]
2023-11-03 19:06 ` [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server management features Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5821DFAAA2235B604304F7D4CDA6A@MW4PR11MB5821.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox