public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error
@ 2023-12-19  6:09 Huang, Li-Xia
  2023-12-19 19:55 ` Nate DeSimone
  2023-12-19 19:56 ` Nate DeSimone
  0 siblings, 2 replies; 3+ messages in thread
From: Huang, Li-Xia @ 2023-12-19  6:09 UTC (permalink / raw)
  To: devel; +Cc: Abner Chang, Nate DeSimone

Fix GCC compiler error in StandaloneMmGenericIpmi.

Cc: Abner Chang <Abner.Chang@amd.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Lixia Huang <lisa.huang@intel.com>
---
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
index 1b9841e4b745..edc9eec9395a 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
@@ -185,12 +185,10 @@ Returns:
 **/
 {
   EFI_STATUS            Status;
-  UINT8                 ErrorCount;
   IPMI_INTERFACE_STATE  InterfaceState;
   UINT8                 Index;
 
   DEBUG ((DEBUG_INFO, "SmmInitializeIpmiKcsPhysicalLayer entry \n"));
-  ErrorCount     = 0;
   InterfaceState = IpmiInterfaceNotReady;
 
   Status = gMmst->MmAllocatePool (
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112691): https://edk2.groups.io/g/devel/message/112691
Mute This Topic: https://groups.io/mt/103258537/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error
  2023-12-19  6:09 [edk2-devel] [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error Huang, Li-Xia
@ 2023-12-19 19:55 ` Nate DeSimone
  2023-12-19 19:56 ` Nate DeSimone
  1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2023-12-19 19:55 UTC (permalink / raw)
  To: Huang, Li-Xia, devel@edk2.groups.io; +Cc: Abner Chang

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Huang, Li-Xia <lisa.huang@intel.com> 
Sent: Monday, December 18, 2023 10:10 PM
To: devel@edk2.groups.io
Cc: Abner Chang <Abner.Chang@amd.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error

Fix GCC compiler error in StandaloneMmGenericIpmi.

Cc: Abner Chang <Abner.Chang@amd.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Lixia Huang <lisa.huang@intel.com>
---
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
index 1b9841e4b745..edc9eec9395a 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
@@ -185,12 +185,10 @@ Returns:
 **/
 {
   EFI_STATUS            Status;
-  UINT8                 ErrorCount;
   IPMI_INTERFACE_STATE  InterfaceState;
   UINT8                 Index;
 
   DEBUG ((DEBUG_INFO, "SmmInitializeIpmiKcsPhysicalLayer entry \n"));
-  ErrorCount     = 0;
   InterfaceState = IpmiInterfaceNotReady;
 
   Status = gMmst->MmAllocatePool (
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112733): https://edk2.groups.io/g/devel/message/112733
Mute This Topic: https://groups.io/mt/103258537/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error
  2023-12-19  6:09 [edk2-devel] [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error Huang, Li-Xia
  2023-12-19 19:55 ` Nate DeSimone
@ 2023-12-19 19:56 ` Nate DeSimone
  1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2023-12-19 19:56 UTC (permalink / raw)
  To: Huang, Li-Xia, devel@edk2.groups.io; +Cc: Abner Chang

Pushed as 59ef582

-----Original Message-----
From: Huang, Li-Xia <lisa.huang@intel.com> 
Sent: Monday, December 18, 2023 10:10 PM
To: devel@edk2.groups.io
Cc: Abner Chang <Abner.Chang@amd.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error

Fix GCC compiler error in StandaloneMmGenericIpmi.

Cc: Abner Chang <Abner.Chang@amd.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Lixia Huang <lisa.huang@intel.com>
---
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
index 1b9841e4b745..edc9eec9395a 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
@@ -185,12 +185,10 @@ Returns:
 **/
 {
   EFI_STATUS            Status;
-  UINT8                 ErrorCount;
   IPMI_INTERFACE_STATE  InterfaceState;
   UINT8                 Index;
 
   DEBUG ((DEBUG_INFO, "SmmInitializeIpmiKcsPhysicalLayer entry \n"));
-  ErrorCount     = 0;
   InterfaceState = IpmiInterfaceNotReady;
 
   Status = gMmst->MmAllocatePool (
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112734): https://edk2.groups.io/g/devel/message/112734
Mute This Topic: https://groups.io/mt/103258537/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-19 19:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-19  6:09 [edk2-devel] [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error Huang, Li-Xia
2023-12-19 19:55 ` Nate DeSimone
2023-12-19 19:56 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox