[edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool
@ 2024-02-23  6:52 phanindrax.babu.pabba
  2024-03-25 22:31 ` Nate DeSimone
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: phanindrax.babu.pabba @ 2024-02-23  6:52 UTC (permalink / raw)
  To: devel; +Cc: PhanindraX Babu Pabba, Nate DeSimone, Liming Gao

From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>

Adding missed out call to FreePool API to free
the allocated memory.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
---
 .../Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
index 990b4b9e..070a3452 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
@@ -250,6 +250,7 @@ BmcAcpiEntryPoint (
       // Increment the instance
       //
       Instance++;
+      FreePool (CurrentTable);
     }
   }
 
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115876): https://edk2.groups.io/g/devel/message/115876
Mute This Topic: https://groups.io/mt/104524860/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool
  2024-02-23  6:52 [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool phanindrax.babu.pabba
@ 2024-03-25 22:31 ` Nate DeSimone
  2024-03-25 22:33 ` Nate DeSimone
  2024-03-26  3:19 ` Chiu, Chasel
  2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2024-03-25 22:31 UTC (permalink / raw)
  To: Pabba, PhanindraX Babu, devel@edk2.groups.io; +Cc: Liming Gao

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com> 
Sent: Thursday, February 22, 2024 10:52 PM
To: devel@edk2.groups.io
Cc: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
Subject: [PATCH] IpmiFeaturePkg: Add missed call to FreePool

From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>

Adding missed out call to FreePool API to free the allocated memory.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
---
 .../Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
index 990b4b9e..070a3452 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
@@ -250,6 +250,7 @@ BmcAcpiEntryPoint (
       // Increment the instance
       //
       Instance++;
+      FreePool (CurrentTable);
     }
   }
 
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117093): https://edk2.groups.io/g/devel/message/117093
Mute This Topic: https://groups.io/mt/104524860/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool
  2024-02-23  6:52 [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool phanindrax.babu.pabba
  2024-03-25 22:31 ` Nate DeSimone
@ 2024-03-25 22:33 ` Nate DeSimone
  2024-03-26  3:19 ` Chiu, Chasel
  2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2024-03-25 22:33 UTC (permalink / raw)
  To: Pabba, PhanindraX Babu, devel@edk2.groups.io; +Cc: Liming Gao

Pushed as 6feac9b

-----Original Message-----
From: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com> 
Sent: Thursday, February 22, 2024 10:52 PM
To: devel@edk2.groups.io
Cc: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
Subject: [PATCH] IpmiFeaturePkg: Add missed call to FreePool

From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>

Adding missed out call to FreePool API to free the allocated memory.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
---
 .../Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
index 990b4b9e..070a3452 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
@@ -250,6 +250,7 @@ BmcAcpiEntryPoint (
       // Increment the instance
       //
       Instance++;
+      FreePool (CurrentTable);
     }
   }
 
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117094): https://edk2.groups.io/g/devel/message/117094
Mute This Topic: https://groups.io/mt/104524860/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool
  2024-02-23  6:52 [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool phanindrax.babu.pabba
  2024-03-25 22:31 ` Nate DeSimone
  2024-03-25 22:33 ` Nate DeSimone
@ 2024-03-26  3:19 ` Chiu, Chasel
  2 siblings, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2024-03-26  3:19 UTC (permalink / raw)
  To: devel@edk2.groups.io, Pabba, PhanindraX Babu
  Cc: Desimone, Nathaniel L, Liming Gao


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> phanindrax.babu.pabba@intel.com
> Sent: Thursday, February 22, 2024 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool
> 
> From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
> 
> Adding missed out call to FreePool API to free the allocated memory.
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
> ---
>  .../Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c   | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
> index 990b4b9e..070a3452 100644
> ---
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
> +++
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.
> +++ c
> @@ -250,6 +250,7 @@ BmcAcpiEntryPoint (
>        // Increment the instance       //       Instance++;+      FreePool
> (CurrentTable);     }   } --
> 2.39.1.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#115876): https://edk2.groups.io/g/devel/message/115876
> Mute This Topic: https://groups.io/mt/104524860/1777047
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] -=-
> =-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117101): https://edk2.groups.io/g/devel/message/117101
Mute This Topic: https://groups.io/mt/104524860/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-03-26  3:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-23  6:52 [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool phanindrax.babu.pabba
2024-03-25 22:31 ` Nate DeSimone
2024-03-25 22:33 ` Nate DeSimone
2024-03-26  3:19 ` Chiu, Chasel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox