From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.3883.1642042141419023879 for ; Wed, 12 Jan 2022 18:49:01 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IGXDM8+d; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042141; x=1673578141; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=E6QEC6o5i7Uc+BQx/6mWPn/OPB09+F/ki6dM32QhbBc=; b=IGXDM8+dX1fNVHocyBqdoJyjmbvpEHsnNixOQwMiWBh0I32IVvE6WNwW pFRTCc9/f8rtBR04UerQr60xH8jJEFbTW+5UeOd7ipDyGXGnY955cNP/T KaNS1yrPMr5huoRLXJKEks1vAGnMd+wvDta3q1gtzGKKF9SV4q7HQULiz HjA7oRIbEWgVgzZ2zyuLSVMs2x7K9J6Nluox4CzVsa0wcoLCq2MrADFjB 7/GtpYR73P9Tc3atfhK6QnB/a8JZWff+0KNdFemEercVaKpvUqxB8zSD4 q5kdOtX9ws1Ybfk+fd38aznRUp7A1R4helGaEUQ0a9R/ZN+Mz8ad4N2cN w==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="330261555" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="330261555" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:49:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="475146989" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 12 Jan 2022 18:48:59 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:48:57 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:48:57 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:48:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQlEsu9ebSHNnlF69aAbF6rOB1JO3pypl8ANan0CX1BbzZsJfAAIgVGxH4VHYnmM9oaI2q/DZjxlHcwDEhDguaq5aeOYqAde5BHkWjEmdEyh2iAOl3VgMsktTwtHOehtMxccE5tVDexWYJFSVeYqL2UoDQEW6oYssTDmBkwYqdVupUu6uyxPohuZW7U/lpW1b1gqOqGZHHYwGeFgfPwThCpsPUReErucFkb9Al1i5uo18SAMF7ucUXL8sEFOU5HkEw5pCe7WyQKqjX1ZmyrJkPj9oVv4MxfHEvPBurzSOWV8KNpuZ/7nZakc0T08CL7NVH32vje2XuWkJrPnyNXXwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4duNtJjVCVJTgV73BpYHTvHw3zWA3OxEYdSoP+20wVU=; b=XYQ0li27tBYBmDmQ1pbbdS9RqOs82M/eXExQ6cBHGoTaHQGBpgQvqdNENmsSjc+BwB3V+64xSHDFJ36e2Pq4w8LSIJOsxwcN+0Twcw0f3myQam0LWqQn+xA+KDWvXE4MKkwVFtf7mpX5fibf+2sV9cH/vr33lrgWUeUSrs+67tK9hRSpxP0nWVmaPOBC+4gc7nnKSV+l4dPSVpufAD/PJm5AIfw2eQbIFdZb2zBaJPPECrWjJZWv7MmktsUcdedgIHS70pPbWgFZObI2a8EXtoodbVEGOkK6RbQ9CLOGu0n4lD9UV7YFUyAyCbpfRkdgA1YwccU6S610kH9sAUqMfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW5PR11MB5812.namprd11.prod.outlook.com (2603:10b6:303:193::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Thu, 13 Jan 2022 02:48:56 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:48:56 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Oram, Isaac W" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 06/27] S3FeaturePkg: Fix all relative package paths Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 06/27] S3FeaturePkg: Fix all relative package paths Thread-Index: AQHYB1saEiohd4h5S0qddAqq6PoblaxgQXyw Date: Thu, 13 Jan 2022 02:48:55 +0000 Message-ID: References: <29902af26459b43d30e4b70244e3742813113f1e.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: <29902af26459b43d30e4b70244e3742813113f1e.1641953242.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23e2ed2b-9548-4443-37e5-08d9d63f3df9 x-ms-traffictypediagnostic: MW5PR11MB5812:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8w8J9L0r8xUyTv4IaRX0QwjjEzF/iTAasCGW9T22hB9gadS70+u7OETOoJMu/6VdMlzPVqlz2MIUB1ml6Xz3mLtIva2LLavmk5OG21YbU1teR0BYY11zF/v62GWVjfEmkhwcjrDVZ+E/ojEwbTnQTBIF3xNPIv/188nUT9k6mdzNy4Asg0FnT8fxzPtyYohhd3Lyiu+b+BhWQ3eZozhstmzi4zVowhYMeLj+Ru1wx1FVY33lZjmGstC/iqkS0THhelp73CAEYS68CG+qGzrKtv/e7ncMwo1dq+KJYv4ph1PlRcsAIj1hL6VpY/IzJQNozSjIOM58GJWbyQNtKfzFA/EoGaEGNIlwUQ4Y3YmEzTrdsFWcRMZsHAK3bcdbaTwV8saF93YWbLVFxaTY2xv+C1ZPKXTaexGAGW8JXx1MnP3QUQQDSBmIvwgImir1OFfDxpuMUsfye8WXvlhkjXEw+DN7FJrRtlqFy4cBygblYEa8IMIhcvXaCAynhate4pZEBGGaKpCb1t4iT3VzLRAsRnHhysgaPuw0L3Ms2LW6wX143bgwMYCKYEN2XpGOJaiKtgvn7WzPTDU83HjOcwyHMy1ifcriUun5YKwCkvz9N0BTQq4DLVnhDGUeV+L84H/Pxm9f5kTfSvyzNOOPY3Z/irYPz1q96wQZj11H+b8j7QiwK2nquCN4Zrd1WcGLq/D1U0H3sfHa5YMgkE4rbNYHwVyNufIG6rF38KQbr50KLhuobgOCFmrJe7NffoWsxgo9Ynqjv8Oa2i8WRxr4vj8wQvU9d7Nt/7UnGtZxLiKMNwXDOgWJmHaKkyS6RyaoET6xihNZ3zGr0tHAo+PvFiXvgA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(508600001)(53546011)(2906002)(54906003)(82960400001)(966005)(8676002)(110136005)(26005)(83380400001)(64756008)(66556008)(7696005)(9686003)(52536014)(33656002)(55016003)(5660300002)(4326008)(6506007)(19627235002)(76116006)(122000001)(66446008)(186003)(6636002)(66946007)(316002)(66476007)(71200400001)(38070700005)(86362001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ou8IV+D9Ko1+WubC2ucnQyzHzNySDQqaqe64d61EdtbnDFFAh2JKIOAWHC1?= =?us-ascii?Q?aOOx4ZkeuhYRBd89l9Y/KopT7+ppEVQKC5tL9EEt4a0Xh2kQ0s2Q3aopMxcy?= =?us-ascii?Q?L4LUmrmvbuDO7UZjcIhydKZ4A6mzJGJoXSR/3iXx1Pa8bUvet5ZJG35fq4vx?= =?us-ascii?Q?2YuhO+AcDPL0syEhoaeQaIOCp4uAo/X4vPDRnhnC+WGUqssf0MMSue6j0dU7?= =?us-ascii?Q?SpBTHih9J0CoJ7JPrssep4rD1teuyn8nopQrrCHbSM5IRyuHq3kd8vRjJLo0?= =?us-ascii?Q?/IJlcLn+9s/243XUBBHxGB/ArBQWrvvqPQ3yqOwiqb0KajT3PiZQz+DtnfUx?= =?us-ascii?Q?49Ya6HEUBW8laMjFVE6wzdq5nje9hd6kddpKJluRmLAD2304aPCVcDaQrSS4?= =?us-ascii?Q?EJOIEC5zv4b+pWBmnVUWc/j0o0H+JuDBnBkATUnyWuu/NzwCeXI9u8PZw5Kn?= =?us-ascii?Q?Lc4cx846CiUgdGEKVkzTg3N5Ks3yCaRmf7nnSmQQbE3bkj+vapze+OpggY0u?= =?us-ascii?Q?Vm/4Ooq81jcGRxhSdV/6kIiAdE1a/aTDZppOPRR08qDCT2TFDFRVsynKN4+r?= =?us-ascii?Q?Aoa/pKgZIgYYecNbJRtJ4q8QMOdEhFxdZXVuqzmQmQlx9NvGhNknfdgp8A+5?= =?us-ascii?Q?71n66Yo1zBO9rtfRm4nqttVINZZkPVCwuNoJ00cdApXuSsBFoGkRKCdIjduN?= =?us-ascii?Q?uWstvGyp+XjzFQAX4eUH3hqnBKZoUaqEE82RKjgWR9D6PBdcu01Ldtr06Xfv?= =?us-ascii?Q?tUJ6DQJBghGC8ACjotHgYvv2B3Z/47OqkX+yRZamXALhxMSWU9tPMqEW+634?= =?us-ascii?Q?FmvjLN+BKnnlFp2GDU83UWBG0hiyyFfJAP8stvddWsU/IdPPAvdpla1H/kGL?= =?us-ascii?Q?Rfd0RYcLNs/jwUUm3K6TCSHfnbXOMzT1wRrfu7+BIsiVhS9YE04RCzNXRSzE?= =?us-ascii?Q?01S7geWi+nJuEWEsp8CEEspk1PSRopJDVvfDeJ54pHcYW8gY4qGMeM3eIYlu?= =?us-ascii?Q?0V0TyPOCc0tioqAm8GNnGZ6asZLxAyL1HVqNQuJsz7BW/1fM9A+YGWw5YWxf?= =?us-ascii?Q?xwX0+SaJAFMrGcdfgsNnzsJL8ZHW+J6HVtefmI12exNA70563psfDiXNoNr+?= =?us-ascii?Q?L26Ly6M7qxoVo5eOpITtkOj1Wl+9JhPVjZfTYhTB89lqlE65ciW0WoCN87ij?= =?us-ascii?Q?k3fTVKOa3FGwcigu1jpq38W/3fv9uDuQRts48+rvGNCiwbw8YrBt3VSbAF9k?= =?us-ascii?Q?RzeJBk/AxEtnQwwtqNdocL2qAIaLZEyUdTCNwyjslla5lx955IDSl8Xbj9hB?= =?us-ascii?Q?rrrBfctDMdTHZPfTlka6F1YKXJu4gt37TqoStZDxgDGlklVUYod9/iqbjB6+?= =?us-ascii?Q?XO7+tCiYoVhTyzY/aEFkreBQI1uGwCOPFH9qaF6tlWOzVZElVPjcnndIui6F?= =?us-ascii?Q?JfZEzlhIOdmu5xULGrMHcBUiABkC89I8+E0lJv7IfKk8rKyU/cfXSieEhPFk?= =?us-ascii?Q?uj7p8eC4dyylXPgxf9lrbrKSHP6vLWjFuQkTxFiflg5UZ9KFP4+8DmDucCAc?= =?us-ascii?Q?jFhlmm1VoNS/PF/qAI+S5ThKbd+zSmlwi0B3grcyAeLXnW1BxvUFscl/rKDR?= =?us-ascii?Q?AwdbNaK/8OhFD3ou6jNRFFlgEk5vhfVgtJpdbE3pBh97Ul71xhQOX6NVCXEY?= =?us-ascii?Q?mF64uQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23e2ed2b-9548-4443-37e5-08d9d63f3df9 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:48:55.9724 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tJnescgMyMg/lKK7xETI+33WBRBC0rtOjIqLVGMgQiXnNJTg2RA3TN9iYMfPKsI3STFaFqTq170OhNTNJhxjMpft61d8zCy6X6yNJXaLdE8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5812 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oram, > Isaac W > Sent: Tuesday, January 11, 2022 6:20 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [edk2-devel][edk2-platforms][PATCH V1 06/27] S3FeaturePkg: Fix a= ll > relative package paths >=20 > Packages should be at the root of a PACKAGES_PATH entry. > At some point, paths were relative to edk2-platforms/Features/Intel which > was functional, but interferes with the proper functioning of packaging t= ools. >=20 > Cc: Sai Chaganty > Cc: Liming Gao >=20 > Signed-off-by: Isaac Oram > --- > Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf > | 2 +- > Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 2 > +- > Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git > a/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fd > f > b/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fd > f > index 3cd5cd9628..34caf3dacc 100644 > --- > a/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fd > f > +++ > b/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fd > f > @@ -7,4 +7,4 @@ > # > ## >=20 > - INF PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf > + INF S3FeaturePkg/S3Pei/S3Pei.inf > diff --git > a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc > b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc > index 312870981e..f94bd2b431 100644 > --- > a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc > +++ > b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc > @@ -91,7 +91,7 @@ > # in the package build. >=20 > # Add components here that should be included in the package build. > - PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf > + S3FeaturePkg/S3Pei/S3Pei.inf >=20 > # > # Feature DXE Components > diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf > b/Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf > index 46fbb62a46..e485eac952 100644 > --- a/Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf > +++ b/Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf > @@ -23,7 +23,7 @@ > [Packages] > MdePkg/MdePkg.dec > IntelSiliconPkg/IntelSiliconPkg.dec > - PowerManagement/S3FeaturePkg/S3FeaturePkg.dec > + S3FeaturePkg/S3FeaturePkg.dec >=20 > [Sources] > S3Pei.c > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20