From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 53608941E46 for ; Mon, 25 Mar 2024 22:36:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RRneHvlnB1T6fXps6XuGWbgs/+KGmdAutg2SlvJqtBQ=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711406170; v=1; b=xHvRgrbRt/D9GExgrqcZuecHnPTAxE6PVZ0B1gULziLRIMQufCgoyE7gn09FbDQUoZkxqEnO aaUYMBHiIG+umAcorvEHa1GVky5R6kFKPCv81eQApneNeHoBRD9nY3EVN+psfGiU8F/CBuuyhNc uJndW7+5xqcAY4B9Cbd/Aj9jTqVtEAvVXxiT1OS0QV9oE8OWNM/3DIP1f4uFDJ29ZCB6CxmfmOq CafhrXZWTj8VRc+uJKe86nRyux2l87CKQBdZvbu+ZCdzr3OR8tCruCLP6Xm7/EVgUeIZFyEwNI+ 5v7AZLv4dBWl3seAAMRwhdrIgdzz02Km/pxfUQqMlJ1Bg== X-Received: by 127.0.0.2 with SMTP id 0UH7YY7687511xUEbXxDtFJn; Mon, 25 Mar 2024 15:36:10 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web10.5431.1711406170328992614 for ; Mon, 25 Mar 2024 15:36:10 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11024"; a="28914356" X-IronPort-AV: E=Sophos;i="6.07,154,1708416000"; d="scan'208";a="28914356" X-Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2024 15:36:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,154,1708416000"; d="scan'208";a="16147938" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Mar 2024 15:36:10 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Mar 2024 15:36:09 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 25 Mar 2024 15:36:09 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Mar 2024 15:36:09 -0700 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by PH0PR11MB5950.namprd11.prod.outlook.com (2603:10b6:510:14f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.11; Mon, 25 Mar 2024 22:36:02 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2769:a1e8:3236:e5a1]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2769:a1e8:3236:e5a1%4]) with mapi id 15.20.7409.031; Mon, 25 Mar 2024 22:36:02 +0000 From: "Nate DeSimone" To: "Pabba, PhanindraX Babu" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg: Add missed call to FreePool Thread-Topic: [PATCH] MinPlatformPkg: Add missed call to FreePool Thread-Index: AQHaZh3IjYTWI3JXX0C5LtbtJLjxKLFJPSUQ Date: Mon, 25 Mar 2024 22:36:02 +0000 Message-ID: References: <03a7571c56639af46ecc7b59ac2aa65ee2ceacdf.1708667871.git.phanindrax.babu.pabba@intel.com> In-Reply-To: <03a7571c56639af46ecc7b59ac2aa65ee2ceacdf.1708667871.git.phanindrax.babu.pabba@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|PH0PR11MB5950:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2j5JrtaRkVCQ+JvoNgwl4Y+gLx7m8/fo7OnsUUOX31KVN54Nu7H+K/Irr4KijW3fcwYt9D7+jJ30kaZA/2qxE+7rMUHBsY+dmzeRlFmrfGyOuAzWLrK7I90uJm4Q0BF8e26+5xIF1NNl+rs3dE8J+peryLXmMr09uZLo7WqP4g6l9zqzMP5H0ca4Z8+0YmdgMiJtkEtCEPImwQecKABg6DOK0i6WnfJl/9UVSLpD6k/8nQcbAT/KyM7KjRHveETJRApTaoXQ2lRYZ8QqmLrRxeSaMRTIeDeNPNMMjeB3a4hT7UqI6Ccr3Yj4o4zBfX13cU/Z8hYTlMR84NqQ2J/qDHmcZgkiYxPPNLkfFOxbz1xtlAx7bVN3J/UtdAP8d+Bk2N1ZdGC9+eTBK0XMcj2IILc3QbH3vEYn6sqZrpYbmAE0IzPaQrN3gFNUEywHcsPq86ksbYiG9xF8olDuetvbplDEurQSW1GOCtjhxmVwuDjhrjekQRhbYSYFH3H2YmKF+wXYgE1YFUqjZL+HDaZnZLw2YIFV7VsgJRlht6CW5DgyeIrtQn02YZe0o7Ki1yWn5QiSSTfvtsVKHhKxQgnxAji928koot5uSuxQ1NoWoIBSIaTzpJjHxHqKNrUBOBXISeP3j+iTkSjAQ0PS/tsMuGBwCrVsL0N7v2djJYwhCtc= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ciwY9GsrqiPbqD2xESjKN/1orYdrsJTxl8r3fSF55qwF+vn5p8QToFVtgluy?= =?us-ascii?Q?bjzH5XY+8Vmi7v2MxV8YJlfzv0fqfz76JKZmalE+Dq9l9QgUTo5hP24a28xQ?= =?us-ascii?Q?W4KI9N6orvXPLK/PYGYibdt8CRXZyvpTfrdtA5PSeqf/4GARfDjwdjSUaIVW?= =?us-ascii?Q?uZ60OhPxKyTbzh7y2hy8WGGYbWpf5jUyTJANLRffkekZG6eOEaDpqcrKJFBl?= =?us-ascii?Q?sbE1TdHnA+FrG4WCwqEc08UiJ4UOVauQysDGEv+uohkYtuhY4e/TUsfdoXGU?= =?us-ascii?Q?LH/J+oR5Blu4GQsD1nCDBipVP9Or7jXre40McQkiNh4TaveeL8sy0orDKGMm?= =?us-ascii?Q?T4gyiU1AhCDGNW37ore2UVxw9r3Wi0Kg3BmeFPhT8yrhg3w9+Bot4z2ReP1F?= =?us-ascii?Q?RTrOBfvflnZoA6feqTUDu39Esgb9n/OLlddoHonY8ryeKbFR7CUON9tVJraX?= =?us-ascii?Q?e4IDQCGVB9r+gak58nIkG9g2PAumM++OIGMqsc5OFxwo5fLLPbHt/Tor3bKV?= =?us-ascii?Q?rr/gk5MsKQGsg6/Xbd+R6GraY8Uau1O1IoYo+l53QLiOBH1hvZcUUHlQcjbo?= =?us-ascii?Q?g4magNf8cwYg1SvqPo+J5NkQlQJnBm3EWAqxAElaC24rQaP5gJ6W+Suxk6wf?= =?us-ascii?Q?TlKKrzHhEjaTH5GK59KPpDpg829LXQwfPI8Kw3NFx638vqHWb2eDXyfXhhdY?= =?us-ascii?Q?Kda9B53dvkp1BOderLK/KExHOUqtxX6qi54f1m44LPXgliZq1s4Ch/yfnjqL?= =?us-ascii?Q?gpgdOt2W4VXTQ24txwGAHX8hoKo+oNcG0XozAsBdZU4kEKrQ9fFP9BcOse5j?= =?us-ascii?Q?fzdKTt5C5rNnhOWpbt6jp6YYTc4kKSJa1K+Eo9bO4T0Qa+1nhq6QBSSlf5aX?= =?us-ascii?Q?hEu+SnVbe96oN8Yq92VcSQKdC4ypRLKsqDdOtQJraxcctCtwTMLnelZ5YNjx?= =?us-ascii?Q?zXzLXmU522zymKYNuezvITSMtfx81d3+tKHG5YP2gYzUqoZxmgoxfcIAZzp0?= =?us-ascii?Q?0U8cLj2Yf/EmUunAOEB6heuYd0ujKWCzUGFRiUMyK5Bm4XMcKMJl/T7Q0DUX?= =?us-ascii?Q?Tyhx4rWWEC3ej34n9gQFGpmrP3JqwwVdODSW33BCZ8/884Oh9X304y5XE0Yx?= =?us-ascii?Q?2M/h32T+SUP8CNK8v7OMfiivw9HEyqtDFQV7uYZLhxJLKt0H6hyFDq51kY57?= =?us-ascii?Q?e8d9yyi6Mexkzq9AUOTRXuxLSfqr+tgmucvXWpiFnbMK9AzU6U0EMG/ioHmv?= =?us-ascii?Q?krQLPLnEtGMjgDVDTjv7n3W37CRfGfWZ43fnHnovn/NyFSHvMnKoI9JLg1l7?= =?us-ascii?Q?f74LDY5iJBaZpIOdO8eStCa3L9RDt9JUERA4Mtk6MczsFuBrYiQ3zqX/FE2E?= =?us-ascii?Q?5HDPhJ/+IL7XGJO647jS5hyZkxo8pTneiR8jJ1j2yC7w+N1Q207u4pBcLEHM?= =?us-ascii?Q?mdHi6O/mOnjHfHDVWyfSVFI+TAeGvxS3pF+xxkRjsvmJeYW9j9qpPB2g1sAd?= =?us-ascii?Q?MZ2e7lQseHecY3Mf2xWrUMVVhl+VPvrXD885SqtQAAkn1V+BWIZGRLrkViCi?= =?us-ascii?Q?RavJMzq4KRJXt3y7+9uHoPtO1pRdG3ctTiWmByCQZOXww+4RvyXNlC6janIo?= =?us-ascii?Q?6Q=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f485917-9a77-4c05-2cab-08dc4d1bf35d X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2024 22:36:02.2115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hdZLo6P22YDImlsAxMOrPU6VeSCnlQxSUvjyMZTyIibZIPwvrns6hDkANnpn7yH9h6ZTk0QxV+Qy6LTDYyzdTUUfa6c+00gbJjS/UKMQBXY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5950 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 25 Mar 2024 15:36:10 -0700 Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YXjnxgsTtCbveHpfs7fD1ebax7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=xHvRgrbR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Babu, If the call to InitializeHeader() fails then the buffer will still not be d= e-allcoated properly. Please add a Done: label and a goto Done; so that the= buffer will still be freed in the case of an error. Thanks, Nate -----Original Message----- From: Pabba, PhanindraX Babu =20 Sent: Thursday, February 22, 2024 10:01 PM To: devel@edk2.groups.io Cc: Pabba, PhanindraX Babu ; Chiu, Chasel = ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [PATCH] MinPlatformPkg: Add missed call to FreePool From: PhanindraX Babu Pabba Adding missed out call to FreePool API to free the allocated memory. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: PhanindraX Babu Pabba --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 +- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 2a833ec9..f637e1c9 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -1002,7 +1002,7 @@ InstallMcfgFromScratch ( McfgTable->Header.Length, = &TableHandle );-+ FreePool (McfgTable); retur= n Status; } diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt= .c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc22245..f5b1a71c 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -195,6 +195,7 @@ PublishAcpiTablesFromFv ( // Increment the instance // Instance++;+ FreePool = (CurrentTable); CurrentTable =3D NULL; } }--=20 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117095): https://edk2.groups.io/g/devel/message/117095 Mute This Topic: https://groups.io/mt/104524859/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-