From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 12946D80287 for ; Tue, 19 Sep 2023 20:04:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MUVWWb/meF/iwQ+aLjCCfHQpO3OjbPX8TgLszX6an6g=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695153875; v=1; b=rY743/5G985/p7NpBqK48XSVQRUt+OA7Z+WDxXlaMTwEBVgJ8TWDBlfLEoNHhvsn6XhnjhYp v1cL8dxYODKzAHVIwzrJY/Z+znYBNPyYxEgzJfCQnMxN8xkzGT6QPkvPqa0zpx2fOkVMDlZoSjo 64CvC2GllqWMaNM6pm15RuIg= X-Received: by 127.0.0.2 with SMTP id ZvcUYY7687511xxLpGVriUqR; Tue, 19 Sep 2023 13:04:35 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.20090.1695153874228236452 for ; Tue, 19 Sep 2023 13:04:35 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="370354708" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="370354708" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 13:04:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="696035048" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="696035048" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Sep 2023 13:04:32 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 19 Sep 2023 13:04:32 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 19 Sep 2023 13:04:32 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 19 Sep 2023 13:04:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M6Z3K+DkHztSHRgdn9SRVviOVsH/eK8glHA2MTcbvboPDayGzCl64nIUCGnMPNH8aNwX4fY0+EaxfpGdGOuIuFnm4XdUQYoR2r5rY1361y9DR/AGRlgcTUyc4OeqEQbVucUA2ZWMeVKUGeFW3lnw6iB0BggkloCHfXD8YXgC3+I+hFmh0uYK1xidU2pcJDr+bH4L2J5DNsue/Yxrj5J84QGNQLSI13/19uXdaCfGBaJptEer0a9Qx8kVkVffBTjXpuGX8ZrTxhdtImFkTei6azjmOx0EAGalW+eDu424amKKd/QGAWgmxADSgOuwh618pb2ysQyEi+B6V5gHAJO7yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zLw2bZnctObekIpms30h6Cbmz0OnYmRHg9581Ux7w7A=; b=eb5Fw0rHoVs/Rq4a3fkMpgKVbzCyWfqfkVs0Yo4mQ56CjChIh/iaa1kXuSUrqcre/hBuX0lRK3bdf4IX6zt6fMRg9p8Hp3k8Tmm8/dH+tOdEW/6ZfTTz5tgC2yQyyZtEOT6TW95Oc00/+qNMyRgW8XkFgqHxPMeIFdMIRSQoMh3rm0l5QZVyiaE40n6oWsNsaDxsMZ2JnaUXG76s88YSCt/5uUsZ1xEtLOrgnSQnU2Bsde5Iusl0dPF9lpo1R3NKwKdbOsBvgtX0ipIXpUSq8MG5cDu8f+w/0uldx/whTqgYZBD3gb7avh5fhbSLUXaSQVXlY4+NPHzCsH+3u8IDkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by PH0PR11MB4998.namprd11.prod.outlook.com (2603:10b6:510:32::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Tue, 19 Sep 2023 20:04:25 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::89db:ecf0:29f5:9f3c]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::89db:ecf0:29f5:9f3c%4]) with mapi id 15.20.6792.026; Tue, 19 Sep 2023 20:04:25 +0000 From: "Nate DeSimone" To: "Huang, Yanbo" , "devel@edk2.groups.io" CC: Isaac Oram , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report Thread-Topic: [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report Thread-Index: AQHZ4GiaQELj/pz2sUGDZsHzaZ1woLAiqBLw Date: Tue, 19 Sep 2023 20:04:25 +0000 Message-ID: References: <20230906021913.54945-1-yanbo.huang@intel.com> In-Reply-To: <20230906021913.54945-1-yanbo.huang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|PH0PR11MB4998:EE_ x-ms-office365-filtering-correlation-id: dee6ac8e-b628-476f-7f17-08dbb94b9f86 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: royOQMpw3A5ONjhkhZzVDv75OtrdFjX5bjMx3VRAPGEMcZrUJ05Myiesb+d8rASiVRsmtYMZYGmUXKUVWtjUD9YB4S10l+aBqZKkdUR/tlR2d2mUXqYhRv6FxqU3RJwFD06SlbYpJ/2EqNvvwx+aro3HhTc/rJy5UiDhAg2Y/ehdbzR9HMi9unX43PMN53zVFFcSAS1TtTtFla+wCYaNkcWhWA1gcYdZEf/LktUecb1cz7w2kemlUm3WhLShlogxB+InVoQ/Qm1NM2g5HpCYblScZLvBA7WChjaT6zw/ap+ptKY381olFI2pRubGX9fCTBQF94DrYKct98YAjIZiLMGU5kvKHy2vUbcAsHvBvW487SvOgkwtIW5OlwfYMwcNzqHEIVozeXCMsUhNfDKMzVm2aIlyT8wm7mA8neOcYb+1p6Iuj2nisW6rbzVEFsAdWKmTokoonurWuuPBvxz6IU9VYvvUbPjyCuyfMBsqRjSyLwhyNYrnDYOQDpACu5OflSpfFgvzv0dhyL4Fc/TxU2mRUxBjkhSwJTBKShBEUriwaeFbPas3nnJLazlsMe71GpDFeHGIB/N7NRVSTrx68BXDAVewUaSdteVxtHV2Hmg= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R4/SsK8TPDeSsMXELGkMC+HYA+eyOP4zFVg6hypt+ZbkL6H2QtFjqcIgCEpk?= =?us-ascii?Q?e38p36nnuow/m0n3NWin0vomkjCv24krNbVZ6gZJ1ncHc8QR89SvnX6oZayn?= =?us-ascii?Q?bChYvuHcFJusuR1Ay7TA0o+WfgNe12zIvoPw+fLt8ToTOOFNvhqQ+6mTrfgV?= =?us-ascii?Q?TBBW1aHyX3zX/i7H3JP8RPU/kEQjqLBfesmnCalcfrlCuTn3+zUTSCAHoSzC?= =?us-ascii?Q?reBXT6jNtJKgXx/yFfFKtYggw4hh/8Y+Tfza6YloMQeZ6kFN/Tjc7JyfillF?= =?us-ascii?Q?wGhGt+kSbZUP1LG0cepRLeKMd/ZmfzpzHDPz+07qpgTUA76bFpRt+q1qXDpr?= =?us-ascii?Q?ouOkJ+cxqK9kptm1jFbOnTX3rPoU9TAzK4kh/Bnfu1+/6TyPCuPAqqjpzslv?= =?us-ascii?Q?BUCxREUlGQYYvjCHSL0PaBvX877j04YDkcIfrFb6esiyze4PpgwAGO4ShIsW?= =?us-ascii?Q?Dx7ioFX7M8UY2ymRACPU0DpdR/snIYw1sYcYHtiwdGPMXYntZ2WjHmXoV121?= =?us-ascii?Q?4sTQTWxid8xG0WP7JI8AC7DbGdiBQPXYZIhab1yRGFwHyIUiATDPAzDiW8cQ?= =?us-ascii?Q?oWrhGtdGNgdLn2VTmh/U3tPFQluOwGhEQseYw8G0CGquyOoXSvazCfxBlnXx?= =?us-ascii?Q?/XAd085+827/+/PzBP7BHT4j69g8/Uyj0Vvd5M0QyEdx+rxKp0bsp9jMCjYf?= =?us-ascii?Q?OB95thw2BzKzW90NNSgaOzQGkp9nmj+8mMpinBP7H46xOSM7ScDH4i7Vzw/q?= =?us-ascii?Q?A/LB+SSUTVFgX7xRJo0TfgMVzwU5Hu98JRqF0ZvlPBjRgTaQ9puqbnvQlHBO?= =?us-ascii?Q?XIMcWHm59TXEby1uVo63nw4GCWgxVOHOwvNZ3XtGMhxEeGkzVjXZ4WmP4kOg?= =?us-ascii?Q?BjgzPI40WvezJRoeGgINkhBKeDkxwwrY62eGkxJZi1Ddh6ix2/8EAfznPsE7?= =?us-ascii?Q?wNQoDqxzUlQ11nkxMXBdbYre1sgf+Dx2FS3i0KGhytv/tXQMMhn6SgDOKbdl?= =?us-ascii?Q?i+fURDUHRW4EOGqrXBEinUMb0bH4TpFXLl1RD7UfSae46G8OGoT2g8o1s2km?= =?us-ascii?Q?vKw3jjmI4gbRWU7iIuymKZNLnfnyEmNbxrl/P6pvC8bPnzrUhCMSieTUQyjh?= =?us-ascii?Q?3dtl5a/ELWrGW65jPGKbBjWj7MVesy2sRvrQQkcbdUMTGwar2ik0WyIO0zo2?= =?us-ascii?Q?bhS1DcKkOA9vH78Lh3uGbOkGLahA5vDRYLZxDN48Shhmvq0Q1mS0/9tJc1Ek?= =?us-ascii?Q?Sr5uTST/vG72ufSPMOaCc1zWgkklQHp664Mj3QseXaH0MZH/D+kNHdyV9cse?= =?us-ascii?Q?Nl3DS4ic30OX7mFrZbCujg5EFLkrJLI6bgpGDJl5kjE5UQ1wjhJaL6hA47S6?= =?us-ascii?Q?TA0TDF1AB7ytJS8I2jQ/Rlu7cZPO5zdiJL22Hwh8tYhfT11DEQxviAkCfDep?= =?us-ascii?Q?BG1SSJ3NBHj8CaYyprCuLk/dHmaS8a9PyGwuuK9J7o+MYZ8PVfezMI4dfoGg?= =?us-ascii?Q?uPWtiCCwnrgcgoJhuHtSwEfDayseUYyR+Z62udRl9m9PzoTTLkeKVguJhi2r?= =?us-ascii?Q?djfW9XkdaahJtkNPQI31RaWbXOMY24ycT0qI8cOpsDrAGYktlqYS/cRRmVQj?= =?us-ascii?Q?Yw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dee6ac8e-b628-476f-7f17-08dbb94b9f86 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2023 20:04:25.2586 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8oa6PA5IUUongVJQCwXk21+mOgCg/k8eJSrR8zL9DibzFZPJhABXSFHqaL/zxWhCvaUaig6UemU09VGLHhCoVr5g/1AVf/u/M078V+iqU1U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4998 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Eqya3s8KwdqxPkywbNTQWmemx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="rY743/5G"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Nate DeSimone -----Original Message----- From: Huang, Yanbo =20 Sent: Tuesday, September 5, 2023 7:19 PM To: devel@edk2.groups.io Cc: Huang, Yanbo ; Isaac Oram ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4522 "if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) {" will not be execute= d in current code, put it within "case SysInterfaceKcs:" to avoid this issu= e. Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Yanbo Huang --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 36 ++++++++---------- .../GenericIpmi/Pei/PeiGenericIpmi.c | 36 ++++++++---------- .../GenericIpmi/Smm/SmmGenericIpmi.c | 38 +++++++++---------- 3 files changed, 49 insertions(+), 61 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 7113556df8..82f6d2a661 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ +++ IpmiInit.c @@ -630,8 +630,8 @@ InitializeIpmiKcsPhysicalLayer ( // Check interface data initialized successfully else register notify = protocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInst= ance->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -646,21 +646,19 @@ InitializeIpmiKcsPhysic= alLayer ( mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Bt.InterfaceState = =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ssif.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ssif.Interf= aceState =3D=3D IpmiInterfaceInitError) { @@ -669,12 +667,11 @@ InitializeI= pmiKcsPhysicalLayer ( &mIpmiInstance->IpmiTr= ansport2.Interface.Ssif.SsifInterfaceApiGuid ); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.Interf= aceState =3D=3D IpmiInterfaceInitError) { @@ -683,9 +680,8 @@ InitializeIpm= iKcsPhysicalLayer ( &mIpmiInstance->IpmiTr= ansport2.Interface.Ipmb.IpmbInterfaceApiGuid ); } - - break; - } + } + break; =20 default: break; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Pei/PeiGenericIpmi.c index 1d8266a0b1..ebc9e7085d 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ +++ PeiGenericIpmi.c @@ -343,8 +343,8 @@ PeiInitializeIpmiKcsPhysicalLayer ( // Check interface data initialized successfully else register notify pr= otocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInstan= ce->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2Ppi.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -359,42 +359,38 @@ PeiInitializeIpmiKcsPhy= sicalLayer ( mIpmiInstance->IpmiTransport2Ppi.Interface.KcsInterfaceState= =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Bt.InterfaceState= =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ssif.InterfaceSta= te =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ssif.Inter= faceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D RegisterPpiCallback (PeiServices, &mIpmiInstance->I= pmiTransport2Ppi.Interface.Ssif.SsifInterfaceApiGuid); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ipmb.InterfaceSta= te =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ipmb.Inter= faceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D RegisterPpiCallback (PeiServices, &mIpmiInstance->I= pmiTransport2Ppi.Interface.Ipmb.IpmbInterfaceApiGuid); } - - break; - } + } + break; =20 default: break; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Smm/SmmGenericIpmi.c index 350d6afef5..2349373317 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/Smm= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/ +++ SmmGenericIpmi.c @@ -210,7 +210,7 @@ SmmNotifyCallback ( &mIpmiInstance->IpmiTrans= port2 ); } - + ASSERT_EFI_ERROR (Status); return EFI_SUCCESS; } =20 @@ -335,8 +335,8 @@ Returns: // Check interface data initialized successfully else register notify = protocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInst= ance->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -351,42 +351,38 @@ Returns: mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Bt.InterfaceState = =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ssif.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ssif.Interf= aceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D SmmRegisterProtocolCallback (&mIpmiInstance->Ipmi= Transport2.Interface.Ssif.SsifInterfaceApiGuid); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.Interf= aceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D SmmRegisterProtocolCallback (&mIpmiInstance->Ipmi= Transport2.Interface.Ipmb.IpmbInterfaceApiGuid); } - - break; - } + } + break; =20 default: break; -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108857): https://edk2.groups.io/g/devel/message/108857 Mute This Topic: https://groups.io/mt/101185487/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-