public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
@ 2022-11-17  8:39 Chen, Gang C
  2022-11-17  9:31 ` Yao, Jiewen
  0 siblings, 1 reply; 5+ messages in thread
From: Chen, Gang C @ 2022-11-17  8:39 UTC (permalink / raw)
  To: devel; +Cc: jiewen.yao, jian.j.wang, Gang Chen

Upgrade openssl to 1.1.1s.

Pick up bugfixes from the latest openssl release, which include
some GCC build warnings cleaning up.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Signed-off-by: Gang Chen <gang.c.chen@intel.com>
---
 CryptoPkg/Library/OpensslLib/openssl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl
index d82e959e62..129058165d 160000
--- a/CryptoPkg/Library/OpensslLib/openssl
+++ b/CryptoPkg/Library/OpensslLib/openssl
@@ -1 +1 @@
-Subproject commit d82e959e621a3d597f1e0d50ff8c2d8b96915fd7
+Subproject commit 129058165d195e43a0ad10111b0c2e29bdf65980
-- 
2.38.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
  2022-11-17  8:39 [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s Chen, Gang C
@ 2022-11-17  9:31 ` Yao, Jiewen
  2022-11-18  8:07   ` Chen, Gang C
  0 siblings, 1 reply; 5+ messages in thread
From: Yao, Jiewen @ 2022-11-17  9:31 UTC (permalink / raw)
  To: Chen, Gang C, devel@edk2.groups.io; +Cc: Wang, Jian J, Yao, Jiewen

Hi
Have you run the tiano CI ?

Would you please share the size data before and after?

Thank you
Yao, Jiewen

> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Thursday, November 17, 2022 4:40 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com>
> Subject: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
> 
> Upgrade openssl to 1.1.1s.
> 
> Pick up bugfixes from the latest openssl release, which include
> some GCC build warnings cleaning up.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> ---
>  CryptoPkg/Library/OpensslLib/openssl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/openssl
> b/CryptoPkg/Library/OpensslLib/openssl
> index d82e959e62..129058165d 160000
> --- a/CryptoPkg/Library/OpensslLib/openssl
> +++ b/CryptoPkg/Library/OpensslLib/openssl
> @@ -1 +1 @@
> -Subproject commit d82e959e621a3d597f1e0d50ff8c2d8b96915fd7
> +Subproject commit 129058165d195e43a0ad10111b0c2e29bdf65980
> --
> 2.38.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
  2022-11-17  9:31 ` Yao, Jiewen
@ 2022-11-18  8:07   ` Chen, Gang C
  2022-11-18  8:10     ` Yao, Jiewen
       [not found]     ` <17289F83EB119B25.25323@groups.io>
  0 siblings, 2 replies; 5+ messages in thread
From: Chen, Gang C @ 2022-11-18  8:07 UTC (permalink / raw)
  To: Yao, Jiewen, devel@edk2.groups.io; +Cc: Wang, Jian J

Hi Jiewen,

Thanks for your review. 

Yes, I did finish the tiano CI: https://github.com/tianocore/edk2/pull/3648. 

Regarding the size, I'm not sure which lib you'd like to know. So I list the 3 CryptLib size here(compiler: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0):

	PeiCryptLib.lib		BaseCryptLib.lib		SmmCryptLib.lib
1.1.1n	 645426			973132			908298
1.1.1s     645402		973140			908298

Thanks.

Best Regards
Gang

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@intel.com> 
Sent: Thursday, November 17, 2022 5:32 PM
To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: RE: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s

Hi
Have you run the tiano CI ?

Would you please share the size data before and after?

Thank you
Yao, Jiewen

> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Thursday, November 17, 2022 4:40 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J 
> <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com>
> Subject: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
> 
> Upgrade openssl to 1.1.1s.
> 
> Pick up bugfixes from the latest openssl release, which include some 
> GCC build warnings cleaning up.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> ---
>  CryptoPkg/Library/OpensslLib/openssl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/openssl
> b/CryptoPkg/Library/OpensslLib/openssl
> index d82e959e62..129058165d 160000
> --- a/CryptoPkg/Library/OpensslLib/openssl
> +++ b/CryptoPkg/Library/OpensslLib/openssl
> @@ -1 +1 @@
> -Subproject commit d82e959e621a3d597f1e0d50ff8c2d8b96915fd7
> +Subproject commit 129058165d195e43a0ad10111b0c2e29bdf65980
> --
> 2.38.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
  2022-11-18  8:07   ` Chen, Gang C
@ 2022-11-18  8:10     ` Yao, Jiewen
       [not found]     ` <17289F83EB119B25.25323@groups.io>
  1 sibling, 0 replies; 5+ messages in thread
From: Yao, Jiewen @ 2022-11-18  8:10 UTC (permalink / raw)
  To: Chen, Gang C, devel@edk2.groups.io; +Cc: Wang, Jian J

Sounds good. No size different is good news.

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

We are in hard-freeze now. This will be merged after freeze.

Thank you
Yao Jiewen

> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Friday, November 18, 2022 4:08 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>
> Subject: RE: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
> 
> Hi Jiewen,
> 
> Thanks for your review.
> 
> Yes, I did finish the tiano CI: https://github.com/tianocore/edk2/pull/3648.
> 
> Regarding the size, I'm not sure which lib you'd like to know. So I list the 3
> CryptLib size here(compiler: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0):
> 
> 	PeiCryptLib.lib		BaseCryptLib.lib
> 	SmmCryptLib.lib
> 1.1.1n	 645426			973132
> 	908298
> 1.1.1s     645402		973140			908298
> 
> Thanks.
> 
> Best Regards
> Gang
> 
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Thursday, November 17, 2022 5:32 PM
> To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>
> Subject: RE: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
> 
> Hi
> Have you run the tiano CI ?
> 
> Would you please share the size data before and after?
> 
> Thank you
> Yao, Jiewen
> 
> > -----Original Message-----
> > From: Chen, Gang C <gang.c.chen@intel.com>
> > Sent: Thursday, November 17, 2022 4:40 PM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com>
> > Subject: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
> >
> > Upgrade openssl to 1.1.1s.
> >
> > Pick up bugfixes from the latest openssl release, which include some
> > GCC build warnings cleaning up.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> > ---
> >  CryptoPkg/Library/OpensslLib/openssl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/OpensslLib/openssl
> > b/CryptoPkg/Library/OpensslLib/openssl
> > index d82e959e62..129058165d 160000
> > --- a/CryptoPkg/Library/OpensslLib/openssl
> > +++ b/CryptoPkg/Library/OpensslLib/openssl
> > @@ -1 +1 @@
> > -Subproject commit d82e959e621a3d597f1e0d50ff8c2d8b96915fd7
> > +Subproject commit 129058165d195e43a0ad10111b0c2e29bdf65980
> > --
> > 2.38.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
       [not found]     ` <17289F83EB119B25.25323@groups.io>
@ 2022-12-01  9:31       ` Yao, Jiewen
  0 siblings, 0 replies; 5+ messages in thread
From: Yao, Jiewen @ 2022-12-01  9:31 UTC (permalink / raw)
  To: devel@edk2.groups.io, Yao, Jiewen, Chen, Gang C; +Cc: Wang, Jian J

Merged https://github.com/tianocore/edk2/pull/3690

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Friday, November 18, 2022 4:11 PM
> To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL
> to 1.1.1s
> 
> Sounds good. No size different is good news.
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> We are in hard-freeze now. This will be merged after freeze.
> 
> Thank you
> Yao Jiewen
> 
> > -----Original Message-----
> > From: Chen, Gang C <gang.c.chen@intel.com>
> > Sent: Friday, November 18, 2022 4:08 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>
> > Subject: RE: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
> >
> > Hi Jiewen,
> >
> > Thanks for your review.
> >
> > Yes, I did finish the tiano CI:
> https://github.com/tianocore/edk2/pull/3648.
> >
> > Regarding the size, I'm not sure which lib you'd like to know. So I list the 3
> > CryptLib size here(compiler: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0):
> >
> > 	PeiCryptLib.lib		BaseCryptLib.lib
> > 	SmmCryptLib.lib
> > 1.1.1n	 645426			973132
> > 	908298
> > 1.1.1s     645402		973140			908298
> >
> > Thanks.
> >
> > Best Regards
> > Gang
> >
> > -----Original Message-----
> > From: Yao, Jiewen <jiewen.yao@intel.com>
> > Sent: Thursday, November 17, 2022 5:32 PM
> > To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>
> > Subject: RE: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
> >
> > Hi
> > Have you run the tiano CI ?
> >
> > Would you please share the size data before and after?
> >
> > Thank you
> > Yao, Jiewen
> >
> > > -----Original Message-----
> > > From: Chen, Gang C <gang.c.chen@intel.com>
> > > Sent: Thursday, November 17, 2022 4:40 PM
> > > To: devel@edk2.groups.io
> > > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> > > <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com>
> > > Subject: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s
> > >
> > > Upgrade openssl to 1.1.1s.
> > >
> > > Pick up bugfixes from the latest openssl release, which include some
> > > GCC build warnings cleaning up.
> > >
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> > > ---
> > >  CryptoPkg/Library/OpensslLib/openssl | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/CryptoPkg/Library/OpensslLib/openssl
> > > b/CryptoPkg/Library/OpensslLib/openssl
> > > index d82e959e62..129058165d 160000
> > > --- a/CryptoPkg/Library/OpensslLib/openssl
> > > +++ b/CryptoPkg/Library/OpensslLib/openssl
> > > @@ -1 +1 @@
> > > -Subproject commit d82e959e621a3d597f1e0d50ff8c2d8b96915fd7
> > > +Subproject commit 129058165d195e43a0ad10111b0c2e29bdf65980
> > > --
> > > 2.38.0
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-12-01  9:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-17  8:39 [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s Chen, Gang C
2022-11-17  9:31 ` Yao, Jiewen
2022-11-18  8:07   ` Chen, Gang C
2022-11-18  8:10     ` Yao, Jiewen
     [not found]     ` <17289F83EB119B25.25323@groups.io>
2022-12-01  9:31       ` [edk2-devel] " Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox