Re: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Xu, Min M <min.m.xu@intel.com>
> Sent: Sunday, June 5, 2022 9:03 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Aktas, Erdem
> <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Tom
> Lendacky <thomas.lendacky@amd.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx
> 
> SecTpmMeasurementLibTdx is an instance of TpmMeasurement lib in SEC phase.
> It provides RTMR based measurement functions for Intel Tdx guest.
> 
> Commit a708536dce introduces SecMeasurementLibTdx which provides the
> same
> functions. But it is not an instance of TpmMeasurementLib.
> We have updated DxeTpmMeasurementLib (which is an instance of
> TpmMeasurementLib) to support RTMR based measurement. To make the
> design
> consistent, SecTpmMeasurementLibTdx is introduced. After that
> SecMeasurementLibTdx is removed.
> 
> Patch #1:
>  Introduce SecMeasurementLibTdx
> Patch #2:
>  Update OvmfPkg to support MeasureHobList/MeasureFvImage with
>  SecMeasurementLibTdx.
> Patch #3:
>  Remove SecMeasurementLibTdx.
> 
> Code: https://github.com/mxu9/edk2/tree/secMeasurementLib.v1
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> 
> Min M Xu (3):
>   Security: Add SecTpmMeasurementLibTdx
>   OvmfPkg: Implement MeasureHobList/MeasureFvImage
>   OvmfPkg: Delete SecMeasurementLibTdx
> 
>  OvmfPkg/Include/Library/SecMeasurementLib.h   |  46 ---
>  OvmfPkg/IntelTdx/IntelTdxX64.dsc              |   2 +-
>  OvmfPkg/Library/PeilessStartupLib/IntelTdx.c  | 186 ++++++++++
>  .../PeilessStartupLib/PeilessStartup.c        |   1 -
>  .../PeilessStartupInternal.h                  |  36 ++
>  .../PeilessStartupLib/PeilessStartupLib.inf   |   2 +-
>  .../SecMeasurementLib/SecMeasurementLibTdx.c  | 340 ------------------
>  .../SecMeasurementLibTdx.inf                  |  30 --
>  OvmfPkg/OvmfPkg.dec                           |   4 -
>  .../SecTpmMeasurementLibTdx.c                 | 176 +++++++++
>  .../SecTpmMeasurementLibTdx.inf               |  34 ++
>  SecurityPkg/SecurityPkg.dsc                   |   2 +
>  12 files changed, 436 insertions(+), 423 deletions(-)
>  delete mode 100644 OvmfPkg/Include/Library/SecMeasurementLib.h
>  delete mode 100644
> OvmfPkg/Library/SecMeasurementLib/SecMeasurementLibTdx.c
>  delete mode 100644
> OvmfPkg/Library/SecMeasurementLib/SecMeasurementLibTdx.inf
>  create mode 100644
> SecurityPkg/Library/SecTpmMeasurementLib/SecTpmMeasurementLibTdx.c
>  create mode 100644
> SecurityPkg/Library/SecTpmMeasurementLib/SecTpmMeasurementLibTdx.inf
> 
> --
> 2.29.2.windows.2