From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.16870.1654394997813689974 for ; Sat, 04 Jun 2022 19:09:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=kJK7M04q; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654394997; x=1685930997; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VZoC2xeM68/vyVmrkXqTiM7I8dNm4eUg5jaj1HHlhlE=; b=kJK7M04qv4YssLORH1/KZKQam+ZRphYNIrcm9tR2GOOH6HUOd5OzKybs PZmS+YOwBYU6aumfo4tvC6UQFsCRe06REF+RbC5kiIWaQ736ftx/kz+/j CQZUMF3i8DVwjp4KBZIBlEzCfdVcbXMkLBI55bisn+SK9/H3J+QP4gUXI 0qsOGZ0vKs9OFDJPj74RsQZcroUgDI9eN5+tuQyxHGKwKYR+r6qti8Mz4 rUpr8au/7dFGgmp44FZ7FmHaR7hgXPYSRVKDR47hsZK477uOJDkHyoWmn 9RVT9+TkYx92AwMiQl8X1HyluXSQQ4S6b7mEZmY/NzS96M6AyjMdXZ4iT Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10368"; a="276545403" X-IronPort-AV: E=Sophos;i="5.91,278,1647327600"; d="scan'208";a="276545403" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2022 19:09:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,278,1647327600"; d="scan'208";a="608055171" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 04 Jun 2022 19:09:55 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 4 Jun 2022 19:09:55 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 4 Jun 2022 19:09:55 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sat, 4 Jun 2022 19:09:55 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sat, 4 Jun 2022 19:09:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GL/0OhAj5EadmgcjNHMN7TmhRgv1hwXvojOBITU3MjwvpqgMQOFJKDo5+QaEc/5ejSh8QZtspY4eYn7GqvogB72QKfIuN0fv4yuVxAxrokAyZ6LI5oERCT2xL5eWrk88Mtze+nFycbOSuUuJQkxa36ojOKcJxxKNaIyXUCduWqORGGuKthegB8kxr0dyEcexz/QgNX4FEf+2SnxHCdnkyzmtdiL8Jf8svNckKUBJJgvzGtmYjOHG0fwnCoFITHtFBY4Ko8b5LZ+aTFQwHNk6aV27421SfikiIEmZ1GYFlKdXNiW6OQX9OZjryWxAzqw2sf/qTD5KobxbnJFhRVyoXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PJFxnxzUv0bZgWAklXPb/HJaa5HXiiD/qTWPUCYgIrA=; b=YTMgy/hNikY5x7sbkpwZDWoReEzfFk+QfyRIwhgx50nKNquq1ZfXt0PewrdOrssGqA7cxADZUrRmiPT8u0kyYKrIQoA+nfxECG5ILVAKccjsSrp89wBJ/znT8wYDi+x7DzbMtA4Ib1qfMWNy4I0HEdvweVyauHLVsMHNYzjWK10rIP+e7wxkLFH2rcGadvPxc1w0yZP/ZQSjHr+ErRocoZ03wUUGuF+Ag9cjc6dlve4K06ZbJbVzKwtaZ0wXvX/r9EPAaMPTU/DVvSYKPa47a3OZ2IYdL71N6L4t0AO6ceGHasCxhEqUC8B9PTOdsMha8iM7h3h9hJcYoZbDXal0vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SN6PR11MB3469.namprd11.prod.outlook.com (2603:10b6:805:bf::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Sun, 5 Jun 2022 02:09:50 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e%5]) with mapi id 15.20.5314.017; Sun, 5 Jun 2022 02:09:50 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Aktas, Erdem" , James Bottomley , Tom Lendacky , Gerd Hoffmann Subject: Re: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx Thread-Topic: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx Thread-Index: AQHYeHgEaWeph+dVlU+NIGI+XLaRZq1AEaTA Date: Sun, 5 Jun 2022 02:09:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8986142a-2564-42b5-eaad-08da469878b9 x-ms-traffictypediagnostic: SN6PR11MB3469:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vOSSY9/YG1jFFt5UdFyHSziMJ2J0VXrnR7NcmEFAWqU/Xh2+xcl4L7zzS1OnQDE4oUqhenY9l9MMlYShiv/OdiE7k3Y1wCPjinaRuqcii9gBBNqUc956Z73Q/2n31jmCLRlVJnB9Y+0T6LwnHBz++5dETpbvvpGOob2SOajUG3Fy5UQAmkwUOhbmi9h9KKCBS0AZ40Nun7e+Dmd8bzCQQoDeaoIu0l/EoxD1CNUcVg+PlPhyk5B1qrRV/bHyPLUIT3GB6Hc/dcZw+3+sLLKULe0ZPJeKEoJUkWGyt/a2r++rIJ8Q5NBDXHt25fH3oIe7BxUPsO8gaFINK4fkFKO9jSY0VvM2pCMfCQrhZ+MJOMwSrGSL4muk75j8FNuB/+XGCVVIafhZz6EwrVX/wjsol5uU1jb707OaKnY+XnPrBHfXBY5kuCew+6uKybQq5S14B32ZPTHSQwJGj7GVhBWtUQpEGdoV+V+Q3OhufOMYKU7e47RKizxr8DB90boYB6RO5ATj6G8YtgGgirA/q3AJUILJpq76/J2PahfHqj06VnvpW0Dr6Bxb2i1LlpSLlDFTCm+4g/xHZz+LoaNje3myvgwlah6HsxWbjrUj3c9ODROPy3K5TIzjs0bf3nDqqR6UlUQMwT95ETkpQSgKy9Ffduq5PuamMZEqCkIIp8sJuQilpc+UIXRCCs9P83xYZNE+6XxEPVZzpSTOuw986ZcDZuoZ0WL64lSWsn/D1Q0kCbEmyJgqlPQK7kwcfHbIE2GlA4yWz3EKqZSs41A/kzKnTlLyo8BscXU3H8v6AfISTGJKj343HVUd7e8lGKLCPx0l x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(66556008)(2906002)(966005)(86362001)(38070700005)(66476007)(66446008)(316002)(110136005)(53546011)(66946007)(83380400001)(6506007)(26005)(9686003)(64756008)(76116006)(33656002)(19627235002)(38100700002)(4326008)(122000001)(8676002)(5660300002)(55016003)(7696005)(82960400001)(71200400001)(508600001)(52536014)(8936002)(186003)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M+D8sC4jBwWfppY56f00Bj/z0mC5Tv1ItAi1JLlZKG0EO7s115C8GdhY4HzF?= =?us-ascii?Q?eZIhshUY1CHyQtA5IrbhSxhAB9eiCMZ8BaJQD7nRISwvZ/oBCTeuakqB9m4c?= =?us-ascii?Q?uqUHLvDuBvg51142zzNQ31K/fyhnc6wzsW7RcuM2zvU4OX6+3QFcKtbHfpIN?= =?us-ascii?Q?DTjOJ/dHePFV0GXppE9at+yHHj7WH6G/hM+2nQ5j8Z8ITJOt6v8kDqL/MzOJ?= =?us-ascii?Q?IpkCN4I01kwImZJBaHKSBxEX+8wAjRPqJwdu+YW8qGhfD/cHVmev5LBLZ2id?= =?us-ascii?Q?i7QWbtbnzDfsg925tMbhFp49874XZTCSHxPDQ9ddq/xO8kSKWmyD03cUQtMT?= =?us-ascii?Q?f+rTAZfusLaEtcykLZBls7IUGRaJb7llAdhGwvq7kK42G2NEDFIKC/49MnP/?= =?us-ascii?Q?N6BJnnziXYCjUXgtMLqjoYozBt/f5+1XD7Xmy5CvJ6gWsp6RqVXSASowoTu/?= =?us-ascii?Q?B7jbJaT3gFxPL5XR7kJhc3FNtgMVtivVx5VUuT7Kd6VzCjHfIA1D49I+UwLP?= =?us-ascii?Q?2wwST8Hv5FdWVoK8NKHoJOVzx7osGPQ8avoqZgahYhgY1I/ihgXKWFtNkRGd?= =?us-ascii?Q?pnEkz1OfhncasOVBSm7r4TsBoHhO1RnVWNjSIkEcaV8kxDN/kkU+q1XT5nDs?= =?us-ascii?Q?zDKyBmhJ40hNJkvphrSGNQUCTD72rxjrrEW0U5vb3r2yIUqPYcRMYEIfheH6?= =?us-ascii?Q?uz2g3bT1qmY5l4cJkomhij8Km+uJNJEOllj47fP5DFsniRtoPWQUH0rOFCSt?= =?us-ascii?Q?GyU5cbXucMAwOlt3oObDM7ye7pwXwbemGzwAWPQtm6/zNE+b2ppQtNLN88ff?= =?us-ascii?Q?L8hMSuQeb80HClGqwIRcW9oGpHQn86jahcUMxmgIaJ9CCJMSH/nDidQA8ujf?= =?us-ascii?Q?6KNC9C3gPoHXc/NxchrQFypbv76NUlRa0fUNubtWKwwgzo6G0IWQ+tUhLhi6?= =?us-ascii?Q?bTi2CRX+BIr3oV4DEPGrD2byaobRXFtw2EjeLJ5JL+Aa4Iy42XwGUEBbkLnf?= =?us-ascii?Q?B7LHiHLVk6fJDyBpsGf+cvseUWvVVUB3ho/czAYRsiiKg1qWrhCIQ990AgHC?= =?us-ascii?Q?6eEIZmxT/LEyhY2Jpp5hWIHo1XTZqG0lD7cnGPiBYmvvPmH9ujwOb7GV2pw/?= =?us-ascii?Q?KxkJBTK/7iONiy2v9guTwRHBeqDOHhUVQDsv7K8+8YpcLNUqtOQc8YD3HpWA?= =?us-ascii?Q?6Fv8JB/UjCbL9ByWdlFpOEPhDVP1xPwN+zMjEE8ZJU7SELzv4yo6x6yjhj5P?= =?us-ascii?Q?UCaQfbxgFc5ZIXl3p0RzVvMWEYKmXV663/Yiu0uhiflFqSMweXG2rFsssOh0?= =?us-ascii?Q?bXHqPSf4Xn15s0Xr1elFLG5wgWB+1dlA/ycy/QNRt/Pg328PPjjthQ6oKlEM?= =?us-ascii?Q?eYBR001oOMhatRqem5IisnxbhehZ5dFoJBctXHDT6ckQ41g7Fe0NY5xfu8Rs?= =?us-ascii?Q?5nXXHt/g5jwhwyIaYzu4hBV8tP3P6B2v6Lztw/FQEVYTO8laWOwcTRoyfI22?= =?us-ascii?Q?kHOCy52IGEbPtiEW938enYQcEaZgwQMrl4SgC0znJ+V9n4Ab6e2PB3sHJADA?= =?us-ascii?Q?22F0Bdx5l1XFpQtni1fW15+mEiKfmE8KHPFuK8REMD+ghVv7p2PCBe0tgJ9y?= =?us-ascii?Q?xfCxooei8K7y4fKFRoXuY+xG1RHGmFUXnTj/5JhtlJhfgkwRJZELFyh6qqAk?= =?us-ascii?Q?5TCDZwsCC2VpP4i0KZt3wQDi2BH9OvUUTonfEl/m5ukHOI1yDkmgCS5eNLkw?= =?us-ascii?Q?IaXQbVIpmw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8986142a-2564-42b5-eaad-08da469878b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2022 02:09:50.0457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pCDfV1n82s1RPZVZ6z7piHR1L//GRMj6fF7Mz2Z9EsTpNWklWSG1UDHWgyTfJZM48bZDSV9Kh15u4RcmBMLDcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3469 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Xu, Min M > Sent: Sunday, June 5, 2022 9:03 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Yao, Jiewen ; > Wang, Jian J ; Aktas, Erdem > ; James Bottomley ; Tom > Lendacky ; Gerd Hoffmann > Subject: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx >=20 > SecTpmMeasurementLibTdx is an instance of TpmMeasurement lib in SEC phase= . > It provides RTMR based measurement functions for Intel Tdx guest. >=20 > Commit a708536dce introduces SecMeasurementLibTdx which provides the > same > functions. But it is not an instance of TpmMeasurementLib. > We have updated DxeTpmMeasurementLib (which is an instance of > TpmMeasurementLib) to support RTMR based measurement. To make the > design > consistent, SecTpmMeasurementLibTdx is introduced. After that > SecMeasurementLibTdx is removed. >=20 > Patch #1: > Introduce SecMeasurementLibTdx > Patch #2: > Update OvmfPkg to support MeasureHobList/MeasureFvImage with > SecMeasurementLibTdx. > Patch #3: > Remove SecMeasurementLibTdx. >=20 > Code: https://github.com/mxu9/edk2/tree/secMeasurementLib.v1 >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Signed-off-by: Min Xu >=20 > Min M Xu (3): > Security: Add SecTpmMeasurementLibTdx > OvmfPkg: Implement MeasureHobList/MeasureFvImage > OvmfPkg: Delete SecMeasurementLibTdx >=20 > OvmfPkg/Include/Library/SecMeasurementLib.h | 46 --- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > OvmfPkg/Library/PeilessStartupLib/IntelTdx.c | 186 ++++++++++ > .../PeilessStartupLib/PeilessStartup.c | 1 - > .../PeilessStartupInternal.h | 36 ++ > .../PeilessStartupLib/PeilessStartupLib.inf | 2 +- > .../SecMeasurementLib/SecMeasurementLibTdx.c | 340 ------------------ > .../SecMeasurementLibTdx.inf | 30 -- > OvmfPkg/OvmfPkg.dec | 4 - > .../SecTpmMeasurementLibTdx.c | 176 +++++++++ > .../SecTpmMeasurementLibTdx.inf | 34 ++ > SecurityPkg/SecurityPkg.dsc | 2 + > 12 files changed, 436 insertions(+), 423 deletions(-) > delete mode 100644 OvmfPkg/Include/Library/SecMeasurementLib.h > delete mode 100644 > OvmfPkg/Library/SecMeasurementLib/SecMeasurementLibTdx.c > delete mode 100644 > OvmfPkg/Library/SecMeasurementLib/SecMeasurementLibTdx.inf > create mode 100644 > SecurityPkg/Library/SecTpmMeasurementLib/SecTpmMeasurementLibTdx.c > create mode 100644 > SecurityPkg/Library/SecTpmMeasurementLib/SecTpmMeasurementLibTdx.inf >=20 > -- > 2.29.2.windows.2