From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.6770.1664247636909049952 for ; Mon, 26 Sep 2022 20:00:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TivJ5cii; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664247635; x=1695783635; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xnUecoCgg//j4hG2VNJX4xLPDQtX3XGMAQqiMVac/Pw=; b=TivJ5cii30MEjfyAtM31mLiCHyDzYdFLJtLS96l72LAC34okVKjdzJnV 8LBjV45CkTSq+1Re16beKF6bflQYwEsjS7wnZvCi62ojmKRJIurIOwSI7 bgON/Vmvgm9DboXEOQ62ql/XX2Al57vqchNEXEJAYVrKtFclsGmv/+eGg YiS/vSAgZGXOY7OQPKJMLHDe7itdNHADl9QRk146DGQ+MT6IvG3DCMEGi WmSmYifJAOiyPjnHpIMF7Or5SMoMKi2t8BgLNtcFI2RExhJINZYiGfX7H I16ly3W5SpNtQWEolwiaYSFNMxitoLHmM4lkHIfm3GFWUH1zn/ugKg4hc g==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="365236218" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="365236218" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2022 20:00:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="616660996" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="616660996" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 26 Sep 2022 20:00:36 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 20:00:35 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 20:00:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 26 Sep 2022 20:00:35 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 26 Sep 2022 20:00:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mU74ONQwgPy2bMZylbR/d2RaKSERh96wBXdnPczxpljeSWIvWpYrocCRtsxQW94wcCYggVbaTndCO+mHxBIyjXokFmAzXc/fo+h5xrgYUDHaQxevsJrmFW8SkfaBHUzWcxl5hbY+nAC72ix/ySBCRGcxxFX5eMrYA7mkFe6H0Cs54Jp5n/X7cliG46yIiZByK8cNVSkK7slEcwTUuP6gzEux5B9PH3GKRS2sr/5u0h8BdQe6ETuAfGJVx7HkXPy0AsiYz6FLIS74IaNnRYBzarxviPTQed63D/x2EME/rheE4l8i5cnoXKvH9A/Ru0nWtEWkAYSFD+4q1IAOXVzX8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Z4MZ6FXveQlLsu2hrO5dCC9TJXTltvwvTLN1xalCWw=; b=eqHT5cpcdRaSF3FCvK23kZdWCNjceYUOlOXDkG2qHTHIa5iNFypcZ4RbqLvNJeVWgR8dbGsNLHMmr3zZq3pbeC1xszNNunX9HhpCQFsC5upMZcMZ7/tqXELSOCmFR38s/PGvfMILNsFsPBK3w04bS3WvtuH8EYkrkBu0o/pM/RqZx00eAu7q9Hfl9lEK7WKJxgfBHnjLtTSqtmTqU2OGDAKRTfKjAENVn7FIOiF0zhI2fSep2wY0PWoXha7yYzDUWJFNYUvvVPfvbjvVxJ3RqLj8PAlMrdeuhx4ImY9lOXAzP8M60Nigwr3SAfjji7o8nhYIESn8vZj0ERoc0Eregg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM6PR11MB4673.namprd11.prod.outlook.com (2603:10b6:5:2a4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 03:00:33 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 03:00:33 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "Xu, Min M" CC: "devel@edk2.groups.io" , "Aktas, Erdem" , James Bottomley , Tom Lendacky Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea Thread-Index: AQHYwmAfAYrKTBs41EOjLRAjuKpiO63q9pIAgAGjhACABhtEgA== Date: Tue, 27 Sep 2022 03:00:33 +0000 Message-ID: References: <1712727D109677C5.26635@groups.io> <20220923054334.lra4csta2haobx7y@sirius.home.kraxel.org> In-Reply-To: <20220923054334.lra4csta2haobx7y@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DM6PR11MB4673:EE_ x-ms-office365-filtering-correlation-id: 78dc8065-69f1-43e8-7b80-08daa03471d9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZhhOJ9/2/W7h/CGu6DQIUIroSM5KB2FNWoT2pG9QW4arw3SbZIJhYNNItDahd+xo+NjNqw5jBjMIhTuLB1xZ4wAVISov1zq6tIdKkbbQPMDOPisxeBdc6tI9Qz0FJPKNKf6PgEgZSU+MS1A44Otbf0tXnfmc9jDWN0PMya6p1oH3aH3zKB2zt7Fr6JhEEMg2P5WnvNvsW9iSchguhNCakE82KPmhGYlwpn0K+h6eupNMshjozxEAqA0PlGmOtNITFnO9YPEurTjBTqMKsJJ23KRDjZDJkIBRjuLWxmAYYKxWMw2jn+QO2Y4YwxpnTM/nYf+CR8XT+PdPM5ASlP2qR01wUIiPmscrcTRmlGzc4Ni6886uOaApEnpJQ9V7uBRIUmqj0eEFbd9htrsou6HDw5hoOGgYXUPoORkq0RcRPTi2Rgd12Ot2iqZGYBIerOBJYIw/hBl6ygSbOzBtoQ/WMG/tc+9XT8ddBeDYuiG/pZeREKs1Kjojt8M6sBoAis6Ycar04a0YXCxDPFUpKuunUpax5wf3LR32dqJ8lgWEiib0ysgL5GMMnJLv3cSzIQnKwyrua6BVQpzZhltgGbrIPh3Y6xkeSJwpuXCkzUqgoFUiZwzRX40XV9AKUuqKa80LAu7NMqJfzFzygyThL0irP7hlLUlUV/bfqPG9hcy7NDvLkYaEA6gRzwtACJjVGMEqsTwhoGpIRXQuYsnSXYXbBppeUuWPGAs91y40q3keCjlbuso0Kr1+s0myxEHA+8odDcDphw7Dp+2xAZCwMK61qw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(136003)(346002)(39860400002)(451199015)(316002)(6636002)(478600001)(66446008)(8936002)(9686003)(52536014)(41300700001)(110136005)(54906003)(53546011)(71200400001)(7696005)(6506007)(2906002)(26005)(5660300002)(64756008)(38070700005)(33656002)(38100700002)(82960400001)(83380400001)(186003)(76116006)(4326008)(66476007)(66556008)(8676002)(66946007)(122000001)(86362001)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?arhygWq6Lkv6Ob0mwpQ/Os7KRFMO+oHnLYBr7ZaG3JoGl9Dci+zbKIKO6+t/?= =?us-ascii?Q?w6Dqv5Mr0VH4EYZ3mA8JLQtWJsubhcDj/5J+rhCqHlYdBzFy1FKpNGWJMHrA?= =?us-ascii?Q?5crE+6j7ITAeLmwS/44/Z5FogWLDULyhVd+QpNczvFzijXyd+rB7ozi5PZOn?= =?us-ascii?Q?vkghDqlFeapx5VCjnoagk8/A2/zCX51WJ4/DSmRvhg8BxAtGUI4SoTAv5u3u?= =?us-ascii?Q?hN2Kj+sW2kKK66FWqDlRethBlKRvPFiZt4jD9K6H8ILAs4YBNdz1BboTth1C?= =?us-ascii?Q?heGQn9FSnt0GLdQx1QVwoZqxPA2QuA/487Y0AGrW3vfHcqqhJ/Epsk9svc6q?= =?us-ascii?Q?0YnNzhBOY0xdqDOkeGlO9nzlkWf/v5QdzKndutgmv39WeEFak2j7wu8V6yRd?= =?us-ascii?Q?mqPvEOqhFIDBJwdd5SEK+22DLfCoBb0UFR9iYF/rRS6B4VIalFUVFT1YyjRU?= =?us-ascii?Q?JAyrkYLdKLhtt+SI2x/KmEAmpLBiQiweowo9q68qyPWXGUw5/hnQRlqM0Lr3?= =?us-ascii?Q?w3KBc+4AUih1fP0G3ujvwgPxc02wSXjGLnKbC6zrfSZOHCPb5uABWJDe3fyA?= =?us-ascii?Q?FookpXyEtwx840Du65d5MDd3tF3vyBmjZ8SmTc3OoHKFpoAb7n9N0pDFIoFw?= =?us-ascii?Q?o03VIjoo+eLd0HoJDPwl83+oaW+m+qcJP4jNS0qx7Dby8W3qwidlU+Jqpu9n?= =?us-ascii?Q?BUaYNUpKMHt2WJNFeSadnVXcWMeQxJ0FYvtiCbFOWWwI5a97s0RfYCvg2UNC?= =?us-ascii?Q?iHw8DscqeXHDgzrhudVM+ICl2Xo4OMw61D9co6GYkbuNdxTVWMILSvpI5kTt?= =?us-ascii?Q?CrmS1rD8Z+E/Mcco78mUxu1y2FTdY7r877N74vmm/o7E8Nv8akJqeQoCTWg0?= =?us-ascii?Q?JhxwQPhVOT1WVPcKxsmhc0u52mJuDo5LMPxwPLw4JiI0afd3RX0Fjm79YLmD?= =?us-ascii?Q?euSVZsdDM6ZXnqc+EYAg0S81EMn6Mz4pgyotuUZncY5K2iLd9WmiAq772ydX?= =?us-ascii?Q?4ncR1mkaB1ZE+Ibo2rMAurvofxyqVXDqsss9rXgTT1wQkd9ak3Yb6opHc9wY?= =?us-ascii?Q?qMpzW4+j5JFXdDAZ5Frign91Atohvs3E9Y6wLxF0jRC+tN/9tUupfI2uUBxd?= =?us-ascii?Q?xidZZ0+CZVx2EqkIL0OBj1h7L1TwSmfaCFnLZ8Wz4C26Ks9r6iTYi4sUriAx?= =?us-ascii?Q?HzyjgAFuDUureBzXiJ5/fPTooLbaQGrlQMrwbfUceBmnuNw+WIw1sNxZ4fdH?= =?us-ascii?Q?1yM7SCzkHPONXArNe68UIet2h6Wzsf4mybxVCodFzTpb0lPWImL6cwNRxrJ4?= =?us-ascii?Q?KToAP2yeJcdywN7cvMauQobT/1YzSx21Q+91BZCMkfsp2w+Pd/dL/z7nmfll?= =?us-ascii?Q?Ck7r+vy/F7L6218dO3Bs1jMYbU9JCI7aCL19+ZPKFRVp5+A6iEWLk6R/E79L?= =?us-ascii?Q?X6gEjzYjGmYPXdm/RGc9DFcYbhpnPXrDAoKz9f0sWRP4l0RIK9cm7VreIu5S?= =?us-ascii?Q?ezRMjHQt6O/OgIiBOoiv6xRj/XEb8eSfuScMFM0RuGDLNfGTuCmYgvaXDlKA?= =?us-ascii?Q?gGRpJgbnGK5D8b9mvLfGU2oxboJqigE51NV4kQ4I?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78dc8065-69f1-43e8-7b80-08daa03471d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 03:00:33.4855 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ukDECrNdyvxchckzRQA462cung6oRZMbTDhzHxRjXt0IBO4IQl5NXqA2l50Ggh+VqUpwZGV0fFgpNBNFx1doHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4673 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable My feeling is that this mPageTablePool is an driver *internal* data. It is not the best idea to expose an internal data structure to *public* sp= ace. Can we have a way to move mPageTablePool to stack instead of global data ar= ea? such as input as function parameter? Thank you Yao Jiewen > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, September 23, 2022 1:44 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Aktas, Erdem ; > James Bottomley ; Yao, Jiewen > ; Tom Lendacky > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in > TdxWorkArea >=20 > On Thu, Sep 22, 2022 at 04:43:04AM +0000, Xu, Min M wrote: > > Hi, Gerd > > Do you have any comments on this patch? >=20 > Looks ok to me. >=20 > But I'm increasingly wondering whenever it actually was that a smart > move to ditch the PEI phase for the IntelTdx builds. Anything which > can't be handled in DXE must be done in SEC, and the SEC restrictions > seem to be a constant struggle. >=20 > We had that when adding tdx measurement support which required sha* > hash support for SEC. And this looks like another case ... >=20 > take care, > Gerd