From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.14553.1671612369874924218 for ; Wed, 21 Dec 2022 00:46:10 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=bOJg0M7g; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671612369; x=1703148369; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=s4ktJzEelw6T/dgnf3eNj+X55+58tN88uVk7YSUh3W8=; b=bOJg0M7g3AZwTw3/SZd6zcZTX8Mp8ZHB3K+bfs7ledeY9orVYwpqn3/K t3IEV4FvZPuCDBHoisbvHc4FCBE8odbbJ2JtrxPT8XzQFCyGR+aJYQi0V ydl8u6tLXZDOGsCzjpq/RcrPLnJy9N+L3Ix7OMOtKMXVMvuyj4OCsWeKe BtMiLXvR4+YJrmqIGG6HpYHFBsRqLe1DHqZDJ7YLZuB/IDClWYEt1H3UB Q2iA0sqtI9jVg9o1/GK8fpUVzKdS01DBhxmhvdHJFfk0KJGuCXXg46mF5 IoGrQ9JMvj5HZB9no6lRyU52td9zb1a5XiB/xqRf9Q3LJ/DV4GCiRGSxX Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="406060904" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="406060904" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 00:46:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="775606720" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="775606720" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 21 Dec 2022 00:46:09 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 21 Dec 2022 00:46:08 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 21 Dec 2022 00:46:08 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 21 Dec 2022 00:46:08 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 21 Dec 2022 00:46:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b5orcANfaJ+BZxedvzj7ZZCAbkC52WepKo7//LC1U6wtloqewD/zj+FsiPuNBnrq21o3eiPM+nCxyo64uTxg49Wfn1XBo0WuuY1iuweyXYEcaxJ7zzal/t5lnwJMBgtEVxjjm30VzQ8ak/cAZjaQD9Vuklqpm4DnfpbV/t1gx3ktNQM2FNETXylY/D2ILWYqxSp9Mun+iVjTQJZ1Ad0AAAdFou1T8wQz5lPoWP+gnMkPs/e8Asrfxbiy0daG+sekfc+bcH7JjqBW8MwKYPri6NxXVmjrDZXrSKbbJq7Tr1yjaFIy1cz3dvqzFgs5BapsTTSQWPxa2uoFZGhXq6nwTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=97rmSuJ/Yowk0OZDVNV2r+My8SujcyW1G50s8+eaIvU=; b=W2G/fED8wX2uUmLBtXqB+tcUbYagcUfILCnOI0mrlGDqZ1n0KkuYWf6MaWkQKMEr4/mMkCImD0Q6X/D0dzbbr/L9POPpaLRbRiU9DaR97U7CjM5AVB6UZy02x/Fy9Zl72wK+ErELu3Fd9e5JKMVIPlICxghzqIviDwC4NDWoBOxusOMgyLEBh8vNk+f4M1hReHuXGfAopOTfexKZyqZTqy0MgYy1YCgeqGY8Kg+uQPzP8FSLeQM8XIz7epEYqBH71q+agmZqtoBQweQfV0gz7JKBeV/xB5hZ2LzRZ5mjP8gsFQr2DYg+SfG4YLtiB0vdDguKOGtJZp8NQQYvlfkd9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DS7PR11MB6037.namprd11.prod.outlook.com (2603:10b6:8:74::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:46:05 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%8]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 08:46:05 +0000 From: "Yao, Jiewen" To: joeyli , "devel@edk2.groups.io" CC: "Lee, Chun-Yi" , "Xu, Min M" , Gerd Hoffmann , Tom Lendacky , James Bottomley , "Aktas, Erdem" , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases Thread-Topic: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases Thread-Index: AQHZEJbIsLy//RV+80m2n9Ozk9GWPq5xarbQgAT4PwCAAawp8A== Date: Wed, 21 Dec 2022 08:46:04 +0000 Message-ID: References: <20221215142723.9788-1-jlee@suse.com> <20221220070958.GJ11807@linux-l9pv.suse> In-Reply-To: <20221220070958.GJ11807@linux-l9pv.suse> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DS7PR11MB6037:EE_ x-ms-office365-filtering-correlation-id: 8a4a1e9e-51dd-406f-12d2-08dae32fcbef x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gnsSV6QVC8CM/yC/5WtJkZ6hJlCLk6mydHCKhAQJEiNxRAoFdIKa20BH7vL554LcayzuGN3sN9oqJ0EGqh4Qh9rnmIkGfSxOU94IUSGXxLgz/50X1W9HrwLxNR+xRuxrtnEsqaM1mDCzR53nzYfT+VL+Hb5SrJHjPpsqyLTzOj54+/fS8wtYFuLV5ZurwIRB+C/zMhiwuMz8GStVtgOgD4p2NcAQpkyoZSWgFBSQw2bYdTtt6E7+LP3IHEcIn0fo5UVyw6hXPubwfSPMpixF+qC9e0ujZApiMLVvOZWPNBX44dr+31urtxNW7jI3RvNNsKdU6URcyv9rX3VtS0vHKLoXNf3UMN2p2qnwUCyAaz0QIEfStbay7C6XW+2nfY587BUTDag9T+5x7Xv1C+MW96LrHdTyxYkIoXrn7X/58Uz31zZ5a+CJc1zvFYUssNprqgpqlQb11LSDAQL8fVkOhcQdXzjtq1KWURaCvjyaWhcPTiIJzjbpgnm6DNlGjaAkJif5CCSLJDX+XuBnA0n+VtO7CLIMne9pwFRHdNk8jC3ttEMZV4mt5phtW2MINNZv0v36MOGPkXEfAKJ4whUkSVx03ar19B6QC1o96uv/TtufXkvvCK/2miMry8IpdEWRL9ljm/EHOoxi2iJ36Fispktr/T2QF0icbxBBRl9J9jO/rOM/6QIyHaQ0jdKw6/bbNSIAtNQSbU1i12OHdMqGlkxjfwI6Pxyqmqppre+DLhZ4jlIJYnjxVOzUZHXy6iiRv65VA+ivfHOQ550WEFCJ8w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(346002)(136003)(39860400002)(376002)(396003)(366004)(451199015)(66446008)(66946007)(5660300002)(66556008)(64756008)(76116006)(52536014)(4326008)(8676002)(33656002)(8936002)(41300700001)(66476007)(122000001)(107886003)(186003)(55016003)(6506007)(110136005)(26005)(7696005)(9686003)(83380400001)(53546011)(86362001)(82960400001)(38100700002)(71200400001)(54906003)(316002)(38070700005)(966005)(478600001)(2906002)(66899015);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jok8xZqz3ZNyUCOBM/MSPy9ZgP3FpYfYTE7ODNP/vfYBHlOGcF3BXikJpZ2Q?= =?us-ascii?Q?t7DkhqAuvOPhKqxtg3N3/QuIGIEvYY34tyn3Ge+ZtrmFXGEp8UE2wDFxz8uy?= =?us-ascii?Q?HK11GO3KF/iGCwN8MLMfer1M2NlxxlCjHeAnNrFQzBrwHs8E0aPd/fPUiK2z?= =?us-ascii?Q?s1VDmW8aK3uMf1lkeUIsJqOsjm1YamzmI8EldsecWd/wyJpkorRwBHnLdpQO?= =?us-ascii?Q?+GRVMDoNMiE+gD96I0aCxFpWljchLm3K7x+ZFJ2nNJCU3bjaU+eHRDNsqU8A?= =?us-ascii?Q?kTgc3/raYASqESSJCayLxXUoa1IGvddz5SNW5UJ6Z2arhVfKheHDXyjhInC5?= =?us-ascii?Q?3r2As5ymTL36aZ2A0ReHUZLTZn4eLDsWzk6rXzmfVkREnRH9lnYQkLZBvHlB?= =?us-ascii?Q?qlIxdr+TmR/9kKj7tT++uqKKd1cJialgoYi3SkukFnnAyOf3RG34loxhHowG?= =?us-ascii?Q?vf+cqnx1JkosaH/O7ujVXHJVv8oek9/cO5oR12lNBxwZXphElGLqJNjDxizP?= =?us-ascii?Q?k5AspOwlVXwjrg6+TBrgOCGnBH7AfSrLdCAzbkvjFMVFZjkjqL/RKdtZ/OS3?= =?us-ascii?Q?nBBPDgpW8ZaRebdODMBTSOmAb7mdmca9M4tTpJt6KTK5cChvIrCufVo0Jemn?= =?us-ascii?Q?O7nQE9tm0RCZOm8qOmOsRANjuH1ua/piUczO66NO5oqWA0vnINRVdOzBZUrH?= =?us-ascii?Q?sTMfBs6HNClrEz8ow/K87P4QNpayZuybfU6BIFNMf+ewBr18pKxtf/VrRnQM?= =?us-ascii?Q?IgJC+ctvE9wO0UYrBLsu8EhwRlbj9XoF5jsQObu5XIxOwNBF7QNXm39fL8Z9?= =?us-ascii?Q?VKMiy6LWIZPpKHUGaOGOya+SqG9t0w3zVIhZN5yBg5ZFraIk673vMHc3FVtP?= =?us-ascii?Q?yPy2vS+Lw2Z3DmMTTxRd383Xf1d2/jvdi2whm+BwW1wzesOjfY5jwy1Iw/2B?= =?us-ascii?Q?l8x17rDp3gVCoyppynFkts+eO32m2fa8a5U/8z0LSY8N4W3K6py8Dm9Y4Z2L?= =?us-ascii?Q?uUHzPuXjcyjdnfXTdo6DWUcyvL3r3BUsLlbJHmrtk/vVisjdRCsiyFtvyo5/?= =?us-ascii?Q?J9mrAkCSiz+4KuNa+Fom3h1t9R7fWCGgcbrBQxkU2yvjjU+i+Roy/HBnUbqi?= =?us-ascii?Q?Qf2+NFk2y0XEim0S9+6+YR8dNuly3CkKU99AuAGKqCkGErMVf0SFpIDQlB9W?= =?us-ascii?Q?1A1jsh2J6jFUW9YcsGqdh1bH+B+6HyYztZGxQ0HxL+7QD3bZURHyB9+H2Gqq?= =?us-ascii?Q?XzOeiAj2FB0ZEQErwMRnlxIgD2RMZ1k3hTTcoZBfZMoAmkNjGY5eImx3Yeuo?= =?us-ascii?Q?HJ0H8Z6wfnoLjm++Wkrriccj2WV1Agkiu32ZfbpTkWRVOIX/l0PvioPDFmO4?= =?us-ascii?Q?i/OWn4RQG/I2HKg7w2oZiQohGQlxHC1/hmhG3TjA3E2bEFhfNJsxW0UzEgFj?= =?us-ascii?Q?d8xZO9b/1+HLN3ch75hQXDAyzGWW2yf9KVYG2Pgu3luwDkU8ydQ7x0XKpG/a?= =?us-ascii?Q?YMBtUjy/w5UBWsxnLT+nu+HVvEOKvFlVobK/zd0ef0CNBOpI7PBDe6l4EOe9?= =?us-ascii?Q?6xQtpk4jYrMoGKBkiTUmJbwgmld35ablbQFBSkDz?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a4a1e9e-51dd-406f-12d2-08dae32fcbef X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2022 08:46:05.0288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BzaUWHQL2nZOJYfOxKFRrHzXLzkxoMjXUt6eSJ0s1unyuz0zxGuEjMBCC8q5S63PgQQnS7utwBJF11ZsygmDmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6037 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Joey You are welcome. Thanks to catch the issue and provide the patch. One thing to clarify: The patch submitter is expected to pass CI, *before* = submit the patch. The benefit is that: If the patch passes the review, the maintainer may mer= ge it directly. There is no need to trigger another round CI-fix, V2 patch submission and r= eview. Thank you Yao, Jiewen > -----Original Message----- > From: joeyli > Sent: Tuesday, December 20, 2022 3:10 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Lee, Chun-Yi ; Xu, Min M > ; Gerd Hoffmann ; Tom > Lendacky ; James Bottomley > ; Aktas, Erdem > Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integri= ty > checking failed of NvVarStore in some cases >=20 > Hi Jiewen, >=20 > Sorry for I didn't create tiano CI on github in time. And thanks for your > help to merge my patch. >=20 > I will create tiano CI in next time after getting our Review-by tag. >=20 > Thanks! > Joey Lee >=20 > On Sat, Dec 17, 2022 at 03:17:42AM +0000, Yao, Jiewen via groups.io wrote= : > > Thanks for the fix. > > Reviewed-by: Jiewen Yao > > > > Question: Have you run tiano CI by yourself, before submit the patch? > > > > > > > > > -----Original Message----- > > > From: Lee, Chun-Yi > > > Sent: Thursday, December 15, 2022 10:27 PM > > > To: devel@edk2.groups.io > > > Cc: Xu, Min M ; Gerd Hoffmann > > > ; Yao, Jiewen ; Tom > Lendacky > > > ; James Bottomley ; > > > Aktas, Erdem ; Lee, Chun-Yi > > > Subject: [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking f= ailed > of > > > NvVarStore in some cases > > > > > > In the commit 4f173db8b4 "OvmfPkg/PlatformInitLib: Add functions for > > > EmuVariableNvStore", it introduced a PlatformValidateNvVarStore() > function > > > for checking the integrity of NvVarStore. > > > > > > In some cases when the VariableHeader->StartId is VARIABLE_DATA, the > > > VariableHeader->State is not just one of the four primary states: > > > VAR_IN_DELETED_TRANSITION, VAR_DELETED, > VAR_HEADER_VALID_ONLY, > > > VAR_ADDED. > > > The state may combined two or three states, e.g. > > > > > > 0x3C =3D (VAR_IN_DELETED_TRANSITION & VAR_ADDED) & > VAR_DELETED > > > or > > > 0x3D =3D VAR_ADDED & VAR_DELETED > > > > > > When the variable store has those variables, system booting/rebooting > will > > > hangs in a ASSERT: > > > > > > NvVarStore Variable header State was invalid. > > > ASSERT > > > /mnt/working/source_code- > > > git/edk2/OvmfPkg/Library/PlatformInitLib/Platform.c(819): > > > ((BOOLEAN)(0=3D=3D1)) > > > > > > Adding more log to UpdateVariable() and PlatformValidateNvVarStore(), > we > > > saw some variables which have 0x3C or 0x3D state in store. > > > e.g. > > > > > > UpdateVariable(), VariableName=3DBootOrder > > > L1871, State=3D0000003F <-- VAR_ADDED > > > State &=3D VAR_DELETED=3D0000003D > > > FlushHobVariableToFlash(), VariableName=3DBootOrder > > > ... > > > UpdateVariable(), VariableName=3DInitialAttemptOrder > > > L1977, State=3D0000003F > > > State &=3D VAR_IN_DELETED_TRANSITION=3D0000003E > > > L2376, State=3D0000003E > > > State &=3D VAR_DELETED=3D0000003C > > > FlushHobVariableToFlash(), VariableName=3DInitialAttemptOrder > > > ... > > > UpdateVariable(), VariableName=3DConIn > > > L1977, State=3D0000003F > > > State &=3D VAR_IN_DELETED_TRANSITION=3D0000003E > > > L2376, State=3D0000003E > > > State &=3D VAR_DELETED=3D0000003C > > > FlushHobVariableToFlash(), VariableName=3DConIn > > > ... > > > > > > So, only allowing the four primary states is not enough. This patch > changes > > > the falid states list (Follow Jiewen Yao's suggestion): > > > > > > 1. VAR_HEADER_VALID_ONLY (0x7F) > > > - Header added (*) > > > 2. VAR_ADDED (0x3F) > > > - Header + data added > > > 3. VAR_ADDED & VAR_IN_DELETED_TRANSITION (0x3E) > > > - marked as deleted, but still valid, before new data is added. (*) > > > 4. VAR_ADDED & VAR_IN_DELETED_TRANSITION & VAR_DELETED (0x3C) > > > - deleted, after new data is added. > > > 5. VAR_ADDED & VAR_DELETED (0x3D) > > > - deleted directly, without new data. > > > (*) means to support surprise shutdown. > > > > > > And removed (VAR_IN_DELETED_TRANSITION) and (VAR_DELETED) > because > > > they are > > > invalid states. > > > > > > v2: > > > Follow Jiewen Yao's suggestion to add the following valid states: > > > VAR_ADDED & VAR_DELETED (0x3D) > > > VAR_ADDED & VAR_IN_DELETED_TRANSITION (0x3E) > > > VAR_ADDED & VAR_IN_DELETED_TRANSITION & VAR_DELETED > > > (0x3C) > > > and removed the following invalid states: > > > VAR_IN_DELETED_TRANSITION > > > VAR_DELETED > > > > > > Signed-off-by: "Lee, Chun-Yi" > > > --- > > > OvmfPkg/Library/PlatformInitLib/Platform.c | 9 +++++---- > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > diff --git a/OvmfPkg/Library/PlatformInitLib/Platform.c > > > b/OvmfPkg/Library/PlatformInitLib/Platform.c > > > index 77f22de046..6963c47e0b 100644 > > > --- a/OvmfPkg/Library/PlatformInitLib/Platform.c > > > +++ b/OvmfPkg/Library/PlatformInitLib/Platform.c > > > @@ -702,10 +702,11 @@ PlatformValidateNvVarStore ( > > > > > > VariableOffset =3D NvVarStoreHeader->Size - sizeof > > > (VARIABLE_STORE_HEADER); > > > } else { > > > - if (!((VariableHeader->State =3D=3D VAR_IN_DELETED_TRANSITION)= || > > > - (VariableHeader->State =3D=3D VAR_DELETED) || > > > - (VariableHeader->State =3D=3D VAR_HEADER_VALID_ONLY) || > > > - (VariableHeader->State =3D=3D VAR_ADDED))) > > > + if (!((VariableHeader->State =3D=3D VAR_HEADER_VALID_ONLY) || > > > + (VariableHeader->State =3D=3D VAR_ADDED) || > > > + (VariableHeader->State =3D=3D (VAR_ADDED & VAR_DELETED)) || > > > + (VariableHeader->State =3D=3D (VAR_ADDED & > > > VAR_IN_DELETED_TRANSITION)) || > > > + (VariableHeader->State =3D=3D (VAR_ADDED & > > > VAR_IN_DELETED_TRANSITION & VAR_DELETED)))) > > > { > > > DEBUG ((DEBUG_ERROR, "NvVarStore Variable header State was > > > invalid.\n")); > > > return FALSE; > > > -- > > > 2.35.3 > > > > > > > >=20 > >