From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.28986.1639268947920408125 for ; Sat, 11 Dec 2021 16:29:08 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@intel.com header.s=intel header.b=jUgLoNob; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639268947; x=1670804947; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=paMCftwmKG7cYCoD9Libk67LAEBFSPR+j1DvDBx/WAY=; b=jUgLoNobKxhQTH12iow+bo7t0U9scbv0cFghPq96ajPKvK6xfIZvnSNb idejuLgil3Ew/u/nY+AbUaqIV7WuzpWz4Ag4eiI9eBJx9vtvJ4a2ixM/M ZtVJvRA/kl1NptXvdXBRTVV9qbKPVO3HJHIcrjDO05JPEWXvzZiCiDoDF oQmZp9Vq8aMa8gEeOl3EHfddM2qEAL8PUAr7F7mscNFcO7r2D0J7fWdbQ hafbmtixTqGoSm1GCkZCyEr+QX24hta12Yb6kR8cUMhhOp2mrlUW24kLe X23wJVDvuObMWOgsDVDSHfGGofyPF1EpkDS65jJ+qtRlrHxWP66PL7W6b g==; X-IronPort-AV: E=McAfee;i="6200,9189,10195"; a="301951706" X-IronPort-AV: E=Sophos;i="5.88,199,1635231600"; d="scan'208";a="301951706" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2021 16:29:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,199,1635231600"; d="scan'208";a="613362344" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 11 Dec 2021 16:29:06 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 11 Dec 2021 16:29:06 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sat, 11 Dec 2021 16:29:06 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sat, 11 Dec 2021 16:29:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LqkzrrDEJBMv+S22nPRZMH1BgY8bvhZub4VMEEbmtPctxzdmcw8FTGLKWR6i01YQFix1rbbqa3BXHVHfp7yOaByXUArwqDV6IyY2VuWZJ2Zb6utCve1+HFcLKIFF576ri/tY094t0yw89c7s45Je4IvIE/w2asu1EKnTv/+3TDxlo235CevMMBoqNOodaWDjF54bCFKlDRAKW5vX2jwYs22oJC6929BzlinPaH5Plo31xwbUy2ib8zRKhjdyKhzM1Ekea4+PTZS9IgbL9Z4txu0MsB+/XNmotTkWQftcoUUw5wZyc0DtCznSsfK0j6wqkxpVpABE42Q6/DMiTTvapQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Em2xmA/vSa6iVDkXMGJ+LLC1o2H1OVwMH1QlEK+9PU8=; b=Z5bOAUPWDLmvZDUs/xFNkNquUTGpjevEfCLP1n2bUybfbmdkv35gSkndfYPAMROVVRsn4dasWyaBdRFe4MiudgJuQMa3poLPMTlLRFdcidn5dc7SXYe4fw83Apd5SbH4RjURMA55Nw0uYiyYTIm+oKYxdr8+XUoS0vRxa5HX9PW+Dsv9gV5RKLQrhPI7ZoHES9syJ/IP8aDEqBaFDSUnYt/TRHrwMDkvvCWj5HPBIJPAiH6108v5ENKZND7ZOgI+UltmqqU8zLFYBvKvLKadDo1vPX4TDV+VcZs/cBaex48DDqPx1qltuD8fP6O3zgeOZUX2KV1/HGBxZgpUjuTPgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Em2xmA/vSa6iVDkXMGJ+LLC1o2H1OVwMH1QlEK+9PU8=; b=tR0aJ5i/fbKVzE+92Jc+H2z71QK5wgL96EuNfD1ie5MlfWIqbOaIrwWrszQomOaApuVhBzvQgjVHKFx4i/CtC3vwrVPUVzyrbDSKn92y/qzA8FFjT9ZIodIZjvZIpw0h6f3CuGQVtrRM1wylg5KIBC4ingsCTBB+AXejXEBVQwY= Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MWHPR11MB1327.namprd11.prod.outlook.com (2603:10b6:300:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Sun, 12 Dec 2021 00:29:04 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae%5]) with mapi id 15.20.4778.012; Sun, 12 Dec 2021 00:29:04 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Xu, Min M" CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Wang, Jian J" , "Lu, Ken" , Sami Mujawar , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProtocol into EDK2 Thread-Topic: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProtocol into EDK2 Thread-Index: AQHX7pBD8by7hUTjl0OXDlwl6S2zoqwtTMLwgAC0ldA= Date: Sun, 12 Dec 2021 00:29:04 +0000 Message-ID: References: <16BFB74A32C27317.32732@groups.io> In-Reply-To: <16BFB74A32C27317.32732@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1807e956-5fed-47b3-d6f7-08d9bd066716 x-ms-traffictypediagnostic: MWHPR11MB1327:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fOJvIWYYX1eCg69lo//klhxCE09J/g85FC4CDOhYVeueO99QWc4MoWcpJvwM0Hk5fldio78x3V2IePqr5tKeltGKuGFZsMRKIpRQ5RraZ55POSdvAL2uAW8QsBiaNMrBeLFsiP9Ki0+uOHCE7pJH3gwoXlcvbJ8CLLu6xBAxP2WenpTdmHk6wmCR5QmQFUg0/iw7ibpdOivLTK5Va6rmGaByw8QlQkDS7joZvB3oUDsc0jiuI6ykjg20JcqFDIrttaDAgyv22sBs6lrK0MWkHcVDUR7qs/D2RoVkazUQ0hFLcaByjjlw5thls9zOGBRsLxSSenoW3AUCt/rGd3H0HHkCsRJ2zae+pruxtxPZbTMu7k/JOuntK7fuhPB/0wO2uxfAJwSfrNdpy9UT038S6s3lwxg90j5AQD+mRwaMGw5fgKQw8LY33cChftVb9sSb1GFzj4Ds4Fd2yiF+4qKSiGC22TpVH5k3RD5bmABc/RjCUFh9tzOnN5oWK41AHTEOr2cnj+lfZ0jy4XRW/4Ns9R3LDPpUdvTLPSdZJUYIgW3RfQhesLgXeT1louBKohPTjty/YptXdvudAfUBMNaMcNDrZBSloUBw7JPbkb62WbmabruIzAhFt/hC3otfbtnwtb4MCIIvIHpS50r5/S3TGOQdSbgbncYFzKDF++a4PAqQAMDyzM1S/7M+klkFiORNpRS3QuvYUd+aUC+FUxOllED6aeV2IF4N7P4RKYG3XT1zSCv2Sz2897jHKPyLVlFQjaQrc5vjjwUnOtsu2fdEnLSMrcTYvMzwul2lBE5hwV5xTNaR/pRHAQY4MY7mKvbW4+HwoH6/PAk4NF0JlRwPnA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(6506007)(19627235002)(33656002)(66946007)(66556008)(8936002)(82960400001)(53546011)(4326008)(64756008)(5660300002)(6636002)(52536014)(76116006)(66446008)(7696005)(66476007)(2906002)(38100700002)(9686003)(86362001)(71200400001)(966005)(110136005)(54906003)(508600001)(83380400001)(122000001)(186003)(55016003)(26005)(38070700005)(8676002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gyEw6UTF573UQH9pwlzY9mOi/f15/6GiVSePH5CyRU5nScMFJ9bBp1JkVU7N?= =?us-ascii?Q?aVYGh76/pjJgXyypYHiEvpN6pL1AeACmoU3I/l0Uh3IMW0+K9zFISvkMPTUJ?= =?us-ascii?Q?ZfXToErN8f0nEw6Wq3ug0KdrEMiKxRz0UECFsEBq3GruIoq4Zgagez4ar/aD?= =?us-ascii?Q?fvyifVtTs55ct4rc46tpU96XFLDYgqlhLF6717za8M1+o6pPcoYSmVbhNMLC?= =?us-ascii?Q?Lh06FXxu+3rOUaG8REP4/o875Py06ul0+xhIYONjnQ+d8PLu3CrMrOTDJjEz?= =?us-ascii?Q?A0D97fK1SWrOyd6KOOJ1lE5Oc8RtrmGwrJw7lVBgDej5S1h7zND1TrBHV93B?= =?us-ascii?Q?V88hByulsyg0l6+zfCRRkhVy58QogP0hlnQYC2hniw5uitiNcUfmukLs/6Gn?= =?us-ascii?Q?f7ZIcWv8CzWsYa5dNIHE5CpBrSj3BBbu1Up54MxkneK0rz//JnbVf5n352TH?= =?us-ascii?Q?kPTKA3EWTC5Nhma6gREmAxvKgmvUbOZlOALlRkUR5EsImu4MusNwOmrrzQoZ?= =?us-ascii?Q?38tC58jKepQx/F470IxDRQ6kZ6AU5E9Z+uzHhCeL+cRCLG1Gwup1Be/qA4Ye?= =?us-ascii?Q?R/uOY+wc3s0AHwK/UScvA6ZtckxeHk17vXeX9UKHYbJ2LEfU/xX+iHhx327J?= =?us-ascii?Q?zYsLziGg1T1wtkSev1//liwD17GElRcIfwx8wLwaGoprJkSGKxfUmBRFX18P?= =?us-ascii?Q?hZhNCjvKF3Ualu1kQtVGN1klGJJu7AXTY/Yho5rmBT6N/UoofGsnd373xX2m?= =?us-ascii?Q?Fd7h9+TAzlWZl+VuALeMX+WqGaKmZx1NiYWZJBZ6L42ya7bwEwolE1SfoMPA?= =?us-ascii?Q?0VIkgM9zMWDWdf3XFkRzVrZmnqEvqmV0SLHNncz3o8sK5u1AFbIFHQ8+puVG?= =?us-ascii?Q?lkGmx8rZeFOkRKHAXpjYfjnGpFgOGGi42Fl6nslDHHfGyEBJs1sFldWZlKV7?= =?us-ascii?Q?mahgy5gaPXD1KT/IGuiep4QLrp2SZsJvMYqbxnpzqE4mAfRpkU2D3xheX87z?= =?us-ascii?Q?dMQEKScTrlWwVyZ3KPw/O5yDx01ES0L+weTwS1AfiMw+ZAvfX3duYMAmqzSo?= =?us-ascii?Q?cHa4B17pM1vPH7CCzVsyPvm/LloPaf7xeLoj449EF5xfmWb1BQy6GOjZMFXH?= =?us-ascii?Q?oFjXJulFafeheMsB9kff11Ex9/OqtePRIGQwGtsMkjTXZeUezNrVhGh9s6Gb?= =?us-ascii?Q?AuDL0g2LJqeH1IppduJFDYY7JxyaN0IgJkQYPCm8ZggIKRzBTmVjLPBOOV8p?= =?us-ascii?Q?UyOvHvI2xaNVs6CJnNwwlMbba1U4X2LUOYoCGHF55quq9dYVlcnvfim0d8yV?= =?us-ascii?Q?WSsqFj7AiON22egj3Q0O/saUE0GkdMF30PItvPqvZ1Db6wUN/eZLp3DjA1O5?= =?us-ascii?Q?bV63pjCRKNjIutfzMILq75oE0gS7DqgyIVkjYVywzC3s3T/YOjVj03MURTBA?= =?us-ascii?Q?0Q6hDmo7pyfR+2nUrwCLK0fUhb4lHhr1QgRdQNp/jxAPmZn3i+KvnF7GfGrn?= =?us-ascii?Q?00VetnPVk7ugYrApuDRh7ihwfHQ/oY8NJ1hTdPxTgk53u/6a7eooUi7E9uMN?= =?us-ascii?Q?e2iVbbkuwr/OE6qX5OOQcvO5Dj08a2MB0pxK2Vc1uhm9z7CwaWGHMhMtMGJj?= =?us-ascii?Q?rtrrS91ppLBIGT+NxTgPe9U=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1807e956-5fed-47b3-d6f7-08d9bd066716 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2021 00:29:04.4295 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R7Zphb2Fpwq9Y0+ufoecZ0GCznXWkbROr/yd6Cwp633Fd/5umHyR+CB7Hch7KfJCQVzNytiEBtaoZJjL7A14Dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1327 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged - https://github.com/tianocore/edk2/pull/2291 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Saturday, December 11, 2021 9:45 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; Wang, > Jian J ; Lu, Ken ; Sami Mujawar > ; Gerd Hoffmann > Subject: Re: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProtocol > into EDK2 >=20 > Series: Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Saturday, December 11, 2021 9:09 PM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Kinney, Michael D > > ; Liming Gao ; Li= u, > > Zhiguang ; Yao, Jiewen ; > > Wang, Jian J ; Lu, Ken ; Sami > > Mujawar ; Gerd Hoffmann > > Subject: [PATCH V7 0/3] Introduce CcMeasurementProtocol into EDK2 > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3625 > > > > If Confidential Computing (Cc) firmware supports measurement and an > > event is created, CC-Guest firmware is designed to report the event > > log with the same data structure in TCG-Platform-Firmware-Profile > > specification with EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 format. > > > > The CC-Guest firmware supports measurement. It is designed to produce > > EFI_CC_MEASUREMENT_PROTOCOL with new GUID > > EFI_CC_MEASUREMENT_PROTOCOL_GUID to report event log and provides > > hash capability. > > > > Patch #1: > > Introduce the CC Measurement Protocol definition into MdePkg. > > > > Patch #2: > > Update DxeTpm2MeasureBootLib to support CC based measure boot. > > > > Patch #3: > > Update DxeTpmMeasurementLib to support CC based measurement. > > > > Code is at https://github.com/mxu9/edk2/tree/td_protocol.v6 > > > > This patch-set has been tested in Intel's internal hardware platform. > > Both TD and TPM pass the tests. > > > > v7 changes: > > - Rebase the code base (commit: e81a81e5846e) and update patch-set wit= h > > uncrustify. > > > > v6 changes: > > - Add ASSERT (sizeof (EFI_CC_EVENT) =3D=3D sizeof (EFI_TCG2_EVENT)) ch= eck. > > - Update the CcMeasureAndLogData () to add CcProtocol pointer as the > > input parameter. > > - Tpm20MeasureAndLogData () / Tpm12MeasureAndLogDat () > > / CcMeasureAndLogData () are made static according to Sami's > > comments. > > > > v5 changes: > > - Add gEfiCcFinalEventsTableGuid in [Guids] section of MdePkg.dec > > - DxeTpm2MeasureBootLib and DxeTpmMeasurementLib will first > > call CC protocol to do the measure boot / measurement. If it is not > > installed, TCG2 protocol will be located and called. > > - CreateCcEventFromTcg2Event is removed. This is because CcEvent is > > similar to Tcg2Event except the MrIndex and PcrIndex. So in the code > > Tcg2Event will be first created and intialized. If > > CcMeasurementProtocol is called to do the measure boot, then CcEvent > > points to Tcg2Event and the MrIndex is adjusted. > > - Some other minor changes. > > > > v4 changes: > > - Rename TeeMeasurementProtocol to CcMeasurementProtocol based > > on the discussion in below links: > > https://edk2.groups.io/g/devel/message/82876 > > https://edk2.groups.io/g/devel/message/82999 > > https://edk2.groups.io/g/devel/message/83000 > > With this protocol, CC based measure boot is supported. > > TD based measure boot is one of the CC based measure boot. > > - The spec will be updated according to the changes later. > > - TdProtocol.h is deleted. Its content is merged into CcMeasurement.h. > > - Add gEfiCcFinalEventsTableGuid definition in MdePkg.dec > > - Update the description in DxeTpm2MeasureBootLib.inf > > and DxeTpmMeasurementLib.inf > > > > v3 changes: > > - Rename TdProtocol to TeeMeasurementProtocol which is a neutral name. > > With this protocol, TEE based measure boot is supported. > > TD based measure boot is one of the TEE based measure boot. > > - The spec will be updated according to the changes later. > > - Fix errors in DxeTpm2MeasureBootLib. > > > > v2 changes: > > - TD based measure boot is implemented in DxeTpm2MeasureBootLib. > > This minimize the code changes. > > - TD based measurement is added. It is implemented in > > DxeTpmMeasurementLib. > > - Fix the typo in comments. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Ken Lu > > Cc: Sami Mujawar > > Cc: Gerd Hoffmann > > Reviewed-by: Sami Mujawar > > Tested-by: Min Xu > > Signed-off-by: Min Xu > > > > Min Xu (3): > > MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware > > SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib > > SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib > > > > MdePkg/Include/Protocol/CcMeasurement.h | 302 +++++++++++++++ > > MdePkg/MdePkg.dec | 6 + > > .../DxeTpm2MeasureBootLib.c | 343 ++++++++++++++---- > > .../DxeTpm2MeasureBootLib.inf | 3 +- > > .../DxeTpmMeasurementLib.c | 122 ++++++- > > .../DxeTpmMeasurementLib.inf | 9 +- > > 6 files changed, 686 insertions(+), 99 deletions(-) > > create mode 100644 MdePkg/Include/Protocol/CcMeasurement.h > > > > -- > > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20