Re: [PATCH V2 0/3] CryptoPkg: Add EC key retrieving and signature interface.

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Merged https://github.com/tianocore/edk2/pull/3469

> -----Original Message-----
> From: Zhang, Qi1 <qi1.zhang@intel.com>
> Sent: Wednesday, October 12, 2022 10:48 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [PATCH V2 0/3] CryptoPkg: Add EC key retrieving and signature
> interface.
> 
> This patch is used to retrieve EC key from PEM and X509 and
> carry out the EC-DSA signature and verify it.
> 
> The interface was tested by:
> 1. DeviceSecurity on edk2-staging
> https://github.com/tianocore/edk2-staging/tree/DeviceSecurity.
> 2. Unit test in CryptoPkg/Test
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4102
> PR: https://github.com/tianocore/edk2/pull/3464
> 
> V2 change: change the protocol version.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
> 
> Qi Zhang (3):
>   CryptoPkg: Add EC key retrieving and signature interface.
>   CryptoPkg: Add EC key interface to DXE and protocol
>   CryptoPkg: add unit test for EC key interface.
> 
>  CryptoPkg/Driver/Crypto.c                     | 143 +++++++++-
>  CryptoPkg/Include/Library/BaseCryptLib.h      | 129 +++++++++
>  .../Pcd/PcdCryptoServiceFamilyEnable.h        |   4 +
>  CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c |  87 ++++++
>  .../Library/BaseCryptLib/Pem/CryptPemNull.c   |  30 ++
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c   | 258
> ++++++++++++++++++
>  .../Library/BaseCryptLib/Pk/CryptEcNull.c     |  82 ++++++
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c |  83 ++++++
>  .../Library/BaseCryptLib/Pk/CryptX509Null.c   |  28 ++
>  .../BaseCryptLibNull/Pem/CryptPemNull.c       |  30 ++
>  .../Library/BaseCryptLibNull/Pk/CryptEcNull.c |  82 ++++++
>  .../BaseCryptLibNull/Pk/CryptX509Null.c       |  28 ++
>  .../BaseCryptLibOnProtocolPpi/CryptLib.c      | 136 +++++++++
>  CryptoPkg/Private/Protocol/Crypto.h           | 131 ++++++++-
>  .../UnitTest/Library/BaseCryptLib/EcTests.c   | 156 +++++++++++
>  15 files changed, 1405 insertions(+), 2 deletions(-)
> 
> --
> 2.26.2.windows.1