Re: [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Xu, Min M <min.m.xu@intel.com>
> Sent: Wednesday, January 18, 2023 4:42 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Bi, Dandan <dandan.bi@intel.com>; Aktas,
> Erdem <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Tom Lendacky <thomas.lendacky@amd.com>; Michael Roth
> <michael.roth@amd.com>
> Subject: [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not
> allowed in AllocatePool
> 
> From: Min M Xu <min.m.xu@intel.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4315
> 
> MemoryType of EfiUnacceptedMemoryType should not be allocated in
> AllocatePool. Instead it should return EFI_INVALID_PARAMETER.
> 
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Reported-by: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> ---
>  MdeModulePkg/Core/Dxe/Mem/Pool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Core/Dxe/Mem/Pool.c
> b/MdeModulePkg/Core/Dxe/Mem/Pool.c
> index 7aaf501600cf..b20cbfdedbab 100644
> --- a/MdeModulePkg/Core/Dxe/Mem/Pool.c
> +++ b/MdeModulePkg/Core/Dxe/Mem/Pool.c
> @@ -213,7 +213,7 @@ CoreInternalAllocatePool (
>    // If it's not a valid type, fail it
>    //
>    if (((PoolType >= EfiMaxMemoryType) && (PoolType <
> MEMORY_TYPE_OEM_RESERVED_MIN)) ||
> -      (PoolType == EfiConventionalMemory) || (PoolType ==
> EfiPersistentMemory))
> +      (PoolType == EfiConventionalMemory) || (PoolType ==
> EfiPersistentMemory) || (PoolType == EfiUnacceptedMemoryType))
>    {
>      return EFI_INVALID_PARAMETER;
>    }
> --
> 2.29.2.windows.2