From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.69687.1674202265206167831 for ; Fri, 20 Jan 2023 00:11:05 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CWfPT5re; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674202265; x=1705738265; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Kbr7sN20rSazyw7asU20AXz5VXqTk4o/cAEH2Dmv/Ns=; b=CWfPT5reVGWzxA7ksGZDWM/IIEV7/bv7HePfLiGS6ZLhiJMx9wKyF0db OtPEwkldheyIsPBQJoTfz6+Mg1vhAY1XeYYmdym/GJRE83UyQpUfqu7F2 TArmWcwbqrBDRD+Zy4oCIINaQkOfM6tTYbW2XE4a6DZyoe6vfh42Dx1IO SQPrn3LhHoCXaArJeecazc79kGnHsHX/Tuf0yHpCv+Qqo7o9w7LZFofFx ilsycJuflcWjVS3lYAi2SkIYrPzxGplQG/ZZl6+AIPvIVI8jcB/dCIiSl Z8GlUp1b+hYyaVjAumpH6jHQd0TRuNNcmyIpVtgQVM2IlNz7SF9ptCO3K g==; X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="313419653" X-IronPort-AV: E=Sophos;i="5.97,231,1669104000"; d="scan'208";a="313419653" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 00:10:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="653715941" X-IronPort-AV: E=Sophos;i="5.97,231,1669104000"; d="scan'208";a="653715941" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 20 Jan 2023 00:10:54 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 20 Jan 2023 00:10:54 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 20 Jan 2023 00:10:54 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 20 Jan 2023 00:10:54 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 20 Jan 2023 00:10:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZE5kAaPQq71Tki/pU+cDnIDanQFBGHIidYnbFwD2cADZM2gmO89z1xl0QilYk1WnxdsiA+eRDucl7ky7J6TOcGh3nlBLTO6bY9/OchRPG6DKZh1GnhYCzFucfbqiaT/IMwJElmQuwC3PoCQHe+D4uQPdG4MkUYi4lSNTRbUBL+EiR+rs9dUKFV852JUz796rx/VTRxPHnalVvOL3gnxocm3eb6vcaIw2xbEdLLrcO+i5fQrbIUTM/vyWA8KUDl2sBc4MTWAWtaC+UBoY6mPSa9X6dg6RRHxl4JWhujIl8Fk3A9eWuf7sSeGW0mkHmiK8vSXizQtedlwyez5lljJYIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+IrDW5OttT5oPPMZRWonxEkucl2JWW3hitW6+5x4Wq4=; b=TqPlLcpQeKsUGmGojD0DSTDOWGUyLuKkm5Ay+Erfd3VjcjYZQOYhrhvRIcKWKFgvRpzFTqUZBtIM+ZcVXbMy6BxF5PKYMufjlDRTYSWN1N0frmGGpiRRa86RS/I7XBC5YqlYzIZjpQ9dxt2jNhoC6JJeceDJ8kYpF03WASqcEO9P2pDkCiUMPk+BWyUbBieMxeUqOusKucGoLkGAKEwwQdraUcjLzWj7Po/jXn40dn1jvLc/FKORx2dL4P1kHpYbv49Id0ek9ccOhp48M4rzAJETSJUfdEyrteH9k0uobwV/dF8uFtAc4adf8pp+ZL9dogS9mY5Em6vmHwQJaYUznQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DS7PR11MB7781.namprd11.prod.outlook.com (2603:10b6:8:e1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.24; Fri, 20 Jan 2023 08:10:46 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%7]) with mapi id 15.20.6002.013; Fri, 20 Jan 2023 08:10:46 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , Gerd Hoffmann CC: "devel@edk2.groups.io" , "Aktas, Erdem" , James Bottomley , Tom Lendacky , Michael Roth Subject: Re: [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib Thread-Topic: [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib Thread-Index: AQHZK7YrT0qB05Pu80yLRbe+RHoLb66lgJYAgAFs3oCAAAeMAA== Date: Fri, 20 Jan 2023 08:10:45 +0000 Message-ID: References: <20230119032822.1406-1-min.m.xu@intel.com> <20230119032822.1406-5-min.m.xu@intel.com> <20230119095422.ou5vbckdyn33hh5c@sirius.home.kraxel.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DS7PR11MB7781:EE_ x-ms-office365-filtering-correlation-id: 78b579ad-51a1-4ad7-bf38-08dafabdd526 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0zB19scjtfvMP13hoBmQ38GMNjsKn+LPfwJmMtqZZOtcMhJflOG6axAmouGUhNtmsHdCwE/6ID32e7GSR4wKQKsKFH+qt0EsfMilZcWBHLBWfc4qOPMUn0LIA33Bl2jUGDu+CbT1eoy+z/0OjP0Fzm/U7A6SnK1xDrRssxoDOlOzN4ashT/5BYwkMdFqLFyxa5jHcuHFlBSm1M6LrSQpag2NyNQu8rqba81NqTSktB1pU+7hyCR3+HedU0UnjTSwOjGmty5eANk8K+ezl35QPNeTyz0mEVHBhgXkC9MuzrZdHgTaXO+0d2B0eZivBvy/3mXCa3SLqlAQ0vmd0zPLMbQdxNOHuE6crtQV/O8Na+gBsYHZLzsdbSVrejLELmHFlhBqrR3wh2CFQchR2GBMuGDMBiy2xWW4aVLkvYHPRPVV+dy/AHMvu5MxmEbAZAafzT+mw2lblHu8aPq+SwTFvQcHLy5MFCVLlLUyp0cYKcYKjMlU6ZCwiI4DopcSwXacHmLGDDc2xtWKCZcuBjwJW78SZ16AkaxmbXcVdyKTnQisKHggfU0LxbYOFBeDRGF7g7nkC3Z+oopnZIOG+BQSKUgiCoZOj42QCFiL4aZTUh73V+mNq7GptT0kAxBEOFrwbGRhetz3bRCGWjlvfhXSsD/scBFeE2DiUq42IccL8NUxApP4zhbFuqN4mhKGfsBManiuBwcncXJsJ+rG3q9DCtM+S1SuZ7WKz2xXI9MOI0Y= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(366004)(376002)(39860400002)(451199015)(82960400001)(52536014)(38100700002)(55016003)(76116006)(66556008)(122000001)(478600001)(86362001)(33656002)(5660300002)(8936002)(66476007)(66946007)(2906002)(4326008)(64756008)(41300700001)(66446008)(8676002)(26005)(83380400001)(186003)(71200400001)(53546011)(316002)(110136005)(54906003)(7696005)(38070700005)(6506007)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RzcxgpI9aGxDDjl3aEzMqCkv+H7PD+VkVauczR+yHi1p+5wwYhX3PXaZ/ZwH?= =?us-ascii?Q?/kp+FtqD/mJs0jn7VaADG9eVzNeibfHCVs/UqFL4Amy4+dAfAHx54kW3KlvB?= =?us-ascii?Q?OWPbpWTxWxBxnLtqGhKoHb/qQcqhnJXThmKOPiFR8soZjtN0HhPZOPFvP2i4?= =?us-ascii?Q?2KOHVjym+3gEDdGo9r9YIscHwAEuJTe8vh61KMgtY2F4Tp9Dy6Dcvp4UZveK?= =?us-ascii?Q?9PM0qifZPCqa+5kSro/2W5ReGjypBPmJGJZrQHYf5fwnEsLkmGZi0p0KGenC?= =?us-ascii?Q?z24Lj6XTIs7Ds2IfG+715/x79E2YAW9xRsHpyCj6MhDB/avQFA4Jp2RPb5u1?= =?us-ascii?Q?ef1GkorIQsMhmoYQbuPQJi6wzMHxp9+D29xQw+ibIwpKOhFPf3OfXHOcUkqL?= =?us-ascii?Q?ZbDwKv1SM6VGjNyyznKeNQeyY64RWGiAiS1cNR2hXfRANcVCF4c1NV1HzIaZ?= =?us-ascii?Q?rNkUiDm8r4yJVZCUwgrLZsN+DUMGE/LYEKb8Dredau9QKPsdt2kXlDH6gdwQ?= =?us-ascii?Q?9XiCe9M0qbiF2wjJGDGA3dQPxwSMQ5BXlxoA9L1z3tsgpUMkW97aRvGvNnzH?= =?us-ascii?Q?aPnjKBfkj9ABtMceJ/9eJk0mVqrZ6iE5/5t/MHQeSz8Q0Aa5dk+a5qXrdALG?= =?us-ascii?Q?1rg7ZxG1ztidPk5LMGVr/Xi6pQ0Z6I3g49Skk/W9ihpI/EkcFEkMxOEzNdtE?= =?us-ascii?Q?1eitTZoOvyGVFx2uUvieCoKOcvHXSQBo+Dhvtx7I2En/bNy9RhBlFygetmZi?= =?us-ascii?Q?nSvf13km53vb5XRBWYrkZ24wtxf9Koqt6TZsR9yZUCsLV++pztHqSGHSkjbs?= =?us-ascii?Q?0UhlqCZgbL2EcBGIr7pwpBfZsvQim0dzxU7Tk3FjpSYYNKtiqXVZmQ2S6opq?= =?us-ascii?Q?QjJLMiyNZMFJz79rWoW7dkL3AmJd4YlZZgROFfkQgbU0FAQg4HUTKgTstpdY?= =?us-ascii?Q?Dl8dMEzWTp/yozF+lYz6zcngR8tFWQeCNZUGQLP1qTG5WlixgF/2fzPDTbt8?= =?us-ascii?Q?gi+w2nliKXKJK0xfaTWMk5YTUeuvDYTrujO0KJ/gI2CcwQpeuaWdjCS8ep+m?= =?us-ascii?Q?XIVqIcH2flGVf8RWIPS79XkofRxN5c1k2OtQsTOp86eGgfUPFrlMlN4pi/TK?= =?us-ascii?Q?lyBscMebDvb4QUKfDb06RkxOWWYd6b9EByXDK0vOzD/m7LDn2tlP8n06n7mj?= =?us-ascii?Q?bXQqEH0FWqchHr/nCovn6k4PGWfGFmVdL66mMbxwaNfVSh3f+wLINmR6Ez2k?= =?us-ascii?Q?Gf8jpETePtUlxG8DEYSNdaqAnC5IXna5kuK1QhBBAvP8J74q9KXmqh5I/ozU?= =?us-ascii?Q?FVEXrVKfHpf//ZKrXp+YKoybYZ81UGYbkf+qhGjvArHPBTU3GJEquzOFr23u?= =?us-ascii?Q?NujGwM2WCizsTHqNlyfZ7NijBnrA2dr2B+t9zxZuWlnRPZe7uo5GYZuBk07l?= =?us-ascii?Q?yax6QvZTBSg5d1shxKNtfs8cCgDRZlGF6yiGRq63Fri7ET/9a9gAZ9OU9dg6?= =?us-ascii?Q?IsXTX1wb7KXTz6shpybBfMlZMwdtIt0fUei8YrgOXZnFLue6ltAwkMleLICk?= =?us-ascii?Q?NrswbGCTfSaAmcJTwmD0QVmLuqHisyehUAb0IUXa?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78b579ad-51a1-4ad7-bf38-08dafabdd526 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2023 08:10:45.7570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p8vXcv0i+fNStGqtoocHGgjiAJ/VmJKhdL1PBSl4BoaIr3UHf76WOpMjL2glOa8bQJavh6F3CybV3T1rk+l8XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7781 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > Can we define FV_HANDOFF_TABLE_POINTERS2 and FV_HANDOFF_TABLE_POINTERS2 i= n MdePkg/Include/IndustryStandard/UefiTcgPlatform.h? [Jiewen] No. We cannot move to MdePkg. TCG defines the field to be variable length. Something like below: typedef struct { UINT8 TableDescriptionSize; UINT8 TableDescription[TableDescriptionSize]; UINT64 NumberOfTables; EFI_CONFIGURATION_TABLE TableEntry[NumberOfTables]; } HANDOFF_TABLE_POINTERS2; typedef struct { UINT8 BlobDescriptionSize; UINT8 BlobDescription[BlobDescriptionSize]; EFI_PHYSICAL_ADDRESS BlobBase; UINT64 BlobLength; } HANDOFF_TABLE_POINTERS2; The implementation can choose its own length as they wish. Thank you Yao, Jiewen > -----Original Message----- > From: Xu, Min M > Sent: Friday, January 20, 2023 3:40 PM > To: Gerd Hoffmann ; Yao, Jiewen > > Cc: devel@edk2.groups.io; Aktas, Erdem ; James > Bottomley ; Tom Lendacky > ; Michael Roth > Subject: RE: [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper > functions in SecTdxHelperLib >=20 > On January 19, 2023 5:54 PM, Gerd Hoffmann wrote: > > > > > +#pragma pack(1) > > > + > > > +#define HANDOFF_TABLE_DESC "TdxTable" > > > +typedef struct { > > > + UINT8 TableDescriptionSize; > > > + UINT8 TableDescription[sizeof (HANDOFF_TABLE_= DESC)]; > > > + UINT64 NumberOfTables; > > > + EFI_CONFIGURATION_TABLE TableEntry[1]; > > > +} TDX_HANDOFF_TABLE_POINTERS2; > > > + > > > +#define FV_HANDOFF_TABLE_DESC "Fv(XXXXXXXX-XXXX-XXXX-XXXX- > > XXXXXXXXXXXX)" > > > +typedef struct { > > > + UINT8 BlobDescriptionSize; > > > + UINT8 BlobDescription[sizeof (FV_HANDOFF_TABLE_D= ESC)]; > > > + EFI_PHYSICAL_ADDRESS BlobBase; > > > + UINT64 BlobLength; > > > +} FV_HANDOFF_TABLE_POINTERS2; > > > + > > > +#pragma pack() > > > > Why do you need this? For standard event types we should have those > > structs already defined somewhere in edk2 I think ... > > > FV_HANDOFF_TABLE_POINTERS2 is related to standard event type > (EV_EFI_PLATFORM_FIRMWARE_BLOB2). > According to comment > (https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Industry > Standard/UefiTcgPlatform.h#L145-L156) we can see this event type uses the > structure of UEFI_PLATFORM_FIRMWARE_BLOB2. It is not a data struct with > fixed size. Instead its size depends on BlobDescriptionSize. > Tcg2Pei measures the FV image with the event type > (EV_EFI_PLATFORM_FIRMWARE_BLOB2) and data struct > (FV_HANDOFF_TABLE_POINTERS2). > Tdx measurement does the same measurement to the Configuration FV > image. > @Yao, Jiewen Can we define FV_HANDOFF_TABLE_POINTERS2 and > FV_HANDOFF_TABLE_POINTERS2 in > MdePkg/Include/IndustryStandard/UefiTcgPlatform.h? >=20 > Thanks > Min