public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Vang, Judah" <judah.vang@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
Date: Mon, 7 Nov 2022 18:41:49 +0000	[thread overview]
Message-ID: <MW4PR11MB5872123A1A066DC1890049FB8C3C9@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221107183640.3470-1-judah.vang@intel.com>

Hey
Would you please split this patch set to two different one? They are two different HSDs.

Please aware that we are in software freeze phase now.

I suggest we include 3991 in this release, because it is an important bug fix.

I suggest we defer 3992 to next release, because it is feature enhancement.

Comment is welcome!

Thank you
Yao, Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Judah
> Vang
> Sent: Tuesday, November 8, 2022 2:37 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=3991
> https://bugzilla.tianocore.org/show_bug.cgi?id=3992
> 
> There is a #define to deprecate Sha1 functions but not
> all the Sha1 function are wrapped around this #define causing
> a build error. The fix is to wrap all Sha1 functions with
> the #define.
> 
> Need crypto AES to be supported for PEI phase and need
> crypto KDF to be supported for SMM phase. Update Readme
> to show AES and HKDF defaults.
> 
> Judah Vang (2):
>   CryptoPkg: Sha1 functions causing build errors
>   CryptoPkg: Need to enable crypto functions
> 
>  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf    |  2 +-
>  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf    |  2 +-
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++-
>  CryptoPkg/Readme.md                               | 26 +++++++++++---------
>  4 files changed, 29 insertions(+), 15 deletions(-)
> 
> --
> 2.35.1.windows.2
> 
> 
> 
> 
> 


  parent reply	other threads:[~2022-11-07 18:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 18:36 [PATCH v2 0/2] CryptoPkg bug fixes Judah Vang
2022-11-07 18:36 ` [PATCH v2 1/2] CryptoPkg: Sha1 functions causing build errors Judah Vang
2022-11-07 18:36 ` [PATCH v2 2/2] CryptoPkg: Need to enable crypto functions Judah Vang
2022-11-07 18:41 ` Yao, Jiewen [this message]
2022-11-07 18:45   ` [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Judah Vang
2022-11-07 18:47     ` Yao, Jiewen
2022-11-07 19:06       ` Judah Vang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5872123A1A066DC1890049FB8C3C9@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox