From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8849374003D for ; Fri, 27 Oct 2023 07:06:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CaNa8kN9rbrj8Cxoyy3+MtFViiFjTX9YCJ6UU3vr39Y=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698390397; v=1; b=CgHr48o0qTkhyH9zvfzwnQd3/bBrqmsRm4uw7MiIRXnIJqnmqRicBb1ruYSlQZ5CG8R9QM+T 8+B/kYt5KoLBs45RcdjPYEVUYwECb2zAzAom1SjTMn2mLHiciyWdA6MzIywUPhRIkS1qnvSVYe4 vHiGGZQ8yQbXmCxmVNv1HMsM= X-Received: by 127.0.0.2 with SMTP id YGvYYY7687511xm1GbZYRlCS; Fri, 27 Oct 2023 00:06:37 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.1589.1698390395901648816 for ; Fri, 27 Oct 2023 00:06:36 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="454185331" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="454185331" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 00:06:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="759522118" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="759522118" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Oct 2023 00:06:33 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 27 Oct 2023 00:06:33 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 27 Oct 2023 00:06:33 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 27 Oct 2023 00:06:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8IV1Can2hv8RJ9EGk/jIE80wN2YTxkCDwo4eZ+KNeIpigpJWj2O06kM08gn2ossJ5B6A0zW5FrxB3u5SVHPuQ8Kf/bjmvlLLZNrm2PICkkKLJoi6763AExAy9qfY4El3t4F9KBeHRyU4YWidpnXvEuLIU5ZvsxXa9CNxv0LQgvSkFEHZRccjsQJg1XdEmUaLwznLuWy3J5S+x98jkYcdeHA3iJS3BSO7co0u8nAzthttKQYvte+4g3OX3j7osQZMJqGYKL4GqN9blJ0Ok3ZWIELfUKUZ4OwakgrbvCVDxoD/gmzU88Hki+mHCrsMlTJA9IMdGXruVld+BrjthN5Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZIDyEOZTUYCWxbKEqyaLT92OIJ2fgSmVl2SKzZhW3s=; b=Vmbu4L4PiRS7QIgaI4WNGh90XXUKyLyTxUua+fXSOYtBxtWa5mmuGgw75sdNW6l8O2wp6yNHunbykJ36HOKtpyxb2xAwRUP3eU4mPkERRpYBHA7B85oIBTmAKvgsizUd5gdu7XY0XExkSUYuWjnT8iaIDQF9DUqrovm8g86v+TBcRf/3z+X/Fk8BDVC3O8n+sB1XqJmTQLAfcm310VEVJKIQgWWvWsjovySJFfOtKFjyV9mYmvOdzOYiAAVjF5685/bRoNI4E/9CgpPUsCm3ZcqfwM8quMoIGvJ1RrvdkQz9+GptSZBvC9SY4ucObuwLJu/+sjBRPrLW9Mhq9LGJSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH7PR11MB5766.namprd11.prod.outlook.com (2603:10b6:510:130::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Fri, 27 Oct 2023 07:06:31 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257%3]) with mapi id 15.20.6907.032; Fri, 27 Oct 2023 07:06:31 +0000 From: "Yao, Jiewen" To: "Tan, Dun" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Thread-Topic: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Thread-Index: AQHaCJiEbq0hqvyGs0+1Tmniw3oYDbBdIKuggAADw7CAABCdIA== Date: Fri, 27 Oct 2023 07:06:30 +0000 Message-ID: References: <20231027054300.1382-1-dun.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH7PR11MB5766:EE_ x-ms-office365-filtering-correlation-id: 36d11889-f669-485e-927b-08dbd6bb3f32 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: +yBG9ktmnlAi9Xw8As7lqX8ixApT9WOy02+m22GXUxEmrr0gTrGFzX8j7uqIcDyK871BJzVCvqQcKdAJVf261AaBVJoNnqzqSVkAk/sjTHP3zH1gviXoAbair3HCMYhsBIogqPs08IfGsJbHEOFTOJ5Vpk3pwe8WNe10zlkV39p+nTtGOgRByuosH5qSR41NGaSwvgVZWCT3LTpS2Fhq2pq+9lh8NaEqmuU5o//tRMe7FvA2vyCHYCXVffY37wD4C8YFyzlrzTbBlfW9DI21rj1+K8H9BD18NvbfhdsvLMSwetogNL3sZPl7h+EW65eGfNohRmhGV/AEtIkMXSoZCgk+2JYPCB3G3mDQD03ABEcdBlJTESxfSnrCHNrf0vYlMa9vMU+oytimTyto3mdzwHzNK9E43uCRJ2Aytcj7pxJG4q+IxFdAig9BugpufSfMBUsLbKPnqaIq61sGBAgFZUk+oaXKJJ0ugIvWy6nKxi4lwYehkg3032aPJ/E9IU/PayszjXXAvUpJf4uz4Ai/Gxf+VuqHHB8Omm99EVg30xAPYSDzUHr/2MMnVbGkUlABbr0g3beMnh1/llLKqC9VCLso3xOGUGK1C5ki+4CVRj/06L+ux6+MKbtl+Lg9jzT+LqUkRn446frQZ3O7ebv8YA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AzpY8HCmdpwH8EjSi9UaT49izHGnUVYNjvNwD3MxGuYLcWceGgkxT88L3tej?= =?us-ascii?Q?D14pIfip6WzVBMU6OaiXjCkmd/gtsp2d/F22GKomZVrsJcvcNAirZVe98Cqx?= =?us-ascii?Q?8aN5hJiQ6Hhtz6k51Vo68PcWomJl920Z6OaCWqY1x81Tcu7ye/MPkWtAmJbx?= =?us-ascii?Q?wOd2oV+4kPJ8JEdblwbhblNrrS8qmGSH4doXooypR6YSwcqHEIM3vp2oSz4M?= =?us-ascii?Q?/ycLY6vfwxq5aZizOHcvulLCD80IklbaXzAOyqsJUTr1tAhK4vg9NcgfL9Nn?= =?us-ascii?Q?dCeuJJFASCB3KghSgRxE9i+0FOMIVDQmtNQVokl5MEeLIvDsTcKlMPybEqGw?= =?us-ascii?Q?4o0ZFI2WXnAWlKvvr20XjcXb7ufxPT1UpmsYmkS7AKbeope8m9l8c6qiAIiL?= =?us-ascii?Q?b1ln5n2K37PuMfcUg8Tz9X1M9/g+nK4nVUn7ZfV/6kK3j1wiIApHC2kDTDic?= =?us-ascii?Q?kUlrmlEetWdKv9lEidKXV4+wtg62xMwsyuJbmMXgKabjVKTNjqPEAFN4f2Yu?= =?us-ascii?Q?TYkywlBUnLo5VEuPgEOz8KJubvPKOrdBXVIBmBazDSz8Q8ywD/38HKjzRhLf?= =?us-ascii?Q?LamqZLW2SU2AonQpLx+IVgfuY5V0M7v6Wvwy+0lCEqjnqFVAmLbnRrnh2HrK?= =?us-ascii?Q?3i3sBSOpjBHtc1bEmR59Hd1TNW0H6IhskoUGJmzX9Qt9121A9gV4JUSYTXr0?= =?us-ascii?Q?FmBnK9w14RGbASVJ1c0LcWoF8ElQeE8QGGSyeoLbPjp8IkuMvTl5cw8aI5lE?= =?us-ascii?Q?wJQwZ2C40b0Qev3kAbiByaNCfEaYN/F0k6ZYVkcX03RE1pVhS8xejrvxT/jW?= =?us-ascii?Q?uRYMhwRRaxN49w7aX7oWyGT+TdTnzNZmBiXdvM0b91CSaRm4LSEtH0xf2zLO?= =?us-ascii?Q?S5nkEA9ZtMj3qRnFgtr24T0kIzDztv8kdM9VnXO9zevxbFB7Gd3Nd9/IJtu7?= =?us-ascii?Q?TRa1k0tmEqeWpTd8YRYkcfe0zrVmPD1GpfkvUxAju43YzNlcXeNIx6vLOwXi?= =?us-ascii?Q?nM5s/qHgYEx2tlC815OuUSpa+xy7nbX1IHasC+/wpJ8TQbwvLQkGOjk0819g?= =?us-ascii?Q?aSrhysPsyeYJz6zOx1TvEitbtnEOdDUm6e2P9ZWmh0y/2smnXHSQq+jLUe7Y?= =?us-ascii?Q?Ow9522wNB4LbVS1nDgfLyfsPfvBmtNoG+6kJvcE1Gpf3HIkrkG1bqXlpM7n8?= =?us-ascii?Q?/bLi2k7Pa8/UAOGavbU8mA/nWNhvGFQRH+GLUjR8Tg9e0IA7IVe4DttTIMXD?= =?us-ascii?Q?IOJyOZQiGR7hu3W0HwRDIbShQt7NVnDlgFuB9vD97gP9W4jCFnt82N0sa2I4?= =?us-ascii?Q?r/EOV7Is7zWLgqBfKHGoMu/RrdfMO2rp6KG1Kjalz4RYCEtyF3ia6rUBkAWZ?= =?us-ascii?Q?AKi6sAgUEyz4MNsmXPxqyr7OdE7Ps4gp32pAuq9dFXla34Cm/Rw6ZlUWVwzV?= =?us-ascii?Q?3SXdcy4/HtieQqvhCdgW9hDCR5Tv0H1G0BgxYR8dyTKAqJBlohfDq4mHn5ko?= =?us-ascii?Q?izTpMA0nMWFkJBj2BFUPszOquHbOiwlR8FiMmH8LvDrRQ1tw8h6ZiqBuN4B+?= =?us-ascii?Q?U/XtddXCM7Te1ItCcun9pyiFFYKEqcUwRFq7a+IF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36d11889-f669-485e-927b-08dbd6bb3f32 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 07:06:31.0040 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oJKKot1EYwtcVQl8fJ43pcR/d4Bj5a0/Ry3yNHNB93XKUErJUAsNIaE9abonBUPHnEPd8t8Q67vCY9oSo6mObw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5766 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: S8r3HTT0nmAMiFHA4gpNi30Xx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CgHr48o0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Here is my suggestion: 1) Please perform the test to ensure the functional part is correct. Without that, how can people know you are doing things right? 2) If you do not run any test, before you send out patch, please call out t= hat clearly. That is important to reminder the maintainer: Don't merge, even if it pass = review. Otherwise, once the review passed, the maintainer may merge it. I don't think that is the intention. Thank you Yao, Jiewen =20 > -----Original Message----- > From: Tan, Dun > Sent: Friday, October 27, 2023 2:32 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibInt= rinsic > and remove BaseIoLibIntrinsicSev >=20 > Hi Jiewen, >=20 > Currently I'm working on the Tdx test. Since the patch set doesn't change= the > code logic when Tdx or SEV is enabled, so I want to send out the patch as= soon as > possible to see if there is any comments from community. >=20 > I will include AMD SEV reviewer in this patch series. Thanks for remindin= g. >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Friday, October 27, 2023 1:49 PM > To: devel@edk2.groups.io; Tan, Dun > Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibInt= rinsic > and remove BaseIoLibIntrinsicSev >=20 > HI > Since this impact TDX and SEV, would you please let me know what kind of = test > you have done? > Have you validated TDX and SEV before you submit the patch? Please descri= be > that clearly in your patch description. >=20 > Also please include AMD SEV reviewer in this patch series. >=20 > Thank you > Yao, Jiewen >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of duntan > > Sent: Friday, October 27, 2023 1:43 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH 0/7] Support Tdx and sev in > > BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev > > > > The goal is to have single BaseIoLibIntrinsic instance that can also > > used for sev and Tdx. > > In this patch set, string I/O instructions are deleted in IoRead/WriteF= ifo API. > > Then change the source file of BaseIoLibIntrinsic to also support Tdx > > and sev feature. So BaseIoLibIntrinsicSev and related assembly code can= be > removed. > > > > Dun Tan (7): > > MdePkg: Create TdxLibNull.inf instance > > MdePkg: Add CcProbeLibNull and TdxLibNull implement > > MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c > > MdePkg:support Tdx and sev in BaseIoLibIntrinsic > > OvmfPkg: Add CcProbeLib in PlatformInitLib.inf > > OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files > > MdePkg:remove BaseIoLibIntrinsicSev related code > > > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 14 ++++= ++++++--- > - > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | 61 > > ------------------ > > ------------------------------------------- > > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm | 131 ----= ------------- > --- > > ---------------------------------------------------------------------- > > ---------------------------- > > ------------- > > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm | 293 ----= ----------- > --- > > ---------------------------------------------------------------------- > > ---------------------------- > > ---------------------------------------------------------------------- > > ---------------------------- > > -----------------------------------------------------------------------= -------- > > MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c | 45 > > +++++++++++++++++++++++++++++++++++++-------- > > MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h | 166 ----= ------------------ > -- > > ---------------------------------------------------------------------- > > ---------------------------- > > -------------------------------------------- > > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm | 120 ----= -------------- > -- > > ---------------------------------------------------------------------- > > ---------------------------- > > -- > > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm | 282 ----= ------------ > -- > > ---------------------------------------------------------------------- > > ---------------------------- > > ---------------------------------------------------------------------- > > ---------------------------- > > -------------------------------------------------------------------- > > MdePkg/Library/TdxLib/TdxLibNull.inf | 21 > > +++++++++++++++++++++ > > MdePkg/MdeLibs.dsc.inc | 4 +++- > > MdePkg/MdePkg.dsc | 2 +- > > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- > > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > > OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 3 ++- > > OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- > > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > > OvmfPkg/OvmfPkgX64.dsc | 2 +- > > OvmfPkg/OvmfXen.dsc | 2 +- > > 21 files changed, 83 insertions(+), 1077 deletions(-) delete mode > > 100644 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf > > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm > > delete mode 100644 > > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm > > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h > > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm > > delete mode 100644 > > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm > > create mode 100644 MdePkg/Library/TdxLib/TdxLibNull.inf > > > > -- > > 2.31.1.windows.1 > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110196): https://edk2.groups.io/g/devel/message/110196 Mute This Topic: https://groups.io/mt/102215661/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-