From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 39A2B780091 for ; Wed, 8 Nov 2023 13:21:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NgqL8gfCOwfVHoIABQQpIWID/bqbhRUt1Agyw61WlyA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699449676; v=1; b=R041fPxKG9AV/Y3FQijUxDP6Mj+5uFZj9lufcPO3Bnh2xjGYMeGbX3owznVm2a3vjjU2nj7P BjsXcPImmrtnBe1DbG+kqdMXj7udLwORTx90UDl1aAzJvf+I4LuWfCnE/2rgP6A37+iirOluERG n3GDbgYcKEyLggn2t71KN51Y= X-Received: by 127.0.0.2 with SMTP id Y98tYY7687511xBFAOsOgfLd; Wed, 08 Nov 2023 05:21:16 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.13315.1699449676155556575 for ; Wed, 08 Nov 2023 05:21:16 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10887"; a="389569052" X-IronPort-AV: E=Sophos;i="6.03,286,1694761200"; d="scan'208";a="389569052" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 05:21:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10887"; a="763055139" X-IronPort-AV: E=Sophos;i="6.03,286,1694761200"; d="scan'208";a="763055139" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Nov 2023 05:21:15 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 05:21:15 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 05:21:14 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 8 Nov 2023 05:21:14 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 8 Nov 2023 05:21:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ivExsSI0eBzX88Y/cNki5+xqicWxOrpMPuKHrv6hjJN8EPZS6ZfSQlgrR0Abl49jse+PoCgkAK4DU/EnBb1D4TYtxfdhW1VjGjqJiSAKAA8+afnIbDv9ZdlGBKmCETkcIJycYyU6C/SNBHIf0iF9/QFIwQaZ/NPentbjzAzQ2LmaA/4h28+yOrMTXDUDcpr1I79MOgmi52tYgvYqu7AMY1Q+3L9quSFgX0Mi0qEb60JoCNqsLLod6MPDYdeZbI2woFpskwrkJd0t8BcZgcs3PmOOqbqKAESsdFMMfnKqY/LaPBqc5PyTOK07AjLSu0knPwQQb2emx980Z44R8ks/xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BV9yD3mAjSXGgIRGhSX8n3tS9KD30Ujer2ZQhzx6v4c=; b=EFKGGdBK7v1kFDBCjF7yDzrT9gp1URiP1duFvu+cffLahjILFZbqN79odV7gtfFt6MLkAvpvuUEnfDPJSkuIIFLmlFzTGGIONcMPB46bAWZ3yMfzLbzYIdfh1RuQBDEUPnyeIqRQz+Tt+UDmyYoUcDCW7wr51kO8fHviA+bL/dQLy8UcqfLix9fSwtepi7uw4x/XzKpvstj36jES7fBMnJXuhWfySHmTgaakvWrnhY2EOsz2SE0Zxc9CaMBD/gfK0ZJzbpMtVu40uDdOeu2edD1HEJHri51PX+GKIAk/cTtelESzV9ZA0DhahpjNl3pFhYeRLQz1RV+O90B8FbjiHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SN7PR11MB8044.namprd11.prod.outlook.com (2603:10b6:806:2ef::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.25; Wed, 8 Nov 2023 13:21:12 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257%3]) with mapi id 15.20.6954.027; Wed, 8 Nov 2023 13:21:12 +0000 From: "Yao, Jiewen" To: "Sun, CepingX" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Kinney, Michael D" , "Aktas, Erdem" , "James Bottomley" , "Xu, Min M" , "Tom Lendacky" , Michael Roth , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH V4 0/3] OvmfPkg: Update TdVmCall to handle the retry for MapGPA Thread-Topic: [PATCH V4 0/3] OvmfPkg: Update TdVmCall to handle the retry for MapGPA Thread-Index: AQHaEjg8qknLj53mhU6OMJfONwxv7rBwaFEQ Date: Wed, 8 Nov 2023 13:21:12 +0000 Message-ID: References: <20231108113827.3917-1-cepingx.sun@intel.com> In-Reply-To: <20231108113827.3917-1-cepingx.sun@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SN7PR11MB8044:EE_ x-ms-office365-filtering-correlation-id: b0e6dfc4-844d-4df9-c218-08dbe05d93ea x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: sXfuWj70LnqBa/LlDid+hM1AmUXsReh/97gp3wUs0jxICeJNLeOyuPzw17X7m5pQtVeE03nurd+Z3rStpa2U9Kj82q0boTulXxCvnZu6BssH+ipp6jWJVO5JfUOuj/0RuIdB1Zg9z5LWrIh4oZooPpN7BWNnIiDcEaLAvT7/h6rbaqiFQEUChvVOg56JF6UNKbB/S3lDJR5n24sBVjFMbm5GrUSA6zJixk4+aTeyypXmCSUbGc9mPx+cMfjJRkmnlchLTI7NFZnGFCeYVBPI8slntl0Fbfl3K8VJ0xXGBygx71nXq26y+5BTMUbWMNzIu+5JuQz/YxgOAN+w+kwD+fuoGEAHEcobMriID1emfZumL0BgmzvT2trGHXFpHPxpXB+giucLQypzWPmJonHLaohCA0+dh9LKaAmu2O006QjdTwV+LPbllLPJExeouSo8k7p2DsFuomeXgTJfwVPF4h5l3G1mQ03bWNitU3H5Y5emDpdvtqEZyu5XR7uXm1BcKovypGF1yPa4DWzb4KDKtZZsw6bwrV3LJFoQ7JBycJj3U0nEfO1PY2hEu6GNxbbrodxD+tuE+7AuBGGWn0AVZQ9Y6EG+Rf/BRKVAmV21uhAW3n90YdGRz4QNQmoZWXFhhmhHF5YTGX6iEsOozon59Q== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nfeNQHQKwQRyUN9Db7YZtPiuzYjl2yrQSks4m4YAnekbB339ahBRbAbCbYdL?= =?us-ascii?Q?Zh6V9WcZnN5nO1gZkPk2YYyDK/GC2KQF1XLn04cZQpea1UI2AloqDvQ3bk5P?= =?us-ascii?Q?3YTHmixuob9EnWmEdld3JXh2BN5tVEYlhSBkRiSUA1ICORrEkHpIEyIAtEmt?= =?us-ascii?Q?XL2u4QsNHbqTa1vKxMwaBMivCNrubv/J0f/Ws6dQSrA3LJ3AfKQpsL6BNQFH?= =?us-ascii?Q?XZC7yUDQXkr0NrKzT8sSwEfvWdbmuuz1gQlSv/xTvJ4v75K1LjxnXyun02cs?= =?us-ascii?Q?4/9hQh5IqqeFPeObMYpzG43vmBZtVcBcXgNa+Aa1jPjtoFAyObs4/yVJ/Z0n?= =?us-ascii?Q?wg4s8p3HGTZYo91VJZFxSSUvSxVbtEy1sQSafCkc4E5mrIbmTg3Ezb+uvPQP?= =?us-ascii?Q?h2OZOrTUy9+HUXbse3gXkmiF2uG0M0oruAwpNQmblR+Hxg/HNLm8knSouOlK?= =?us-ascii?Q?AgqJzw4Dcofl0WOTAQ7sbtwGGKfLyjyv5r2KDIP3aYpJ2L6wpRo0DcYsm3+Z?= =?us-ascii?Q?UxPGvFwYS1SLIkch++DCdrgbOg7WeqEc9OURTDagxL2T7QA+U6INUEceSwls?= =?us-ascii?Q?6lqLg3gSYBOlsnxfEZsOa6X6JM3T1aeENP/tr5P4X3HgZjzYHXtn/00dQTNe?= =?us-ascii?Q?4hgKWRt76JPsypBvnA2myCVAnODD9HffSGhOaTJ5QIspAcY507NNkicLXyPp?= =?us-ascii?Q?KQnVHLnWhv0fTnl0hqkuFn7gw3mZYbzsqxbT/loePzEUPWny+mzE1MmQb6gM?= =?us-ascii?Q?fKEAMVMiy/A9r32Sk94ieBxjdJQsqoaJuayaxeSN1D3SYGTSsB9H7RqKc32i?= =?us-ascii?Q?pRpDwkcMi1qLB4MOwUPMAGOcsp2xJjNRx08e0TTbph3NZzQcO7ykaDcEEi3g?= =?us-ascii?Q?ReaSdTM058/VdJGvjazdEeF+8Up0erRQFzeDGg6xGThamxxoD7nTAJT0dWzt?= =?us-ascii?Q?G9UL+jtLIo56lmelHW1h9Wb1phQpqaC3tcqUSpOpnOIc52qEXpD3EI5rzX3U?= =?us-ascii?Q?W05aMkiwIslsQMP+ZvZDhMoav6tkPCpPxgfT+Rd6nN9bmF1ArdgW70ON2O9W?= =?us-ascii?Q?WqMNcsXVdMDRy/SgDtnKc6SM34rKZKOqSCdAQLd7/hB1YbhcTckaFCLdqg+X?= =?us-ascii?Q?AGRYluRgd7HJeFcCZwdcl8qX0hY6XS7ztVh3aak4ABrlZxow6hhekyOon7fq?= =?us-ascii?Q?vs5k6c0EOcJHN/lVFTFqU99tH6nrcJH8LQ1PFzXhHCbG15EFpiblT0REVhgS?= =?us-ascii?Q?L/BA9cewqLL4NIMY+cw9sb41xHIfYzoM/4F4ECqxwsPTK0PSQfjKPGVYMYq2?= =?us-ascii?Q?DhFT2/gtgj93tbhw5F9p22ihGwfxxQdIlLI1OWPlBmJYK8VMHGieLHIiSjoY?= =?us-ascii?Q?ZvZPl9aSnyExusNZUlKRIWAraPsFd+vM+aBc68CeZMtSrEoOkfwSsT8H2GZs?= =?us-ascii?Q?lHpzbQYLVK24Z3Kjd0aw6cAebfIV5zhfqGpQ9IXk9PyeThRRJziLyhz6yBbz?= =?us-ascii?Q?ZIa6hvojVxTqtq/iXlsGF/gn0CPxgEmPS7fSVGOlRhRg5yLvx4tK0SWtb7C8?= =?us-ascii?Q?ldTvkkcEdPCd3rHRrxkyGkTPCw8xSCQJZogZzIu+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0e6dfc4-844d-4df9-c218-08dbe05d93ea X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2023 13:21:12.0883 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7ZQg0mIWcNg0mbB42SFrmf1MnJ153/nXc+eex41UKJf9pr8rOdUZLrHd2jg/FJJSXmDi5mRVr4itQvwx4Aoh1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8044 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 28TWW8iEEjZcZB7eNovQFwbqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=R041fPxK; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io All: Reviewed-by: Jiewen Yao > -----Original Message----- > From: Sun, CepingX > Sent: Wednesday, November 8, 2023 7:38 PM > To: devel@edk2.groups.io > Cc: Sun, CepingX ; Gao, Liming > ; Kinney, Michael D ; > Aktas, Erdem ; James Bottomley > ; Xu, Min M ; Tom Lendacky > ; Michael Roth ; Yao, > Jiewen ; Gerd Hoffmann > Subject: [PATCH V4 0/3] OvmfPkg: Update TdVmCall to handle the retry for > MapGPA >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4572 >=20 > According to section 3.2 of the [GHCI] spec, if the result is > "TDG.VP.VMCALL_RETRY" for TDG.VP.VMCALL.MapGPA, TD must retry the > mapping for the pages in the region starting at the GPA specified in r11. >=20 > Currently, TDVF does not properly handle the retry results of MapGPA. > For this, TDVF should update the TdVmCall to return the value in R11 > and must retry the mapping for the pages by the value. >=20 > How to verify the retry for MapGPA in TDVF: > Note: Since the range size of MapGPA in QEMU is limited to 64MB and > TDVF always maps 1.5GB( 2GB~3.5GB) MMIO to shared-memory for TD guest, > the retry action is triggered always. > Pre-Config: > QEMU: > https://github.com/intel/qemu-tdx/tree/tdx-qemu-upstream | tag: tdx-qemu- > upstream-2023.10.20-v8.1.0 > KERNEL: > https://github.com/intel/tdx/tree/kvm-upstream-2023.10.16-v6.6-rc2 >=20 > Step: > Boot with TD guest and check the log with TdVmcall(MAPGPA), as below: > TdxDxe:SetMemorySharedOrPrivate: Cr3Base=3D0x0 Physical=3D0x80000000 > Length=3D0x60000000 Mode=3DShared > SetOrClearSharedBit: TdVmcall(MAPGPA) Retry PhysicalAddress is > 8000080000000, MapGpaRetryaddr is 8000084000000 >=20 > Reference: > [GHCI]: TDX Guest-Host-Communication Interface v1.0 > https://cdrdv2.intel.com/v1/dl/getContent/726790 >=20 > v2 changes: > - Update the code based on the comments of v1 reviewer > - Update TdVmcall to instead of the extra API file >=20 > v3 changes: > - Move the definition of TDVMCALL_STATUS_RETRY to Tdx.h >=20 > v4 changes: > - Split the patch to MdePkg update and OvmfPkg update. >=20 > code: https://github.com/sunceping/edk2/tree/handleRetryMapGPA.v4 >=20 > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Min Xu > Cc: Tom Lendacky > Cc: Michael Roth > Cc: Jiewen Yao > Acked-by: Gerd Hoffmann > Signed-off-by: Ceping Sun >=20 > Ceping Sun (3): > MdePkg/BaseLib: Update TdVmcall to always output the value in R11 > MdePkg/Tdx.h: Add TDVMCALL_STATUS_RETRY > OvmfPkg/BaseMemEncryptTdxLib: Handle retry result of MapGPA >=20 > MdePkg/Include/IndustryStandard/Tdx.h | 2 + > MdePkg/Library/BaseLib/X64/TdVmcall.nasm | 4 +- > .../BaseMemEncryptTdxLib/MemoryEncryption.c | 41 ++++++++++++++++++- > 3 files changed, 43 insertions(+), 4 deletions(-) >=20 > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110912): https://edk2.groups.io/g/devel/message/110912 Mute This Topic: https://groups.io/mt/102461779/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-