From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.25527.1664176346004859876 for ; Mon, 26 Sep 2022 00:12:26 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YR+cMvpC; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664176346; x=1695712346; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ucG5m/YGfDjHuR5c+cmU/gNQzLDnNDrImelYkFmc0Vs=; b=YR+cMvpCe02hrMc0pBhZh6ETkbTmvPv7HgoLTl3eJsb4R+pxH/+kpB2z Twfh7Z3/+IEdjO1EtH3yV151phbB6JrUVwvTffF6PZA710SYOGjTKq/j/ HegiRoh6pV7x/A/irOPKiKzYalbqDZKlW9HdgkDFttMjsxqgIkM2KFEEX FQuWrfaRNtInHXt12WpD0DLZQaXvkXOhU4kwehRrowEP5wFEg7ktFazD9 vQWjuxh0CrQYUpKC2PIUVXcxGQTvP1jBbm37YfcyHLh08qw0pH30trYnK Ng4ltR/OeNHjKuJQfssndFM9uZOTYR01dIp19XsMeX3LqtmUiLWPiRJnu A==; X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="327301543" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="327301543" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2022 00:12:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="616296954" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="616296954" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 26 Sep 2022 00:11:24 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 00:11:23 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 00:11:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 26 Sep 2022 00:11:23 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 26 Sep 2022 00:11:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItWoZPB3KPfPd2xEKOxL2+EunMpWG0IFi8to78BJkQkrQzK/Hkh64O7uDE4fivDaLXCAwoSO4B/8Kp45HVotnKFyfWvZ9sAHJ8JWf1ETglF6FWpbc0hFSF2gN3PfjqEr21XY/NjzH5F7fiwjRhdeMV5Xge/mvJ/iecGSxFbeYtJcT6P5zz0lvv4DAE1nfuou6cBZuRfZSWDjbWpIgFpoPWFntfOsytyWrrv8jUSMjF6w/5tuX7oU9Yt3hfwptyp6Y9CWfQn8wbpawtvDtQBjJAyeeK+CxiZUuqWn4WkzvgNa+e2kSBxfxuB544hlukI5raUH5U5XrULVNlqa6onEFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TMQt6cNcstHLQ00EmdYkz/VXI8kfMtF1DxScKq8NJY4=; b=HxMq1PY2mQ/E56N622iStT6ch7ES7VTa/MmW7E/ts/ImqDLXhCVN4dEIewCBgmLHD+kUUKmwxgz1yvOWLgJAhqaw7j5dF1Y0uSbpDJyzetyV4C/eYViZXMVHIM/yUC3ato1pXWUuCVRi/EaqsRxSVxLTDFHk0i5x3QRGXWCiVLOS3QK1B1cqpVP4E5fjHIqAJhsPLbfXLFbbbFR/8kUVxB4Y+YOmYOJENOkAIR9qCXqNkmAASHrjuNDSvcLzoFJ8lLWH7MPIqATiG1n14s9IlgGRMTwdsKss7OOvOtB1/PRfTluoDOFFdnVNv7cwdjBwyFXPqZmcl23Wco3ig9Si5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MW3PR11MB4698.namprd11.prod.outlook.com (2603:10b6:303:5a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Mon, 26 Sep 2022 07:11:16 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 07:11:16 +0000 From: "Yao, Jiewen" To: "Li, Yi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" , "Kinney, Michael D" Subject: Re: [PATCH V5 0/4] CryptoPkg: Add EC support Thread-Topic: [PATCH V5 0/4] CryptoPkg: Add EC support Thread-Index: AQHY0MDq1klprXGmW0C+MlY2YqvgAK3xTLIw Date: Mon, 26 Sep 2022 07:11:16 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|MW3PR11MB4698:EE_ x-ms-office365-filtering-correlation-id: 94318f3e-76e0-47b1-3e1e-08da9f8e4da3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZaQkVUpZwGA0ckxfqQdBoT6HtSUoD6z88UO8ow9uvCHg7KEqSofBZH/PtyYZi6f9cCnylNKqtpv8A9ZQHfR617r7tq3GA57TO9yR3lIIjsub4BYOOPW+AU1T+8OJEF8w66eE2wFwSkzD1pxrCbpYkdo01OqlOInW4pOmkMHh6T8hC0RG7+mrIW3fVG+G558gZ6vOgudkZEww+WDY/APx59WhabQvZVpINqH+iJ7TUyEHgWO69/o4llD+6U+DeOGlnV4p05rW8k1tB/vwY5TAnCvI9z2IWjpUPJQw2wJd8vi3PcsmaQzECKCn9rUpHsPPEKZ/oIfEEtYa7O9o+KQB3LpzpPCNJLi9Zph8Onmh1mAdbnUfRNrOLvRnVc0WQz5Qjo9vUZQyhuE9VOujgahSQ3M5pX6bS7AbG5XupoWHsDY3Oqypyz5nI9WqNinRAMNy0C2+wikJOANnNxaxpfxp/q5zwqiGFBWspHqlqYBdIjwjHI+cQjqQMPfCQUdrGG7ZVHTawVD1CpWA96Cs9TOEbQvLEwEQeUF0eP3TAA5O0OUYq/o5tTZNq8P3TcMqvM+ZCy6XslXJI5Q0yYQfY8g8H/mO/TlsJr9qhtq04ukZ90jg/xqEBd5Nsi3h+eBCROquuTxTnADLYl7eZ68OtG6QXL6t07d5AKxoPTU5fjX9Q6Lb9Kt4SA/KYFL+xUsuFcjEvCUs92wOiKu+54TuPe+SUNGHuvyq9YrF3KPqUZxvAAqbcgepn2V+yC8NAAMGpMZH6phhBkdSBHtkpUXrHCtt6MASsyeCt5vHyu2IxWWjE+4tzxPkF3zGUCdgWb5RbpZFWqn7bfeS1i80veOm2Nj6og== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199015)(54906003)(110136005)(26005)(478600001)(5660300002)(9686003)(316002)(66946007)(66556008)(8676002)(76116006)(66476007)(71200400001)(7696005)(6506007)(8936002)(41300700001)(107886003)(53546011)(52536014)(2906002)(83380400001)(122000001)(38100700002)(186003)(33656002)(55016003)(86362001)(966005)(4326008)(66446008)(64756008)(82960400001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LubhbBphQPe9oMLfSsobG1G30LIOjvEsQ3vJ2P1AMaEV504jMLnytf30RNcM?= =?us-ascii?Q?6hfltt+tnV/LAwbwrEvdwy0A7Jvsgz/AoU3twTc3WPOcgzvjIA9kkAk7JYLM?= =?us-ascii?Q?hpRGnPYyoLtN4psXx2bUo8T8t6v2sAW+qgwMg9aRVl9kMEFCWve03i2FBn8k?= =?us-ascii?Q?eGvfz3BFcg5ZK16n2PGIaQa8tCwulqkMpo60DX1MM2jR3x4ZgWFGzwQpY0um?= =?us-ascii?Q?eFxwG7q9OlKKuB+R9neYGlgVSVTKdjSxGyiPaumr+ROldHoqbymQYDLH4W1Y?= =?us-ascii?Q?QWDUt3uUOQXnKgpzf5bbM7Bch0c2//vY56TizwvU9G4BoUGGxyNuEMzKM24k?= =?us-ascii?Q?IuOagspwjcxEGiPYe66lsxqaaxjJVJIUiUQ8loK6OyrdpenN84qSUHSrGflZ?= =?us-ascii?Q?t4YI124PTuAy7oYv64jbHyeK6/5aE+NULbFAXwOKWcIVa/T22KlEnmJCv6UG?= =?us-ascii?Q?dHwv57BUHuFPd4I34dTmGr8CURhVApncD5d+gtKrGz3DIsic3ZhrQEhN9G3d?= =?us-ascii?Q?H5KOu973Adkbuez8hXcbD9lGGbUpifee/wyWdwScy86czKmtnkIxr4a4JdP4?= =?us-ascii?Q?wOzsnFnFte6LIZOjqFh4R2Y4x4uXZPKIt0iEYn6+732hMHUqwcKVXkTnlDqU?= =?us-ascii?Q?xZLyNfWw4WWwEOfMwUQMyxLdmuwWKOWkrGG7q5GKyRwlEbC0bL+eDtrlcKFK?= =?us-ascii?Q?5erNPj9wRuWXYIabbIMKSIal+28qkuYObxMmyuxVM/2LdMrSwddYpVgK63Ci?= =?us-ascii?Q?gVI8uRTd8dF+yquVJ2SSfaY8fTQOztsxNXdLbUWW+EBFzcp0gFwkmqCT2W9E?= =?us-ascii?Q?5y+cOQa601SRDTh2zmSpp/vjf0+YAwt02ie4xPrE77Qz8ZGVRo/n7EP7jCkw?= =?us-ascii?Q?Y8zXNsuMOXvB42ayctrH5hoIoIsSiU1aXEJa/OGZcmlVGgRzXIMEynBA5H8e?= =?us-ascii?Q?dZ0J+KOVxBLuj/tQVNHrcYoT8siUsIOrbAfUZokgqSbMWzvnYOKVHf4vfpLt?= =?us-ascii?Q?ssSlr8nV5cMqpM5VASbNvzF8bjfJocdWUDEG62YWdoqfWg+ookG/9xzCJGf/?= =?us-ascii?Q?ccduLtCU5E4PJmJm76zm0qANGJbI8N2/Wuxtf1Nkc9KO3CNLOFsMd9l3+qbU?= =?us-ascii?Q?Hm88MeiKYJBahd6M8t0gvoGpr/42sKTykuT++0PtyOi6Th8z1rAclhAyrZhQ?= =?us-ascii?Q?w+3uMlF3YUusybtPsUQhBaX9xxJBYAmtc7AN8kmdvnEbSUkk8Hau0i1hh6xq?= =?us-ascii?Q?vyVs0MfrpRclQnZsKytSyj3vtEcYqxUf8d0aDqmBrtQtg9H8CgRP+Sw4CMDo?= =?us-ascii?Q?YH/kZdWBshCOdHiqAvFTHl+ths1Yjj6nw21DLwmmp+ZbnVqnmz/NqKHSiuMy?= =?us-ascii?Q?MEPF+81Jk1Msa9aiN/62bdaj3/noHH6VHRW40w+DqLGLBDC2eGUsZp736Ilc?= =?us-ascii?Q?xY8/4ae3ZYsTnxOh4UUhHtzjo3yuME+6NrEiW7BFKh8+Mibsq8kLRmMMlS5a?= =?us-ascii?Q?27aSQDKpdVDT4TDVIQNsjySdckxRaXjJn0A3EsudGGn58g6Nblf1ICDEShRv?= =?us-ascii?Q?6YwQ85GcHqlKaCoQOMAs/0/gXm53UAWjBqT36/ZV?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94318f3e-76e0-47b1-3e1e-08da9f8e4da3 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 07:11:16.2437 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zfpy+VfnvqETLHK+Ap9FAXVMD3DCVwuC27CsjvT+iFSfn+EytFDPwjg7cmXfcOuurO00Jr8DITM0zrH4HrBpkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4698 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3403, with minor typo fix. > -----Original Message----- > From: Li, Yi1 > Sent: Sunday, September 25, 2022 5:26 PM > To: devel@edk2.groups.io > Cc: Li, Yi1 ; Yao, Jiewen ; Wang, > Jian J ; Lu, Xiaoyu1 ; Jiang= , > Guomin ; Kinney, Michael D > > Subject: [PATCH V5 0/4] CryptoPkg: Add EC support >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3828 >=20 > Review PR: https://github.com/tianocore/edk2/pull/3398 > This patch sequence is used to add CryptEc library, which are wrapped > over OpenSSL. The implementation provides library functions for EFI > BaseCrypt protocol and EFI BaseCrypt Configuration Protocol. >=20 > All APIs passed unit test and fuzzing test, detail as: > 1. Unit test: > The purpose of unit testing is to ensure that the function obtains the > expected result under specific input, that is, to ensure the correctness > of APIs. > All test case show in patch 3 :CryptoPkg/Test: Add unit test for CryptoEc= . > 2. Fuzzing test: > Various Fuzz Testing are employed across the all introduced APIs, and the > test is used AFL (2.52b) and Libfuzzer (clang+llvm-11.0.0) as the fuzzer, > based on HBFA. > Fuzzing Pass Rate is 100%; > The Code Coverage new APIs is 90.3%. > All test case show in: > https://github.com/liyi77/edk2- > staging/tree/HBFA/HBFA/UefiHostFuzzTestCasePkg/TestCase/CryptoPkg >=20 > V2 change: > 1. Squash uncrustify tool update into previous patch. > 2. Increase EDKII_CRYPTO_VERSION to 10. > V3 change: > Fix typo in comment. > V4 change: > Add ECC related usage reference > V5 change: > Optimized the description of ECC reference >=20 > Tested-by: Yi Li > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Michael D Kinney >=20 > Signed-off-by: Yi Li >=20 > Yi Li (4): > CryptoPkg: Add EC support > CryptoPkg: Add EC APIs to DXE and protocol > CryptoPkg: Add ECC related usage reference > CryptoPkg/Test: Add unit test for CryptoEc >=20 > CryptoPkg/CryptoPkg.dec | 29 + > CryptoPkg/CryptoPkg.dsc | 1 + > CryptoPkg/Driver/Crypto.c | 496 +++++++++++ > CryptoPkg/Include/Library/BaseCryptLib.h | 424 +++++++++ > .../Pcd/PcdCryptoServiceFamilyEnable.h | 25 + > .../Library/BaseCryptLib/BaseCryptLib.inf | 2 + > .../Library/BaseCryptLib/PeiCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c | 765 ++++++++++++++++ > .../Library/BaseCryptLib/Pk/CryptEcNull.c | 496 +++++++++++ > .../Library/BaseCryptLib/SmmCryptLib.inf | 1 + > .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 + > .../BaseCryptLibNull/BaseCryptLibNull.inf | 1 + > .../Library/BaseCryptLibNull/Pk/CryptEcNull.c | 496 +++++++++++ > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 469 ++++++++++ > CryptoPkg/Private/Protocol/Crypto.h | 831 +++++++++++++----- > CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 3 + > .../BaseCryptLib/BaseCryptLibUnitTests.c | 1 + > .../UnitTest/Library/BaseCryptLib/EcTests.c | 290 ++++++ > .../Library/BaseCryptLib/TestBaseCryptLib.h | 2 + > .../BaseCryptLib/TestBaseCryptLibHost.inf | 1 + > .../BaseCryptLib/TestBaseCryptLibShell.inf | 1 + > 21 files changed, 4137 insertions(+), 200 deletions(-) > create mode 100644 CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c > create mode 100644 CryptoPkg/Library/BaseCryptLib/Pk/CryptEcNull.c > create mode 100644 CryptoPkg/Library/BaseCryptLibNull/Pk/CryptEcNull.c > create mode 100644 > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/EcTests.c >=20 > -- > 2.31.1.windows.1