From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 81296780479 for ; Mon, 15 Apr 2024 14:01:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aZJBBrbrpmWB6V/kuRY/Gr6Ed7t8oWQQ6noYmGpm0IE=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713189660; v=1; b=5TZ/skREQ29OmlEWI8zdCpnyP7xFF9opBQ2IuXodgu4enTM3YCxOgGubqHbcz75q8gSjn0BI KjsfJJne1wDMlJAN8DydzQJVzdi+9xxehYSaNmRADsyVcsPAX2JYHgx2CX5FYgsfXudnbEXaYQr oTK54KG735T3HfzoanX7CcYIvWxVy3p1iGVpba8f9zAOJjPaLRuI3m392dAbjuNdCHVcAQ7WkBG sq/wfso+li97dzCP+kJhsFLbkATZmq3M4gzaYYXi+62XEPvGmycRNyIYV/yduoJZH/SHad5OI5k nWC226Ky8NANw62LMjv3yNHm4jNWcEmGYANbARcldHtug== X-Received: by 127.0.0.2 with SMTP id F1EKYY7687511xMRZ4jJpJNk; Mon, 15 Apr 2024 07:01:00 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mx.groups.io with SMTP id smtpd.web11.21888.1713189660150166947 for ; Mon, 15 Apr 2024 07:01:00 -0700 X-CSE-ConnectionGUID: 3b1Aea8dT3qGTSzFA3cGwg== X-CSE-MsgGUID: k4nI5LfYTw+P9NJ8D/OtZQ== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8749980" X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="8749980" X-Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 07:00:58 -0700 X-CSE-ConnectionGUID: 0qeL1s/XQ3WKP1CbYiS6EA== X-CSE-MsgGUID: mimlAGELSwG/toMNRpWzEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="26591028" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Apr 2024 07:00:58 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 15 Apr 2024 07:00:57 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 15 Apr 2024 07:00:57 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 15 Apr 2024 07:00:57 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 15 Apr 2024 07:00:57 -0700 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 14:00:54 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9%4]) with mapi id 15.20.7472.027; Mon, 15 Apr 2024 14:00:54 +0000 From: "Yao, Jiewen" To: "Kuo, CindyX" , "devel@edk2.groups.io" CC: "Kumar, Rahul R" , "Bi, Dandan" , "Tan, Ming" , "Chen, Arthur G" , "Chen, Xiao X" , "Chen, Tina" Subject: Re: [edk2-devel] [PATCH v4 0/1] SecurityPkg/OpalPasswordDxe: Update UI according to UEFI spec Thread-Topic: [PATCH v4 0/1] SecurityPkg/OpalPasswordDxe: Update UI according to UEFI spec Thread-Index: AQHajLPfVQf99e0AcE2xY7A1pIMO8rFpYPrw Date: Mon, 15 Apr 2024 14:00:54 +0000 Message-ID: References: <8a6534ad58af4caf89d7d11725ab15fdcb1e424e.1712910291.git.cindyx.kuo@intel.com> In-Reply-To: <8a6534ad58af4caf89d7d11725ab15fdcb1e424e.1712910291.git.cindyx.kuo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DS0PR11MB7997:EE_ x-ms-office365-filtering-correlation-id: cb3bb16b-430a-43ac-1d98-08dc5d547765 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: O8SD6A+ZcSovu57PqZT62ASteECCjczPguen0Ny5iUL7ZpailHo+NzL0SVLmBmMnb59ckHnItDD34bmjUD8p2mixwH6WkETfALHiz5npq0rn57Zr8fCeUag+Urn/2qhyUGuPas/sc7OsQaeo/9l7y8qCd8wtVrbeTzxUvm7zK35rlBCpgjonLguyVBn1k5Iw/f9Uqw79ieBLRl6KC7mTKY5PKc4eKl8JlFww/CaiAz0k1Rbw3ltdMxDyHOSJEz+8DJSIergTBN+O3rTjB/Rirgb9uVwtvszhZVQGWnBl6qPqWQtIRLZgwFwPABD4tPF000748mKuKtecmgfL6cP8sDRVL2G8mqbAPPElMPjujEZTF4JN2Tuc6TbxfxJxXRIZ3ErDe/7FVwvs/8Xs++8j+AOUGHoDfflurUEiwUh/LSHtCbkr1RkVFROJR0JoZy43Zudd+DQxuPm/jb9pdtdgomNCFZ253OQTrwD+3e4vB7aYjxydEuEG1GAc60x919Gif2jW612Jlb6At2fpohUPCQFyQ7FfBh6DIZ6xyGuEhXT9XMp9e9unLjtG/nAAPU/JQ5X0ncim1DwkZo1vnBqni9vP5S2T/9Luh61vGzWZ5qPvfAFZtSd7ZmYOq3lC958QpI0CvlcU6RvCG7AvFk0MrXv0t2b3GHnobPfeO5jU+jo= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O4qi4v57kLwAKoZVI6jYb7H7dS+0Yh2JLlSHMbTrs2GUXAgce2cbPyWg7H7g?= =?us-ascii?Q?SosndMmY/6o/4O8Cb+k5B2G6OK707CFXvq+e7AXKGY/LbROsGZ7Fc0qLXNqi?= =?us-ascii?Q?FxIFwjFLO8rSnTJdQkoHrVx8VdpxJDcFSJ6CtotqaynciN41OV6/SZGUwl1C?= =?us-ascii?Q?olx/kbpdg/5aN/a+Iqg6fsVccSS1Vc8ajxNZOSFkKwIYk+1gn329idIYodWL?= =?us-ascii?Q?HIOHyL22WM8LIdl5McHoI6AwcoSs1wR7BVyDMxcY5WbNV97pO235fbaFK4lt?= =?us-ascii?Q?l14pMS5L3nYxskqM7vO0cREOFIw5yE82vO0d7FEAQ6+SmR3amXkrrj0tbzg+?= =?us-ascii?Q?JYmB/0lPLBYjLB7UOXZdGIYIfftss58M2beLYrnQIoiEtXem6Tle7OohOepf?= =?us-ascii?Q?2OqFF71CdHq13GPyAYlXMgg/syXK75lxsvTBR1QNm/h/sePsGcbLyrL1bBQ7?= =?us-ascii?Q?DE/Pp+1WyUmZHLGSTzp5tyJPcruogI/SeifA1YwTMoPL0MBJJlxDbpw5qVTF?= =?us-ascii?Q?E6cA1/Vw1fUEpt+4uOq1mcvUwiufFFU+L6BLG+C+Moc9468MAhLEYtlDxS+6?= =?us-ascii?Q?9GabSOVYCZX8AcVVUM9/iTgohqbTo2mri+Ht2DrkGDOPtt6GU5EP59iQm5I9?= =?us-ascii?Q?yrOduGefAjYHpz0pxcnC0JUmcO09Cv/c2exl9+6bSrjNL88maqaCfILlw8yR?= =?us-ascii?Q?3BzZ8fVcVJPy+SbfYKnNtNyS/6ztHBFabqCqf94k+1dEHkzx8OkfemfNbU6a?= =?us-ascii?Q?ZCy0Mg8GKAegwyv7G08lBseviFrU+0fzE/MO44DeSd2mCScJdm2sDRrqgXWZ?= =?us-ascii?Q?dwriuBWmy5S4Eb5ExOduRkwVXH/oaFiLe6PMhTyOCVXsGiXVwiifGTIze9HC?= =?us-ascii?Q?v/4DKeMLqQaNPqimYwJlsIBSe9eeFaToxX9aGI5pyp3a+G1WUo/zrdi7s/ML?= =?us-ascii?Q?GU4i+G2WHJ2pgzoapADtTK2S3khK5dQB6qWZg+IK0k0PmnIbVALufj7k1WSb?= =?us-ascii?Q?WZfAhpYCjST0mvP2IY/RIyXmjEARjybwW0S+R5BbvDhXU/B0YgFc2S3z+ldX?= =?us-ascii?Q?ZvsF+p6oYOA7KTrEGldBHybOYbuNxomnya7wKVoLaDqKk0tYGTj3BiUj/LGy?= =?us-ascii?Q?/udEnW5sbnso8oVT9kRz7X+riD+9Gis6B5b03Eh66UqJPB9rWok+FGYQRxOv?= =?us-ascii?Q?X3vxErUqhaTTR6eccaB6AfZurfGuolZ7+AsoZZrfXdVmW3i7gkflhGN2eDaP?= =?us-ascii?Q?PzdrcF3uQI6hbZcGQulEzShQMYK5anCcJBYDMN3AaiHMxTG/1wf+MisgppLz?= =?us-ascii?Q?FX0MnYKwg//DsqSHWoI2r54R6kBu79o3ae8A8VFNQRa6F/VpBNQzbtN6cGh6?= =?us-ascii?Q?j5N+hKpTyQr/7M3DsARGanBMLmrSOhr9wGRoAOwYRLtHqemKbLmAjX5dMwL9?= =?us-ascii?Q?RnDwavgLcNEu8Z1F0zDYEqyVuTAHDnWGf92vfkwcASPngP9cB1OUhewgBWkq?= =?us-ascii?Q?ET4e8OKETur8QJ6sltP+Sas1UbpGw6FkXYIy5K112b6RIaB8mQLUPe7tk4VR?= =?us-ascii?Q?XzXzwQ+psFu9wJn9H0UXx4+lSKD2q/cLvgZuevSP?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb3bb16b-430a-43ac-1d98-08dc5d547765 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2024 14:00:54.1420 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wL8mmvVqdZDoPPNBohFLJYUUFrv2IeX8XpAzapUxNi3nEmMtRSBcjSLEdqTvpGMYO8ZgEHJRo4CWOS2QFta1Iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7997 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 07:01:00 -0700 Resent-From: jiewen.yao@intel.com Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uRYgiO72XhFGCrDxXRhmjxUzx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="5TZ/skRE"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io I am not sure why patch 0/1 contains the code. It should be the cover lette= r. Also, if Dandan has already reviewed that, you may add R-B tag. > -----Original Message----- > From: Kuo, CindyX > Sent: Friday, April 12, 2024 4:31 PM > To: devel@edk2.groups.io > Cc: Kuo, CindyX ; Yao, Jiewen ; > Kumar, Rahul R ; Bi, Dandan ; > Tan, Ming ; Chen, Arthur G ; > Chen, Xiao X ; Chen, Tina > Subject: [PATCH v4 0/1] SecurityPkg/OpalPasswordDxe: Update UI according = to > UEFI spec >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4735 >=20 > Should not call HiiGetBrowserData() and HiiSetBrowserData() in FORM_OPEN > call back function. > Those APIs are called within OpalHiiSetBrowserData/OpalHiiGetBrowserData > which have been used by OpalHii.c. >=20 > Change callback action from FORM_OPEN to RETRIEVE. >=20 > Cc: Jiewen Yao > Cc: Rahul Kumar > Cc: Dandan Bi > Cc: Ming Tan > Cc: Arthur Chen > Cc: Xiao X Chen > Cc: Tina Chen > Signed-off-by: CindyX Kuo > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c > index 8035f44ebe..56ada1a9f3 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c > @@ -632,7 +632,7 @@ DriverCallback ( > HiiKey.Raw =3D QuestionId; > HiiKeyId =3D (UINT8)HiiKey.KeyBits.Id; >=20 > - if (Action =3D=3D EFI_BROWSER_ACTION_FORM_OPEN) { > + if (Action =3D=3D EFI_BROWSER_ACTION_RETRIEVE) { > switch (HiiKeyId) { > case HII_KEY_ID_VAR_SUPPORTED_DISKS: > DEBUG ((DEBUG_INFO, "HII_KEY_ID_VAR_SUPPORTED_DISKS\n")); > -- > 2.44.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117787): https://edk2.groups.io/g/devel/message/117787 Mute This Topic: https://groups.io/mt/105478921/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-