[PATCH v1 01/28] MdeModulePkg: Add a new GUID

[PATCH v1 01/28] MdeModulePkg: Add a new GUID

[judah.vang]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594

Add a new Variable Store Guid.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
Signed-off-by: Judah Vang <judah.vang@intel.com>
---
 MdeModulePkg/MdeModulePkg.dec | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 40601c95832b..681607db0da6 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -4,7 +4,7 @@
 # and libraries instances, which are used for those modules.
 #
 # Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
-# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR>
 # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
 # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<BR>
 # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
@@ -93,6 +93,14 @@ [LibraryClasses]
   #
   TpmMeasurementLib|Include/Library/TpmMeasurementLib.h
 
+  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
+  #
+  EncryptionVariableLib|Include/Library/EncryptionVariableLib.h
+
+  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
+  #
+  ProtectedVariableLib|Include/Library/ProtectedVariableLib.h
+
   ## @libraryclass  Provides authenticated variable services.
   #
   AuthVariableLib|Include/Library/AuthVariableLib.h
@@ -505,6 +513,9 @@ [Ppis]
   gEdkiiPeiCapsuleOnDiskPpiGuid             = { 0x71a9ea61, 0x5a35, 0x4a5d, { 0xac, 0xef, 0x9c, 0xf8, 0x6d, 0x6d, 0x67, 0xe0 } }
   gEdkiiPeiBootInCapsuleOnDiskModePpiGuid   = { 0xb08a11e4, 0xe2b7, 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1  } }
 
+  ## Include/Ppi/ReadOnlyVariable2.h
+  gEfiPeiVariableStoreDiscoveredPpiGuid     = { 0xa2fc038d, 0xfdf5, 0x4501, { 0xaf, 0x8e, 0x69, 0xb0, 0x20, 0xec, 0xe6, 0x63 } }
+
 [Protocols]
   ## Load File protocol provides capability to load and unload EFI image into memory and execute it.
   #  Include/Protocol/LoadPe32Image.h
-- 
2.26.2.windows.1

回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

[gaoliming]

Judah:
  Is there the detail information or wiki about the code design and usage
for this feature? 

Thanks
Liming
> -----邮件原件-----
> 发件人: Judah Vang <judah.vang@intel.com>
> 发送时间: 2022年3月26日 6:03
> 收件人: devel@edk2.groups.io
> 抄送: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Nishant C Mistry <nishant.c.mistry@intel.com>
> 主题: [PATCH v1 01/28] MdeModulePkg: Add a new GUID
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> 
> Add a new Variable Store Guid.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> Signed-off-by: Judah Vang <judah.vang@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 40601c95832b..681607db0da6 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -4,7 +4,7 @@
>  # and libraries instances, which are used for those modules.
>  #
>  # Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
> -# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR>
>  # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
>  # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development
> LP<BR>
>  # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
> @@ -93,6 +93,14 @@ [LibraryClasses]
>    #
>    TpmMeasurementLib|Include/Library/TpmMeasurementLib.h
> 
> +  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
> +  #
> +  EncryptionVariableLib|Include/Library/EncryptionVariableLib.h
> +
> +  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
> +  #
> +  ProtectedVariableLib|Include/Library/ProtectedVariableLib.h
> +
>    ## @libraryclass  Provides authenticated variable services.
>    #
>    AuthVariableLib|Include/Library/AuthVariableLib.h
> @@ -505,6 +513,9 @@ [Ppis]
>    gEdkiiPeiCapsuleOnDiskPpiGuid             = { 0x71a9ea61, 0x5a35,
> 0x4a5d, { 0xac, 0xef, 0x9c, 0xf8, 0x6d, 0x6d, 0x67, 0xe0 } }
>    gEdkiiPeiBootInCapsuleOnDiskModePpiGuid   = { 0xb08a11e4, 0xe2b7,
> 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1  } }
> 
> +  ## Include/Ppi/ReadOnlyVariable2.h
> +  gEfiPeiVariableStoreDiscoveredPpiGuid     = { 0xa2fc038d, 0xfdf5,
> 0x4501, { 0xaf, 0x8e, 0x69, 0xb0, 0x20, 0xec, 0xe6, 0x63 } }
> +
>  [Protocols]
>    ## Load File protocol provides capability to load and unload EFI image
into
> memory and execute it.
>    #  Include/Protocol/LoadPe32Image.h
> --
> 2.26.2.windows.1

Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

[Wang, Jian J]

Hi Judah,

You could update the readme in edk2-staging or your own forked branch.

Here's an example in edk2-staging repo:

https://github.com/tianocore/edk2-staging/tree/ProtectedVariable/libs

BTW, I didn't find the cover letter patch (the file with name starting with 0000).
Please don't skip it and use it to give summary description for the whole patch series.

Regards,
Jian

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Monday, March 28, 2022 4:55 PM
> To: Vang, Judah <judah.vang@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Mistry, Nishant C
> <nishant.c.mistry@intel.com>
> Subject: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID
> 
> Judah:
>   Is there the detail information or wiki about the code design and usage
> for this feature?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Judah Vang <judah.vang@intel.com>
> > 发送时间: 2022年3月26日 6:03
> > 收件人: devel@edk2.groups.io
> > 抄送: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Nishant C Mistry <nishant.c.mistry@intel.com>
> > 主题: [PATCH v1 01/28] MdeModulePkg: Add a new GUID
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> >
> > Add a new Variable Store Guid.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> > Signed-off-by: Judah Vang <judah.vang@intel.com>
> > ---
> >  MdeModulePkg/MdeModulePkg.dec | 13 ++++++++++++-
> >  1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec
> > index 40601c95832b..681607db0da6 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -4,7 +4,7 @@
> >  # and libraries instances, which are used for those modules.
> >  #
> >  # Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
> > -# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR>
> >  # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
> >  # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development
> > LP<BR>
> >  # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
> > @@ -93,6 +93,14 @@ [LibraryClasses]
> >    #
> >    TpmMeasurementLib|Include/Library/TpmMeasurementLib.h
> >
> > +  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
> > +  #
> > +  EncryptionVariableLib|Include/Library/EncryptionVariableLib.h
> > +
> > +  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
> > +  #
> > +  ProtectedVariableLib|Include/Library/ProtectedVariableLib.h
> > +
> >    ## @libraryclass  Provides authenticated variable services.
> >    #
> >    AuthVariableLib|Include/Library/AuthVariableLib.h
> > @@ -505,6 +513,9 @@ [Ppis]
> >    gEdkiiPeiCapsuleOnDiskPpiGuid             = { 0x71a9ea61, 0x5a35,
> > 0x4a5d, { 0xac, 0xef, 0x9c, 0xf8, 0x6d, 0x6d, 0x67, 0xe0 } }
> >    gEdkiiPeiBootInCapsuleOnDiskModePpiGuid   = { 0xb08a11e4, 0xe2b7,
> > 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1  } }
> >
> > +  ## Include/Ppi/ReadOnlyVariable2.h
> > +  gEfiPeiVariableStoreDiscoveredPpiGuid     = { 0xa2fc038d, 0xfdf5,
> > 0x4501, { 0xaf, 0x8e, 0x69, 0xb0, 0x20, 0xec, 0xe6, 0x63 } }
> > +
> >  [Protocols]
> >    ## Load File protocol provides capability to load and unload EFI image
> into
> > memory and execute it.
> >    #  Include/Protocol/LoadPe32Image.h
> > --
> > 2.26.2.windows.1
> 
> 
> 
> 
> 
> 
> 

Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

[Yao, Jiewen]

Agree with Jian.

I don’t understand this patch set and the feature.
I request a design review in EDKII.

Thank you
Yao Jiewen

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wang, Jian
> J
> Sent: Tuesday, March 29, 2022 2:12 PM
> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Vang,
> Judah <judah.vang@intel.com>
> Cc: Mistry, Nishant C <nishant.c.mistry@intel.com>
> Subject: Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new
> GUID
> 
> Hi Judah,
> 
> You could update the readme in edk2-staging or your own forked branch.
> 
> Here's an example in edk2-staging repo:
> 
> https://github.com/tianocore/edk2-staging/tree/ProtectedVariable/libs
> 
> BTW, I didn't find the cover letter patch (the file with name starting with 0000).
> Please don't skip it and use it to give summary description for the whole patch
> series.
> 
> Regards,
> Jian
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> > Sent: Monday, March 28, 2022 4:55 PM
> > To: Vang, Judah <judah.vang@intel.com>; devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Mistry, Nishant C
> > <nishant.c.mistry@intel.com>
> > Subject: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new
> GUID
> >
> > Judah:
> >   Is there the detail information or wiki about the code design and usage
> > for this feature?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Judah Vang <judah.vang@intel.com>
> > > 发送时间: 2022年3月26日 6:03
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Nishant C Mistry
> <nishant.c.mistry@intel.com>
> > > 主题: [PATCH v1 01/28] MdeModulePkg: Add a new GUID
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> > >
> > > Add a new Variable Store Guid.
> > >
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> > > Signed-off-by: Judah Vang <judah.vang@intel.com>
> > > ---
> > >  MdeModulePkg/MdeModulePkg.dec | 13 ++++++++++++-
> > >  1 file changed, 12 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > > b/MdeModulePkg/MdeModulePkg.dec
> > > index 40601c95832b..681607db0da6 100644
> > > --- a/MdeModulePkg/MdeModulePkg.dec
> > > +++ b/MdeModulePkg/MdeModulePkg.dec
> > > @@ -4,7 +4,7 @@
> > >  # and libraries instances, which are used for those modules.
> > >  #
> > >  # Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
> > > -# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
> > > +# Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR>
> > >  # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
> > >  # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development
> > > LP<BR>
> > >  # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
> > > @@ -93,6 +93,14 @@ [LibraryClasses]
> > >    #
> > >    TpmMeasurementLib|Include/Library/TpmMeasurementLib.h
> > >
> > > +  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
> > > +  #
> > > +  EncryptionVariableLib|Include/Library/EncryptionVariableLib.h
> > > +
> > > +  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
> > > +  #
> > > +  ProtectedVariableLib|Include/Library/ProtectedVariableLib.h
> > > +
> > >    ## @libraryclass  Provides authenticated variable services.
> > >    #
> > >    AuthVariableLib|Include/Library/AuthVariableLib.h
> > > @@ -505,6 +513,9 @@ [Ppis]
> > >    gEdkiiPeiCapsuleOnDiskPpiGuid             = { 0x71a9ea61, 0x5a35,
> > > 0x4a5d, { 0xac, 0xef, 0x9c, 0xf8, 0x6d, 0x6d, 0x67, 0xe0 } }
> > >    gEdkiiPeiBootInCapsuleOnDiskModePpiGuid   = { 0xb08a11e4, 0xe2b7,
> > > 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1  } }
> > >
> > > +  ## Include/Ppi/ReadOnlyVariable2.h
> > > +  gEfiPeiVariableStoreDiscoveredPpiGuid     = { 0xa2fc038d, 0xfdf5,
> > > 0x4501, { 0xaf, 0x8e, 0x69, 0xb0, 0x20, 0xec, 0xe6, 0x63 } }
> > > +
> > >  [Protocols]
> > >    ## Load File protocol provides capability to load and unload EFI image
> > into
> > > memory and execute it.
> > >    #  Include/Protocol/LoadPe32Image.h
> > > --
> > > 2.26.2.windows.1
> >
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 

Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

[Judah Vang]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

I'd like to re-use something like this one.
I'm still reviewing it but so far I've only seen a couple of changes.

https://github.com/jwang36/edk2-staging/tree/ProtectedVariable/libsv2#readme

I can also send out of the cover letter patch.

[-- Attachment #2: Type: text/html, Size: 392 bytes --]

Re: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

[Wang, Jian J]

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Vang, Judah <judah.vang@intel.com>
> Sent: Saturday, March 26, 2022 6:03 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Mistry, Nishant C <nishant.c.mistry@intel.com>
> Subject: [PATCH v1 01/28] MdeModulePkg: Add a new GUID
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> 
> Add a new Variable Store Guid.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> Signed-off-by: Judah Vang <judah.vang@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 40601c95832b..681607db0da6 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -4,7 +4,7 @@
>  # and libraries instances, which are used for those modules.
>  #
>  # Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
> -# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR>
>  # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
>  # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<BR>
>  # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
> @@ -93,6 +93,14 @@ [LibraryClasses]
>    #
>    TpmMeasurementLib|Include/Library/TpmMeasurementLib.h
> 
> +  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
> +  #
> +  EncryptionVariableLib|Include/Library/EncryptionVariableLib.h
> +
> +  ## @libraryclass  Provides interfaces to encrypt/decrypt variable.
> +  #
> +  ProtectedVariableLib|Include/Library/ProtectedVariableLib.h
> +
>    ## @libraryclass  Provides authenticated variable services.
>    #
>    AuthVariableLib|Include/Library/AuthVariableLib.h
> @@ -505,6 +513,9 @@ [Ppis]
>    gEdkiiPeiCapsuleOnDiskPpiGuid             = { 0x71a9ea61, 0x5a35, 0x4a5d, { 0xac,
> 0xef, 0x9c, 0xf8, 0x6d, 0x6d, 0x67, 0xe0 } }
>    gEdkiiPeiBootInCapsuleOnDiskModePpiGuid   = { 0xb08a11e4, 0xe2b7, 0x4b75,
> { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1  } }
> 
> +  ## Include/Ppi/ReadOnlyVariable2.h
> +  gEfiPeiVariableStoreDiscoveredPpiGuid     = { 0xa2fc038d, 0xfdf5, 0x4501,
> { 0xaf, 0x8e, 0x69, 0xb0, 0x20, 0xec, 0xe6, 0x63 } }
> +
>  [Protocols]
>    ## Load File protocol provides capability to load and unload EFI image into
> memory and execute it.
>    #  Include/Protocol/LoadPe32Image.h
> --
> 2.26.2.windows.1