From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4E23EAC0ADD for ; Wed, 30 Aug 2023 03:45:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JYN6WzZlOqlsCLaN0Ffm48sOep2m/Rzyg1+mDHe09fk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693367102; v=1; b=GH0M42K2IKfl1g56ERAu7IwUmOcfyiBhZKisF9qtH09Tk78f7TEMcRxjx2hojr/4TXZR8aUl VLbod4hZY3BiUlNvu8aDV++lsuIeLafVpMPYZPR7BcrjaWamO5OaJcIX+8hRvXF4J6ud3/8OVob fAmnPh7lmdl07E5t3ae1YWGI= X-Received: by 127.0.0.2 with SMTP id cpfJYY7687511xuUkgFjb5jz; Tue, 29 Aug 2023 20:45:02 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.6415.1693367101958125708 for ; Tue, 29 Aug 2023 20:45:02 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="441903124" X-IronPort-AV: E=Sophos;i="6.02,212,1688454000"; d="scan'208";a="441903124" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 20:45:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="688733829" X-IronPort-AV: E=Sophos;i="6.02,212,1688454000"; d="scan'208";a="688733829" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 29 Aug 2023 20:45:01 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 29 Aug 2023 20:45:00 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 29 Aug 2023 20:45:00 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 29 Aug 2023 20:44:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iOmQhTyGPAmTPRKtt5myA/RjB6NbCxPsjj21TscHZSBYQJ/jp3lO65zMp5AwNusYmItI6kn9KD5hNdyxrmt5gAfSrfBYOudtLSc38pWIQ3mTjplyT3dVII+rluLV8Je0gbFt5ImgquqoRZrC+9eZYCwn3w/oi8JMsi0rGxkzP1r6T90McJbU+/fHXjRGC/3Vfi0R3GZw0m7aMbcui6gJptwqi3z8Wc15/2wX0Q0Ln9iS39lAg9qWI8CdBwci7rlXjEV6ASutUTD6rRedx1dgOzI52FAagW5zl1950xhSyp8W9D10BqZ1XmnmdBqxeQi6pQRneMIOQpTcD5n4v2H0FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/teYADYZ10BGN5+FzlfjNJUbO3oxMUet0VHbjQAmys=; b=eRZgSH2E3jT0OXZXXRtVtE/S9brFQ2ZPM9dMvcrtwzJOWucpiP5enLYx3wIipFy9Q9qlY5gHHj973x9JsXb+2UV/Tyou/4bJZFyJYI016699/RnUFHtCjkpE8WcAkMo3Nux4iEKV67s8UXHonoV9yXsxrQDX9/QL/cgqCvIDxzjHsxGLkemqs4HF9SDbn6+CXzRKzFSnTFHm103s7kH6jElXneolGghDEbFKM62TO+O6jpd+e8oowXMAIb9jXi1yWqoQ1CqsJXglwgDzwbmPLKtk59xnLlXF+SqH5PP+hjKX+jL7z50LZHmlHUuGEU993ZLsMtpDlUUU6CaWDmtXwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by LV8PR11MB8533.namprd11.prod.outlook.com (2603:10b6:408:1e5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Wed, 30 Aug 2023 03:44:52 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b%4]) with mapi id 15.20.6699.035; Wed, 30 Aug 2023 03:44:52 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static Thread-Topic: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static Thread-Index: AQHZ2s5/plhL1u0iQUiOaPIJ8/cgILACMwSw Date: Wed, 30 Aug 2023 03:44:51 +0000 Message-ID: References: <177B99510AB70F56.12117@groups.io> <24eb8e60-7ead-ad03-483f-6d9b6a999c5b@linux.microsoft.com> In-Reply-To: <24eb8e60-7ead-ad03-483f-6d9b6a999c5b@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|LV8PR11MB8533:EE_ x-ms-office365-filtering-correlation-id: fd752a4b-2563-428c-2733-08dba90b77af x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: lGIq4uZe0FH7D1gWynsB4zdvpzNo3sXNczhHLapr1PDrSVrgyWIw5/WsMo2R9Wfw/hq7P7ykW0EoivJd1nLxfGnIy0Hj8Mb3uY5h75dZOR4mGugfjXPpwsy0vtaDxY5nxFMa8wZ7B8d/ybf5f8nn/0zq2R00CFamiShsIQiPtIu8kAKe9nytCIODcKgH1Mw2oe7Pu2P5briqxcAZ7f7JXdJnGuOzMGIaVX46JOATu97maSOmivitcIbQSYeSuaxFm/pbRCWIV4a+ve3MyXq7EcOXXlQ4O2lmKVSbRwTR/6LLkjfu1MUjVlPe549VYLe6bEAsylhV33YJhydxDbGxeVnB3gGrVmnN1mobeC9IibKCFMfyWSvN03hvICIlhuVDg/ujR68MZZreTm3roqwZnzRyQngBC7I1y53o+fY9kdiau03nPX1k8vQDW8gmeNQjDkE1rO64b5y3BteNjWgExq8oVT+fz/8JKzOPnyaOA3h59HZc8EkyPJSlbwwgGGZGuuox86M9EhqVMiXC6aMXsb4EK8OKratF7dZX4ZGto+FoaC4YWX0VlXNWzxW3HX74VmEDbLPB8RmVxIYdUhcFdBE9efhE+dkOJjNAzt+LfBE= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DVJRa9pTC64jQu+K6tvbICo/y1GW/DiSIbfL8Dd9rTPAodYeyI3+oTsrfTZH?= =?us-ascii?Q?Zfgzzkz15WUddq4KY/OrHm9jxkBs0B+1V7Mfs7IpBa19o6FtBbkaqZBh4BdW?= =?us-ascii?Q?A3nZG0Ym1FPzPHhEdgiRvE7GsfI1kFDZz5w23GqrKgjNw53Quqh9NrRHpwsK?= =?us-ascii?Q?s4Pr1ngipdIwAKozZdsG/CP7iaNXi+J9SdegNYCF1BmMtw3PhbFAlKzUFF1i?= =?us-ascii?Q?PC2CVsm710eTQ8uWC6wDNXeFQFQPB9Yttj9e0vRbxwZq2FdiCJbUfIQHzz3M?= =?us-ascii?Q?twuxxoxMDu6vpJ74BGYo1A9iA2Utyr5qM4pz8VzgImA4bYn/Xuuq9U0j5RY9?= =?us-ascii?Q?WqoRnRWP+rjIc93HeOwtiuETmT+F9kCLBxVFEuPYQ+G/3RB6mXhdeJ2PoD4a?= =?us-ascii?Q?E0j18opS3JSxzUQj4rEM8YAiWLA7QWnmP74F6UN+EZYBb4hYANGOlM301hxv?= =?us-ascii?Q?pr7s9uXZojE/fcQGhA8zUU284U6uXMYCqYOM81WqeDYYq+cBTAqM7bm/knNt?= =?us-ascii?Q?OH7/p3POMUAKgyWig/3n+rBMirMMrL3s4/l4UdC+ZSAuWUXYHa+w+M/yDPmY?= =?us-ascii?Q?EHlFehqFoeQkng1Lp23SjQ04QiAAhbTs4IwaLasWqv4pw6a6Q7bLU0hGJKIS?= =?us-ascii?Q?i0Wkg2hVJ4jTVYFwANvpnKnX5cy6pliQaMtLcTbPhaSuQ6yR6EKM9+OU38vt?= =?us-ascii?Q?4B/iwesT8xLhw8qe6IwXb7cm1iBPqcxms6ftSkGd9/Hvdq2248+gBVFJwEoo?= =?us-ascii?Q?NfbPKOtCFJRMaRNJ3WKAXTuWxS9FiefySQtqKL23ltYsKcaZFTCVqA2tnouu?= =?us-ascii?Q?6y7FQ/ifY9FH8FRBkQQxtAcLeL69IjAhYAbFP7ZrnJEPZND5VJGHxccocqfs?= =?us-ascii?Q?hQsg7PjiScrm4qxtQJE7Au/BaTT1qlakyBMxvy7McJGzWYcipmqNYATNwFP/?= =?us-ascii?Q?SV89q9lOWR5lwP66V8gqYos3mcxBRPYaffC1dvLxC8gTF5pY/95rKCiQyBB1?= =?us-ascii?Q?vc/aSZji4J3McPNRt16ylLOImzlPK047ApwGZ5PgH3SHUePZNTUnySmJgSaf?= =?us-ascii?Q?zY8GUFirUD3It0XPxTtxsCwol5XRSk2zbveterUD2h8+gSNFQAOAApZw4Ht0?= =?us-ascii?Q?iAvu8QtwiLm5Cz5NuRGAP15OQLRz7AXU27LFY/8CThjKfuPa8cfSWnc6txAM?= =?us-ascii?Q?kkMxvXxNkNbkLKqOt0YOc+2yVkquNJ/HEFGGF2KyhlpRA/vO9W2bVnjnYJiY?= =?us-ascii?Q?F8uFJfggnfWUGzzd22RDUjB7QPrgcEJ6G1L87c1phBIlqUFv/lzxZ2cQEHh3?= =?us-ascii?Q?2P6O5puV1yNHwpwAN5HyKxGyIrtWfohgIe2mUdPeDEh0sjyIssxNpJbSiguN?= =?us-ascii?Q?Sw7se0tzyvQLIqhR2fkmGNEvhSSX1ouVMypy+9Jn8s7vs3muldY5UxgyKaHa?= =?us-ascii?Q?WumdIrni3Krwh5iIHVtUCfd0Rpus6UI33WbAsQjzfdR2/r7CXYVn4ZdVv5/Q?= =?us-ascii?Q?n9swMgHaJ5lic9wvrt/AW2wJaVx+cQXQFaLEaIUJP8gWqbsmt4fcho2JKdY8?= =?us-ascii?Q?J/uoDT9lpEaAtoK6FT9kwzJn8BDoDT3JRtVYVrsK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd752a4b-2563-428c-2733-08dba90b77af X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2023 03:44:51.8627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6f3GEXYIIWwjq1K7Dh+nMWtpiGW/dPPEAPkGNbvFHWvMWUo9SeqqjwFzTSxxP+vR1b+RQFuSVFSbYXWmcuRYLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8533 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BVumrqFzed7VXfVsGEPadok0x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GH0M42K2; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Merged https://github.com/tianocore/edk2/pull/4770 > -----Original Message----- > From: Michael Kubacki > Sent: Wednesday, August 30, 2023 7:14 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian = J > > Subject: Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: M= ake > mTcg2Protocol static >=20 > Hello, >=20 > Can you please help review this change when you get a chance? >=20 > Thanks, > Michael >=20 > On 8/15/2023 11:50 AM, Michael Kubacki wrote: > > From: Michael Kubacki > > > > The global variable has a common name that can conflict with other > > TCG modules. For example, Tcg2Dxe has a similarly named global that > > is of type EFI_TCG2_PROTOCOL instead of EFI_TCG2_PROTOCOL*. > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Signed-off-by: Michael Kubacki > > --- > > SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > b/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > > index 3c8cf4fa117a..c792b1d67b06 100644 > > --- a/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > > +++ b/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include > > #include > > > > -EFI_TCG2_PROTOCOL *mTcg2Protocol =3D NULL; > > +STATIC EFI_TCG2_PROTOCOL *mTcg2Protocol =3D NULL; > > > > /** > > This service enables the sending of commands to the TPM2. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108113): https://edk2.groups.io/g/devel/message/108113 Mute This Topic: https://groups.io/mt/100760659/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-