public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Li, Zhihao" <zhihao.li@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	"Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Subject: Re: [PATCH v1 1/1] OvmfPkg: Add dependency of VariableSmm driver to make it work normally.
Date: Fri, 1 Apr 2022 11:35:26 +0000	[thread overview]
Message-ID: <MW4PR11MB58721A5DB1125F9E1D9471978CE09@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220329063738.1098-1-zhihao.li@intel.com>

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Is this a standalone patch? Or one of a series patch?
I think it should be later. But, please enlighten me.


> -----Original Message-----
> From: Li, Zhihao <zhihao.li@intel.com>
> Sent: Tuesday, March 29, 2022 2:38 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Gerd
> Hoffmann <kraxel@redhat.com>; Boeuf, Sebastien <sebastien.boeuf@intel.com>
> Subject: [PATCH v1 1/1] OvmfPkg: Add dependency of VariableSmm driver to
> make it work normally.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3861
> 
> UefiCpuPkg define a new Protocol with the new services
> SmmWaitForAllProcessor(), which can be used by SMI handler
> to optionally wait for other APs to complete SMM rendezvous in
> relaxed AP mode.
> 
> VariableSmm driver need use SmmCpuRendezvousLib, So add
> SmmCpuRendezvousLib in OvmfPkg.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
> 
> Signed-off-by: Zhihao Li <zhihao.li@intel.com>
> ---
>  OvmfPkg/CloudHv/CloudHvX64.dsc | 1 +
>  OvmfPkg/OvmfPkgIa32.dsc        | 3 ++-
>  OvmfPkg/OvmfPkgIa32X64.dsc     | 3 ++-
>  OvmfPkg/OvmfPkgX64.dsc         | 3 ++-
>  4 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc
> b/OvmfPkg/CloudHv/CloudHvX64.dsc
> index 8ac9227c5f50..c5f8314a37b6 100644
> --- a/OvmfPkg/CloudHv/CloudHvX64.dsc
> +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc
> @@ -429,6 +429,7 @@
>  !endif
> 
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> 
>    PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf
> 
> +
> SmmCpuRendezvousLib|UefiCpuPkg/Library/SmmCpuRendezvousLib/SmmCpuR
> endezvousLib.inf
> 
> 
> 
>  [LibraryClasses.common.SMM_CORE]
> 
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> 
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index 29eea82571c5..e6122118e07e 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  EFI/Framework Open Virtual Machine Firmware (OVMF) platform
> 
>  #
> 
> -#  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> 
> +#  Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
> 
>  #  (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> 
>  #  Copyright (c) Microsoft Corporation.
> 
>  #
> 
> @@ -427,6 +427,7 @@
>  !endif
> 
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> 
>    PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf
> 
> +
> SmmCpuRendezvousLib|UefiCpuPkg/Library/SmmCpuRendezvousLib/SmmCpuR
> endezvousLib.inf
> 
> 
> 
>  [LibraryClasses.common.SMM_CORE]
> 
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> 
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 56d3c49ab21a..05c16aa3fd3e 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  EFI/Framework Open Virtual Machine Firmware (OVMF) platform
> 
>  #
> 
> -#  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> 
> +#  Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
> 
>  #  (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> 
>  #  Copyright (c) Microsoft Corporation.
> 
>  #
> 
> @@ -431,6 +431,7 @@
>  !endif
> 
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> 
>    PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf
> 
> +
> SmmCpuRendezvousLib|UefiCpuPkg/Library/SmmCpuRendezvousLib/SmmCpuR
> endezvousLib.inf
> 
> 
> 
>  [LibraryClasses.common.SMM_CORE]
> 
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> 
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index f0924c0f9d0a..ea42bee22cb5 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  EFI/Framework Open Virtual Machine Firmware (OVMF) platform
> 
>  #
> 
> -#  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> 
> +#  Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
> 
>  #  (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> 
>  #  Copyright (c) Microsoft Corporation.
> 
>  #
> 
> @@ -432,6 +432,7 @@
>  !endif
> 
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> 
>    PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf
> 
> +
> SmmCpuRendezvousLib|UefiCpuPkg/Library/SmmCpuRendezvousLib/SmmCpuR
> endezvousLib.inf
> 
> 
> 
>  [LibraryClasses.common.SMM_CORE]
> 
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> 
> --
> 2.26.2.windows.1


  parent reply	other threads:[~2022-04-01 11:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  6:37 [PATCH v1 1/1] OvmfPkg: Add dependency of VariableSmm driver to make it work normally Li, Zhihao
2022-03-29  8:39 ` [edk2-devel] " Gerd Hoffmann
2022-04-01 11:35 ` Yao, Jiewen [this message]
2022-04-01 17:10   ` Li, Zhihao
2022-04-02 12:38     ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB58721A5DB1125F9E1D9471978CE09@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox