From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.26903.1654866736046331529 for ; Fri, 10 Jun 2022 06:12:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=h+NNpPCr; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654866736; x=1686402736; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Q2vfu9w6H2XfuwqJueZTqTFqYKzEf2rZvV5YxcCPIKE=; b=h+NNpPCrrV/Je4CkxZUtQIykRrVkmIaJSFk/pgEjPKR4cKxX9cbXtMWn 4RcFgCggKy66xBWinzzZavKV9LhvfoDopCDsnfDPx2v7xJhpaW8Jdl0rm Kz3Mkk8ZjuOBB2APMw4E/H3CdMLQGzzrmqz1hHmeVhQlQQKiT9cEPsBcs KkwVMqwCeWGSOTggDtDFUNdoPw1rnBi7wCN1OCaSZWpHUWYJso5FGZrFE 1Dw6rzEAkRMC4gOhsFc75PzsVZVoIP3btCsGvoHtLTj+mml1zpP0e7ELT s1/57YVBu/bZuIG5EZPbY0jkt9mG5bPNgxJORoBMo/WwJGl7DJsrBGKEf w==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="275156873" X-IronPort-AV: E=Sophos;i="5.91,290,1647327600"; d="scan'208";a="275156873" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 06:12:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,290,1647327600"; d="scan'208";a="760504107" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 10 Jun 2022 06:12:06 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 10 Jun 2022 06:12:06 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 10 Jun 2022 06:12:05 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 10 Jun 2022 06:12:05 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 10 Jun 2022 06:12:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lnIcXA2BFVNbn/xzHOeR+R2x3A024xvEUzeCcFPPDdtOo83KNl99oB83BNGU27lvpT0XSxmzTxiT25MFmJq6tqH+R+D5elRJIQ9JB/TAKHpTPbymwJN1wVGEIMl/aUqD6E9bwmxPkKk8GfyrtKOmWnEBa8uJfRKntpHKxf/+HA/y7UGgQQ5LiXafz3kIHSjxrLcOartGWHCCYBhKigr74vUG521JkZbnLKmDm5Ys4D7CVXYfTm0n3QOlkNm6C/r2dpcx2+J5MfVUg/+cPdKOt77pbGi91Kc6XuacXYDTc33R4wDJspHLcDCvfafouecS47Ik3ew7l6UlI9uJc7R+PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jx1vvms99wZEU4xkq8cLNKcl4bTKX9xp13kWb4T63wM=; b=V4qMw4eC17wtmuB/KfUlX60dz0/ZZtKZ6kuBaoGeHFhNcPb7p9pGr+FTq7N1LW4ZX6TedXvvNS6hjiAgDnig0dI/ED5QCJ6TKCJ7L3hGEaar8oGLb8wHtDRg/g/APfYc2iFZNMITZ96VLjXWCeFU/rKDhpVyNXjhC3gSOn/fObqHTpkw47moaKrKAR612B+cGqh90f+l/5NOWEljnHWtJ7rWlEvMVVfEXk6Krp983vSJcNKeZG8sbsBXK4PCNAfBMC0h38RBv/XxlnjbtQpmtRBWQpcOetutQHJGaC3DxEoLTPmP/GP5ZIIN7MMVbsOOZkVqaY4kw+g0YMCppt7+pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BN6PR11MB1891.namprd11.prod.outlook.com (2603:10b6:404:107::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Fri, 10 Jun 2022 13:12:03 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e%7]) with mapi id 15.20.5332.013; Fri, 10 Jun 2022 13:12:02 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Oliver Steffen , James Bottomley , Tom Lendacky , "Justen, Jordan L" , "Chen, Christine" , Brijesh Singh , "Aktas, Erdem" , "Gao, Liming" , "Ard Biesheuvel" , Pawel Polawski , "Feng, Bob C" , "Xu, Min M" Subject: Re: [edk2-devel] [PATCH v6 1/3] Revert "OvmfPkg/Sec: fix stack switch" Thread-Topic: [edk2-devel] [PATCH v6 1/3] Revert "OvmfPkg/Sec: fix stack switch" Thread-Index: AQHYfLmsm/QaPI1XS0i0KR0zy+vwOa1InbrQ Date: Fri, 10 Jun 2022 13:12:02 +0000 Message-ID: References: <20220610110246.2031470-1-kraxel@redhat.com> <20220610110246.2031470-2-kraxel@redhat.com> In-Reply-To: <20220610110246.2031470-2-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ea8e550a-fa70-4c07-bff4-08da4ae2cf4c x-ms-traffictypediagnostic: BN6PR11MB1891:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DM0SPWGyIXrtuyKKKc81h8B2kM6MG8QNmRpbeUyv1RzPu9d/U3aBT/XaON87W0H8rskeh8xJ21Q10FnK/bZLfK3EmIix1QlGYtqkUlYIKRS/Xs/A+sZOuQpIcyBnz42fXhVU+4m3Bxlc/1IK0g/T012gSTtfABkBLU9aMrq2S80KO80qmhuXzl4hUNB2YfZjUalIu4l2xVyAXiEJJq0gJQCk9tJkkQCnHcZ/+f7tUWoLPHwBZBgAB+AULYyPgpjhcmjBY7BWsQycoI/FQZ59ACxo7QtcE62va2fnXMmB7qesjz5ayKkm9UgIVhKFdDMd1fASM3i2ABn51dvllTBemfOUd6F/nSbeVR8y+5SSdWCQalNB4qPlBGQfr1LdRB81ODwtzcLaI7txmo1sz+tckMP3sjFWlKK2G55DZFddFjck88Y/VvJ9/Js1IiROO+FVuh3CTAJprzh4b1BhSYy4tBayeVSuiPVvmdC+nwwX6+0MIFmFPIfMiSR6JBWpKHPmd9B/uh+Ll3NMzxd+5EGHdr4+9JVRMvyf4o7vJpiNpWNnDMuXwMQi2PzAY9SDIGoQkY8nhgGMmE6eo40uHfqYL8hjWGYlXsjL88CE8eX1a32LLIo5OwcoOs/+hXTiFfzHrD4TBWAc6/8vRlS1vcSLYz9JxMr3ZNj5dy7RV1UjY29BTbc56GgxSWHaoxGpih6PuSEoPSYCtNqTmj16zLs+9d8tRUOMQOiJky0/bK0XzggSV7mYKoBPOCu5OzKqAq4mTeVmantj/ln3P51ezizu/CaBeEOZfqzjBdAWXFAXMJ2y4LXmcIpzI3FGw8w6h4em2DFq33eje4E0ckzaLOqzMQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(5660300002)(52536014)(82960400001)(508600001)(83380400001)(122000001)(2906002)(71200400001)(966005)(316002)(110136005)(33656002)(54906003)(38070700005)(26005)(86362001)(9686003)(7696005)(6506007)(8676002)(4326008)(53546011)(186003)(7416002)(64756008)(55016003)(8936002)(76116006)(107886003)(66446008)(66476007)(66946007)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n+fYmj2s8NV4vINi7afXioHf7nru8RKci1rKiMFeVNq9ZzAnTw+i+D9p33zk?= =?us-ascii?Q?hBR68h3YqHl56Se8jKA7xIaowRSxmNmHtpTsJ9WSk7LnDezsY0+sjsaH4bPR?= =?us-ascii?Q?4igHTn7sMWtX8p3pA4VXf+PXcywePb+9sXjwHPXJjVlQ+QplLS1dBuRa22KE?= =?us-ascii?Q?6ZN00HD/A2rOX3tpLXxCM/r/RWIEUZ/Hnf6Vr/gJmlIj8u47JkecDIjCaDtg?= =?us-ascii?Q?w+FUk8uAHaYrjGQJVS1rO/FI1PgALyEIFM/Z3xPDHkGMfJQ87EQhGGO1x/jC?= =?us-ascii?Q?ax75NzmXxyb3I9D/ycf5esa9EkEQTiUE3L7fX4PMVGSGtJygYNGqDWlVtwL9?= =?us-ascii?Q?ScZeQIZ0DTs9zgoDxAnxoEfDU2F8SBL1wseOTlq8RORbQ7zSddRSrQ0nMQqN?= =?us-ascii?Q?wvbhiAFoF5l+gNbynZStNUEpKvvzbLl3qqS6TArH6cAVKDyrRgun+bhCyanI?= =?us-ascii?Q?IzM3jCcxAMJVHYq7kKV7yB79ysehadrktpmI8Zwfoh5dFHaaRADPp3EkKmxE?= =?us-ascii?Q?aN8OTCv4aIzwdekSz2PqzwaXcyzlLWwogcusJ1jfpqndwYBgyKcYqWBJsgGu?= =?us-ascii?Q?qm1NmGlm5GSitxaxM22BsRGdt6GGf8F9JbKottdYE2ozQFiP9qU/ddMp/wgY?= =?us-ascii?Q?KlZwMAir76B4L8XvCYs+FazJQnqoqgPtvwUaAm9qMR2iOkZLgMcP6z5GTpUl?= =?us-ascii?Q?qPA/JFtu3CMteqwjADktsgMC3nHoFKIJSOffCh0fH4JXBiPmIOqxBfqoYmcP?= =?us-ascii?Q?r1z7SpQuxO2jVebJkDoq5Uy0GzjyHCD7urhBwRLmiGXpmlLy39agCg1Cj2Me?= =?us-ascii?Q?Oc5uCx4oDpbkGn8+T3tLgGVuHR9tljz0tIx6oTT0YIkKrl/GUBG7HhoJMPnM?= =?us-ascii?Q?jhtcoOR4/W6MCvrhrfqMBzypaEjxjaBuROsXB5GqZSdifmU2d4oE0uyO9Khb?= =?us-ascii?Q?2VXyoeTQhJ0+yLaeWE3Kw8DKzG+LE6qqvbz7HjauhQlKwy5kGKoalipEByOD?= =?us-ascii?Q?lAtKpaH3PIUMi0nGRrp/BHzRZSs9lyjNKWEcJxRdRTfsFXcN9uDyN3unMqC2?= =?us-ascii?Q?CqqZVAmXDHuzIfUIlBqpODI7VROrfrrjgzJZ/OrdSkeLtllxhXrN9ijLc1Ok?= =?us-ascii?Q?AgnXRUXQ5RK6mqJMR/NX71CvMlEtwM44yqhUwxul+4MW6oqxXAfwFEdJ9/r5?= =?us-ascii?Q?2OcRDJ00V8coRV4ZbYuZZ+V5jnq+x/vM5YQIv1JgGRVaP9sH9Rg8+5Khol0H?= =?us-ascii?Q?mkLPm4NdREHO7skN5V4Im2om7+S73yPQRrSdPC/oUDB23HM8OYkltDtcpMZo?= =?us-ascii?Q?7j9N/QeP9z6QgvxUuQsB8QCSreUzt1eYHxfdYEAJxrdWvACagM2MPc6RiKaN?= =?us-ascii?Q?VXIkEIIZGS6sRRfFpliA5ha9kR2drL75mocejjkDt2a31LtBRpls6WLTRReD?= =?us-ascii?Q?vsLQGDNEuPh/Sjy3fBrbp6nKBifyzjz2r3yNoJXCmddk0jRz2/PMi4uW7eQ5?= =?us-ascii?Q?953IGavyPGGCl/59fCfBRd0D3JQ3mtRv8dKdG1Zpvp7dU9JJUN4ToGxzlZhf?= =?us-ascii?Q?00mgd9iVV3EPeK6HQpW4xHG6KknI8i/H0da/Z2sY+IZhP5vzJRXpYskABM8J?= =?us-ascii?Q?kMsqen+/TsGGeIHt1s68ZKk89JFJHUKbczogHtQp7d8xwhHZkV02eId5lY3k?= =?us-ascii?Q?pihucrwgcV+9irs2ujcSLN1obezx8fgIgQLfKsjSoldbVRBMJASfWgTD1Jsz?= =?us-ascii?Q?RsKqgXQHEw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea8e550a-fa70-4c07-bff4-08da4ae2cf4c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 13:12:02.7011 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WwB4bJIZ0ClGszBK1JJv73BWjtHXwdKtfcxQ3mmSmzmK4qOoxRCwAE3VHyN/1zDXVir3O3bOntLAPm+Ltqgdxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1891 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. I will revert this at first. Let's figure out a right solution. Acked-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Friday, June 10, 2022 7:03 PM > To: devel@edk2.groups.io > Cc: Oliver Steffen ; James Bottomley > ; Tom Lendacky ; Gerd > Hoffmann ; Justen, Jordan L ; > Chen, Christine ; Brijesh Singh > ; Aktas, Erdem ; Yao, > Jiewen ; Gao, Liming ; > Ard Biesheuvel ; Pawel Polawski > ; Feng, Bob C ; Xu, Min M > > Subject: [edk2-devel] [PATCH v6 1/3] Revert "OvmfPkg/Sec: fix stack switc= h" >=20 > This reverts commit ff36b2550f94dc5fac838cf298ae5a23cfddf204. >=20 > Has no effect because GCC_IA32_CC_FLAGS and GCC_X64_CC_FLAGS are > unused. >=20 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Sec/SecMain.c | 4 ---- > BaseTools/Conf/tools_def.template | 6 +++--- > 2 files changed, 3 insertions(+), 7 deletions(-) >=20 > diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c > index 3ca0dcdfd3dd..1167d22a68cc 100644 > --- a/OvmfPkg/Sec/SecMain.c > +++ b/OvmfPkg/Sec/SecMain.c > @@ -1052,15 +1052,11 @@ TemporaryRamMigration ( > if (SetJump (&JumpBuffer) =3D=3D 0) { > #if defined (MDE_CPU_IA32) > JumpBuffer.Esp =3D JumpBuffer.Esp + DebugAgentContext.StackMigrateOf= fset; > - #ifndef OMIT_FRAME_POINTER > JumpBuffer.Ebp =3D JumpBuffer.Ebp + DebugAgentContext.StackMigrateOf= fset; > #endif > - #endif > #if defined (MDE_CPU_X64) > JumpBuffer.Rsp =3D JumpBuffer.Rsp + DebugAgentContext.StackMigrateOf= fset; > - #ifndef OMIT_FRAME_POINTER > JumpBuffer.Rbp =3D JumpBuffer.Rbp + DebugAgentContext.StackMigrateOf= fset; > - #endif > #endif > LongJump (&JumpBuffer, (UINTN)-1); > } > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index adcd23f7273f..5ed19810b727 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1849,9 +1849,9 @@ NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =3D --add- > gnu-debuglink=3D$(DEBUG_DIR)/$(MODULE_N > *_*_*_DTC_PATH =3D DEF(DTC_BIN) >=20 > DEFINE GCC_ALL_CC_FLAGS =3D -g -Os -fshort-wchar -fno-builtin= -fno- > strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno- > common > -DEFINE GCC_IA32_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -m32 -malig= n- > double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg= - > probe -fno-omit-frame-pointer > -DEFINE GCC_X64_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mno-red-zo= ne - > Wno-address -mno-stack-arg-probe -fomit-frame-pointer - > DOMIT_FRAME_POINTER=3D1 > -DEFINE GCC_ARM_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mlittle-en= dian > -mabi=3Daapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata= - > sections -fomit-frame-pointer -DOMIT_FRAME_POINTER=3D1 -Wno-address - > mthumb -mfloat-abi=3Dsoft -fno-pic -fno-pie > +DEFINE GCC_IA32_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -m32 -malig= n- > double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg= - > probe > +DEFINE GCC_X64_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mno-red-zo= ne > -Wno-address -mno-stack-arg-probe > +DEFINE GCC_ARM_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mlittle-en= dian > -mabi=3Daapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata= - > sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=3Dsoft -fn= o-pic > -fno-pie > DEFINE GCC_ARM_CC_XIPFLAGS =3D -mno-unaligned-access > DEFINE GCC_AARCH64_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mlittle- > endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-section= s - > fdata-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind- > tables -fno-pic -fno-pie -ffixed-x18 > DEFINE GCC_AARCH64_CC_XIPFLAGS =3D -mstrict-align -mgeneral-regs-onl= y > -- > 2.36.1 >=20 >=20 >=20 >=20 >=20