Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers

[Michael Kubacki]

Please review this patch when possible. It is just removing two 
irrelevant comments.

Thanks,
Michael

On 4/5/2022 8:50 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> MU_CHANGE tags are used in a different project (Project Mu) to
> highlight deviations from Tianocore. Therefore, the comments are
> not needed when the changes are present in a Tianocore repository.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> index b5d9aca06535..03726fd7264c 100644
> --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> @@ -130,8 +130,6 @@ TlsSetVerify (
>     ASSERT (FALSE);
>   }
>   
> -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) accepted. [BEGIN]
> -
>   /**
>     Set the specified host name to be verified.
>   
> @@ -156,8 +154,6 @@ TlsSetVerifyHost (
>     return EFI_UNSUPPORTED;
>   }
>   
> -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) accepted. [END]
> -
>   /**
>     Sets a TLS/SSL session ID to be used during TLS/SSL connect.
>   

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers

[Yao, Jiewen]

Ah, thanks for the reminder. I overlooked this one.

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Thursday, April 14, 2022 10:19 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove
> MU_CHANGE comment markers
> 
> Please review this patch when possible. It is just removing two
> irrelevant comments.
> 
> Thanks,
> Michael
> 
> On 4/5/2022 8:50 PM, Michael Kubacki wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > MU_CHANGE tags are used in a different project (Project Mu) to
> > highlight deviations from Tianocore. Therefore, the comments are
> > not needed when the changes are present in a Tianocore repository.
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ----
> >   1 file changed, 4 deletions(-)
> >
> > diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> > index b5d9aca06535..03726fd7264c 100644
> > --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> > +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> > @@ -130,8 +130,6 @@ TlsSetVerify (
> >     ASSERT (FALSE);
> >   }
> >
> > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN)
> accepted. [BEGIN]
> > -
> >   /**
> >     Set the specified host name to be verified.
> >
> > @@ -156,8 +154,6 @@ TlsSetVerifyHost (
> >     return EFI_UNSUPPORTED;
> >   }
> >
> > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN)
> accepted. [END]
> > -
> >   /**
> >     Sets a TLS/SSL session ID to be used during TLS/SSL connect.
> >
> 
> 
> 
> 

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers

[Yao, Jiewen]

Merged - https://github.com/tianocore/edk2/pull/2779

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Thursday, April 14, 2022 10:32 PM
> To: devel@edk2.groups.io; mikuback@linux.microsoft.com
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>;
> Jiang, Guomin <guomin.jiang@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove
> MU_CHANGE comment markers
> 
> Ah, thanks for the reminder. I overlooked this one.
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> > Kubacki
> > Sent: Thursday, April 14, 2022 10:19 PM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>;
> > Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove
> > MU_CHANGE comment markers
> >
> > Please review this patch when possible. It is just removing two
> > irrelevant comments.
> >
> > Thanks,
> > Michael
> >
> > On 4/5/2022 8:50 PM, Michael Kubacki wrote:
> > > From: Michael Kubacki <michael.kubacki@microsoft.com>
> > >
> > > MU_CHANGE tags are used in a different project (Project Mu) to
> > > highlight deviations from Tianocore. Therefore, the comments are
> > > not needed when the changes are present in a Tianocore repository.
> > >
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> > > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > > ---
> > >   CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ----
> > >   1 file changed, 4 deletions(-)
> > >
> > > diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> > b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> > > index b5d9aca06535..03726fd7264c 100644
> > > --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> > > +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> > > @@ -130,8 +130,6 @@ TlsSetVerify (
> > >     ASSERT (FALSE);
> > >   }
> > >
> > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN)
> > accepted. [BEGIN]
> > > -
> > >   /**
> > >     Set the specified host name to be verified.
> > >
> > > @@ -156,8 +154,6 @@ TlsSetVerifyHost (
> > >     return EFI_UNSUPPORTED;
> > >   }
> > >
> > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN)
> > accepted. [END]
> > > -
> > >   /**
> > >     Sets a TLS/SSL session ID to be used during TLS/SSL connect.
> > >
> >
> >
> >
> >
> 
> 
> 
> 
>