From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.36093.1674094528445685856 for ; Wed, 18 Jan 2023 18:15:28 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CmtgsK9Q; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674094528; x=1705630528; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gLV7iZFtvhPz51vyNENr0mr/vQWTuG5f1fXCmyw8EHw=; b=CmtgsK9QvhR4znT8Wc+Vl7N63ZTGKpw6znlXzLuQtN/hHazUhV5N3Hwk Ijb7QU0LKgtzORiRcjKtxXNg2PPugrNwYAJkhurprKk9usi9d0WyzinUI x+4Y9mAn3NJ5ppWTp8AbOCfKBPAbO6LIQOagfOYQ4rjEgNZGW/tZjGiMg jC2n2RVSlGse4cGwnmA9NJN9l1kMyPicG6bM2c3IAOsD8WxhuC5lGRTcs Mj3ibGU2k5GlOvQ5GZaErxF/Mwft7858gujYKjjxShreh0zyOu3co5pSy X33mOpTcJl1BD/tqn92vW+9zuq/4lillUQbSl6UBY5KDQlObItwsPIsXk A==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="304851705" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="304851705" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 18:15:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="723332127" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="723332127" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 18 Jan 2023 18:15:27 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 18:15:27 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 18:15:27 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 18 Jan 2023 18:15:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B9TVll9mV/cvFOrCdad1+ux/1kf28yazwBivpXN226jTpL3agrjP0MV8NBwzhoBXP6q2gnLLup+/P0QjrQBkK186BaeVn2DFozZiECpOBaGGasVl21Vab6RILlqTyOb4OK3IJwvFA3cc5B1SkuvfxcI1F2/07BnvvBMGNveiqS8VxpqwR7kKFKbK2953fIU7SUAyxJjrNbLb/01TWuBDuSejo3yHh98Sxx6P8S2hRUmRYqQnTA1iwBUDEZ7uk+N0TMX/aMcrLqEGiRc+iUITCXCmfZcmlrDqgnV2LO2BJU485JSTNfUYMGHLAr4KdMjpGymU3J/LIsXapGPWR8Seow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEFmGnKXG2fHaTPVfvF9f3RKlvBJWv2TfwLJOsu7aWY=; b=UeHYZMY2s8I5WWKvWJqqq9ylPkUZbIGQZJItza0HVH1EEMiVy6sJnEAxZmd+mpMwVUkQLnDBKfPt796IDWodDzUo0ydp624HOyZFKVJ5TyGsnd62Zo6gHrDeIklp7F7ikMkI9Mgqam3X3etP/EgNsJ4+XbTUW456af5gzxHYGAbCF2Miy+KxGrELM6TFQV20qrCev5qbcgWkdq9MTMhXylq4MIn+vNUQiQkLpqssvqTc36wGcBEFNnOrVCpRC/aVyHu38CafK01AznxhUPbExaejrn29PSUnIaeCi9smQLYhbYUO/eJRfF6aUl4A+h9x0IBfzB4gsaPZIqN6QNqM7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CY8PR11MB6986.namprd11.prod.outlook.com (2603:10b6:930:56::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.25; Thu, 19 Jan 2023 02:15:25 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%7]) with mapi id 15.20.6002.013; Thu, 19 Jan 2023 02:15:25 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: Leif Lindholm , Ard Biesheuvel , Abner Chang , "Daniel Schaefer" , Gerd Hoffmann , "Aktas, Erdem" , James Bottomley , "Tom Lendacky" Subject: Re: [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg Thread-Topic: [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg Thread-Index: AQHZK6iM9i52bnsBt0647aYQWBxwG66lADbA Date: Thu, 19 Jan 2023 02:15:25 +0000 Message-ID: References: <20230119015108.1323-1-min.m.xu@intel.com> In-Reply-To: <20230119015108.1323-1-min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CY8PR11MB6986:EE_ x-ms-office365-filtering-correlation-id: 69777052-93c4-45ad-a558-08daf9c306ad x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Ld41Ue1Zz2VgJDM+k9oB19WtFaBrl2WrXUX6b6CYLs2uL0hriTpfwq3S4fnHW31KtneNLjMUvw0W8hr635c++JN0nCShsdY4UQUf1h7BOYpoc5t7uYyj4rjICAuvLGvhWe64999USPENp/Fz2xlnc/R555v+w80PFzUcauMHwKUwIuEnCwejEzVg/XTicDTqSh70d9b7kv8XbDOQSNEkmgX66WYa1Qo7aE9VBOOcQBsBoSTA/xCLXtiw28BfAXaeWesxIJu/VtjzOgNTsfzb/2fHFEJEhd44mvr0lFo3JnICnZMiVc0ftLxkkiDkz8P0wRL0y33oW2n5UpJasVY8MKp7hkU+FSMW5bsRwSYatyCzEtc/8Cp3ihZgXQ2usWARKz0jHdRN0J/9KCD0aFxiTeYkfvvkzispHFHzPSuKpM6rQFewwEIHHfJyioR2NlzFZhot4xNF7vKppGm0ELON5R6pIATXg/86WmXCS5n7XXd/axo5hf/+NXdtHyOZnWp40cvmhqazax4BniBYI7lvDQJRsZrJkzwROwIIlQae5Ebz23JqnjtmTtCzzE0VRLYBAn25dCUFu5gh697JaJ96pC8rwqzx9r3bd1tLhJ4TE8wx90IREM6+2n3YOnxM2lC4zf03beMeyAkN4UW+mM8xTeL2LNvj87nXJekJ6Y97b/z3yN7gIUTTh6ZU0l/iLnklkcHJR/2DkG7hpUU4Feykw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(7696005)(38070700005)(71200400001)(53546011)(6506007)(478600001)(26005)(186003)(9686003)(86362001)(316002)(54906003)(110136005)(76116006)(66946007)(66476007)(66446008)(64756008)(8676002)(66556008)(4326008)(41300700001)(83380400001)(5660300002)(38100700002)(8936002)(52536014)(122000001)(33656002)(82960400001)(55016003)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BejxEQxExZ2tu+6Q+PamNFFWWpMGfyBOmSEAaQtmtNcgvmV5CP4czcWj5tLF?= =?us-ascii?Q?/8fhmdwteBT/rxbNcc1RW2yDc2gvCCyIdp4lG7dkrsD6b+dIOAVgS1Kriu3r?= =?us-ascii?Q?voKjIoxtqCitTfRZA6L71dedEv2ZtO5w0XsCckozaI2g6ZmtGNo8GU+M3sOZ?= =?us-ascii?Q?3gupGBpdXVVbuIr1fPTyokrY1Ci82BW2129ZZH170/uQHCvzuuuVm22NpyFd?= =?us-ascii?Q?IO4za4fqe5o2/dLmz7mcJmFjFVzXYg5NHvG7Un4X+DWZ5R3zGsqm/EOpPVOP?= =?us-ascii?Q?VSax5JPjDUpLxe81P+1q71awI/Z3MeEQtKVDGFbaNIdOuTTU/cauCQuSznzZ?= =?us-ascii?Q?9RbM0DgQ5F4iUXQCEgu2KNsfeTN2KAbY6dsp/vrxTzgnzC/8T1KX5sk9J6/C?= =?us-ascii?Q?Jotm9ejlOA5/bmEn2TmgYKnf+A+1OUI2RF8nIKFmUtGC2fhY8vkWzc5f2pO4?= =?us-ascii?Q?Can+qFD6NYcpERnlAT/Qb00GTI5Q+bVJ3yERGwg0oATMPv2piiBr73FCqYnW?= =?us-ascii?Q?i7z/fo7Tj4Ho2SkUI3TArkScIU5XNdue0pyRFcP9LJXupLg4oFI6GEIOBXa0?= =?us-ascii?Q?ElBJMdOot1SGGxfsnZRoID/BET1Z091p2nzR9DIldo8BWt21Sv94ITQJLshn?= =?us-ascii?Q?mK+LlyUd15qbAFxBqWgaPYVRXxScFYkI67I2JXZcmCCCGkSX8mUSxyG7gQir?= =?us-ascii?Q?59BP6CPuzF1ey4Ryi1KSq/Nrl/TQ2iVWmY4Jo8GJPJJtK1WYS4dAvkhS4ClZ?= =?us-ascii?Q?uxN1E9YkxAhyX0QD2l3gZLOtG651onLBBipG/ICbXfZZ7lgJYV628CFBXPB/?= =?us-ascii?Q?76jkCbytbbIz/J942pRcUgHq1YbStsSeMMrfqwFml3xofUISHYOZbhVmZNkX?= =?us-ascii?Q?caTVvH/Q0y+KpuaTp7Ix/LQPgVP0C1+jUKZCDEEA3eQlhQju0O2UuJN5sWRi?= =?us-ascii?Q?0Iy0fC2jWNoxH0HDRglbLpCcwMzmq5Tz6lEK41riL9UAotNC7c2YWUVrFGvQ?= =?us-ascii?Q?nykM3Es2hnqcCVT63uH2Ctbos7HTqnid2F6vQkU5YS87eI/puI9EaiLjihlX?= =?us-ascii?Q?UHKxsQJ7rreSqt2rA+OlLe+QLaoExHgcwDvmwalzhBLtXNBHs6U4C5Er/e8Q?= =?us-ascii?Q?Eyg37BaxS+3NkhHGJx00EAIybUVjENyOa7NTUYObemEi5TXEUC3lSirKM5u5?= =?us-ascii?Q?4g2cSX5JphA/sw3Xhgh8K7n7Hyo/XFa2eEq6VkatmAIbUDzlVjoydX8hgYjh?= =?us-ascii?Q?tXUEiswmKBnNaTqfK1ieRLTs0UrtOOjKRjxtoJBimxGeiQ0TmO3uu2dawTAa?= =?us-ascii?Q?9Xe8ULyWW7FPAGwxoz1GwF7txCFLt3nZ+mRrW4AoIZXaiWs9RFBFzeHvXp6I?= =?us-ascii?Q?DZjCJgMSTsvjbeOkMJ04DK3vvuNvPqeGDg2Uf28US83EV08fgnsialX31RqK?= =?us-ascii?Q?eMpeokoiFze+fA4m38Xqgzb3pUD/gSUVIxoW9du+LeJOMHYR9zHKS/i+7uyS?= =?us-ascii?Q?OXmXQa2PhnMkkmhbEGjpAdy87XGXhRIqy80tJplrtzhMagxKNiBOCv/P+LIO?= =?us-ascii?Q?CkVXXSZMg77722mJwsLbDVTRP1FYF/Bva5nd9EjD?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69777052-93c4-45ad-a558-08daf9c306ad X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2023 02:15:25.2016 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5onOw0ze069+PQ9YZWnoC0edxdGFvJ/dqqV/XfTG/nCktidTcFHIXisgwxweWG6IZmtfsBTyUS8dTw+DUdHmwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6986 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the quick update. Reviewed-by: Jiewen Yao > -----Original Message----- > From: Xu, Min M > Sent: Thursday, January 19, 2023 9:51 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Leif Lindholm > ; Ard Biesheuvel ; > Abner Chang ; Daniel Schaefer > ; Gerd Hoffmann ; Aktas, > Erdem ; James Bottomley ; > Yao, Jiewen ; Tom Lendacky > > Subject: [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg >=20 > Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the > second input parameter in FfsFindSectionData. This change breaks the buil= d > of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData > is renamed as FfsFindSectionDataWithHook. Then the original > FfsFindSectionData is added back. >=20 > After FfsFindSectionData is renamed as FfsFindSectionDataWithHook, > PeilessStartupLib in OvmfPkg is updated as well. >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Cc: Gerd Hoffmann > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Signed-off-by: Min Xu >=20 > Min M Xu (2): > EmbeddedPkg: Rename FfsFindSectionData as FfsFindSectionDataWithHook > EmbeddedPkg: Add back FfsFindSectionData >=20 > EmbeddedPkg/Include/Library/PrePiLib.h | 22 +++++++++++++- > EmbeddedPkg/Library/PrePiLib/FwVol.c | 33 ++++++++++++++++++--- > EmbeddedPkg/Library/PrePiLib/PrePiLib.c | 2 +- > OvmfPkg/Library/PeilessStartupLib/DxeLoad.c | 4 +-- > 4 files changed, 53 insertions(+), 8 deletions(-) >=20 > -- > 2.29.2.windows.2