From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"osteffen@redhat.com" <osteffen@redhat.com>
Cc: Andrew Fish <afish@apple.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Bi, Dandan" <dandan.bi@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Michael Kubacki <mikuback@linux.microsoft.com>,
"Ni, Ray" <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"Chen, Christine" <yuwei.chen@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>,
"chris.fernald@outlook.com" <chris.fernald@outlook.com>
Subject: Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
Date: Tue, 17 Jan 2023 12:20:16 +0000 [thread overview]
Message-ID: <MW4PR11MB58722FF0745D1AB134569ED78CC69@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CA+bRGFr9N=YWVfoWec=rReuoS+M+1CrzG+yqJkMmNQq_q3Nj0Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4495 bytes --]
I have seen Gerd sent out V4 patch set for #4251. Is that not enough?
In general, I prefer no work-around, unless there is strong reason.
I would like to have Gerd and Ard to feedback.
Thank you
Yao, Jiewen
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oliver Steffen
Sent: Tuesday, January 17, 2023 6:37 PM
To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>
Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Wang, Jian J <jian.j.wang@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Ni, Ray <ray.ni@intel.com>; Sami Mujawar <sami.mujawar@arm.com>; Sean Brogan <sean.brogan@microsoft.com>; Chen, Christine <yuwei.chen@intel.com>; Pawel Polawski <ppolawsk@redhat.com>; chris.fernald@outlook.com
Subject: Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
It is this one:
https://bugzilla.tianocore.org/show_bug.cgi?id=4251
Should have put that into the commit message, sorry.
On Tue, Jan 17, 2023 at 1:16 AM Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> wrote:
Not sure the detail.
Could you please add more comment, such as, what issue? Why crash? Why changing to Broadwell can resolve it?
any URL?
> -----Original Message-----
> From: Oliver Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>
> Sent: Tuesday, January 17, 2023 1:41 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Andrew Fish <afish@apple.com<mailto:afish@apple.com>>; Ard Biesheuvel
> <ardb+tianocore@kernel.org<mailto:ardb%2Btianocore@kernel.org>>; Feng, Bob C <bob.c.feng@intel.com<mailto:bob.c.feng@intel.com>>; Bi,
> Dandan <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>; Gerd Hoffmann <kraxel@redhat.com<mailto:kraxel@redhat.com>>;
> Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>;
> Justen, Jordan L <jordan.l.justen@intel.com<mailto:jordan.l.justen@intel.com>>; Leif Lindholm
> <quic_llindhol@quicinc.com<mailto:quic_llindhol@quicinc.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>;
> Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Michael Kubacki
> <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Sami
> Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>; Sean Brogan
> <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>; Chen, Christine <yuwei.chen@intel.com<mailto:yuwei.chen@intel.com>>;
> Pawel Polawski <ppolawsk@redhat.com<mailto:ppolawsk@redhat.com>>; chris.fernald@outlook.com<mailto:chris.fernald@outlook.com>; Oliver
> Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>
> Subject: [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
>
> Work around a bug in Ovmf that causes Ovmf to crash on startup
> when running in recent versions of Qemu. Setting the cpu model
> to something older, for example "Broadwell" works around the issue.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>
> ---
> OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> index bfef9849c749..93f7d7aa13d6 100644
> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> @@ -194,6 +194,7 @@ class PlatformBuilder( UefiBuilder,
> BuildSettingsManager):
> cmd = "qemu-system-x86_64"
> args = "-debugcon stdio" # write messages to
> stdio
> args += " -global isa-debugcon.iobase=0x402" # debug
> messages out thru virtual io port
> + args += " -cpu Broadwell" # workaround Qvmf
> bug
> args += " -net none" # turn off network
> args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" #
> Mount disk with startup.nsh
>
> --
> 2.39.0
[-- Attachment #2: Type: text/html, Size: 9738 bytes --]
next prev parent reply other threads:[~2023-01-17 12:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 17:40 [PATCH v11 00/17] CI: Use Fedora 35 container for Linux jobs Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 01/17] CI: make Python version configurable Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 02/17] ArmVirtPkg: CI: use Python version from defaults template Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 03/17] EmulatorPkg: " Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 04/17] OvmfPkg: " Oliver Steffen
2023-01-17 0:14 ` [edk2-devel] " Yao, Jiewen
2023-01-16 17:40 ` [PATCH v11 05/17] CI: add ~/.local/bin to PATH (Linux only) Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 06/17] CI: Allow running in a container Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 07/17] CI: Use Fedora 35 container (Linux only) Oliver Steffen
2023-01-17 17:27 ` Michael Kubacki
2023-01-16 17:40 ` [PATCH v11 08/17] ArmVirtPkg: " Oliver Steffen
2023-01-17 17:27 ` Michael Kubacki
2023-01-16 17:40 ` [PATCH v11 09/17] EmulatorPkg: " Oliver Steffen
2023-01-17 17:28 ` Michael Kubacki
2023-01-16 17:40 ` [PATCH v11 10/17] OvmfPkg: " Oliver Steffen
2023-01-17 0:14 ` [edk2-devel] " Yao, Jiewen
2023-01-17 17:28 ` Michael Kubacki
2023-01-16 17:40 ` [PATCH v11 11/17] .pytool: CISettings.py: don't add scopes for GCC Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 12/17] BaseTools: remove ext_dep files for gcc Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 13/17] ArmVirtPkg: CI: use ubuntu-22.04 vm_image (Linux only) Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 14/17] EmulatorPgk: " Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 15/17] OvmfPkg: " Oliver Steffen
2023-01-17 0:15 ` [edk2-devel] " Yao, Jiewen
2023-01-16 17:40 ` [PATCH v11 16/17] CI: use ubuntu-22.04 image " Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell Oliver Steffen
2023-01-17 0:16 ` Yao, Jiewen
2023-01-17 10:37 ` [edk2-devel] " Oliver Steffen
2023-01-17 12:20 ` Yao, Jiewen [this message]
2023-01-17 12:38 ` Gerd Hoffmann
2023-01-17 14:49 ` Yao, Jiewen
2023-01-17 14:52 ` Oliver Steffen
2023-01-17 18:22 ` [PATCH v11 00/17] CI: Use Fedora 35 container for Linux jobs Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB58722FF0745D1AB134569ED78CC69@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox